Re: [fpc-pascal] Widestring Questions

2010-10-25 Thread Jonas Maebe

On 25 Oct 2010, at 23:25, Tobias Giesen wrote:

> is it possible to turn off reference counting, for a test?

No.

> Is there a difference between UnicodeString and WideString on the
> Mac version (i386) of FPC 2.4 / 2.5?

No. UnicodeString and WideString only differ on Windows.


Jonas
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Widestring Questions

2010-10-25 Thread Tobias Giesen
Hi,

I think the problem might be that Widestring reference counting is not 
thread safe. But it worked fine in FPC 2.2.

I will add some UniqueString calls and also try to isolate the issue.

Cheers,
Tobias


___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Widestring Questions

2010-10-25 Thread Honza
2010/10/26 Tobias Giesen :
> I think the problem might be that Widestring reference counting is not
> thread safe. But it worked fine in FPC 2.2.

A bug may show anytime anywhere, but the built in ref counted string
types are AFAIK thread safe what concerns the ref count per se. I
suspect a subtle flaw in the client code is more probable.

-- 
bflm
freepascal-bits.blogspot.com
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Widestring Questions

2010-10-26 Thread Tobias Giesen
> A bug may show anytime anywhere, but the built in ref counted string
> types are AFAIK thread safe what concerns the ref count per se. I
> suspect a subtle flaw in the client code is more probable.

No, it is a compiler bug. The same code works 100% perfectly on 
Windows using Delphi, as well as on Mac OS X using FPC 2.2. Starting
with FPC 2.4, it loses memory, which can be fixed by using

UniqueString

in a number of spots in the code. That is proof enough that the
compiler has a bug. I am trying to isolate it today by finding out
where exactly the UniqueString is necessary.

Kind Regards,
Tobias Giesen

"To avoid a reboot, make sure that no SuperFlexible or ExtremeSync 
 processes are running in Task Manager before installing an update."

Super Flexible Software Ltd. & Co. KG
Lessingstr. 42
48485 Neuenkirchen, Germany
www.superflexible.com
www.tgtools.com

---
Registered at register court Steinfurt as HRA 5061
Liability / general partner: TGTools Ltd.
Company No. 05513299
Registered in England and Wales
Directors: Tobias Giesen and Claudia Giesen

___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Widestring Questions

2010-10-26 Thread Florian Klaempfl
Am 26.10.2010 10:55, schrieb Tobias Giesen:
>> A bug may show anytime anywhere, but the built in ref counted string
>> types are AFAIK thread safe what concerns the ref count per se. I
>> suspect a subtle flaw in the client code is more probable.
> 
> No, it is a compiler bug. The same code works 100% perfectly on 
> Windows using Delphi, as well as on Mac OS X using FPC 2.2. Starting
> with FPC 2.4, it loses memory, which can be fixed by using

So without ref. counting it works.

> 
> UniqueString
> 
> in a number of spots in the code. That is proof enough that the
> compiler has a bug.

It is possible, but it depends on the usage of the string.

> I am trying to isolate it today by finding out
> where exactly the UniqueString is necessary.
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Widestring Questions

2010-10-26 Thread Tobias Giesen
Hi,

I was wrong, UniqueString does not help after all. I am now using an
extended version of the heaptrc unit to show the reference count (and 
string value) for unfreed WideStrings and they usually have 1 as a 
reference count.

Will keep you posted.

Cheers,
Tobias


___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Widestring Questions

2010-10-26 Thread Tobias Giesen
Hello,

I have been making tests all day long and I do not have any conclusive
results. I fixed a small memory leak in my code too. This leak may have
misled me to believe that the compiler has a leak. However after all the
efforts, the application still uses more and more memory while it is
doing its processing. 

Upon exit, the memory does seem to be freed correctly now according to
heaptrc. But MacOS stops giving memory to the app after a while and 
then it quits.

Could it be that the memory manager has been changed since FPC 2.2 and
is now more susceptible to heap fragmentation?

Could there be any allocations that bypass heaptrc?

The app is allocating hundreds of Megabytes of memory over time and I 
still don't know how it is happening.

I can't believe that I have made zero progress in two days. Wow.
Haven't had such an extreme experience in a while. Well except for 
trying to install Linux on my MacBook Pro 13 inch ;=)

Cheers,
Tobias


___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Widestring Questions

2010-10-26 Thread Jonas Maebe

On 26 Oct 2010, at 21:28, Tobias Giesen wrote:

> Upon exit, the memory does seem to be freed correctly now according to
> heaptrc. But MacOS stops giving memory to the app after a while and 
> then it quits.
> 
> Could it be that the memory manager has been changed since FPC 2.2 and
> is now more susceptible to heap fragmentation?

It has been changed, but if anything it should be less susceptible to heap 
fragmentation.

> Could there be any allocations that bypass heaptrc?

Yes, if you call external code that uses libc's malloc() family of routines to 
allocate memory.

> The app is allocating hundreds of Megabytes of memory over time and I 
> still don't know how it is happening.

What you can try is
a) add "cmem" to the uses clause of your program, to change from FPC's default 
heap manager to the libc memory manager. If that solves the problem, it's 
probably a heap fragmentation issue
b) if that does not help (or not enough), disable heaptrc (but keep cmem) and 
run Valgrind's massif tool on your program. You can download Valgrind from 
http://valgrind.org/ and information about massif at 
http://valgrind.org/docs/manual/ms-manual.html


Jonas___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] Widestring Questions

2010-10-26 Thread Tobias Giesen
Hi Jonas,

thanks very much!!!

I am sorry for the wrong things that I wrote. Now I can clearly see that
the memory is not lost on the FPC heap. The total heap size doesn't even
change at all. So there's no difference with CMem either.

More work to do ...

Cheers,
Tobias


___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal