Re: [Framework-Team] PLIP #246 ready for review (pending review notes)

2009-01-17 Thread Andreas Zeidler

On Jan 18, 2009, at 1:44 AM, Ricardo Alves wrote:

Hi,


hi ricardo,

- We should also support this view in collections/topics. I think it  
makes sense, since collections are a common way to list events from  
a plone site.


+1, and in fact, this is already on my list for next week.

- Change the view name to "ics_view", which is the same name used  
for a single event. I find the current name ("calendar.ics") a bit  
confusing, because I would expect it to be the downloaded file's  
name, but that will be "[CONTEXT_ID].ics".


hmm, iirc i just picked the name rather arbitrarily.  iow, i don't  
really care too much what it is and am fine with changing it to  
whatever people think makes more sense.  however, before going ahead  
right away, i'd rather wait for the review and some more comments from  
the fwt, and also others, of course...


- I'm not so sure about it, but shouldn't we also support vCalendar?  
It's still provided for single events.


we could, and it should also be easy.  i was just running short on  
time last week and the PLIP luckily only mentioned iCal... :)



- Are there any plans to add a new document action for this feature?


i'm not sure if it makes sense to globally configure such an action.   
i reckon a more common use-case will be that people want feeds for two  
or three folders/collections in their site, but not for the rest (at  
least not automatically linked).  we were brainstorming about this a  
little and will probably work on a way to enable such an action on an  
instance-level.


Thanks for working on this :) and please let know if you need any  
help.


help's always welcome, of course! :)

good night,


andi

--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.1.7 released! -- http://plone.org/products/plone/



PGP.sig
Description: This is a digitally signed message part
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] PLIP #246 ready for review (pending review notes)

2009-01-17 Thread Ricardo Alves

Andreas Zeidler wrote:

hi,

as a heads-up, the review bundle for PLIP 246 (View for rendering 
events as an iCalendar file) is ready for review.  you can get it from 
https://svn.plone.org/svn/plone/review/plip246-ical-feed/



Hi,

I'm very interested in this PLIP, since I've being implementing such 
feature for several projects and would be great to have it shipped with 
Plone.


From a first look at the review bundle, I have some suggestions:


- We should also support this view in collections/topics. I think it 
makes sense, since collections are a common way to list events from a 
plone site.


- Change the view name to "ics_view", which is the same name used for a 
single event. I find the current name ("calendar.ics") a bit confusing, 
because I would expect it to be the downloaded file's name, but that 
will be "[CONTEXT_ID].ics".


- I'm not so sure about it, but shouldn't we also support vCalendar? 
It's still provided for single events.


- Are there any plans to add a new document action for this feature?


Thanks for working on this :) and please let know if you need any help.


Ricardo

--
Ricardo Alves 
Eurotux  



___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] PLIP #241 ready for review

2009-01-17 Thread Andreas Zeidler

hi,

the review bundle for PLIP 241 (Clean up auto-sort, auto-order code)  
is ready for review.  you can get it from https://svn.plone.org/svn/plone/review/plip241-auto-sort-cleanup/


review notes are available in the bundle's top-level `README.txt` file.

cheers,


andi

--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.1.7 released! -- http://plone.org/products/plone/



PGP.sig
Description: This is a digitally signed message part
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] PLIP 238 review buildout available

2009-01-17 Thread Wichert Akkerman
I have just created the review buildout for PLIP 238. For reference I
have included the implementation notes below.


Implementation notes


This buildout contains the base implementation for PLIP 238: disable
inline edit by default.

The implementation is trivial: the option introduced in
http://dev.plone.org/plone/changeset/21784 is used to disable inline
edit.

This is only done for new sites: no migration is added to prevent
unexpected behavioural changes in existing sites.


Needed documentation changes


User manuals should be updated to reflect that inline edit is disabled by
default, and can be enabled through the ZMI.


Wichert.

-- 
Wichert Akkerman It is simple to make things.
http://www.wiggy.net/   It is hard to make things simple.

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] PLIP 243 review buildout available

2009-01-17 Thread Wichert Akkerman
For reference here are the implementation notes. They are also present in the
README.txt in the buildout itself.


Implementation notes


This buildout contains the base implementation for PLIP 243: replace the
standard workflow history viewlet with a content history viewlet.

This buildout contains two changes:

- plone.app.layout has a new content history viewlet. This viewlet shows
  both versioning and workflow changes, and provides direct options to
  show the differences between versions, review an older version or revert
  to an older version.

- a new history view was added which provides a much simpler way to
  show the differences between different revisions.


Needed documentation changes


User manuals should be updated to show the content viewlet and describe the
actions it exposes.


Outstanding issues
--

- the html_diff code difference view can trigger a UnicodeDecodeError, so I
  disabled it for now. For some unknown reason this only happens in the
  history browser view. The exact same diff works fine when shown via the
  version_diff CMF page template.

- the CSS and icons needed for the content history viewlet are still
  missing. My CSS skills are too limited and my graphics skills
  non-existant, so someone else will need to tackle this. I can show
  screenshots of the viewlet as it is running on a customer site
  if desirable.

- it might be desirable to add a migration step to Plone to remove the
   old history action.

- the permission used for the @@history form may need to be verified


-- 
Wichert Akkerman It is simple to make things.
http://www.wiggy.net/   It is hard to make things simple.

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] PLIP #246 ready for review (pending review notes)

2009-01-17 Thread Andreas Zeidler

On Jan 17, 2009, at 4:37 PM, Andreas Zeidler wrote:
as a heads-up, the review bundle for PLIP 246 (View for rendering  
events as an iCalendar file) is ready for review.  you can get it  
from https://svn.plone.org/svn/plone/review/plip246-ical-feed/


it does not yet contain any review notes (as i need to go afk now),  
but i'll add them tonight.


the review notes are available now in the bundle's top-level  
`README.txt` file.



cheers,


andi


--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.1.7 released! -- http://plone.org/products/plone/



PGP.sig
Description: This is a digitally signed message part
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] PLIP #246 ready for review (pending review notes)

2009-01-17 Thread Andreas Zeidler

hi,

as a heads-up, the review bundle for PLIP 246 (View for rendering  
events as an iCalendar file) is ready for review.  you can get it from https://svn.plone.org/svn/plone/review/plip246-ical-feed/


it does not yet contain any review notes (as i need to go afk now),  
but i'll add them tonight.  sorry for being so "last minute"...


cheers,


andi

--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.1.7 released! -- http://plone.org/products/plone/



PGP.sig
Description: This is a digitally signed message part
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team