Re: [Framework-Team] PLIP Tallies

[Andreas Zeidler]

On Jan 30, 2009, at 8:47 PM, Tom Lazar wrote:
FYI i have completed my two remaining reviews and have additionally  
reviewed #243 which was without a review.


as a status update:  i've completed all but one (247), but won't get  
around to do the last in time.  i'm simply too tired to keep going.   
sorry about that, i'll try to get it in asap.  probably only on  
monday, though.


cheers,


andi

--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.2rc1 released! -- http://plone.org/products/plone/



PGP.sig
Description: This is a digitally signed message part
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team

[Framework-Team] Plone 3.3 PLIP Bundle Review Status

[Steve McMahon]

This is a summary of the Framework Team's 3.3 PLIP bundle review status as
of Saturday:

*Reviews Complete
*
Accepted: 197, 237, 238, 239, 240, 241
Rejected: 234
Mixed: 126 (documentation & UI issues)

*Reviews Not Yet Completed:* 232, 243, 246, 247

*Details (complete chart at http://dev.plone.org/plone/wiki/PLIPTallies33)*

*PLIP #126 : Link type should
automatically redirect when accessed directly*

Review Complete:  +2 technical (qualified); -1 UI (qualified)

*PLIP #197 : Add FeedParser as
external requirement
*
Review Complete: +2

*PLIP #232 : Resource
Registries Improvements
*
No reviews yet.

*PLIP #234 : Standardizing our
use of INavigationRoot
*
Review Complete: -2

*PLIP #237 : Minor i18n
upgrades
*
Review Complete: +2

*PLIP #238 : Disable inline
editing by default
*
Review Complete: +2 technical; +1 UI

*PLIP #239 : Adapterise the
Extensible Indexable Object Wrapper
*
Review Complete: +2

*PLIP #240 : Improve locking
configurability
*
Review Complete: +2 technical; +1 UI

*PLIP #241 : Clean up
auto-sort: auto-order code
*
Review Complete: +2

*PLIP #243 : Replace workflow
history viewlet with content history viewlet
*
Review Incomplete: +1

*PLIP #246 : View for rendering
events as an iCalendar file
*
Review Incomplete: +1

*PLIP #247 : Automate ZCML
Loading for Plone Plug-ins
*
Review Incomplete: +1

-- 

Steve McMahon
Reid-McMahon, LLC
st...@reidmcmahon.com
st...@dcn.org
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team

Re: [Framework-Team] PLIP #240 ready for review

[Andreas Zeidler]

On Jan 17, 2009, at 12:04 AM, Andrew Burkhalter wrote:

PLIP 240 (Improve locking configurability) has been implemented.  You
can get the review buildout from:
https://svn.plone.org/svn/plone/review/plip240-locking-improvements/


i've added my review notes in http://dev.plone.org/plone/changeset/24800

in short:  i'm +1 for merging.  minor improvements are possible, but  
otherwise another really nice PLIP implementation from andrew & david.


cheers,


andi

--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.2rc1 released! -- http://plone.org/products/plone/



PGP.sig
Description: This is a digitally signed message part
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team

Re: [Framework-Team] PLIP Tallies

[Wichert Akkerman]

On 1/31/09 2:18 PM, Tom Lazar wrote:
i've updated my local buildout and the the site works fine now, i do 
get some 404 for the images in the timeline 
(http://localhost:8080/newsite/history_compare_with_current.png) etc, 
no showstopper, obviously, but if you can fix that still today i can 
give your review an unconditional +1


I can't, as I stated in the readme I need some help with that due to my 
complete lack of graphic skills. I'll try to get Danny to do that.


Wichert.

--
Wichert AkkermanIt is simple to make things.
http://www.wiggy.net/  It is hard to make things simple.


___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team

Re: [Framework-Team] PLIP Tallies

[Tom Lazar]

On 30.01.2009, at 21:56, Wichert Akkerman wrote:


Previously Tom Lazar wrote:

FYI i have completed my two remaining reviews and have additionally
reviewed #243 which was without a review.


I've fixed the problems you saw with #243.


i've updated my local buildout and the the site works fine now, i do  
get some 404 for the images in the timeline (http://localhost:8080/newsite/history_compare_with_current.png 
) etc, no showstopper, obviously, but if you can fix that still today  
i can give your review an unconditional +1


Might I request that review comments are emailed to the PLIP author?


meanwhile i've spoken to each on irc, next time i'll send mails.

cheers,

tom




Wichert.

--
Wichert Akkerman It is simple to make things.
http://www.wiggy.net/   It is hard to make things  
simple.





___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team

[Framework-Team] Re: PLIP #126 ready for review

[Raphael Ritz]

Andrew Burkhalter wrote:





[..]


Just for the record, this was broken for a brief time on our branch
due to some jostling around of language, but was resolved in the
following changeset:
http://dev.plone.org/plone/changeset/24272


Yup. confirmed.
Sorry, but obviously I had gotten this intermediate version before
getting on a plane the other day.



I hope that lies w/in your "as of 2009-01-16" range (e.g. it was fixed
right after you started your review).  Not sure though.  I'm not
seeing a failure right now at least.

I can look at the CMFPlone failures now.



I don't think that has anything to do with your plip but
of course it would be great to see these fixed anyway (in
case you can confirm them).

I've just checked in my comments.
http://svn.plone.org/svn/plone/review/plip126-link-redirects/REVIEW-NOTES.txt

Raphael



Andrew




___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team