Re: [Framework-Team] Re: Final review report
On Feb 4, 2009, at 5:48 PM, Steve McMahon wrote: This is a summary of the Framework Team's 3.3 PLIP bundle review status as of Wednesday: first of all, thank you steve! Reviews Not Yet Completed: 232 (review bundle never submitted) this is not correct, imo. the bundle was submitted late (it was ready, but florian never sent the mail to the list), but the team decided to review it nevertheless. so these reviews are also pending. andi -- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.2rc1 released! -- http://plone.org/products/plone/ PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: Final review report
On Feb 4, 2009, at 8:16 PM, Wichert Akkerman wrote: On 2/4/09 5:48 PM, Steve McMahon wrote: Does this give you what you need? If not, I'll be happy to add detail. Please add some detail. In particular for rejected PLIPs it should state why they were rejected and what the PLIP author has to do to get them accepted in the next round. this only applies to 234, and its PLIP page contains tom's review notes as well as a link to mine. andi -- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.2rc1 released! -- http://plone.org/products/plone/ PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: Final review report
hi wichert, On Feb 4, 2009, at 10:11 AM, Wichert Akkerman wrote: The deadline for the PLIP review report was four days ago. From what I can see not all reviews are in, and no report has been written yet. Can I please get a proper report which covers the PLIPs that have been reviewed properly, and a date when the rest will be ready as well? steve has compiled and posted an overview last saturday. i don't think we need an "official" update for that — it's only the first round of reviews after all. of course that'll be different for the final deadline, i.e. the on on february 14th. for now PLIP authors have been informed about the status of their respective implementations and should know if there's still work to do. essentially the only PLIP that still needs some atm is 234, and calvin told me before he was going to work through the issues. that said, there are still missing bundle reviews, of course. in particular both reviews for 232 as well as mine for 247. i'd like to apologize for not having submitted it yet. i simply didn't manage to do all six until last friday, after which two unforeseen circumstances essentially took up all of my spare time. i should have asked for help, but tom had already offered it at some point, so i didn't. however, as it turns out he was also overworked and otherwise pressed with time (but can't be blamed for trying to help anyway). anyway, i'll try to turn it in asap, can't really promise anything though. i hope i'll be able to wrap it up tonight, but might be kept from it once more. sorry to be so vague, but some things need to have priority. in the unlikely case anyone from the new team wants to go for a practice run, it'd be much appreciated! :) cheers, andi -- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.2rc1 released! -- http://plone.org/products/plone/ PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: Final review report
On 2/4/09 5:48 PM, Steve McMahon wrote: Hi Wichert, Does this give you what you need? If not, I'll be happy to add detail. Please add some detail. In particular for rejected PLIPs it should state why they were rejected and what the PLIP author has to do to get them accepted in the next round. Wichert. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: Final review report
thanks steve, for the summary report! there's only one thing i'd like to point out (or rather make explicit), namely, that: On 04.02.2009, at 17:48, Steve McMahon wrote: [...] PLIP #234: Standardizing our use of INavigationRoot Review Complete: -2 does not mean, that it is flat out rejected. both reviewers (i.e. andi and myself) have stated, that the current deficits are fixable within the second review phase. AFAIK calvin has already started to work on it, based on our reviews. like i said, i just wanted to state that more clearly to prevent any confusion, cheers, tom ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: Final review report
Hi Wichert, Does this give you what you need? If not, I'll be happy to add detail. This is a summary of the Framework Team's 3.3 PLIP bundle review status as of Wednesday: Reviews Complete Accepted: 126, 197, 237, 238, 239, 240, 241, 243, 246 Rejected: 234 Reviews Not Yet Completed: 232 (review bundle never submitted) 247 (+1 from MJ) Details (complete chart at http://dev.plone.org/plone/wiki/PLIPTallies33) PLIP #126: Link type should automatically redirect when accessed directly Review Complete: Based on reading the list discussion: +2 technical; +1 UI PLIP #197: Add FeedParser as external requirement Review Complete: +2 PLIP #232: Resource Registries Improvements No reviews yet. PLIP #234: Standardizing our use of INavigationRoot Review Complete: -2 PLIP #237: Minor i18n upgrades Review Complete: +2 PLIP #238: Disable inline editing by default Review Complete: +2 technical; +1 UI PLIP #239: Adapterise the Extensible Indexable Object Wrapper Review Complete: +2 PLIP #240: Improve locking configurability Review Complete: +2 technical; +1 UI PLIP #241: Clean up auto-sort: auto-order code Review Complete: +2 PLIP #243: Replace workflow history viewlet with content history viewlet Review Complete: +2 PLIP #246: View for rendering events as an iCalendar file Review: +2 PLIP #247: Automate ZCML Loading for Plone Plug-ins Review Incomplete: +1 from MJ -- Steve McMahon Reid-McMahon, LLC st...@reidmcmahon.com st...@dcn.org On Wed, Feb 4, 2009 at 1:11 AM, Wichert Akkerman wrote: > The deadline for the PLIP review report was four days ago. From what I > can see not all reviews are in, and no report has been written yet. > > Can I please get a proper report which covers the PLIPs that have been > reviewed properly, and a date when the rest will be ready as well? > > Regards, > Wichert. > > -- > Wichert Akkerman It is simple to make things. > http://www.wiggy.net/ It is hard to make things simple. > -- Steve McMahon Reid-McMahon, LLC st...@reidmcmahon.com st...@dcn.org ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: plone.z3cform and absoluteURL
Wichert Akkerman wrote: Previously Laurent Mignon wrote: How can I do to have getMultiAdapter((myWrappedForm, request), IAbsoluteURL) working when myWrappedForm is a z3c.form wrapped py plone.z3cform.layout.FormWrapper? This sounds like a question for another list (product-developers or possible plone-develop). Wichert. Sorry, I'll post on plone-develop list. Thanks ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] plone.z3cform and absoluteURL
Previously Laurent Mignon wrote: > How can I do to have getMultiAdapter((myWrappedForm, request), > IAbsoluteURL) working when myWrappedForm is a z3c.form wrapped py > plone.z3cform.layout.FormWrapper? This sounds like a question for another list (product-developers or possible plone-develop). Wichert. -- Wichert Akkerman It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] plone.z3cform and absoluteURL
Hi, How can I do to have getMultiAdapter((myWrappedForm, request), IAbsoluteURL) working when myWrappedForm is a z3c.form wrapped py plone.z3cform.layout.FormWrapper? I've the feeling that something is missing in plone.z3cform to cover this need. (maybe am I wrong...) When a z3c.form is wrapped by the FormWrapper class, nothing is done to mark the z3c.form as wrapped and to give it who is the original form (the called BrowserView). Marking the form_instance with a IWrappedForm interface and setting on it a ??_original_form?? attribute will give us the opportunity to register a dedicated adapter on IWrappedForm for IAbsoluteURL. The adapter should only return a call getMultiAdapter((myWrappedForm.??_oiginal_form???, request), IAbsoluteURL) What do you think, Thanks, sagblmi ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Final review report
The deadline for the PLIP review report was four days ago. From what I can see not all reviews are in, and no report has been written yet. Can I please get a proper report which covers the PLIPs that have been reviewed properly, and a date when the rest will be ready as well? Regards, Wichert. -- Wichert Akkerman It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
