[Framework-Team] Re: [Plone-cvs] r29756 - plone.app.layout/branches/2.0/plone/app/layout/viewlets
That needs to throught the FWT at the very least. You can't just change
that markup structure without some approval process - this can break
every third party theme.
On 2009-9-17 08:04, Alexander Limi wrote:
If it broke the standard theme, I need to fix that too. We're putting
the personal tools in a pulldown regardless of whether the new theme lands.
--
Alexander Limi ยท http://limi.net
On Wed, Sep 16, 2009 at 10:52 PM, Wichert Akkerman wich...@wiggy.net
mailto:wich...@wiggy.net wrote:
Shouldn't this be in a sunburst branch? I suspect this broke the
standard Plone skin.
On 2009-9-17 07:06, Alexander Limi wrote:
Author: limi
Date: Thu Sep 17 05:06:13 2009
New Revision: 29756
Modified:
plone.app.layout/branches/2.0/plone/app/layout/viewlets/personal_bar.pt
http://personal_bar.pt
Log:
Turn the personal actions into a pulldown menu.
Modified:
plone.app.layout/branches/2.0/plone/app/layout/viewlets/personal_bar.pt
http://personal_bar.pt
==
---
plone.app.layout/branches/2.0/plone/app/layout/viewlets/personal_bar.pt
http://personal_bar.pt (original)
+++
plone.app.layout/branches/2.0/plone/app/layout/viewlets/personal_bar.pt
http://personal_bar.pt Thu Sep 17 05:06:13 2009
@@ -6,21 +6,18 @@
h5 class=hiddenStructure
i18n:translate=heading_personal_toolsPersonal tools/h5
-ul id=portal-personaltools
-tal:condition=python:view.user_actions or not view.anonymous
-class=visualInline
-tal:block condition=not: view/anonymous
-lia
- id=user-name
- tal:attributes=href view/homelink_url
-img src= tal:replace=structure context/user.gif /
-span class=visualCaseSensitive
- tal:content=view/user_name
+dl class=actionMenu id=portal-personaltools
+tal:condition=python:view.user_actions or not view.anonymous
+tal:block condition=not: view/anonymous !-- TODO: Can we
nest these in a better way? --
+dt class=actionMenuHeader
+!-- The following a-tag needs to be clicked to dropdown the
menu --
+a id=user-name
+ tal:attributes=href view/homelink_url
+ tal:content=view/user_name
John
-/span
-/a/li
-/tal:block
-
+/a
+/dt
+dd class=actionMenuContent
tal:actions repeat=action view/user_actions
li tal:define=icon action/icon|nothing;
icon python:icon is not None and icon
or view.getIconFor(action['category'], action['id'], None);
@@ -36,6 +33,16 @@
/a
/li
/tal:actions
+/dd
+/tal:block
+/dl
+
+dl class=actionMenu id=portal-personaltools
+tal:condition=view/anonymous
+dt
+a href=
+ tal:attributes=href
string:${view/navigation_root_url}/loginLog in/a
+/dt
+/dl
-/ul
/div
--
Come build with us! The BlackBerryreg; Developer Conference in
SF, CA
is the only developer event you need to attend this year.
Jumpstart your
developing skills, take BlackBerry mobile applications to market
and stay
ahead of the curve. Join us from November 9#45;12, 2009.
Register now#33;
http://p.sf.net/sfu/devconf
___
Plone-CVS mailing list
plone-...@lists.sourceforge.net
mailto:plone-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plone-cvs
--
Wichert Akkerman wich...@wiggy.net mailto:wich...@wiggy.net It
is simple to make things.
http://www.wiggy.net/ It is hard to make things simple.
--
Wichert Akkerman wich...@wiggy.net It is simple to make things.
http://www.wiggy.net/ It is hard to make things simple.
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team
[PLIP-Advisories] Re: [Plone] #9310: User registration process more flexible
#9310: User registration process more flexible -+-- Reporter: dokter |Owner: dokter Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Changes (by rossp): * cc: khink (added) Comment: Replying to [comment:33 rossp]: Replying to [comment:32 rossp]: From khink's email: The error you mentioned should be fixed now. I still get the Error: REQUEST error on the new @@join_form. I double checked that I had the latest SVN versions of everything including your branches. Please confirm that the plone-coredev/plips/plip9310-flexible- user-registration.cfg works in a fresh environment before reporting it fixed again so I can re-run the load tests against it. Also, please document the rest of your work here in the ticket. Finally, can you address the rest of the feedback in my review? -- Ticket URL: http://dev.plone.org/plone/ticket/9310#comment:34 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #8802: Move our upgrade / migration infrastructure to GenericSetup
#8802: Move our upgrade / migration infrastructure to GenericSetup ---+ Reporter: hannosch |Owner: davisagli Type: PLIP | Status: assigned Priority: minor |Milestone: 4.0 Component: Upgrade/Migration | Resolution: Keywords: | ---+ Comment(by esteele): Your PLIP has been reviewed by the Framework team. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/8802#comment:20 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #8814: Replace SecureMailHost with a standard Zope mailhost
#8814: Replace SecureMailHost with a standard Zope mailhost +--- Reporter: hannosch|Owner: alecm Type: PLIP| Status: assigned Priority: n/a |Milestone: 4.0 Component: Infrastructure | Resolution: Keywords: | +--- Comment(by esteele): Your PLIP has been reviewed by the Framework team. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/8814#comment:41 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9214: support logins using e-mail address instead of user id
#9214: support logins using e-mail address instead of user id ---+ Reporter: davisagli |Owner: maurits Type: PLIP | Status: assigned Priority: minor |Milestone: 4.0 Component: Unknown| Resolution: Keywords: | ---+ Comment(by esteele): Your PLIP has been reviewed by the Framework team. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9214#comment:32 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9256: Expand variable substitution in mailing action of plone.app.contentrules
#9256: Expand variable substitution in mailing action of plone.app.contentrules ---+ Reporter: smcmahon |Owner: smcmahon Type: PLIP | Status: assigned Priority: minor |Milestone: 4.0 Component: Content Rules | Resolution: Keywords: | ---+ Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9256#comment:32 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9263: GenericSetup syntax for importing Sharing page roles
#9263: GenericSetup syntax for importing Sharing page roles +--- Reporter: optilude|Owner: optilude Type: PLIP| Status: assigned Priority: major |Milestone: 4.0 Component: Infrastructure | Resolution: Keywords: | +--- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9263#comment:20 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9264: Merge backport patches from plone.app.dexterity into Plone
#9264: Merge backport patches from plone.app.dexterity into Plone +--- Reporter: optilude|Owner: optilude Type: PLIP| Status: assigned Priority: major |Milestone: 4.0 Component: Infrastructure | Resolution: Keywords: | +--- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9264#comment:27 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9288: Improved commenting infrastructure
#9288: Improved commenting infrastructure +--- Reporter: timo|Owner: timo Type: PLIP| Status: assigned Priority: minor |Milestone: 4.0 Component: Infrastructure | Resolution: Keywords: | +--- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9288#comment:27 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9305: Use real names instead of usernames
#9305: Use real names instead of usernames --+- Reporter: laurenskling |Owner: ralphjacobs Type: PLIP | Status: assigned Priority: minor |Milestone: 4.0 Component: Unknown | Resolution: Keywords:| --+- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9305#comment:24 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:20 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9310: User registration process more flexible
#9310: User registration process more flexible -+-- Reporter: dokter |Owner: dokter Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9310#comment:35 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9316: Unify folder implementations
#9316: Unify folder implementations +--- Reporter: smcmahon|Owner: witsch Type: PLIP| Status: assigned Priority: n/a |Milestone: 4.0 Component: Infrastructure | Resolution: Keywords: | +--- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9316#comment:26 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9321: Reimplement the search form with an eye on usability
#9321: Reimplement the search form with an eye on usability -+-- Reporter: csenger |Owner: csenger Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: | -+-- Comment(by esteele): Your PLIP has passed the Framework team's initial review. Feel free to discuss any suggested changes either here in the PLIP ticket or on the mailing lists. Final deadline for this PLIP is set for September 30. -- Ticket URL: http://dev.plone.org/plone/ticket/9321#comment:27 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9309: Better search for East Asian (multi-byte) languages.
#9309: Better search for East Asian (multi-byte) languages. -+-- Reporter: terapyon |Owner: terapyon Type: PLIP | Status: assigned Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: Keywords: search splitter CJK | -+-- Comment(by terapyon): Thank you for reviewing my code. 1) Don't use monkey patch. OK, I will create new branche on both Zope and Plone. 2) Broken livesearch. I think that problem is not cause by our code. In Plone 3.3.0, it was already broken. Then in Plone 3.3.1 it became functional. There must be some other code doing that. 3) UnicodeDecodeError and not using re.LOCALE I will modify my code to use re.LOCALE. But I have no idea, when and how to use it? 4) Performance As I see, performance of code comes after functional of code, isn't it? 5) Functions nameing and not docstrings. I will rename functions and write docstrings. 6) Using fuctions and args. I will modiry it. 7) Test coverage. OK, I will write additional tests after I have made regained change. 8) Don't use functions. I will check it. 9) Last. I and my development team should have finished revising old code by end of SEP. And I'm going to join on 21th Plone Tune-Up day from Japan. -- Ticket URL: http://dev.plone.org/plone/ticket/9309#comment:21 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
