[PLIP-Advisories] Re: [Plone] #9310: User registration process more flexible
#9310: User registration process more flexible
-+--
Reporter: dokter |Owner: dokter
Type: PLIP | Status: assigned
Priority: minor|Milestone: 4.0
Component: Unknown | Resolution:
Keywords: |
-+--
Comment(by khink):
The Error: REQUEST happens after the new user is created. This happens
finally in
'Products.PlonePAS.plugins.role.getRolesForPrincipal', which assumes it
has a 'REQUEST' on it. It doesn't. Also, the method takes an optional
'request' argument, which doesn't seem to be used.
I'm not sure what the idea behind this is. The attached patch fixes the
Error: REQUEST. It simply tests if 'self' has a 'REQUEST' attr, before
trying to fetch it. As this may have consequences, i would like a second
opinion on this.
{{{
Index: Products.PlonePAS/Products/PlonePAS/plugins/role.py
===
--- Products.PlonePAS/Products/PlonePAS/plugins/role.py (revision 97735)
+++ Products.PlonePAS/Products/PlonePAS/plugins/role.py (working copy)
@@ -112,8 +112,9 @@
# the ones he got through his groups. In this case, the
# '__ignore_group_roles__'= True should be previously pushed
# in the request.
-if not self.REQUEST.get('__ignore_group_roles__', False) and
hasattr(principal, 'getGroups'):
-principal_ids.extend( principal.getGroups() )
+if hasattr(self, 'REQUEST'):
+if not self.REQUEST.get('__ignore_group_roles__', False) and
hasattr(principal, 'getGroups'):
+principal_ids.extend( principal.getGroups() )
for pid in principal_ids:
roles.extend( self._principal_roles.get( pid, () ) )
return tuple( unique( roles ) )
}}}
--
Ticket URL: http://dev.plone.org/plone/ticket/9310#comment:37
Plone http://plone.org
Plone Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9256: Expand variable substitution in mailing action of plone.app.contentrules
#9256: Expand variable substitution in mailing action of plone.app.contentrules ---+ Reporter: smcmahon |Owner: smcmahon Type: PLIP | Status: assigned Priority: minor |Milestone: 4.0 Component: Content Rules | Resolution: Keywords: | ---+ Comment(by smcmahon): (In [29803]) Add browser view for getting a list of substitutions; add category and discription information. refs #9256 -- Ticket URL: http://dev.plone.org/plone/ticket/9256#comment:35 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9256: Expand variable substitution in mailing action of plone.app.contentrules
#9256: Expand variable substitution in mailing action of plone.app.contentrules ---+ Reporter: smcmahon |Owner: smcmahon Type: PLIP | Status: assigned Priority: minor |Milestone: 4.0 Component: Content Rules | Resolution: Keywords: | ---+ Comment(by smcmahon): (In [29804]) Add UI for substitution listing. refs #9256 -- Ticket URL: http://dev.plone.org/plone/ticket/9256#comment:36 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
Re: [Framework-Team] PLIPs and plone.pot
On Sun, Sep 20, 2009 at 11:00 PM, Steve McMahon st...@dcn.org wrote: It looks like I'd need to branch collective/PloneTranslations, then branch plone.app.locales in order to make the externals point to the new collective/PloneTranslations branch. But, I don't see a sign that anyone's ever done it that way before. So, I suspect I'm on the wrong track That would be the only technical way to make a branch indeed. Anybody got a handle on the right way to add to the .pot for a PLIP? The right way is not to care about updating the pot files before PLIP's are merged. All messages are extracted automatically anyways and should only be exposed to the translators once the corresponding PLIP is approved and merged. You can run the i18ndude extract on your branches and see if they pick up all messages correctly - just don't commit it. Hanno ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
