[PLIP-Advisories] Re: [Plone] #9310: User registration process more flexible
#9310: User registration process more flexible
-+--
Reporter: dokter |Owner: dokter
Type: PLIP | Status: closed
Priority: minor|Milestone: 4.0
Component: Unknown | Resolution: fixed
Keywords: |
-+--
Comment(by maurits):
I get several failures like the next because home page and location are
not on the join form by default anymore. Perhaps this worked on the
branch but not after merging to trunk? Could this have something to do
with the new Plone theme?
{{{
$ bin/instance test -s plone.app.users
...
File /home/maurits/buildout/plone-
coredev/4.0/src/plone.app.users/plone/app/users/tests/flexible_user_registration.txt,
line 10, in flexible_user_registration.txt
Failed example:
form.getControl(name='form.location')
Exception raised:
Traceback (most recent call last):
File /home/maurits/shared-
eggs/zope.testing-3.7.7-py2.6.egg/zope/testing/doctest.py, line 1361, in
__run
compileflags, 1) in test.globs
File doctest flexible_user_registration.txt[line 10, example 3],
line 1, in module
form.getControl(name='form.location')
File /home/maurits/shared-
eggs/zope.testbrowser-3.6.0a2-py2.6.egg/zope/testbrowser/browser.py, line
755, in getControl
control, form = disambiguate(intermediate, msg, index)
File /home/maurits/shared-
eggs/zope.testbrowser-3.6.0a2-py2.6.egg/zope/testbrowser/browser.py, line
54, in disambiguate
raise LookupError(msg)
LookupError: name 'form.location'
}}}
I am trying to integrate this plip with plip #9214 (see ticket #9643) and
having successful tests before I start would be nice.
This is with r30654. I did some test and pep8/pyflakes fixes after that
which did not result in extra test failures. And I have begun integrating
that plip anyway. Sorry if I step on anyone's foot. :)
--
Ticket URL: http://dev.plone.org/plone/ticket/9310#comment:48
Plone http://plone.org
Plone Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9310: User registration process more flexible
#9310: User registration process more flexible -+-- Reporter: dokter |Owner: dokter Type: PLIP | Status: closed Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: fixed Keywords: | -+-- Comment(by maurits): (In [30720]) Integrated the 'email as login' plip (#9214). Made the email field and widget ascii-only, otherwise you get validation errors or unicode errors when trying to log in. Always show the email field. Made the code more robust against input errors, at least for the username and email fields. Fixes #9643, refs #9310 and refs#9214. -- Ticket URL: http://dev.plone.org/plone/ticket/9310#comment:49 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
[PLIP-Advisories] Re: [Plone] #9310: User registration process more flexible
#9310: User registration process more flexible -+-- Reporter: dokter |Owner: dokter Type: PLIP | Status: closed Priority: minor|Milestone: 4.0 Component: Unknown | Resolution: fixed Keywords: | -+-- Comment(by maurits): Okay, I made the changes necessary for proper handling of the email login plip in the new @@join_form. See r30720 for details. Some remarks for clarity follow. I made sure the email widget is always displayed, as this field has always been required. If wanted I could do this only when the email address is used as login (#9214), but there are more cases, like for the 'mail_me' field. The email field is now an ASCIIField and uses an ASCIIWidget, as non-ascii emails are not accepted by the email regular expression in the registration tool, and even if you have only ascii the input value is still unicode and when using such an email address as login you run into a unicode error when hashing the username in plone.protect. I protected the code against a few InputErrors (WidgetInputError, ValidationError, ConversionError). For instance, adding accented characters in the username resulted in a traceback instead of a friendly widget error shown in the form. Oh, and a ConflictError was caught and turned into a status message, but I have changed that to raise the Exception so Zope can handle it, which is how those ConflictErrors should be handled AFAIK. In CMFPlone I changed tests/emaillogin.txt to use the new @@join_form; tests are passing; changeset is r30721. The same may need to be done for csrf.txt, but I am already getting errors on the unchanged file, so I am trying not to get side tracked there. :-) -- Ticket URL: http://dev.plone.org/plone/ticket/9310#comment:50 Plone http://plone.org Plone Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org http://lists.plone.org/mailman/listinfo/plip-advisories
