Re: [Framework-Team] PLIP #10778 (UUIDs) - ready for initial review

2010-08-29 Thread Wichert Akkerman
On 2010-8-29 07:24, Martin Aspeli wrote:
 The principal API is the IUUID() adapter factory, which can be used to
 return a (byte string) UUID. There is also an IUUIDGenerator utility
 to generate new UUIDs. The default implementation uses the standard
 library uuid.uuid1() method.

Please change that to use uuid4() instead. uuid1() uses the unique 
hardware address of the machine it runs on to generate the UUID, which 
means the result UUID can be used to track down the specific machine 
used to generate it. This has been used succesfully to track down people 
and machines, and for that reason everyone has switched to the random 
based approach as implemented by uuid4().

Wichert.

-- 
Wichert Akkerman wich...@wiggy.net   It is simple to make things.
http://www.wiggy.net/  It is hard to make things simple.
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] PLIP #10778 (UUIDs) - ready for initial review

2010-08-29 Thread Martin Aspeli
On 29 August 2010 17:41, Wichert Akkerman wich...@wiggy.net wrote:
 On 2010-8-29 07:24, Martin Aspeli wrote:
 The principal API is the IUUID() adapter factory, which can be used to
 return a (byte string) UUID. There is also an IUUIDGenerator utility
 to generate new UUIDs. The default implementation uses the standard
 library uuid.uuid1() method.

 Please change that to use uuid4() instead. uuid1() uses the unique
 hardware address of the machine it runs on to generate the UUID, which
 means the result UUID can be used to track down the specific machine
 used to generate it. This has been used succesfully to track down people
 and machines, and for that reason everyone has switched to the random
 based approach as implemented by uuid4().

Done.

Martin
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] 4.1 not available as milestone?

2010-08-29 Thread Geir Bækholt

Adding a new PLIP, i am not able to select 4.1 as a milestone. Only 4.0 
exists in the vocabulary.

-- 
Geir Bækholt
www.jarn.com/baekholt

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] 4.1 not available as milestone?

2010-08-29 Thread David Glick
 On 8/29/10 2:26 PM, Geir Bækholt wrote:
 Adding a new PLIP, i am not able to select 4.1 as a milestone. Only 4.0 
 exists in the vocabulary.
4.1 shows for me.
--  
David Glick
 Web Developer
 davidgl...@groundwire.org
 206.286.1235x32

Groundwire: You Are Connected   
 http://groundwire.org  
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] 4.1 not available as milestone?

2010-08-29 Thread Geir Bækholt
On 29-08-2010 23.26, Geir Bækholt wrote:

 Adding a new PLIP, i am not able to select 4.1 as a milestone. Only 4.0
 exists in the vocabulary.

It is now. Problem solved.


-- 
Geir Bækholt
www.jarn.com/baekholt

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] New PLIP ready for initial review: Content governance metadata

2010-08-29 Thread Geir Bækholt

https://dev.plone.org/plone/ticket/11003

Proposal for adding a responsible person field and making some changes 
to the expiry date field, in order to make it simpler to work maintain 
and manage large amounts of Plone content over time.

-- 
Geir Bækholt
www.jarn.com/baekholt

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] plone.uuid behaviour

2010-08-29 Thread Wichert Akkerman
I'm noticing something odd with plone.uuid: if you use the adapter on an 
object which is marked with IAttributeUUID but which does not have a UID 
you get an Could not adapt TypeError when you do IUUID(obj). That 
error is misleading and confusing: the adaption worked fine, but ZCA 
does not like an adapter factory returning None. That makes the API a 
bit awkward, so I would suggest to replace the IUUID adaptor based 
approach with a simpler helper function.

Wichert.

-- 
Wichert Akkerman wich...@wiggy.net   It is simple to make things.
http://www.wiggy.net/  It is hard to make things simple.
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


Re: [Framework-Team] plone.uuid behaviour

2010-08-29 Thread Wichert Akkerman
On 2010-8-30 01:21, Martin Aspeli wrote:
 On 30 August 2010 07:37, Wichert Akkermanwich...@wiggy.net  wrote:
 I'm noticing something odd with plone.uuid: if you use the adapter on an
 object which is marked with IAttributeUUID but which does not have a UID
 you get an Could not adapt TypeError when you do IUUID(obj). That
 error is misleading and confusing: the adaption worked fine, but ZCA
 does not like an adapter factory returning None. That makes the API a
 bit awkward, so I would suggest to replace the IUUID adaptor based
 approach with a simpler helper function.

 -1 -- We need to have an adapter for looking this up. For example, the
 AT integration needs a different storage than IAttributeUUID, which is
 only one choice.

I did not see not use an adapter. I said use a simple method to make the 
API nicer. That method can use an adapter internally. For example:

_marker=[]
def getUUID(obj):
 u=IUUID(obj _marker)
 if u is _marker:
 raise TypeError(UUID not supported)
 return u

 You can do:

 uuid = IUUID(context, None)

Do you expect people to always use that calling convention? My guess is 
that it will forgotten more often than not, resulting in hard to 
interpret errors too often. The wrapper method has the advantage of
having a more intuitive name and can distinguish between missing UUID 
support and a None UUID, while not loosing any functionality.

Wichert.

-- 
Wichert Akkerman wich...@wiggy.net   It is simple to make things.
http://www.wiggy.net/  It is hard to make things simple.
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team