Re: [Framework-Team] PLIP #239 ready for review

2009-01-25 Thread Martijn Pieters
On Sun, Jan 11, 2009 at 18:56, Martin Aspeli optilude+li...@gmail.com wrote:
 I've just finished the base implementation of PLIP #239, adapterise the
 ExtensibleIndexableObjectWrapper, for your review.

This PLIP gets my +1.

As usual, Martin delivers. Great implementation, great documentation. I did
add one sentence to the README to clarify why IIndexer adapters cannot be used
for workflow variables; it was a question I had while reviewing. No further
comments required. :-)

-- 
Martijn Pieters

___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team


[Framework-Team] PLIP #239 ready for review

2009-01-11 Thread Martin Aspeli

Hello team,

I've just finished the base implementation of PLIP #239, adapterise the 
ExtensibleIndexableObjectWrapper, for your review.


I've not created a branched buildout, mainly because it takes so long to 
check out a full coredev. Instead, please follow the following instructions:


 $ cd your checkout of plone-coredev/branches/3.2
 $ cd src
 $ svn co https://svn.plone.org/svn/plone/plone.indexer/trunk plone.indexer
 $ cd ../Plone
 $ svn switch https://svn.plone.org/svn/plone/Plone/branches/plip-239
 $ cd ../../
 $ ./bin/buildout

The bulk of the code is in a new package, plone.indexer. You can read 
its doctest here: 
http://dev.plone.org/plone/browser/plone.indexer/trunk/plone/indexer/README.txt


I've tried to make this test read as a manual for how to write new 
indexers. In short, you do:


 @indexer(IMyType)
 def index_my_attribute(object, **kargs):
 return some value to index

 adapter factory=.indexers.index_my_attribute name=my_attribute /

The changes to Products.CMFPlone are just to load plone.indexer and use 
it instead of the old ExtensibleIndexableObjectWrapper.


There is one outstanding change that I'll do if and when I merge this: 
in plone.app.content, we need to add a deprecated deferred-import for 
the IIndexableObjectWrapper interface, which I've moved to the new 
plone.indexer package.


I've updated http://plone.org/products/plone/roadmap/239 to reflect the 
current state of the PLIP.


Cheers,
Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book


___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team