Re: [Framework-Team] PLIP 197 ready for review: feedparser as external dependency
On Wed, Dec 31, 2008 at 17:19, Maurits van Rees wrote: > PLIP 197: Add FeedParser as external requirement instead of shipping with it > > > See http://plone.org/products/plone/roadmap/197 > > Basically the only thing that needs doing is: > > - Remove portlets/feedparser.py from plone.app.portlets. > > - Instead add FeedParser as requirement in setup.py. > > This has been done on this branch (see src/plone.app.portlets in this > buildout): > > > https://svn.plone.org/svn/plone/plone.app.portlets/branches/plip197-feedparser-as-external-egg This looks great, it is indeed as simple as this. +1 from me. > One possible gotcha is that the *package* is called ``FeedParser`` and > the *module* contained in that package is called ``feedparser``. > ``easy_install`` can handle both spellings just fine. But I once > encountered problems when using the lowercased name in setup.py. See > http://dev.plone.org/plone/ticket/7299 (which is where this plip > originated). I could not reproduce that later, but I say we call the > dependency ``FeedFeeder`` and everything should work. I take it you meant 'FeedParser' in that last sentence ;-) The name difference is perfectly normal. Eggs can contain more than one module and thus the egg name must be independent, and there are more eggs whose name does not match the contained module(s). A case in point is the Plone egg, which contains the Products.Plone module. -- Martijn Pieters ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP 197 ready for review: feedparser as external dependency
On Jan 18, 2009, at 3:21 PM, Wichert Akkerman wrote: How come this PLIP has not been reviewed yet? I think we agreed to encourage people to submit PLIPs early so the framework team can start earlier as well in order to reduce the workload? i reckon none of the fwt members have had enough time to review it. iow, the plan & good intentions haven't worked out... andi -- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.1.7 released! -- http://plone.org/products/plone/ PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP 197 ready for review: feedparser as external dependency
How come this PLIP has not been reviewed yet? I think we agreed to encourage people to submit PLIPs early so the framework team can start earlier as well in order to reduce the workload? Wichert. Previously Maurits van Rees wrote: > > The buildout is here: > https://svn.plone.org/svn/plone/review/plip197-feedparser > > Note that I will not be online the next few days, so be patient when > you have questions. > > I'll paste the README.txt below for convenience. > > > PLIP 197: Add FeedParser as external requirement instead of shipping with it > > > See http://plone.org/products/plone/roadmap/197 > > Basically the only thing that needs doing is: > > - Remove portlets/feedparser.py from plone.app.portlets. > > - Instead add FeedParser as requirement in setup.py. > > This has been done on this branch (see src/plone.app.portlets in this > buildout): > > > https://svn.plone.org/svn/plone/plone.app.portlets/branches/plip197-feedparser-as-external-egg > > > One possible gotcha is that the *package* is called ``FeedParser`` and > the *module* contained in that package is called ``feedparser``. > ``easy_install`` can handle both spellings just fine. But I once > encountered problems when using the lowercased name in setup.py. See > http://dev.plone.org/plone/ticket/7299 (which is where this plip > originated). I could not reproduce that later, but I say we call the > dependency ``FeedFeeder`` and everything should work. > > ``bin/test`` will run the plone.app.portlets tests. > > > Happy New Year! > > -- > Maurits van Rees | http://maurits.vanrees.org/ > Work | http://zestsoftware.nl/ > "This is your day, don't let them take it away." [Barlow Girl] > > > ___ > Framework-Team mailing list > Framework-Team@lists.plone.org > http://lists.plone.org/mailman/listinfo/framework-team -- Wichert Akkerman It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] PLIP 197 ready for review: feedparser as external dependency
The buildout is here: https://svn.plone.org/svn/plone/review/plip197-feedparser Note that I will not be online the next few days, so be patient when you have questions. I'll paste the README.txt below for convenience. PLIP 197: Add FeedParser as external requirement instead of shipping with it See http://plone.org/products/plone/roadmap/197 Basically the only thing that needs doing is: - Remove portlets/feedparser.py from plone.app.portlets. - Instead add FeedParser as requirement in setup.py. This has been done on this branch (see src/plone.app.portlets in this buildout): https://svn.plone.org/svn/plone/plone.app.portlets/branches/plip197-feedparser-as-external-egg One possible gotcha is that the *package* is called ``FeedParser`` and the *module* contained in that package is called ``feedparser``. ``easy_install`` can handle both spellings just fine. But I once encountered problems when using the lowercased name in setup.py. See http://dev.plone.org/plone/ticket/7299 (which is where this plip originated). I could not reproduce that later, but I say we call the dependency ``FeedFeeder`` and everything should work. ``bin/test`` will run the plone.app.portlets tests. Happy New Year! -- Maurits van Rees | http://maurits.vanrees.org/ Work | http://zestsoftware.nl/ "This is your day, don't let them take it away." [Barlow Girl] ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
