[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

Oleksandr Tymoshenko  changed:

   What|Removed |Added

 CC||go...@freebsd.org
 Status|New |Closed
 Resolution|--- |FIXED

--- Comment #8 from Oleksandr Tymoshenko  ---
There is a commit referencing this PR, but it's still not closed and has been
inactive for some time. Closing the PR as fixed but feel free to re-open it if
the issue hasn't been completely resolved.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

--- Comment #7 from commit-h...@freebsd.org ---
A commit references this bug:

Author: kib
Date: Mon Feb  5 10:29:58 UTC 2018
New revision: 328879
URL: https://svnweb.freebsd.org/changeset/base/328879

Log:
  MFC r328773:
  On pageout, in vnode generic pager, for partially dirty page, only
  clear dirty bits for completely invalid blocks.

  PR:   225586

Changes:
_U  stable/11/
  stable/11/sys/vm/vnode_pager.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

--- Comment #6 from tris_v...@hotmail.com ---
(In reply to Peter Holm from comment #4)
Thanks for the fix and the testing. It did fix the problem for me as well after
rebuilding the kernel on 11-STABLE. I am unfamiliar with the test suite
however.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

--- Comment #5 from commit-h...@freebsd.org ---
A commit references this bug:

Author: kib
Date: Fri Feb  2 11:56:30 UTC 2018
New revision: 328773
URL: https://svnweb.freebsd.org/changeset/base/328773

Log:
  On pageout, in vnode generic pager, for partially dirty page, only
  clear dirty bits for completely invalid blocks.

  Otherwise we might not write out the last chunk that is shorter than
  512 bytes, if the file end is not aligned on disk block boundary.
  This become important after the r324794.

  PR:   225586
  Reported by:  tris_v...@hotmail.com
  Tested by:pho
  Sponsored by: The FreeBSD Foundation
  MFC after:3 days

Changes:
  head/sys/vm/vnode_pager.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

--- Comment #4 from Peter Holm  ---
(In reply to Konstantin Belousov from comment #3)
The patch fixed the issue for me. I ran all of the stress2 mmap() test cases
and a buildworld. No problems seen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

--- Comment #3 from Konstantin Belousov  ---
(In reply to Konstantin Belousov from comment #2)
THis is a simple change, but if you can run all mmap(2) tests, I will believe
into it correctness much easier.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

Konstantin Belousov  changed:

   What|Removed |Added

 CC||k...@freebsd.org

--- Comment #2 from Konstantin Belousov  ---
Created attachment 190246
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=190246=edit
For partially dirty page, only clear dirty bits for completely invalid device
blocks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

Peter Holm  changed:

   What|Removed |Added

 CC||p...@freebsd.org

--- Comment #1 from Peter Holm  ---
Problem reproduced on 12.0-CURRENT #0 r328587.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

[Bug 225586] ftruncate+mmap+fsync fails for small maps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225586

Bug ID: 225586
   Summary: ftruncate+mmap+fsync fails for small maps
   Product: Base System
   Version: 11.1-STABLE
  Hardware: amd64
OS: Any
Status: New
  Severity: Affects Many People
  Priority: ---
 Component: misc
  Assignee: freebsd-bugs@FreeBSD.org
  Reporter: tris_v...@hotmail.com

Created attachment 190220
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=190220=edit
test on tmp filesystem that can be unmounted

When doing an ftruncate+mmap+fsync to a size less than 512 bytes the data never
seems to be sync'd properly to disk.

This work fine on the latest 11.1-RELEASE but not the latest 11.1-STABLE. It is
also ok if the ftruncate is to the existing file size.

While the mapped changes are visible in the file before an umount, after even a
failed umount, the changes are no longer present.


(non-error checked) C code below.

After running the binary, check the contents of the file (eg hd) and it will be
all 0xFF. Then, umount the filesystem you are on*. Then check the contents of
the file again. It will now be 0x01.

Running extra sync's or fsync's from the command line before the umount doesn't
seem to help.

* The umount should fail but still shows the problem. However note it doesn't
seem to work with the error given for the root filesystem "/".

I've also attached a script that creates a filesystem to umount

---

#include 
#include 
#include 
#include 
#include 
#include 

int
main (int argc, char *argv[])
{
   int fd;
   size_t i, size1, size2;
   char *data;
   char *filename;
   char pattern = 0x01;

   if (argc < 2) {
  fprintf(stderr, "Usage: %s filename size1 size2\n", argv[0]);
  exit(1);
   }

   filename = argv[1];
   size1 = atoi(argv[2]);
   size2 = atoi(argv[3]);

   fd = open(filename, O_RDWR | O_TRUNC | O_CREAT, 0644);
   for (i = 0; i < size1; i++)
  write(fd, , 1);
   close(fd);

   fd = open(filename, O_RDWR, 0644);
   ftruncate(fd, size2);
   data = mmap(NULL, size2, PROT_READ|PROT_WRITE,MAP_SHARED,fd,0);
   memset(data, 0xFF, size2);
   fsync(fd);

   munmap(data, size2);
   close(fd);
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"