Re: PAM forgets to unblock signals [was Terminal line discipline is broken [sorta]]
Bruce Evans wrote:
On Wed, 6 Jun 2001, Maxim Sobolev wrote:
It is very strange, but control keys [^C,^Z etc] no longer work (nop)
in the /bin/sh and bash2 after today's build/installworld. I see this
misbehaviour on two machines.
PAM now blocks keyboard signals when reading the password, and usually
forgets to unblock them. I use the workaround of backing out the broken
code (rev.1.4 of /usr/src/contrib/libpam/libpam_misc/misc_conv.c).
That explains... Attached patch solved the problem for me.
Even more strange that /bin/tcsh doesn't
have this problem.
This may be a bug in tcsh.
Maybe...
-Maxim
Index: misc_conv.c
===
RCS file: /home/ncvs/src/contrib/libpam/libpam_misc/misc_conv.c,v
retrieving revision 1.4
diff -d -u -r1.4 misc_conv.c
--- misc_conv.c 2001/06/04 20:59:49 1.4
+++ misc_conv.c 2001/06/07 08:10:55
@@ -132,6 +132,7 @@
static char *read_string(int echo, const char *prompt)
{
struct termios term_before, term_tmp;
+char *input;
char line[INPUTSIZE];
struct sigaction old_sig;
int delay, nc, have_term=0;
@@ -191,8 +192,6 @@
if (expired) {
delay = get_delay();
} else if (nc 0) { /* we got some user input */
- char *input;
-
if (nc 0 line[nc-1] == '\n') { /* NUL terminate */
line[--nc] = '\0';
} else {
@@ -201,25 +200,27 @@
input = x_strdup(line);
_pam_overwrite(line);
- return input; /* return malloc()ed string */
+ goto cleanexit; /* return malloc()ed string */
} else if (nc == 0) {/* Ctrl-D */
char *input;
D((user did not want to type anything));
input = x_strdup();
- return input; /* return malloc()ed string */
+ goto cleanexit; /* return malloc()ed string */
}
}
}
/* getting here implies that the timer expired */
+memset(line, 0, INPUTSIZE); /* clean up */
+input = NULL;
+
+cleanexit:
if (have_term) {
(void)_sigprocmask(SIG_SETMASK, oset, NULL);
(void) tcsetattr(STDIN_FILENO, TCSADRAIN, term_before);
}
-
-memset(line, 0, INPUTSIZE); /* clean up */
-return NULL;
+return input;
}
/* end of read_string functions */
Re: PAM forgets to unblock signals [was Terminal line discipline is broken [sorta]]
That explains... Attached patch solved the problem for me. I have a functionally similar but less clean patch in BDE's court for testing. Thanks for letting me know this works - I'll commit it. M Content-Type: text/plain; charset=koi8-r; name=misc_conv.c.diff Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename=misc_conv.c.diff -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: mdconfig and _virtual_ memory
In message [EMAIL PROTECTED], Mikhail Teterin write s: When I moved to mdconfig, I figured I have to use ``-t swap'' for the same effect, but it seems, I was wrong -- apparently, ``swap'' means the filesystem will always hit the disk, even if there is plenty of RAM to go around. My suspicion was further confirmed, by disabling the swapping at all -- the mdconfig-ed device stopped working -- disklabel got ENOMEM. The swap backing in md(4) is a straight copy of the code which lived in vn(4). I'm not terribly familiar with that code, but I would expect that it would work with no swap space as well. Your man is probably Matt Dillon... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: PAM forgets to unblock signals [was Terminal line discipline isbroken [sorta]]
On Thu, 7 Jun 2001, Mark Murray wrote:
That explains... Attached patch solved the problem for me.
I have a functionally similar but less clean patch in BDE's court
for testing. Thanks for letting me know this works - I'll commit
it.
Yours seems to be more clean (it's shorter and uses to fewer gotos).
Why not reduce it to 1 line by putting the sigprocmask() together with
the tcsetattr() for the usual case like it already is for the unusual
case?
Index: misc_conv.c
===
RCS file: /home/ncvs/src/contrib/libpam/libpam_misc/misc_conv.c,v
retrieving revision 1.4
diff -u -2 -r1.4 misc_conv.c
--- misc_conv.c 2001/06/04 20:59:49 1.4
+++ misc_conv.c 2001/06/07 10:19:02
@@ -182,4 +182,5 @@
nc = read(STDIN_FILENO, line, INPUTSIZE-1);
if (have_term) {
+ (void)_sigprocmask(SIG_SETMASK, oset, NULL);
(void) tcsetattr(STDIN_FILENO, TCSADRAIN, term_before);
if (!echo || expired) /* do we need a newline? */
Bruce
To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message
dual athlons
Just curious, but are there plans to support the EV6 bus that the dual athlon motherboards use? I'm not going to buy that kind of system unless FreeBSD 5 will support it. Ken To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
installworld dies .../usr/share/examples/ipfw/change_rules.sh
I cvsup'd sources at about 13:00 MST 6-Jun-2001 make -j6 -DNOPROFILE=true buildworld --- Completed successfully make -DNOPROFILE=true installworld --- Failed as follows. install -c -o root -g wheel -m 644 ipfw/change_rules.sh /usr/share/examples/ipfw/change_rules.sh install: /usr/share/examples/ipfw/change_rules.sh: No such file or directory *** Error code 71 Stop in /usr/src/share/examples. *** Error code 1 Stop in /usr/src/share. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Went to /usr/share/examples and found that the ipfw directory did not exist. My successful work-around was to create it manually and re-run the installworld. I only track -current on occasion. Previous upgrade was Mar18,2001. src/share/examples/ipfw/change_rules.sh was new to the tree as of yesterday. This failure smacks of a Makefile deficiency. Is this a valid problem? Did I grab my cvsup at an unlucky time in relation to this file being recently committed? Did I commit an egregious error by using the -j6 switch in the buildworld? 1 3 o 1 3 13o13 BoB To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: dual athlons
* Kenneth Wayne Culver [EMAIL PROTECTED] [010607 16:18] wrote: Just curious, but are there plans to support the EV6 bus that the dual athlon motherboards use? I'm not going to buy that kind of system unless FreeBSD 5 will support it. Rumor has it that it booted without a hitch when it was tested. -- -Alfred Perlstein [[EMAIL PROTECTED]] Instead of asking why a piece of software is using 1970s technology, start asking why software is ignoring 30 years of accumulated wisdom. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: dual athlons
Just curious, but are there plans to support the EV6 bus that the dual athlon motherboards use? I'm not going to buy that kind of system unless FreeBSD 5 will support it. FreeBSD works just fine on the dual K7 evaluation systems that AMD have been shipping around. It seems that they wimped out and licensed Intel's APIC design/interface, presumably because Microsoft wouldn't add OpenAPIC support to NT, so the boards look just like ordinary SMP x86 systems. -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: dual athlons
From: Kenneth Wayne Culver [EMAIL PROTECTED] Subject: dual athlons Date: Thu, 7 Jun 2001 16:18:13 -0400 (EDT) Just curious, but are there plans to support the EV6 bus that the dual athlon motherboards use? I'm not going to buy that kind of system unless FreeBSD 5 will support it. Both FreeBSD 4 and 5 already support it. - Jordan To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: dual athlons
Alfred Perlstein wrote: * Kenneth Wayne Culver [EMAIL PROTECTED] [010607 16:18] wrote: Just curious, but are there plans to support the EV6 bus that the dual athlon motherboards use? I'm not going to buy that kind of system unless FreeBSD 5 will support it. Rumor has it that it booted without a hitch when it was tested. Not rumor, it is definate. At least 4.2+ and 5.0 work without a hitch. In fact, they work better than most intel or serverworks chipset based systems as they comply better with the MP spec. One gotcha.. Make sure that the bios is set to 'MP SPEC 1.4' (not 1.1) and that 'PCI USE APIC' is on. The AMD developer boards (Tyan Thunder K7, which went on sale on Tuesday this week) have had various different sets of defaults for these with different bios revs, so check them. Cheers, -Peter -- Peter Wemm - [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] All of this is for nothing if we don't go to the stars - JMS/B5 To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: dual athlons
Do they still perform better than the regular apic from INTEL though? I mean it IS an EV6 bus. On Thu, 7 Jun 2001, Mike Smith wrote: Just curious, but are there plans to support the EV6 bus that the dual athlon motherboards use? I'm not going to buy that kind of system unless FreeBSD 5 will support it. FreeBSD works just fine on the dual K7 evaluation systems that AMD have been shipping around. It seems that they wimped out and licensed Intel's APIC design/interface, presumably because Microsoft wouldn't add OpenAPIC support to NT, so the boards look just like ordinary SMP x86 systems. -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: dual athlons
I guess it won't be a waste of money then. :-) On Thu, 7 Jun 2001, Jordan Hubbard wrote: From: Kenneth Wayne Culver [EMAIL PROTECTED] Subject: dual athlons Date: Thu, 7 Jun 2001 16:18:13 -0400 (EDT) Just curious, but are there plans to support the EV6 bus that the dual athlon motherboards use? I'm not going to buy that kind of system unless FreeBSD 5 will support it. Both FreeBSD 4 and 5 already support it. - Jordan To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
