makefs && gpart (...)

2015-01-01 Thread Matthias Apitz 


Hello,

I have a small question and a small request re/ makefs && gpart:

There is a script src/release/i386/make-memstick.sh to create an image
from a full directory tree; the tree is result of

make installworld DESTDIR=/tree
make installkernel DESTDIR=/tree

the script mainly does:

...
makefs -B little -o label=FreeBSD_Install ${2} ${1}
if [ $? -ne 0 ]; then
echo "makefs failed"
exit 1
fi
rm ${1}/etc/fstab

unit=$(mdconfig -a -t vnode -f ${2})
if [ $? -ne 0 ]; then
echo "mdconfig failed"
exit 1
fi
gpart create -s BSD ${unit}
gpart bootcode -b ${1}/boot/boot ${unit}
gpart add -t freebsd-ufs ${unit}
mdconfig -d -u ${unit}

As you can see, it does makefs first, and after this it creates the
gpart structure in the image (i.e. in its memory file system).

Why is this in this order and where exactly starts the file system
created by makefs?

The request is: it would also be nice if 'make-memstick.sh' would allow
to pass from the command line some values for the size of the file
system to be created in the image; I modified it to fit my needs as:

   size=15482880b
   ...
   makefs -B little -M ${size} -m ${size} -f 40 

Thanks

matthias

-- 
Matthias Apitz, g...@unixarea.de, http://www.unixarea.de/ +49-170-4527211
1989-2014: The Wall was torn down so that we go to war together again.
El Muro ha sido derribado para que nos unimos en ir a la guerra otra vez.
Diese Grenze wurde aufgehoben damit wir gemeinsam wieder in den Krieg ziehen.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread O. Hartmann 
Am Wed, 31 Dec 2014 21:41:34 +0100
Dimitry Andric  schrieb:

> Hi,
> 
> I just committed an upgrade of clang, llvm and lldb to 3.5.0 to head, in
> r276479.
> 
> Please note that this version now requires C++11 support to build; see
> UPDATING for more information.
> 
> Release notes for llvm and clang can be found here:
> 
> 
> 
> Thanks to Ed Maste, Roman Divacky, Andrew Turner, Justin Hibbits and
> Antoine Brodin for their invaluable help with this import.
> 
> -Dimitry
> 

This is great news, thank you very much.

I gave it a try, but my system's drop out at the error shown below. I use 
non-standard
optimisation flags (/etc/src.conf), but even with those switched off, I receive 
the error
shown below.

Regards,

Oliver

[...]

===> lib/atf/libatf-c++ (all)
c++-O2 -pipe -O3 -O3 -pipe -march=native -DHAVE_CONFIG_H 
-I/usr/src/contrib/atf
-I/usr/src/lib/atf/libatf-c++/../libatf-c -I. -DHAVE_CONFIG_H -fstack-protector
-Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter 
-Wpointer-arith
-Wno-uninitialized -Wno-empty-body -Wno-string-plus-int 
-Wno-unused-const-variable
-Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
-Wno-unused-function -Wno-enum-conversion -Qunused-arguments -std=c++11
-Wno-c++11-extensions -c /usr/src/contrib/atf/atf-c++/detail/application.cpp -o
application.o In file included
from /usr/src/contrib/atf/atf-c++/detail/application.cpp:26: In file included
from /usr/src/contrib/atf/atf-c++/detail/application.hpp:29: In file included
from /usr/obj/usr/src/tmp/usr/include/c++/v1/ostream:131: In file included
from /usr/obj/usr/src/tmp/usr/include/c++/v1/ios:216: In file included
from /usr/obj/usr/src/tmp/usr/include/c++/v1/__locale:15: In file included
from /usr/obj/usr/src/tmp/usr/include/c++/v1/string:439: In file included
from /usr/obj/usr/src/tmp/usr/include/c++/v1/algorithm:624: 
/usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2033:8:
error: keyword '__is_constructible' will be made available as an identifier for 
the
remainder of the translation unit [-Werror,-Wkeyword-compat] struct 
__is_constructible //
false, _Tp is not a scalar ^ 
/usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2584:51:
error: keyword '__is_nothrow_constructible' will be made available as an 
identifier for
the remainder of the translation unit [-Werror,-Wkeyword-compat] template 
 struct __is_nothrow_constructible;
^ /usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2746:47: error: keyword
'__is_nothrow_assignable' will be made available as an identifier for the 
remainder of
the translation unit [-Werror,-Wkeyword-compat] template 
struct __is_nothrow_assignable; ^ 3 errors generated. *** Error code 1

Stop.
make[6]: stopped in /usr/src/lib/atf/libatf-c++
*** Error code 1

Stop.
make[5]: stopped in /usr/src/lib/atf
*** Error code 1



pgpcnrv9wPmVo.pgp
Description: OpenPGP digital signature

Re: [RFC] kern/kern_timeout.c rewrite in progress

2015-01-01 Thread Hans Petter Selasky 

On 01/01/15 02:16, Hans Petter Selasky wrote:

On 01/01/15 02:02, Hans Petter Selasky wrote:

On 12/31/14 23:56, Ivan Klymenko wrote:

В Mon, 29 Dec 2014 21:03:24 +0100
Hans Petter Selasky  пишет:



Hi,

Is your kernel compiled with Witness? Do you see any lock order reversal
warnings?

Can you do from kgdb:

thread apply all bt

And send me the result off-list?

I'll have a closer look at this tomorrow.



panic: spin lock held too long
http://paste.org.ru/?acf7io



Thank you!





Hi,

I see what is going on. There is an LOR which is not printed because 
MTX_QUIET is passed when locking inside the callback process routine.


It happens because cv_timedwait() is using callouts() to timeout and 
callout_drain() is using cv_wait() to wait for draining. This was not so 
well documented in the old code.


I'll update my patch and send out a new one later today.

I see a room for doing some improvements too:

callout_init(&td->td_slpcallout, CALLOUT_MPSAFE)

Possibly we could use a so-called "DIRECT" callback from the fast IRQ of 
the timer, when waking up other threads from cv_timedwait(), hence only 
spinlocks are involved? This would save waking up the callout SWI only 
to wakeup another thread !


Thank you for testing!

--HPS
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: makefs && gpart (...)

2015-01-01 Thread Nathan Whitehorn 


On 01/01/15 03:48, Matthias Apitz wrote:


Hello,

I have a small question and a small request re/ makefs && gpart:

There is a script src/release/i386/make-memstick.sh to create an image
from a full directory tree; the tree is result of

make installworld DESTDIR=/tree
make installkernel DESTDIR=/tree

the script mainly does:

...
makefs -B little -o label=FreeBSD_Install ${2} ${1}
if [ $? -ne 0 ]; then
echo "makefs failed"
exit 1
fi
rm ${1}/etc/fstab

unit=$(mdconfig -a -t vnode -f ${2})
if [ $? -ne 0 ]; then
echo "mdconfig failed"
exit 1
fi
gpart create -s BSD ${unit}
gpart bootcode -b ${1}/boot/boot ${unit}
gpart add -t freebsd-ufs ${unit}
mdconfig -d -u ${unit}

As you can see, it does makefs first, and after this it creates the
gpart structure in the image (i.e. in its memory file system).
Why is this in this order and where exactly starts the file system
created by makefs?



This is a quirk of BSD disklabels: the first partition can start at 
address 0 and the first 16 sectors of UFS2 file systems are reserved for 
the label headers. It's not portable to other partition schemes. For 
-CURRENT, this script has been replaced, by the way, and doesn't use BSD 
labels anymore.

-Nathan



The request is: it would also be nice if 'make-memstick.sh' would allow
to pass from the command line some values for the size of the file
system to be created in the image; I modified it to fit my needs as:

size=15482880b
...
makefs -B little -M ${size} -m ${size} -f 40 

Thanks

matthias



___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread Oliver Pinter 
Hi!

We at  HardenedBSD got this error, with out jenkins instance:

--- dis_tables.o ---
/jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (cpu_mode == SIZE64 && dp->it_invalid64 ||
~~~^~~ ~~
/jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
note: place parentheses around the '&&' expression to silence this
warning
if (cpu_mode == SIZE64 && dp->it_invalid64 ||
   ^
( )
/jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
cpu_mode != SIZE64 && dp->it_invalid32)
~~~^~~
/jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
note: place parentheses around the '&&' expression to silence this
warning
cpu_mode != SIZE64 && dp->it_invalid32)
   ^
( )
--- all_subdir_ed ---


full log: 
http://nyi-01.build.hardenedbsd.org:8180/jenkins/job/HardenedBSD_Master/109/consoleText

On Thu, Jan 1, 2015 at 12:50 PM, O. Hartmann
 wrote:
> Am Wed, 31 Dec 2014 21:41:34 +0100
> Dimitry Andric  schrieb:
>
>> Hi,
>>
>> I just committed an upgrade of clang, llvm and lldb to 3.5.0 to head, in
>> r276479.
>>
>> Please note that this version now requires C++11 support to build; see
>> UPDATING for more information.
>>
>> Release notes for llvm and clang can be found here:
>> 
>> 
>>
>> Thanks to Ed Maste, Roman Divacky, Andrew Turner, Justin Hibbits and
>> Antoine Brodin for their invaluable help with this import.
>>
>> -Dimitry
>>
>
> This is great news, thank you very much.
>
> I gave it a try, but my system's drop out at the error shown below. I use 
> non-standard
> optimisation flags (/etc/src.conf), but even with those switched off, I 
> receive the error
> shown below.
>
> Regards,
>
> Oliver
>
> [...]
>
> ===> lib/atf/libatf-c++ (all)
> c++-O2 -pipe -O3 -O3 -pipe -march=native -DHAVE_CONFIG_H 
> -I/usr/src/contrib/atf
> -I/usr/src/lib/atf/libatf-c++/../libatf-c -I. -DHAVE_CONFIG_H 
> -fstack-protector
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter 
> -Wpointer-arith
> -Wno-uninitialized -Wno-empty-body -Wno-string-plus-int 
> -Wno-unused-const-variable
> -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
> -Wno-unused-function -Wno-enum-conversion -Qunused-arguments -std=c++11
> -Wno-c++11-extensions -c /usr/src/contrib/atf/atf-c++/detail/application.cpp 
> -o
> application.o In file included
> from /usr/src/contrib/atf/atf-c++/detail/application.cpp:26: In file included
> from /usr/src/contrib/atf/atf-c++/detail/application.hpp:29: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/ostream:131: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/ios:216: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/__locale:15: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/string:439: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/algorithm:624: 
> /usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2033:8:
> error: keyword '__is_constructible' will be made available as an identifier 
> for the
> remainder of the translation unit [-Werror,-Wkeyword-compat] struct 
> __is_constructible //
> false, _Tp is not a scalar ^ 
> /usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2584:51:
> error: keyword '__is_nothrow_constructible' will be made available as an 
> identifier for
> the remainder of the translation unit [-Werror,-Wkeyword-compat] template 
>  _Tp, class... _Args> struct __is_nothrow_constructible;
> ^ /usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2746:47: error: keyword
> '__is_nothrow_assignable' will be made available as an identifier for the 
> remainder of
> the translation unit [-Werror,-Wkeyword-compat] template  class _Arg>
> struct __is_nothrow_assignable; ^ 3 errors generated. *** Error code 1
>
> Stop.
> make[6]: stopped in /usr/src/lib/atf/libatf-c++
> *** Error code 1
>
> Stop.
> make[5]: stopped in /usr/src/lib/atf
> *** Error code 1
>
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread David Wolfskill 
On Wed, Dec 31, 2014 at 09:41:34PM +0100, Dimitry Andric wrote:
> Hi,
> 
> I just committed an upgrade of clang, llvm and lldb to 3.5.0 to head, in
> r276479.
> .

Hmm...  I'm seeing a problem with src/sys/modules/asr, using (head)
sources @276499 in native i386 environments that are presently running:

FreeBSD g1-253.catwhisker.org 11.0-CURRENT FreeBSD 11.0-CURRENT #1470  
r276462M/276468:1100051: Wed Dec 31 06:18:00 PST 2014 
r...@g1-253.catwhisker.org:/common/S4/obj/usr/src/sys/CANARY  i386

and:

FreeBSD freebeast.catwhisker.org 11.0-CURRENT FreeBSD 11.0-CURRENT #1707  
r276462M/276468:1100051: Wed Dec 31 05:48:32 PST 2014 
r...@freebeast.catwhisker.org:/common/S4/obj/usr/src/sys/GENERIC  i386

(For a history, showing at what points I've successfully built,
installed, and booted i386/head on these machines, please see
 or
.)

Here's an excerpt from one of the failures (re-created without a -j
specification in order to help keep things clear):

>>> Kernel build for CANARY started on Thu Jan  1 08:56:50 PST 2015
...
>>> stage 3.2: building everything
...
===> asmc (all)
cc  -O2 -pipe  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   
-DHAVE_KERNEL_OPTION_HEADERS -include 
/common/S4/obj/usr/src/sys/CANARY/opt_global.h -I. -I/usr/src/sys 
-I/usr/src/sys/contrib/altq -fno-common -g -I/common/S4/obj/usr/src/sys/CANARY  
-mno-mmx -mno-sse -msoft-float -ffreestanding -fstack-protector -gdwarf-2 
-Wno-error-tautological-compare -Wno-error-empty-body  
-Wno-error-parentheses-equality -Wno-error-unused-function  
-Wno-error-pointer-sign -Wno-error-format -Wno-error-parentheses  
-Wno-error-switch -Wno-error-switch  -Wno-error-shift-count-negative  
-Wno-error-shift-count-overflow  -Wno-error-constant-conversion -mno-aes 
-mno-avx -std=iso9899:1999 -c /usr/src/sys/modules/asmc/../../dev/asmc/asmc.c
/usr/src/sys/modules/asmc/../../dev/asmc/asmc.c:975:7: warning: assigning to
  'char *' from 'uint8_t *' (aka 'unsigned char *') converts between
  pointers to integer types with different sign [-Wpointer-sign]
desc = buf+4;
 ^ ~
1 warning generated.
ctfconvert -L VERSION -g asmc.o
ld -d -warn-common -r -d -o asmc.kld asmc.o
ctfmerge -L VERSION -g -o asmc.kld asmc.o
:> export_syms
awk -f /usr/src/sys/conf/kmod_syms.awk asmc.kld  export_syms | xargs -J% 
objcopy % asmc.kld
ld -Bshareable -d -warn-common -o asmc.ko.debug asmc.kld
objcopy --only-keep-debug asmc.ko.debug asmc.ko.symbols
objcopy --strip-debug --add-gnu-debuglink=asmc.ko.symbols asmc.ko.debug asmc.ko
===> asr (all)
cc  -O2 -pipe  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   
-DHAVE_KERNEL_OPTION_HEADERS -include 
/common/S4/obj/usr/src/sys/CANARY/opt_global.h -I. -I/usr/src/sys 
-I/usr/src/sys/contrib/altq -fno-common -g -I/common/S4/obj/usr/src/sys/CANARY  
-mno-mmx -mno-sse -msoft-float -ffreestanding -fstack-protector -gdwarf-2 
-Wno-error-tautological-compare -Wno-error-empty-body  
-Wno-error-parentheses-equality -Wno-error-unused-function  
-Wno-error-pointer-sign -Wno-error-format -Wno-error-parentheses  
-Wno-error-switch -Wno-error-switch  -Wno-error-shift-count-negative  
-Wno-error-shift-count-overflow  -Wno-error-constant-conversion -mno-aes 
-mno-avx -std=iso9899:1999 -c /usr/src/sys/modules/asr/../../dev/asr/asr.c
/usr/src/sys/modules/asr/../../dev/asr/asr.c:1844:4: warning: assigning to
  'caddr_t' (aka 'char *') from 'u_int8_t *' (aka 'unsigned char *')
  converts between pointers to integer types with different sign
  [-Wpointer-sign]
v = ccb->csio.data_ptr;
  ^ ~~
/usr/src/sys/modules/asr/../../dev/asr/asr.c:1849:29: error: array index 58 is
  past the end of the array (which contains 1 element)
  [-Werror,-Warray-bounds]
while ((len > 0) && (sg < &((PPRIVATE_SCSI_SCB_EXECUTE_MESSAGE)
   ^
/usr/src/sys/dev/asr/i2omsg.h:934:8: note: array 'Simple' declared here
   I2O_SGE_SIMPLE_ELEMENT  Simple[1];
   ^
/usr/src/sys/modules/asr/../../dev/asr/asr.c:2621:18: warning: passing
  'char [8]' to parameter of type 'u_int8_t *' (aka 'unsigned char *')
  converts between pointers to integer types with different sign
  [-Wpointer-sign]
ASR_prstring (iq->vendor, 8);
  ^~
/usr/src/sys/modules/asr/../../dev/asr/asr.c:732:24: note: passing argument to
  parameter 's' here
ASR_prstring(u_int8_t *s, int len)
   ^
/usr/src/sys/modules/asr/../../dev/asr/asr.c:2626:18: warning: passing
  'char [16]' to parameter of type 'u_int8_t *' (aka 'unsigned char *')
  converts between pointers to integer types with different sign
  [-Wpointer-sign]
ASR_prstring (iq->product, 16);
/usr/src/sys/modules/asr/../.

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread Dimitry Andric 
On 01 Jan 2015, at 18:35, Oliver Pinter  wrote:
> We at  HardenedBSD got this error, with out jenkins instance:
> 
> --- dis_tables.o ---
> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
>if (cpu_mode == SIZE64 && dp->it_invalid64 ||
>~~~^~~ ~~
> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
> note: place parentheses around the '&&' expression to silence this
> warning
>if (cpu_mode == SIZE64 && dp->it_invalid64 ||
>   ^
>( )
> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
>cpu_mode != SIZE64 && dp->it_invalid32)
>~~~^~~
> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
> note: place parentheses around the '&&' expression to silence this
> warning
>cpu_mode != SIZE64 && dp->it_invalid32)
>   ^
>( )
> --- all_subdir_ed ---

I can't reproduce this warning here, at least not with pristine head.

Did you change any of the -Wno-xxx flags in your customized source tree?

-Dimitry



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread Oliver Pinter 
No, we don't touch them. Only added -DHARDEBEDBSD into make
environment.  I will schedule a new round of build to recheck them,

On Thu, Jan 1, 2015 at 6:53 PM, Dimitry Andric  wrote:
> On 01 Jan 2015, at 18:35, Oliver Pinter  wrote:
>> We at  HardenedBSD got this error, with out jenkins instance:
>>
>> --- dis_tables.o ---
>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
>> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
>>if (cpu_mode == SIZE64 && dp->it_invalid64 ||
>>~~~^~~ ~~
>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
>> note: place parentheses around the '&&' expression to silence this
>> warning
>>if (cpu_mode == SIZE64 && dp->it_invalid64 ||
>>   ^
>>( )
>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
>> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
>>cpu_mode != SIZE64 && dp->it_invalid32)
>>~~~^~~
>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
>> note: place parentheses around the '&&' expression to silence this
>> warning
>>cpu_mode != SIZE64 && dp->it_invalid32)
>>   ^
>>( )
>> --- all_subdir_ed ---
>
> I can't reproduce this warning here, at least not with pristine head.
>
> Did you change any of the -Wno-xxx flags in your customized source tree?
>
> -Dimitry
>
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: makefs && gpart (...)

2015-01-01 Thread Matthias Apitz 
El día Thursday, January 01, 2015 a las 09:23:06AM -0800, Nathan Whitehorn 
escribió:

> 
> On 01/01/15 03:48, Matthias Apitz wrote:

> > gpart add -t freebsd-ufs ${unit}
> > mdconfig -d -u ${unit}
> >
> > As you can see, it does makefs first, and after this it creates the
> > gpart structure in the image (i.e. in its memory file system).
> > Why is this in this order and where exactly starts the file system
> > created by makefs?
> 
> 
> This is a quirk of BSD disklabels: the first partition can start at 
> address 0 and the first 16 sectors of UFS2 file systems are reserved for 
> the label headers. It's not portable to other partition schemes. For 
> -CURRENT, this script has been replaced, by the way, and doesn't use BSD 
> labels anymore.
> -Nathan

I'm on -HEAD (r272526) and the script remains unchanged there. Thanks
anyway for your feedback.

matthias

-- 
Matthias Apitz, g...@unixarea.de, http://www.unixarea.de/ +49-170-4527211
1989-2014: The Wall was torn down so that we go to war together again.
El Muro ha sido derribado para que nos unimos en ir a la guerra otra vez.
Diese Grenze wurde aufgehoben damit wir gemeinsam wieder in den Krieg ziehen.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread Oliver Pinter 
No difference between FreeBSD's and our dis_tables.c file, and we
added the following modification to "master" Makefile:

op@robot hardenedBSD.git.opntr> git diff origin/master
origin/hardened/current/master -- sys/cddl/dev/dtrace/x86/dis_tables.c
op@robot hardenedBSD.git.opntr> git diff origin/master
origin/hardened/current/master -- us
usr.bin/  usr.sbin/
op@robot hardenedBSD.git.opntr> git diff origin/master
origin/hardened/current/master -- share/mk
mk/   mklocale/
op@robot hardenedBSD.git.opntr> git diff origin/master
origin/hardened/current/master -- share/mk
diff --git a/share/mk/Makefile b/share/mk/Makefile
index cd69ca8..7e1b51f 100644
--- a/share/mk/Makefile
+++ b/share/mk/Makefile
@@ -13,6 +13,7 @@ FILES=\
bsd.doc.mk \
bsd.endian.mk \
bsd.files.mk \
+   bsd.hardenedbsd.mk \
bsd.incs.mk \
bsd.info.mk \
bsd.init.mk \
diff --git a/share/mk/bsd.hardenedbsd.mk b/share/mk/bsd.hardenedbsd.mk
new file mode 100644
index 000..9d5bcd3
--- /dev/null
+++ b/share/mk/bsd.hardenedbsd.mk
@@ -0,0 +1,2 @@
+CFLAGS+=   -DHARDENEDBSD
+CXXFLAGS+= -DHARDENEDBSD
diff --git a/share/mk/sys.mk b/share/mk/sys.mk
index f691820..1edb4d8 100644
--- a/share/mk/sys.mk
+++ b/share/mk/sys.mk
@@ -368,3 +368,5 @@ SHELL=  ${__MAKE_SHELL}
 .include 

 .endif # ! Posix
+
+.include 

and our origin/master is a vanilla copy of FreeBSD's master:

op@robot hardenedBSD.git.opntr> git fetch freebsd
remote: Counting objects: 2753, done.
remote: Compressing objects: 100% (1653/1653), done.
remote: Total 2753 (delta 1379), reused 1987 (delta 1088)
Receiving objects: 100% (2753/2753), 6.19 MiB | 556.00 KiB/s, done.
Resolving deltas: 100% (1379/1379), done.
>From https://github.com/freebsd/freebsd
   1daffcf..16bfeff  master -> freebsd/master
   4ce956b..2786226  projects/arm_intrng -> freebsd/projects/arm_intrng
   8afde97..e891a45  projects/building-blocks ->
freebsd/projects/building-blocks
   ae94017..79b9044  projects/clang350-import ->
freebsd/projects/clang350-import
 * [new branch]  projects/elftoolchain-update-r3130 ->
freebsd/projects/elftoolchain-update-r3130
   191c3a1..ef329bf  projects/ifnet -> freebsd/projects/ifnet
 + f39bd7c...33c47ad projects/ino64 -> freebsd/projects/ino64  (forced update)
 * [new branch]  projects/paravirt -> freebsd/projects/paravirt
   fdb4571..637702c  projects/routing -> freebsd/projects/routing
   e3732e9..6970b8a  projects/sendfile -> freebsd/projects/sendfile
   73a106c..4bbc2e1  releng/10.0 -> freebsd/releng/10.0
   29f4af5..8bdb2f8  releng/10.1 -> freebsd/releng/10.1
   93a7c22..6c98ecd  releng/8.4 -> freebsd/releng/8.4
   18b185b..42bd402  releng/9.1 -> freebsd/releng/9.1
   62fc296..81febb2  releng/9.2 -> freebsd/releng/9.2
   587e3b5..825bd30  releng/9.3 -> freebsd/releng/9.3
   f3fce3a..f0fc25a  stable/10  -> freebsd/stable/10
   038c20d..2a2bb65  stable/7   -> freebsd/stable/7
   ab2b3fb..4ece3be  stable/8   -> freebsd/stable/8
   cd6870d..4c08e33  stable/9   -> freebsd/stable/9
   dab26aa..b4e212b  svn_head   -> freebsd/svn_head
   947b121..2d9be08  user/cperciva/freebsd-update-build ->
freebsd/user/cperciva/freebsd-update-build
   e94160d..f74291e  user/marcel/libvdsk -> freebsd/user/marcel/libvdsk
   aeef35a..7a5b8d5  user/pho/stress2 -> freebsd/user/pho/stress2
op@robot hardenedBSD.git.opntr> git diff freebsd/master origin/master
op@robot hardenedBSD.git.opntr>



And I started a new instance of build/

On Thu, Jan 1, 2015 at 7:20 PM, Oliver Pinter
 wrote:
> No, we don't touch them. Only added -DHARDEBEDBSD into make
> environment.  I will schedule a new round of build to recheck them,
>
> On Thu, Jan 1, 2015 at 6:53 PM, Dimitry Andric  wrote:
>> On 01 Jan 2015, at 18:35, Oliver Pinter  
>> wrote:
>>> We at  HardenedBSD got this error, with out jenkins instance:
>>>
>>> --- dis_tables.o ---
>>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
>>> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
>>>if (cpu_mode == SIZE64 && dp->it_invalid64 ||
>>>~~~^~~ ~~
>>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
>>> note: place parentheses around the '&&' expression to silence this
>>> warning
>>>if (cpu_mode == SIZE64 && dp->it_invalid64 ||
>>>   ^
>>>( )
>>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
>>> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
>>>cpu_mode != SIZE64 && dp->it_invalid32)
>>>~~~^~~
>>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
>>> note: place parentheses around the '&&' expression to silence this
>>> warning
>>>cpu_mode != SIZE64 && dp->it_invalid32)
>>>   ^
>>>(

Last week for submitting FreeBSD 2014Q4 Status Reports

2015-01-01 Thread Benjamin Kaduk 
Dear FreeBSD Community,

Less than a week remains before the deadline for submissions to the next
FreeBSD Quarterly Status Report.  Submissions are due on January 7, 2015,
covering work done in October through December.

Status report submissions do not have to be very long.  They may be
about anything happening in the FreeBSD project and community, and
provide a great way to inform FreeBSD users and developers about what
you're working on.  Submission of reports is not restricted to
committers.  Anyone doing anything interesting and FreeBSD-related
can -- and should -- write one!

The preferred and easiest submission method is to use the XML
generator [1] with the results emailed to the status report team at
monthly at freebsd.org .  There is also an XML template [2] which can be
filled out manually and attached if preferred.  For the expected
content and style, please study our guidelines on how to write a good
status report [3].  You can also review previous issues [4][5] for
ideas on the style and format.

We are looking forward to all of your 2014Q4 reports!

Thanks,
Ben (on behalf of monthly@)


[1] http://www.freebsd.org/cgi/monthly.cgi
[2] http://www.freebsd.org/news/status/report-sample.xml
[3] http://www.freebsd.org/news/status/howto.html
[4] http://www.freebsd.org/news/status/report-2014-04-2014-06.html
[5] http://www.freebsd.org/news/status/report-2014-07-2014-09.html

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread Dimitry Andric 
On 01 Jan 2015, at 12:50, O. Hartmann  wrote:
...
> ===> lib/atf/libatf-c++ (all)
> c++-O2 -pipe -O3 -O3 -pipe -march=native -DHAVE_CONFIG_H 
> -I/usr/src/contrib/atf
> -I/usr/src/lib/atf/libatf-c++/../libatf-c -I. -DHAVE_CONFIG_H 
> -fstack-protector
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter 
> -Wpointer-arith
> -Wno-uninitialized -Wno-empty-body -Wno-string-plus-int 
> -Wno-unused-const-variable
> -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
> -Wno-unused-function -Wno-enum-conversion -Qunused-arguments -std=c++11
> -Wno-c++11-extensions -c /usr/src/contrib/atf/atf-c++/detail/application.cpp 
> -o
> application.o In file included
> from /usr/src/contrib/atf/atf-c++/detail/application.cpp:26: In file included
> from /usr/src/contrib/atf/atf-c++/detail/application.hpp:29: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/ostream:131: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/ios:216: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/__locale:15: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/string:439: In file included
> from /usr/obj/usr/src/tmp/usr/include/c++/v1/algorithm:624: 
> /usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2033:8:
> error: keyword '__is_constructible' will be made available as an identifier 
> for the
> remainder of the translation unit [-Werror,-Wkeyword-compat] struct 
> __is_constructible //
> false, _Tp is not a scalar ^ 
> /usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2584:51:
> error: keyword '__is_nothrow_constructible' will be made available as an 
> identifier for
> the remainder of the translation unit [-Werror,-Wkeyword-compat] template 
>  _Tp, class... _Args> struct __is_nothrow_constructible;
> ^ /usr/obj/usr/src/tmp/usr/include/c++/v1/type_traits:2746:47: error: keyword
> '__is_nothrow_assignable' will be made available as an identifier for the 
> remainder of
> the translation unit [-Werror,-Wkeyword-compat] template  class _Arg>
> struct __is_nothrow_assignable; ^ 3 errors generated. *** Error code 1
> 
> Stop.
> make[6]: stopped in /usr/src/lib/atf/libatf-c++
> *** Error code 1

Hi Oliver,

This should now be fixed by r276516 and r276517.  Please update your
tree to after those revisions, and try again.  Thanks for the report.

-Dimitry



signature.asc
Description: Message signed with OpenPGP using GPGMail

Jenkins build is back to normal : Build-UFS-image #820

2015-01-01 Thread jenkins-admin 
See 

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Jenkins build became unstable: FreeBSD_HEAD-tests2 #509

2015-01-01 Thread jenkins-admin 
See 

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread Larry Rosenman 

On 2015-01-01 12:44, Oliver Pinter wrote:

No difference between FreeBSD's and our dis_tables.c file, and we
added the following modification to "master" Makefile:

op@robot hardenedBSD.git.opntr> git diff origin/master
origin/hardened/current/master -- sys/cddl/dev/dtrace/x86/dis_tables.c
op@robot hardenedBSD.git.opntr> git diff origin/master
origin/hardened/current/master -- us
usr.bin/  usr.sbin/
op@robot hardenedBSD.git.opntr> git diff origin/master
origin/hardened/current/master -- share/mk
mk/   mklocale/
op@robot hardenedBSD.git.opntr> git diff origin/master
origin/hardened/current/master -- share/mk
diff --git a/share/mk/Makefile b/share/mk/Makefile
index cd69ca8..7e1b51f 100644
--- a/share/mk/Makefile
+++ b/share/mk/Makefile
@@ -13,6 +13,7 @@ FILES=\
bsd.doc.mk \
bsd.endian.mk \
bsd.files.mk \
+   bsd.hardenedbsd.mk \
bsd.incs.mk \
bsd.info.mk \
bsd.init.mk \
diff --git a/share/mk/bsd.hardenedbsd.mk b/share/mk/bsd.hardenedbsd.mk
new file mode 100644
index 000..9d5bcd3
--- /dev/null
+++ b/share/mk/bsd.hardenedbsd.mk
@@ -0,0 +1,2 @@
+CFLAGS+=   -DHARDENEDBSD
+CXXFLAGS+= -DHARDENEDBSD
diff --git a/share/mk/sys.mk b/share/mk/sys.mk
index f691820..1edb4d8 100644
--- a/share/mk/sys.mk
+++ b/share/mk/sys.mk
@@ -368,3 +368,5 @@ SHELL=  ${__MAKE_SHELL}
 .include 

 .endif # ! Posix
+
+.include 

and our origin/master is a vanilla copy of FreeBSD's master:

op@robot hardenedBSD.git.opntr> git fetch freebsd
remote: Counting objects: 2753, done.
remote: Compressing objects: 100% (1653/1653), done.
remote: Total 2753 (delta 1379), reused 1987 (delta 1088)
Receiving objects: 100% (2753/2753), 6.19 MiB | 556.00 KiB/s, done.
Resolving deltas: 100% (1379/1379), done.
From https://github.com/freebsd/freebsd
   1daffcf..16bfeff  master -> freebsd/master
   4ce956b..2786226  projects/arm_intrng -> freebsd/projects/arm_intrng
   8afde97..e891a45  projects/building-blocks ->
freebsd/projects/building-blocks
   ae94017..79b9044  projects/clang350-import ->
freebsd/projects/clang350-import
 * [new branch]  projects/elftoolchain-update-r3130 ->
freebsd/projects/elftoolchain-update-r3130
   191c3a1..ef329bf  projects/ifnet -> freebsd/projects/ifnet
 + f39bd7c...33c47ad projects/ino64 -> freebsd/projects/ino64  (forced 
update)

 * [new branch]  projects/paravirt -> freebsd/projects/paravirt
   fdb4571..637702c  projects/routing -> freebsd/projects/routing
   e3732e9..6970b8a  projects/sendfile -> freebsd/projects/sendfile
   73a106c..4bbc2e1  releng/10.0 -> freebsd/releng/10.0
   29f4af5..8bdb2f8  releng/10.1 -> freebsd/releng/10.1
   93a7c22..6c98ecd  releng/8.4 -> freebsd/releng/8.4
   18b185b..42bd402  releng/9.1 -> freebsd/releng/9.1
   62fc296..81febb2  releng/9.2 -> freebsd/releng/9.2
   587e3b5..825bd30  releng/9.3 -> freebsd/releng/9.3
   f3fce3a..f0fc25a  stable/10  -> freebsd/stable/10
   038c20d..2a2bb65  stable/7   -> freebsd/stable/7
   ab2b3fb..4ece3be  stable/8   -> freebsd/stable/8
   cd6870d..4c08e33  stable/9   -> freebsd/stable/9
   dab26aa..b4e212b  svn_head   -> freebsd/svn_head
   947b121..2d9be08  user/cperciva/freebsd-update-build ->
freebsd/user/cperciva/freebsd-update-build
   e94160d..f74291e  user/marcel/libvdsk -> freebsd/user/marcel/libvdsk
   aeef35a..7a5b8d5  user/pho/stress2 -> freebsd/user/pho/stress2
op@robot hardenedBSD.git.opntr> git diff freebsd/master origin/master
op@robot hardenedBSD.git.opntr>



And I started a new instance of build/

On Thu, Jan 1, 2015 at 7:20 PM, Oliver Pinter
 wrote:

No, we don't touch them. Only added -DHARDEBEDBSD into make
environment.  I will schedule a new round of build to recheck them,

On Thu, Jan 1, 2015 at 6:53 PM, Dimitry Andric  
wrote:
On 01 Jan 2015, at 18:35, Oliver Pinter 
 wrote:

We at  HardenedBSD got this error, with out jenkins instance:

--- dis_tables.o ---
/jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
   if (cpu_mode == SIZE64 && dp->it_invalid64 ||




I can't reproduce this warning here, at least not with pristine head.

Did you change any of the -Wno-xxx flags in your customized source 
tree?


-Dimitry

I was seeing the same failure.  r276496 seems(!) to have moved some of 
the warning / error suppressions

and fixed my issue.


--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 108 Turvey Cove, Hutto, TX 78634-5688

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread Oliver Pinter 
I checked in amd64 case on my desktop machine, and building fine.
After that, I looked again into build log, and I found this:

make[2]: stopped in
/usr/obj/i386.i386/jenkins/workspace/HardenedBSD_Master/sys/HARDENEDBSD
1 error

make[2]: stopped in
/usr/obj/i386.i386/jenkins/workspace/HardenedBSD_Master/sys/HARDENEDBSD
*** [buildkernel] Error code 2

Seems like, the error affected the i386 case.


On Thu, Jan 1, 2015 at 6:53 PM, Dimitry Andric  wrote:
> On 01 Jan 2015, at 18:35, Oliver Pinter  wrote:
>> We at  HardenedBSD got this error, with out jenkins instance:
>>
>> --- dis_tables.o ---
>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
>> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
>>if (cpu_mode == SIZE64 && dp->it_invalid64 ||
>>~~~^~~ ~~
>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25:
>> note: place parentheses around the '&&' expression to silence this
>> warning
>>if (cpu_mode == SIZE64 && dp->it_invalid64 ||
>>   ^
>>( )
>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
>> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
>>cpu_mode != SIZE64 && dp->it_invalid32)
>>~~~^~~
>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25:
>> note: place parentheses around the '&&' expression to silence this
>> warning
>>cpu_mode != SIZE64 && dp->it_invalid32)
>>   ^
>>( )
>> --- all_subdir_ed ---
>
> I can't reproduce this warning here, at least not with pristine head.
>
> Did you change any of the -Wno-xxx flags in your customized source tree?
>
> -Dimitry
>
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0

2015-01-01 Thread Benjamin Kaduk 
On Thu, 1 Jan 2015, Oliver Pinter wrote:

> I checked in amd64 case on my desktop machine, and building fine.
> After that, I looked again into build log, and I found this:
>
> make[2]: stopped in
> /usr/obj/i386.i386/jenkins/workspace/HardenedBSD_Master/sys/HARDENEDBSD
> 1 error
>
> make[2]: stopped in
> /usr/obj/i386.i386/jenkins/workspace/HardenedBSD_Master/sys/HARDENEDBSD
> *** [buildkernel] Error code 2

That is not the actual error; you will need to copy more of the build
output.

> Seems like, the error affected the i386 case.

Maybe, but we can't tell for sure with the data at hand.

-Ben
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

asr(4) error with new clang/llvm

2015-01-01 Thread Bjoern A. Zeeb 
Hi,

you need the next line of source to see that while the union only defines 
Simple[1], the comparison goes up to SG_LIST (or something) which is indeed 
defined as 58.   Cn someone fix this?   This makes i386 compiles failing 
currently.

/scratch/tmp/bz/head.svn/sys/modules/asr/../../dev/asr/asr.c:1849:29: error: 
array index 58 is past the end of the array (which contains 1 element) 
[-Werror,-Warray-bounds]
while ((len > 0) && (sg < &((PPRIVATE_SCSI_SCB_EXECUTE_MESSAGE)
   ^
/scratch/tmp/bz/head.svn/sys/dev/asr/i2omsg.h:934:8: note: array 'Simple' 
declared here
   I2O_SGE_SIMPLE_ELEMENT  Simple[1];
   ^


— 
Bjoern A. Zeeb  Charles Haddon Spurgeon:
"Friendship is one of the sweetest joys of life.  Many might have failed
 beneath the bitterness of their trial  had they not found a friend."

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: asr(4) error with new clang/llvm

2015-01-01 Thread Steven Hartland 


On 02/01/2015 01:23, Bjoern A. Zeeb wrote:

Hi,

you need the next line of source to see that while the union only defines 
Simple[1], the comparison goes up to SG_LIST (or something) which is indeed 
defined as 58.   Cn someone fix this?   This makes i386 compiles failing 
currently.

/scratch/tmp/bz/head.svn/sys/modules/asr/../../dev/asr/asr.c:1849:29: error: 
array index 58 is past the end of the array (which contains 1 element) 
[-Werror,-Warray-bounds]
 while ((len > 0) && (sg < &((PPRIVATE_SCSI_SCB_EXECUTE_MESSAGE)
^
/scratch/tmp/bz/head.svn/sys/dev/asr/i2omsg.h:934:8: note: array 'Simple' 
declared here
I2O_SGE_SIMPLE_ELEMENT  Simple[1];
^
If that's wrong it looks like there's also a number of calls to the 
macro SG(SGL,Index,Flags,Buffer,Size)  which are also wrong as Index is 
used in the same way:

&(((PI2O_SG_ELEMENT)(SGL))->u.Simple[Index]

There appears to be two calls to SG where Index is 1.

I'm afraid I have no idea what the fix would be as the entire driver is 
very voodoo like to me :(


Regards
Steve
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: asr(4) error with new clang/llvm

2015-01-01 Thread Ed Maste 
On 1 January 2015 at 23:13, Steven Hartland  wrote:
>
> On 02/01/2015 01:23, Bjoern A. Zeeb wrote:
>>
>> Hi,
>>
>> you need the next line of source to see that while the union only defines
>> Simple[1], the comparison goes up to SG_LIST (or something) which is indeed
>> defined as 58.   Cn someone fix this?   This makes i386 compiles failing
>> currently.
>>
>> /scratch/tmp/bz/head.svn/sys/modules/asr/../../dev/asr/asr.c:1849:29:
>> error: array index 58 is past the end of the array (which contains 1
>> element) [-Werror,-Warray-bounds]
>>  while ((len > 0) && (sg < &((PPRIVATE_SCSI_SCB_EXECUTE_MESSAGE)
>> ^
>> /scratch/tmp/bz/head.svn/sys/dev/asr/i2omsg.h:934:8: note: array 'Simple'
>> declared here
>> I2O_SGE_SIMPLE_ELEMENT  Simple[1];
>> ^
>
> If that's wrong it looks like there's also a number of calls to the macro
> SG(SGL,Index,Flags,Buffer,Size)  which are also wrong as Index is used in
> the same way:
> &(((PI2O_SG_ELEMENT)(SGL))->u.Simple[Index]
>
> There appears to be two calls to SG where Index is 1.
>
> I'm afraid I have no idea what the fix would be as the entire driver is very
> voodoo like to me :(

It's a variable length array in a struct / union. Other than being
confusing and now triggering a warning after the clang update it
should be fine.

Most likely we need to build asr with -Werror disabled for that
warning, perhaps -Wno-error-array-bounds. I'll take a look tomorrow
morning if nobody else gets to it first.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Jenkins build is still unstable: FreeBSD_HEAD-tests2 #510

2015-01-01 Thread jenkins-admin 
See 

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: asr(4) error with new clang/llvm

2015-01-01 Thread Garrett Cooper 
On Jan 1, 2015, at 21:00, Ed Maste  wrote:

> On 1 January 2015 at 23:13, Steven Hartland  wrote:
>> 
>> On 02/01/2015 01:23, Bjoern A. Zeeb wrote:
>>> 
>>> Hi,
>>> 
>>> you need the next line of source to see that while the union only defines
>>> Simple[1], the comparison goes up to SG_LIST (or something) which is indeed
>>> defined as 58.   Cn someone fix this?   This makes i386 compiles failing
>>> currently.
>>> 
>>> /scratch/tmp/bz/head.svn/sys/modules/asr/../../dev/asr/asr.c:1849:29:
>>> error: array index 58 is past the end of the array (which contains 1
>>> element) [-Werror,-Warray-bounds]
>>> while ((len > 0) && (sg < &((PPRIVATE_SCSI_SCB_EXECUTE_MESSAGE)
>>>^
>>> /scratch/tmp/bz/head.svn/sys/dev/asr/i2omsg.h:934:8: note: array 'Simple'
>>> declared here
>>>I2O_SGE_SIMPLE_ELEMENT  Simple[1];
>>>^
>> 
>> If that's wrong it looks like there's also a number of calls to the macro
>> SG(SGL,Index,Flags,Buffer,Size)  which are also wrong as Index is used in
>> the same way:
>> &(((PI2O_SG_ELEMENT)(SGL))->u.Simple[Index]
>> 
>> There appears to be two calls to SG where Index is 1.
>> 
>> I'm afraid I have no idea what the fix would be as the entire driver is very
>> voodoo like to me :(
> 
> It's a variable length array in a struct / union. Other than being
> confusing and now triggering a warning after the clang update it
> should be fine.
> 
> Most likely we need to build asr with -Werror disabled for that
> warning, perhaps -Wno-error-array-bounds. I'll take a look tomorrow
> morning if nobody else gets to it first.

It looks like more fallout from bsd.sys.mk being removed from bad.kmod.mk 
(NO_WARRAY_BOUNDS should be defined to the appropriate compiler flag):

 1 # $FreeBSD: projects/building-blocks/sys/modules/asr/Makefile 228865 
2011-12-24 17:54:58Z dim $
 2 
 3 .PATH: ${.CURDIR}/../../dev/asr
 4 
 5 KMOD=   asr
 6 SRCS=   asr.c
 7 SRCS+=  opt_scsi.h opt_cam.h
 8 SRCS+=  device_if.h bus_if.h pci_if.h
 9 
10 .if ${MACHINE_CPUARCH} == "i386"
11 SRCS+=  opt_asr.h
12 .endif
13 
14 .include 
15 
16 CWARNFLAGS.asr.c=   ${NO_WARRAY_BOUNDS}
17 CWARNFLAGS+=${CWARNFLAGS.${.IMPSRC:T}}



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: asr(4) error with new clang/llvm

2015-01-01 Thread Scott Long 

> On Jan 2, 2015, at 12:00 AM, Ed Maste  wrote:
> 
> On 1 January 2015 at 23:13, Steven Hartland  wrote:
>> 
>> On 02/01/2015 01:23, Bjoern A. Zeeb wrote:
>>> 
>>> Hi,
>>> 
>>> you need the next line of source to see that while the union only defines
>>> Simple[1], the comparison goes up to SG_LIST (or something) which is indeed
>>> defined as 58.   Cn someone fix this?   This makes i386 compiles failing
>>> currently.
>>> 
>>> /scratch/tmp/bz/head.svn/sys/modules/asr/../../dev/asr/asr.c:1849:29:
>>> error: array index 58 is past the end of the array (which contains 1
>>> element) [-Werror,-Warray-bounds]
>>> while ((len > 0) && (sg < &((PPRIVATE_SCSI_SCB_EXECUTE_MESSAGE)
>>>^
>>> /scratch/tmp/bz/head.svn/sys/dev/asr/i2omsg.h:934:8: note: array 'Simple'
>>> declared here
>>>I2O_SGE_SIMPLE_ELEMENT  Simple[1];
>>>^
>> 
>> If that's wrong it looks like there's also a number of calls to the macro
>> SG(SGL,Index,Flags,Buffer,Size)  which are also wrong as Index is used in
>> the same way:
>> &(((PI2O_SG_ELEMENT)(SGL))->u.Simple[Index]
>> 
>> There appears to be two calls to SG where Index is 1.
>> 
>> I'm afraid I have no idea what the fix would be as the entire driver is very
>> voodoo like to me :(
> 
> It's a variable length array in a struct / union. Other than being
> confusing and now triggering a warning after the clang update it
> should be fine.
> 
> Most likely we need to build asr with -Werror disabled for that
> warning, perhaps -Wno-error-array-bounds. I'll take a look tomorrow
> morning if nobody else gets to it first.
> 

I got to it first ;-)

Scott


___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Jenkins build is still unstable: FreeBSD_HEAD-tests2 #511

2015-01-01 Thread jenkins-admin 
See 

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"