Re: CURRENT: "service netif restart" looses default route
> On Oct 6, 2016, at 09:40, Pete Wright wrote: > >> On 10/6/16 12:27 AM, Oliver Peter wrote: >>> On Wed, Oct 05, 2016 at 06:47:48PM +0200, O. Hartmann wrote: >>> >>> Today, I checked on two servers of ours running both a recent CURRENT (i.e. >>> FreeBSD >>> 12.0-CURRENT #43 r306701: Wed Oct 5 06:40:40 CEST 2016) via "service netif >>> restart" the >>> upcoming network and realised that the default route is lost then! >>> >>> I'm able to config the route via "service routing restart" - or manually as >>> I did >>> otherwise. But I recall that I did a simple "service netif restart" in >>> 11-CURRENT >>> recently and that worked. >>> >>> Has there been a change? What is now the official way to restart network? >> >> Since the past couple of years on every new FreeBSD I put this in motd for my >> linux colleagues and coworkers: >> >>Network: >>To apply changes you have made to the network: >># /etc/rc.d/netif restart && /etc/rc.d/routing restart >> >> Perhaps we could introduce a wrapper to be used with: >># service network restart > > > > I think this is a great idea - especially as it would make it easier for > dev's and other novice admin's to use freebsd as a development platform. Special casing would need to be done with DHCP, btw.. Also, what about IPv6 (rtsol/rtsold, etc)? Thanks! -Ngie ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Large patch/diff refuses to apply
On 10/06/16 10:58, Dimitry Andric wrote: > On 06 Oct 2016, at 17:23, Sean Bruno wrote: >> >> On 10/06/16 09:19, Sean Bruno wrote: >>> >>> On 10/06/16 09:00, Alan Somers wrote: On Thu, Oct 6, 2016 at 8:41 AM, Sean Bruno wrote: > > On 10/06/16 08:23, Slawa Olhovchenkov wrote: >> On Thu, Oct 06, 2016 at 07:57:57AM -0600, Sean Bruno wrote: > ... >> A good example of what I was trying to do: >> svn mkdir sys/modules/ix/ix_iflib >> svn cp sys/modules/ix/Makefile sys/modules/ix/ix/ix_iflib/Makefile >> >> >> That seems to really confuse things. > > Try using: svn diff --show-copies-as-adds > > -Dimitry > Most of what I was trying to do was with arcanist. The review generation seemed to be fine, but applying the diff from arcanist seemed to blow up. sean signature.asc Description: OpenPGP digital signature
11.0-RELEASE Status Update
As many of you are aware, 11.0-RELEASE needed to be rebuilt to address several issues that were discovered after the release was built. Extra caution is being taken in testing the rebuilt releases, so at present, the final release announcement is planned for Monday, October 10. Thank you for your patience in waiting for 11.0-RELEASE. Glen On behalf of: re@ signature.asc Description: PGP signature
Re: [request for testing] isl, cyapa on chromebooks
On Thu, 6 Oct 2016 11:12:27 +0300 Andriy Gapon wrote: > On 06/10/2016 11:10, Michael Gmelin wrote: > > > > > >> On 06 Oct 2016, at 09:48, Andriy Gapon wrote: > >> > >>> On 06/10/2016 08:37, Andriy Gapon wrote: > >>> The more testing the better! > >> > >> Based on Michael's results I've uploaded a new version: > >> https://people.freebsd.org/~avg/ig4-i2c.v4.diff > >> > >> > > > > Good news. Applying the last two fixes manually, isl is working > > now. > > Great! > > > I'll rebuild a kernel using the complete v4 patch on my second > > machine later today to test the modified cyapa driver. > > Thank you again! > Just tested, cyapa is working ok as well, cool. Now, if we wanted to make touchpads like the Elantech (and probably other increasingly popular devices work), I assume we'll need HID over I2C support. OpenBSD got that recently (imt(4) and friends). Anybody interested in porting/re-implementing? -m -- Michael Gmelin ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Large patch/diff refuses to apply
On 06 Oct 2016, at 17:23, Sean Bruno wrote: > > On 10/06/16 09:19, Sean Bruno wrote: >> >> On 10/06/16 09:00, Alan Somers wrote: >>> On Thu, Oct 6, 2016 at 8:41 AM, Sean Bruno wrote: On 10/06/16 08:23, Slawa Olhovchenkov wrote: > On Thu, Oct 06, 2016 at 07:57:57AM -0600, Sean Bruno wrote: ... > A good example of what I was trying to do: > svn mkdir sys/modules/ix/ix_iflib > svn cp sys/modules/ix/Makefile sys/modules/ix/ix/ix_iflib/Makefile > > > That seems to really confuse things. Try using: svn diff --show-copies-as-adds -Dimitry signature.asc Description: Message signed with OpenPGP using GPGMail
Re: CURRENT: "service netif restart" looses default route
On 10/6/16 12:27 AM, Oliver Peter wrote: On Wed, Oct 05, 2016 at 06:47:48PM +0200, O. Hartmann wrote: Today, I checked on two servers of ours running both a recent CURRENT (i.e. FreeBSD 12.0-CURRENT #43 r306701: Wed Oct 5 06:40:40 CEST 2016) via "service netif restart" the upcoming network and realised that the default route is lost then! I'm able to config the route via "service routing restart" - or manually as I did otherwise. But I recall that I did a simple "service netif restart" in 11-CURRENT recently and that worked. Has there been a change? What is now the official way to restart network? Since the past couple of years on every new FreeBSD I put this in motd for my linux colleagues and coworkers: Network: To apply changes you have made to the network: # /etc/rc.d/netif restart && /etc/rc.d/routing restart Perhaps we could introduce a wrapper to be used with: # service network restart I think this is a great idea - especially as it would make it easier for dev's and other novice admin's to use freebsd as a development platform. cheers, -pete -- Pete Wright p...@nomadlogic.org nomadlogicLA ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Large patch/diff refuses to apply
On 10/06/16 09:19, Sean Bruno wrote: > > > On 10/06/16 09:00, Alan Somers wrote: >> On Thu, Oct 6, 2016 at 8:41 AM, Sean Bruno wrote: >>> >>> >>> On 10/06/16 08:23, Slawa Olhovchenkov wrote: On Thu, Oct 06, 2016 at 07:57:57AM -0600, Sean Bruno wrote: > I'm doing a large amount of change to ixgbe(4) in support of IFLIB > implementations and running into failures when trying to apply large > diffs. This is causing phabricator reviews to be unuseable as well. > > I've setup two trees to test this. The first tree is used to generate > the diff and the second (vanilla) is used to apply the diff. The entire > patch fails to apply, so I'm assuming that the size of the diff is > failing because of a sanity check or something. No. This is expanded/collapsed keywords issuse: === -**/ -/*$FreeBSD$*/ === svn diff over repo generate patch w/ collapsed keywords. At working copy all keywords expanded. >>> >>> Ah, I see. Thank you. >>> >>> I am regenerating the failed files now. That seems to work (if I leave >>> the keywords alone). >>> >>> sean >>> >> >> Also, I think the "svn patch" command (as opposed to plain "patch") >> can deal with the RCS keywords. >> > > The use of "svn cp" also seems to generate a lot of failures as well. > > I do want to maintain history between certain files when I go to commit. > e.g. svn cp fileA new_fileA, but this seems to confuse the crap out of > diff/patch no matter what I do. This leads to suffering with > phabricator as well. > > For now, I'm not going to do the "svn cp" part of my commit, but I will > try and do this when I am ready to shove my work into current. > > sean > A good example of what I was trying to do: svn mkdir sys/modules/ix/ix_iflib svn cp sys/modules/ix/Makefile sys/modules/ix/ix/ix_iflib/Makefile That seems to really confuse things. sean signature.asc Description: OpenPGP digital signature
Re: Large patch/diff refuses to apply
On 10/06/16 09:00, Alan Somers wrote: > On Thu, Oct 6, 2016 at 8:41 AM, Sean Bruno wrote: >> >> >> On 10/06/16 08:23, Slawa Olhovchenkov wrote: >>> On Thu, Oct 06, 2016 at 07:57:57AM -0600, Sean Bruno wrote: >>> I'm doing a large amount of change to ixgbe(4) in support of IFLIB implementations and running into failures when trying to apply large diffs. This is causing phabricator reviews to be unuseable as well. I've setup two trees to test this. The first tree is used to generate the diff and the second (vanilla) is used to apply the diff. The entire patch fails to apply, so I'm assuming that the size of the diff is failing because of a sanity check or something. >>> >>> No. This is expanded/collapsed keywords issuse: >>> >>> === >>> -**/ >>> -/*$FreeBSD$*/ >>> === >>> >>> svn diff over repo generate patch w/ collapsed keywords. >>> At working copy all keywords expanded. >>> >> >> Ah, I see. Thank you. >> >> I am regenerating the failed files now. That seems to work (if I leave >> the keywords alone). >> >> sean >> > > Also, I think the "svn patch" command (as opposed to plain "patch") > can deal with the RCS keywords. > The use of "svn cp" also seems to generate a lot of failures as well. I do want to maintain history between certain files when I go to commit. e.g. svn cp fileA new_fileA, but this seems to confuse the crap out of diff/patch no matter what I do. This leads to suffering with phabricator as well. For now, I'm not going to do the "svn cp" part of my commit, but I will try and do this when I am ready to shove my work into current. sean signature.asc Description: OpenPGP digital signature
Re: Large patch/diff refuses to apply
On Thu, Oct 6, 2016 at 8:41 AM, Sean Bruno wrote: > > > On 10/06/16 08:23, Slawa Olhovchenkov wrote: >> On Thu, Oct 06, 2016 at 07:57:57AM -0600, Sean Bruno wrote: >> >>> I'm doing a large amount of change to ixgbe(4) in support of IFLIB >>> implementations and running into failures when trying to apply large >>> diffs. This is causing phabricator reviews to be unuseable as well. >>> >>> I've setup two trees to test this. The first tree is used to generate >>> the diff and the second (vanilla) is used to apply the diff. The entire >>> patch fails to apply, so I'm assuming that the size of the diff is >>> failing because of a sanity check or something. >> >> No. This is expanded/collapsed keywords issuse: >> >> === >> -**/ >> -/*$FreeBSD$*/ >> === >> >> svn diff over repo generate patch w/ collapsed keywords. >> At working copy all keywords expanded. >> > > Ah, I see. Thank you. > > I am regenerating the failed files now. That seems to work (if I leave > the keywords alone). > > sean > Also, I think the "svn patch" command (as opposed to plain "patch") can deal with the RCS keywords. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Large patch/diff refuses to apply
On 10/06/16 08:23, Slawa Olhovchenkov wrote: > On Thu, Oct 06, 2016 at 07:57:57AM -0600, Sean Bruno wrote: > >> I'm doing a large amount of change to ixgbe(4) in support of IFLIB >> implementations and running into failures when trying to apply large >> diffs. This is causing phabricator reviews to be unuseable as well. >> >> I've setup two trees to test this. The first tree is used to generate >> the diff and the second (vanilla) is used to apply the diff. The entire >> patch fails to apply, so I'm assuming that the size of the diff is >> failing because of a sanity check or something. > > No. This is expanded/collapsed keywords issuse: > > === > -**/ > -/*$FreeBSD$*/ > === > > svn diff over repo generate patch w/ collapsed keywords. > At working copy all keywords expanded. > Ah, I see. Thank you. I am regenerating the failed files now. That seems to work (if I leave the keywords alone). sean signature.asc Description: OpenPGP digital signature
Re: Large patch/diff refuses to apply
On Thu, Oct 06, 2016 at 07:57:57AM -0600, Sean Bruno wrote: > I'm doing a large amount of change to ixgbe(4) in support of IFLIB > implementations and running into failures when trying to apply large > diffs. This is causing phabricator reviews to be unuseable as well. > > I've setup two trees to test this. The first tree is used to generate > the diff and the second (vanilla) is used to apply the diff. The entire > patch fails to apply, so I'm assuming that the size of the diff is > failing because of a sanity check or something. No. This is expanded/collapsed keywords issuse: === -**/ -/*$FreeBSD$*/ === svn diff over repo generate patch w/ collapsed keywords. At working copy all keywords expanded. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: CURRENT: "service netif restart" looses default route
On Thu, 6 Oct 2016 09:27:53 +0200
Oliver Peter wrote:
> On Wed, Oct 05, 2016 at 06:47:48PM +0200, O. Hartmann wrote:
> >
> > Today, I checked on two servers of ours running both a recent
> > CURRENT (i.e. FreeBSD 12.0-CURRENT #43 r306701: Wed Oct 5 06:40:40
> > CEST 2016) via "service netif restart" the upcoming network and
> > realised that the default route is lost then!
> >
> > I'm able to config the route via "service routing restart" - or
> > manually as I did otherwise. But I recall that I did a simple
> > "service netif restart" in 11-CURRENT recently and that worked.
> >
> > Has there been a change? What is now the official way to restart
> > network?
>
> Since the past couple of years on every new FreeBSD I put this in
> motd for my linux colleagues and coworkers:
>
> Network:
> To apply changes you have made to the network:
> # /etc/rc.d/netif restart && /etc/rc.d/routing restart
>
> Perhaps we could introduce a wrapper to be used with:
> # service network restart
>
> oliver@local ~ % cat /etc/rc.d/network
> #!/bin/sh
>
> # PROVIDE: network
> # REQUIRE: netif routing
> # KEYWORD: nojailvnet
>
> . /etc/rc.subr
> . /etc/network.subr
>
> name="network"
> start_cmd="network_start"
> stop_cmd="network_stop"
>
> network_start()
> {
> /etc/rc.d/netif start
> /etc/rc.d/routing start
> }
>
> network_stop()
> {
> /etc/rc.d/netif stop
> /etc/rc.d/routing stop
> }
>
> load_rc_config $name
> run_rc_command $*
>
>
I'm sorry that my sloppyness brought up this discussion.
I recall that I tried to hunt down a bug and did lots of "service netif
restart". But on a local network with all essential servers on the same
net, I never faced a problem with routing.
If life gets too easy, people start digging for the reason of a problem
too deep when the framework does too much stuff automated ...
The knowledge of the fact that I also have to restart routing via a
script is sufficient for me - also the fact to know that netif restart
doesn't restart routing.
Regards,
Oliver
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Large patch/diff refuses to apply
I'm doing a large amount of change to ixgbe(4) in support of IFLIB implementations and running into failures when trying to apply large diffs. This is causing phabricator reviews to be unuseable as well. I've setup two trees to test this. The first tree is used to generate the diff and the second (vanilla) is used to apply the diff. The entire patch fails to apply, so I'm assuming that the size of the diff is failing because of a sanity check or something. https://people.freebsd.org/~sbruno/test.diff % svn stat sys/dev/ixgbe/if_ix.c M sys/dev/ixgbe/if_ix.c % svn diff sys/dev/ixgbe/if_ix.c > ~/test.diff % cd ../vanilla/ % patch -p0 < ~/test.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |Index: sys/dev/ixgbe/if_ix.c |=== |--- sys/dev/ixgbe/if_ix.c (revision 306673) |+++ sys/dev/ixgbe/if_ix.c (working copy) -- Patching file sys/dev/ixgbe/if_ix.c using Plan A... Hunk #1 failed at 1. 1 out of 1 hunks failed--saving rejects to sys/dev/ixgbe/if_ix.c.rej done % ls -l sys/dev/ixgbe/if_ix.c* -rw-r--r-- 1 sbruno wheel 166692 Oct 6 06:41 sys/dev/ixgbe/if_ix.c -rw-r--r-- 1 sbruno wheel 166692 Oct 6 06:37 sys/dev/ixgbe/if_ix.c.orig -rw-r--r-- 1 sbruno wheel 172779 Oct 6 06:41 sys/dev/ixgbe/if_ix.c.rej % svn stat sys/dev/ixgbe/ ? sys/dev/ixgbe/if_ix.c.orig signature.asc Description: OpenPGP digital signature
Re: [request for testing] isl, cyapa on chromebooks
On 06/10/2016 11:10, Michael Gmelin wrote: > > >> On 06 Oct 2016, at 09:48, Andriy Gapon wrote: >> >>> On 06/10/2016 08:37, Andriy Gapon wrote: >>> The more testing the better! >> >> Based on Michael's results I've uploaded a new version: >> https://people.freebsd.org/~avg/ig4-i2c.v4.diff >> >> > > Good news. Applying the last two fixes manually, isl is working now. Great! > I'll rebuild a kernel using the complete v4 patch on my second machine later > today to test the modified cyapa driver. Thank you again! -- Andriy Gapon ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: [request for testing] isl, cyapa on chromebooks
> On 06 Oct 2016, at 09:48, Andriy Gapon wrote: > >> On 06/10/2016 08:37, Andriy Gapon wrote: >> The more testing the better! > > Based on Michael's results I've uploaded a new version: > https://people.freebsd.org/~avg/ig4-i2c.v4.diff > > Good news. Applying the last two fixes manually, isl is working now. I'll rebuild a kernel using the complete v4 patch on my second machine later today to test the modified cyapa driver. -m ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: [request for testing] isl, cyapa on chromebooks
On 06/10/2016 08:37, Andriy Gapon wrote: > The more testing the better! Based on Michael's results I've uploaded a new version: https://people.freebsd.org/~avg/ig4-i2c.v4.diff -- Andriy Gapon ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: [request for testing] isl, cyapa on chromebooks
On 06/10/2016 10:25, Andriy Gapon wrote: > On 06/10/2016 10:08, Michael Gmelin wrote: >> >> >>> On 05 Oct 2016, at 15:01, Andriy Gapon wrote: >>> On 05/10/2016 14:19, Michael Gmelin wrote: ig4iic_start is called, but iicbus_hinted_child, isl_probe, iicbus_probe and iicbus_attach are not. >>> >>> Thank you! >>> Now I think I see where I made a silly mistake. >>> Please try an updated version of the patch from here >>> https://people.freebsd.org/~avg/ig4-i2c.v3.diff >>> It contains a fix and some cosmetic changes on top of the previous patch. >>> >> >> Isl attaches cleanly on iicbus1 now, but it doesn't appear to function (all >> inputs, like dev.isl.ir etc, are stuck at 0). > > At least some progress... > Anything interesting in logs? > > Oh! and I've just spotted a typo in isl.c: the last call to isl_read_byte() in > isl_read_sensor() should have REG_DATA2 (not REG_DATA1 again). And another, more severe typo :-( In isl_read_byte we should pass both messages to the bus: return (iicbus_transfer(dev, msgs, 2)); That is, s/1/2/. -- Andriy Gapon ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: CURRENT: "service netif restart" looses default route
On Wed, Oct 05, 2016 at 06:47:48PM +0200, O. Hartmann wrote:
>
> Today, I checked on two servers of ours running both a recent CURRENT (i.e.
> FreeBSD
> 12.0-CURRENT #43 r306701: Wed Oct 5 06:40:40 CEST 2016) via "service netif
> restart" the
> upcoming network and realised that the default route is lost then!
>
> I'm able to config the route via "service routing restart" - or manually as I
> did
> otherwise. But I recall that I did a simple "service netif restart" in
> 11-CURRENT
> recently and that worked.
>
> Has there been a change? What is now the official way to restart network?
Since the past couple of years on every new FreeBSD I put this in motd for my
linux colleagues and coworkers:
Network:
To apply changes you have made to the network:
# /etc/rc.d/netif restart && /etc/rc.d/routing restart
Perhaps we could introduce a wrapper to be used with:
# service network restart
oliver@local ~ % cat /etc/rc.d/network
#!/bin/sh
# PROVIDE: network
# REQUIRE: netif routing
# KEYWORD: nojailvnet
. /etc/rc.subr
. /etc/network.subr
name="network"
start_cmd="network_start"
stop_cmd="network_stop"
network_start()
{
/etc/rc.d/netif start
/etc/rc.d/routing start
}
network_stop()
{
/etc/rc.d/netif stop
/etc/rc.d/routing stop
}
load_rc_config $name
run_rc_command $*
--
Oliver PETER oli...@gfuzz.de 0x456D688F
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: [request for testing] isl, cyapa on chromebooks
On 06/10/2016 10:08, Michael Gmelin wrote: > > >> On 05 Oct 2016, at 15:01, Andriy Gapon wrote: >> >>> On 05/10/2016 14:19, Michael Gmelin wrote: >>> >>> ig4iic_start is called, but iicbus_hinted_child, isl_probe, iicbus_probe and >>> iicbus_attach are not. >> >> Thank you! >> Now I think I see where I made a silly mistake. >> Please try an updated version of the patch from here >> https://people.freebsd.org/~avg/ig4-i2c.v3.diff >> It contains a fix and some cosmetic changes on top of the previous patch. >> > > Isl attaches cleanly on iicbus1 now, but it doesn't appear to function (all > inputs, like dev.isl.ir etc, are stuck at 0). At least some progress... Anything interesting in logs? Oh! and I've just spotted a typo in isl.c: the last call to isl_read_byte() in isl_read_sensor() should have REG_DATA2 (not REG_DATA1 again). Thank you for testing! -- Andriy Gapon ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: [request for testing] isl, cyapa on chromebooks
> On 05 Oct 2016, at 15:01, Andriy Gapon wrote: > >> On 05/10/2016 14:19, Michael Gmelin wrote: >> >> ig4iic_start is called, but iicbus_hinted_child, isl_probe, iicbus_probe and >> iicbus_attach are not. > > Thank you! > Now I think I see where I made a silly mistake. > Please try an updated version of the patch from here > https://people.freebsd.org/~avg/ig4-i2c.v3.diff > It contains a fix and some cosmetic changes on top of the previous patch. > Isl attaches cleanly on iicbus1 now, but it doesn't appear to function (all inputs, like dev.isl.ir etc, are stuck at 0). -m ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
