Re: buildkernel failure because ctfconvert not installed

2020-04-09 Thread Poul-Henning Kamp

In message <9f03fb79-a0ad-3c11-9a50-bc7731882...@fastmail.com>, Yuri Pankov 
writes:
>Trond Endrestøl wrote:
>> On Thu, 9 Apr 2020 10:56+0200, Gary Jennejohn wrote:
>> 
>>> OK, I figured it out.
>>>
>>> I used to have MK_CTF=no in src.conf, but I recently changed it to
>>> WITH_CTF=no.
>> 
>> It's either WITH_xxx=yes or WITHOUT_xxx=yes.
>
>Or even WITH_xxx= or WITHOUT_xxx=, src.conf(5) explicitly states that 
>value is NOT checked:
>
>The values of variables are ignored regardless of their setting; even if 
>  they would be set to "FALSE" or "NO".  The presence of an option 
>causes it to be honored by make(1).

That is not even close to POLA-compliance...

Obviously negative values ("false", "no") should either be reported as
errors or preferably be respected.

PS: [This is not the bikeshed you are looking for]
 

-- 
Poul-Henning Kamp   | UNIX since Zilog Zeus 3.20
p...@freebsd.org | TCP/IP since RFC 956
FreeBSD committer   | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: .debug files, skip?

2020-04-09 Thread Alexey Dokuchaev
On Sun, Apr 05, 2020 at 07:41:38PM -0400, Ed Maste wrote:
> On Sun, 5 Apr 2020 at 08:32, Jeffrey Bouquet wrote:
> >
> > A recent build[k,w] [ ** stable  12.1] and many .debug files I'd
> > like to skip if poss. A knob?
> 
> Yes, from src.conf(5):
>  WITHOUT_DEBUG_FILES
>  Set to avoid building or installing standalone debug
>  files for each executable binary and shared library.

I have "MK_DEBUG_FILES=no" in /etc/make.conf, which one is more correct?

./danfe
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: 12-STABLE: BEARSSL: liblua compiler error: too few arguments to function call

2020-04-09 Thread Simon J. Gerraty
Fixed in r359769

Hartmann, O.  wrote:

> While recent CURRENT doesn't show any problems, 12-STABLE (r359768)
> drops out from buildworld with the error shown below when option
> 
> WITH_BEARSSL= YES
> 
> is set in /etc/src.conf
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: 12-STABLE: BEARSSL: liblua compiler error: too few arguments to function call

2020-04-09 Thread Simon J. Gerraty
Hartmann, O.  wrote:

> While recent CURRENT doesn't show any problems, 12-STABLE (r359768)
> drops out from buildworld with the error shown below when option
> 
> WITH_BEARSSL= YES

Sorry, I did buildworld just before committing r359735
but I use ficl, - missed the below for lua.
Will fix.

> 
> is set in /etc/src.conf
> 
> [...]
> Building /usr/obj/usr/src/amd64.amd64/stand/liblua/lutils.o
> --- lstd.o ---
> /usr/src/stand/liblua/lstd.c:86:44: error: too few arguments to
> function call, expected 5, have 4 if (verify_file(fd, filename, 0,
> VE_GUESS) < 0) { ~~~  ^
> /usr/src/lib/libsecureboot/h/verify_file.h:50:1: note: 'verify_file'
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: r359627 is panicked with 'softdep_setup_blkfree: not free'

2020-04-09 Thread Kirk McKusick
> Date: Fri, 10 Apr 2020 11:17:39 +0900 (JST)
> To: freebsd-current@freebsd.org
> Cc: mckus...@mckusick.com
> Subject: Re: r359627 is panicked with 'softdep_setup_blkfree: not free'
> From: Masachika ISHIZUKA 
> 
>>I'm using r359627M. (r359627 with mount_udf2).
>>It is panicked with 'softdep_setup_blkfree: not free'.
 
 Could you please try this workaround to see if it clears your panic:
 
>   [snip]
 
 +  journaltrunc = 0;
>> 
>> Thanks for checking and sorry it did not help.
>> 
>> If you can bisect to find the commit that caused the problem to show
>> up or if you find a way to trigger the panic that would be very helpful
>> in tracking it down.
> 
>   Hi.
> 
>   I applied the above patch to r359627M and occured panic.
>   This was r359668 was not applied.
> 
>   I made buildkernel on r359766M and this looks work fine.
>   Thank you very much for your effort.
> 
> # The panic was occured to open/close tabs on firefox.
> -- 
> Masachika ISHIZUKA

Sounds like r359766M solved the problem. Thanks for your report.
Glad to hear that everything is back to working.

Kirk McKusick
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


12-STABLE: BEARSSL: liblua compiler error: too few arguments to function call

2020-04-09 Thread Hartmann, O.
While recent CURRENT doesn't show any problems, 12-STABLE (r359768)
drops out from buildworld with the error shown below when option

WITH_BEARSSL= YES

is set in /etc/src.conf

[...]
Building /usr/obj/usr/src/amd64.amd64/stand/liblua/lutils.o
--- lstd.o ---
/usr/src/stand/liblua/lstd.c:86:44: error: too few arguments to
function call, expected 5, have 4 if (verify_file(fd, filename, 0,
VE_GUESS) < 0) { ~~~  ^
/usr/src/lib/libsecureboot/h/verify_file.h:50:1: note: 'verify_file'
declared here int verify_file(int, const char *, off_t, int, const
char *); ^
1 error generated.
*** [lstd.o] Error code 1

Kind regards,

oh


pgppK5ZbxAh72.pgp
Description: OpenPGP digital signature


Re: r359627 is panicked with 'softdep_setup_blkfree: not free'

2020-04-09 Thread Masachika ISHIZUKA
>I'm using r359627M. (r359627 with mount_udf2).
>It is panicked with 'softdep_setup_blkfree: not free'.
>>> 
>>> Could you please try this workaround to see if it clears your panic:
>>> 
  [snip]
>>> 
>>> +   journaltrunc = 0;
> 
> Thanks for checking and sorry it did not help.
> 
> If you can bisect to find the commit that caused the problem to show
> up or if you find a way to trigger the panic that would be very helpful
> in tracking it down.

  Hi.

  I applied the above patch to r359627M and occured panic.
  This was r359668 was not applied.

  I made buildkernel on r359766M and this looks work fine.
  Thank you very much for your effort.

# The panic was occured to open/close tabs on firefox.
-- 
Masachika ISHIZUKA
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: lib/libsysdecode /usr/include/./sys/pioctl.h:45:2: error: " is deprecated

2020-04-09 Thread Brooks Davis
On Thu, Apr 09, 2020 at 11:49:47PM +0200, Julian H. Stacey wrote:
> Anyoe else seeing this on current ?
> 
> ===> lib/libsysdecode (all)
> env CPP="cpp" MK_PF="yes"  /bin/sh /usr/src/lib/libsysdecode/mkioctls 
> /usr/include > ioctl.c.tmp
> In file included from :97:
> /usr/include/./sys/pioctl.h:45:2: warning: " is deprecated, 
> ptrace() should be used instead"
>   [-W#warnings]
> #warning " is deprecated, ptrace() should be used instead"
>  ^
> 1 warning generated.
> if [ ! -e ioctl.c ] || ! cmp -s ioctl.c ioctl.c.tmp; then  mv -f ioctl.c.tmp 
> ioctl.c;  fi
> cc  -O2 -pipe -fno-common   
> -I/data/release/s1/usr/obj/usr/src/amd64.amd64/lib/libsysdecode 
> -I/usr/src/sys -I/usr/src/libexec/rtld-elf -DPF -g -MD  -MF.depend.ioctl.o 
> -MTioctl.o -std=gnu99 -Wno-format-zero-length -fstack-protector-strong 
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter 
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type 
> -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align 
> -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls 
> -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations 
> -Wthread-safety -Wno-empty-body -Wno-string-plus-int 
> -Wno-unused-const-variable  -Qunused-arguments-c ioctl.c -o ioctl.o
> In file included from ioctl.c:126:
> /usr/include/./sys/pioctl.h:45:2: error: " is deprecated, 
> ptrace() should be used instead"
>   [-Werror,-W#warnings]
> #warning " is deprecated, ptrace() should be used instead"

Hmm, I thought that the default removal of obsolete headers would at
least get right of the header in WORLDTMP, but now I'm wondering if
there's an additional boundary condition.  (I'm surprised there isn't a
--sysroot in your compiler command which is presumably why you're
getting the system sys/pioctl.h...)

You can do a clean build or work around it by removing ioctl.c in
/lib/libsysdecode and /obj-lib32/lib/libsysdecode.

-- Brooks


signature.asc
Description: PGP signature


lib/libsysdecode /usr/include/./sys/pioctl.h:45:2: error: " is deprecated

2020-04-09 Thread Julian H. Stacey
Anyoe else seeing this on current ?

===> lib/libsysdecode (all)
env CPP="cpp" MK_PF="yes"  /bin/sh /usr/src/lib/libsysdecode/mkioctls 
/usr/include > ioctl.c.tmp
In file included from :97:
/usr/include/./sys/pioctl.h:45:2: warning: " is deprecated, 
ptrace() should be used instead"
  [-W#warnings]
#warning " is deprecated, ptrace() should be used instead"
 ^
1 warning generated.
if [ ! -e ioctl.c ] || ! cmp -s ioctl.c ioctl.c.tmp; then  mv -f ioctl.c.tmp 
ioctl.c;  fi
cc  -O2 -pipe -fno-common   
-I/data/release/s1/usr/obj/usr/src/amd64.amd64/lib/libsysdecode -I/usr/src/sys 
-I/usr/src/libexec/rtld-elf -DPF -g -MD  -MF.depend.ioctl.o -MTioctl.o 
-std=gnu99 -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers 
-Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes 
-Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings 
-Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline 
-Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign 
-Wmissing-variable-declarations -Wthread-safety -Wno-empty-body 
-Wno-string-plus-int -Wno-unused-const-variable  -Qunused-arguments-c 
ioctl.c -o ioctl.o
In file included from ioctl.c:126:
/usr/include/./sys/pioctl.h:45:2: error: " is deprecated, 
ptrace() should be used instead"
  [-Werror,-W#warnings]
#warning " is deprecated, ptrace() should be used instead"

Cheers
--
Julian Stacey, Consultant Systems Engineer, BSD Linux http://berklix.com/jhs/
http://berklix.org/corona/   Brexit 31 Dec 2020 will damage UK & EU yet more.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: r359627 is panicked with 'softdep_setup_blkfree: not free'

2020-04-09 Thread Masachika ISHIZUKA
>>>I'm using r359627M. (r359627 with mount_udf2).
>>>It is panicked with 'softdep_setup_blkfree: not free'.
> 
> Could you please try this workaround to see if it clears your panic:
> 
> *** sys/ufs/ffs/ffs_inode.c   Wed Apr  8 21:57:31 2020
> --- sys/ufs/ffs/ffs_inode.c.new   Wed Apr  8 22:33:36 2020
> ***
> *** 244,249 
> --- 244,250 
>   needextclean = 0;
>   softdeptrunc = 0;
>   journaltrunc = DOINGSUJ(vp);
> + journaltrunc = 0;
>   if (journaltrunc == 0 && DOINGSOFTDEP(vp) && length == 0)
>   softdeptrunc = !softdep_slowdown(vp);
>   extblocks = 0;

  Thank you for reply, and sorry to late reply.

  Unfortunately, this patch did not prevent panic.
-- 
Masachika ISHIZUKA
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: buildkernel failure because ctfconvert not installed

2020-04-09 Thread Gary Jennejohn
On Thu, 9 Apr 2020 06:34:08 -0500
Justin Hibbits  wrote:

> On Thu, Apr 9, 2020, 03:57 Gary Jennejohn  wrote:
> 
> >
> > OK, I figured it out.
> >
> > I used to have MK_CTF=no in src.conf, but I recently changed it to
> > WITH_CTF=no.
> >  
> 
> It should be spelled
> 
> WITHOUT_CTF=
> 
> only the existence of WITH_/WITHOUT_ is checked, not the value.
> 

You're right, just having WITHOUT_CTF= in src.conf fixes all my
problems.  It was fooled by there only being
/usr/src/tools/build/options/WITH_CTF.

> 
> 
> > /sys/conf/kern.post.mk checks whether MK_CTF is no and apparently
> > does not invoke ctfconvert if that is the case.
> >
> > I put MK_CTF=no back into src.conf.
> >
> > So, now everything works without having cftconvert installed.
> >
> > --
> > Gary Jennejohn
> >  


-- 
Gary Jennejohn
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: buildkernel failure because ctfconvert not installed

2020-04-09 Thread Yuri Pankov

Trond Endrestøl wrote:

On Thu, 9 Apr 2020 10:56+0200, Gary Jennejohn wrote:


OK, I figured it out.

I used to have MK_CTF=no in src.conf, but I recently changed it to
WITH_CTF=no.


It's either WITH_xxx=yes or WITHOUT_xxx=yes.


Or even WITH_xxx= or WITHOUT_xxx=, src.conf(5) explicitly states that 
value is NOT checked:


The values of variables are ignored regardless of their setting; even if 
 they would be set to "FALSE" or "NO".  The presence of an option 
causes it to be honored by make(1).



/sys/conf/kern.post.mk checks whether MK_CTF is no and apparently
does not invoke ctfconvert if that is the case.

I put MK_CTF=no back into src.conf.

So, now everything works without having cftconvert installed.




___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: buildkernel failure because ctfconvert not installed

2020-04-09 Thread Trond Endrestøl
On Thu, 9 Apr 2020 10:56+0200, Gary Jennejohn wrote:

> OK, I figured it out.
> 
> I used to have MK_CTF=no in src.conf, but I recently changed it to
> WITH_CTF=no.

It's either WITH_xxx=yes or WITHOUT_xxx=yes.

> /sys/conf/kern.post.mk checks whether MK_CTF is no and apparently
> does not invoke ctfconvert if that is the case.
> 
> I put MK_CTF=no back into src.conf.
> 
> So, now everything works without having cftconvert installed.

-- 
Trond.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: buildkernel failure because ctfconvert not installed

2020-04-09 Thread Gary Jennejohn


OK, I figured it out.

I used to have MK_CTF=no in src.conf, but I recently changed it to
WITH_CTF=no.

/sys/conf/kern.post.mk checks whether MK_CTF is no and apparently
does not invoke ctfconvert if that is the case.

I put MK_CTF=no back into src.conf.

So, now everything works without having cftconvert installed.

-- 
Gary Jennejohn
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: buildkernel failure because ctfconvert not installed

2020-04-09 Thread Gary Jennejohn
On Wed, 8 Apr 2020 14:51:14 -0700
John Baldwin  wrote:

> On 4/7/20 11:32 PM, Gary Jennejohn wrote:
> > Has anyone else seen this error?
> > 
> > I tried to build a kernel yesterday, but the build failed while compiling
> > modules because ctfconvert was not found.
> > 
> > I've had WITH_CTF=no in my src.conf for years, so neither ctfconvert nor
> > ctfmerge were installed.
> > 
> > OK, I'll just go to the source dirctories and build and install.
> > 
> > Nope.  I got this error:
> > make: exec(ctfconvert) failed (No such file or directory)
> > and the build failed.
> > 
> > WTF?  ctfconvert requires ctfconvert to build?  That makes no sense and is
> > a real chicken-and-egg problem if I've ever seen one.
> > 
> > I ended up creating /usr/bin/ctf{convert,merge} shell scripts which simply
> > did exit 0.  That allowed me to finally compile and install the utilities.
> > 
> > Now I'm forced to have WITH_CTF=yes in my src.conf.  No big deal.
> > 
> > Still, it seems like the change to the make infrastructure which assumed
> > that cft{convert,merge} are always installed was rather premature.  
> 
> The change is that GENERIC has 'makeoptions WITH_CTF=yes'.  If you build a
> kernel without that, you shouldn't need to have ctfconvert installed.  This
> does mean you need to use a custom kernel instead of GENERIC.
> 

That is exactly what I found confusing.  I tried both with and without
CTF in my kernel config file and the build still failed.

grep CTF /sys/amd64/conf/ernst_new
#makeoptions WITH_CTF=1  # Run ctfconvert(1) for DTrace support
#options DDB_CTF # Kernel ELF linker loads CTF data

I also have
makeoptions MODULES_OVERRIDE="cpuctl msdosfs pseudofs filemon"

If I move ctfconvert away then I see this error:

cd /usr/src; make buildkernel

--
>>> Kernel build for ernst_new started on Thu Apr  9 08:51:06 CEST 2020
--
===> ernst_new
--
>>> stage 1: configuring the kernel
--
Kernel build directory is /home/garyj/obj/usr/src/amd64.amd64/sys/ernst_new
Don't forget to do ``make cleandepend && make depend''

--
>>> stage 2.3: build tools
--

--
>>> stage 3.1: building everything
--
sh: ctfconvert: not found
*** [cpuctl.o] Error code 127
make[4]: *** cpuctl.o removed

make[4]: stopped in /usr/src/sys/modules/cpuctl
.ERROR_TARGET='cpuctl.o'
.ERROR_META_FILE='/home/garyj/obj/usr/src/amd64.amd64/sys/ernst_new/modules/usr/src/sys/modules/cpuctl/cpuctl.o.meta'

So, without ctfconvert installed buildkernel ALWAYS fails to build the
modules no matter what CTF options are used in the kernel config file.

In contrast, buildworld does still work without ctfconvert.

-- 
Gary Jennejohn
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"