Re: panic after update from main-n258027-c9baa974717a to main-n258075-5b5b7e2ca2fa

2022-09-17 Thread Mateusz Guzik
this is already fixed, please update

On 9/17/22, David Wolfskill  wrote:
> Not reproducible on reboot; only happened on one machine (main laptop)
> out of 3 that I updated this morning.  No dump. :-/
>
> A screenshot, a copy of the full dmesg.boot from the
> immediately-following successful (verbose) boot, and a copy of the
> uname output:
>
> FreeBSD 14.0-CURRENT #589 main-n258075-5b5b7e2ca2fa: Sat Sep 17 12:22:57 UTC
> 2022
> r...@g1-70.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/CANARY
> amd64 1400068 1400068
>
> may be found at https://www.catwhisker.org/~david/FreeBSD/head/n258075/
>
> The screenshot includes a backtrace; a hand-transcription:
>
> Trying to mount root from ufs:/dev/ada0s4a [rw]...
> panic: Assertion _ndp->ni_cnd.cn_pnbuf != NULL failed at
> /usr/src/sys/kern/vfs_mountroot.c:731
> cpuid = 1
> time = 2
> KDB: stack backtrace:
> db_trace_self_wrapper() at 0x804b9dfb =
> db_trace_self_wrapper+0x2b/frame 0xfe0fba5d4af0
> vpanic() at 0x80bd90f1 = vpanic+0x151/frame 0xfe0fba5d4b40
> panic() at 0x80bd8ec3 = panic+0x43/frame 0xfe0fba5d4ba0
> parse_mount_dev_present() at 0x80cc7f76 =
> parse_mount_dev_present+0x116/frame 0xfe0fba5d4c90
> parse_mount() at 0x80cc7c49 = parse_mount+0x5c9/frame
> 0xfe0fba5d4d00
> vfs_mountroot() at 0x80cc60c3 = vfs_mountroot+0x7c3/frame
> 0xfe0fba5d4e60
> start_init() at 0x80b60093 = start_init+0x23/frame
> 0xfe0fba5d4ef0
> fork_exit() at 0x80b8f770 = fork_exit+0x80/frame 0xfe0fba5d4f30
> fork_trampoline() at 0x810c264e = fork_trampoline+0xe/frame
> 0xfe0fba5d4f30
> --- trap 0, rip = 0, rsp = 0, rbp = 0 ---
> KDB: enter: panic
> [ thread pid 1 tid 12 ]
> Stopped at0x80c26ac2 = kdb_enter+0x32:movq
> $0,0x12ab643(%rip)
> db>
>
>
>
> For all I know, the machine may be a little flaky -- it is the
> oldest of the 3.  But I thought it might be worth mentioning.
>
> Peace,
> david
> --
> David H. Wolfskill  da...@catwhisker.org
> "In my administration, I'm going to enforce all laws concerning the
> protection of classified information. No one will be above the law."
>  -- D. Trump, August, 2016
>
> See https://www.catwhisker.org/~david/publickey.gpg for my public key.
>


-- 
Mateusz Guzik 



panic after update from main-n258027-c9baa974717a to main-n258075-5b5b7e2ca2fa

2022-09-17 Thread David Wolfskill
Not reproducible on reboot; only happened on one machine (main laptop)
out of 3 that I updated this morning.  No dump. :-/

A screenshot, a copy of the full dmesg.boot from the
immediately-following successful (verbose) boot, and a copy of the
uname output:

FreeBSD 14.0-CURRENT #589 main-n258075-5b5b7e2ca2fa: Sat Sep 17 12:22:57 UTC 
2022 
r...@g1-70.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/CANARY amd64 
1400068 1400068

may be found at https://www.catwhisker.org/~david/FreeBSD/head/n258075/

The screenshot includes a backtrace; a hand-transcription:

Trying to mount root from ufs:/dev/ada0s4a [rw]...
panic: Assertion _ndp->ni_cnd.cn_pnbuf != NULL failed at 
/usr/src/sys/kern/vfs_mountroot.c:731
cpuid = 1
time = 2
KDB: stack backtrace:
db_trace_self_wrapper() at 0x804b9dfb = 
db_trace_self_wrapper+0x2b/frame 0xfe0fba5d4af0
vpanic() at 0x80bd90f1 = vpanic+0x151/frame 0xfe0fba5d4b40
panic() at 0x80bd8ec3 = panic+0x43/frame 0xfe0fba5d4ba0
parse_mount_dev_present() at 0x80cc7f76 = 
parse_mount_dev_present+0x116/frame 0xfe0fba5d4c90
parse_mount() at 0x80cc7c49 = parse_mount+0x5c9/frame 0xfe0fba5d4d00
vfs_mountroot() at 0x80cc60c3 = vfs_mountroot+0x7c3/frame 
0xfe0fba5d4e60
start_init() at 0x80b60093 = start_init+0x23/frame 0xfe0fba5d4ef0
fork_exit() at 0x80b8f770 = fork_exit+0x80/frame 0xfe0fba5d4f30
fork_trampoline() at 0x810c264e = fork_trampoline+0xe/frame 
0xfe0fba5d4f30
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---
KDB: enter: panic
[ thread pid 1 tid 12 ]
Stopped at  0x80c26ac2 = kdb_enter+0x32:movq
$0,0x12ab643(%rip)
db> 



For all I know, the machine may be a little flaky -- it is the
oldest of the 3.  But I thought it might be worth mentioning.

Peace,
david
-- 
David H. Wolfskill  da...@catwhisker.org
"In my administration, I'm going to enforce all laws concerning the
protection of classified information. No one will be above the law."
 -- D. Trump, August, 2016

See https://www.catwhisker.org/~david/publickey.gpg for my public key.


signature.asc
Description: PGP signature


Re: build of vfs_lookup.c now broken in non-INVARIANTS kernels

2022-09-17 Thread Gary Jennejohn
On Sat, 17 Sep 2022 12:46:36 +0200
Mateusz Guzik  wrote:

> fixed in 
> https://cgit.freebsd.org/src/commit/?id=b77bdfdb67c2e9660658a0373662e4263a905e90
>
> On 9/17/22, Gary Jennejohn  wrote:
> > Compiling vfs_lookup.c now fails when NONINVARIANTS is not included in
> > the kernel config file because NDVALIDATE is defined as NDVALIDATE_impl,
> > which itself is only defined when NONINVARIANTS is also defined.
> >
> > This breaks buildkernel.
> >

Thanks!

--
Gary Jennejohn



Re: build of vfs_lookup.c now broken in non-INVARIANTS kernels

2022-09-17 Thread Gary Jennejohn
On Sat, 17 Sep 2022 12:41:25 +0200
Gary Jennejohn  wrote:

> Compiling vfs_lookup.c now fails when NONINVARIANTS is not included in
> the kernel config file because NDVALIDATE is defined as NDVALIDATE_impl,
> which itself is only defined when NONINVARIANTS is also defined.
>
> This breaks buildkernel.
>

Woops. NONINVARIANTS should be INVARIANTS.

--
Gary Jennejohn



Re: build of vfs_lookup.c now broken in non-INVARIANTS kernels

2022-09-17 Thread Mateusz Guzik
fixed in 
https://cgit.freebsd.org/src/commit/?id=b77bdfdb67c2e9660658a0373662e4263a905e90

On 9/17/22, Gary Jennejohn  wrote:
> Compiling vfs_lookup.c now fails when NONINVARIANTS is not included in
> the kernel config file because NDVALIDATE is defined as NDVALIDATE_impl,
> which itself is only defined when NONINVARIANTS is also defined.
>
> This breaks buildkernel.
>
> --
> Gary Jennejohn
>
>


-- 
Mateusz Guzik 



build of vfs_lookup.c now broken in non-INVARIANTS kernels

2022-09-17 Thread Gary Jennejohn
Compiling vfs_lookup.c now fails when NONINVARIANTS is not included in
the kernel config file because NDVALIDATE is defined as NDVALIDATE_impl,
which itself is only defined when NONINVARIANTS is also defined.

This breaks buildkernel.

--
Gary Jennejohn