Re: MOTD is not created correctly (since 2022/02/18)
On 2023-05-22 8:18 PM, Jamie Landeg-Jones wrote: I've just finally updated to 13-stable, and can't be the first to notice this?! /etc/rc.d/motd contains the line: uname -v | sed -e 's,^\([^#]*\) #\(.* [1-2][0-9][0-9][0-9]\).*/\([^\]*\) $,\1 (\3) #\2,' Note the space before the "$" - needed because the uname -v output used to have a trailing space. This was fixed and comitted on 2022/02/18: https://cgit.freebsd.org/src/commit/usr.bin/uname/uname.c?id=7e05fa3b449007adaa6e588ebb3b8d76f30b355c Since then, the sed doesn't match, so the uname(1) output is unchanged. There's no point altering the sed to work with both posibilities, so can someone commit the fix of removing the ' ' before the '$' in /etc/rc.d/motd ? Maybe https://reviews.freebsd.org/D40225 ? (Nice find by the way! I always feel that something was not right but haven't looked close enough.) Cheers, OpenPGP_signature Description: OpenPGP digital signature
MOTD is not created correctly (since 2022/02/18)
I've just finally updated to 13-stable, and can't be the first to notice this?! /etc/rc.d/motd contains the line: uname -v | sed -e 's,^\([^#]*\) #\(.* [1-2][0-9][0-9][0-9]\).*/\([^\]*\) $,\1 (\3) #\2,' Note the space before the "$" - needed because the uname -v output used to have a trailing space. This was fixed and comitted on 2022/02/18: https://cgit.freebsd.org/src/commit/usr.bin/uname/uname.c?id=7e05fa3b449007adaa6e588ebb3b8d76f30b355c Since then, the sed doesn't match, so the uname(1) output is unchanged. There's no point altering the sed to work with both posibilities, so can someone commit the fix of removing the ' ' before the '$' in /etc/rc.d/motd ? Cheers Jamie
Re: builworld fails due to error in af_inet.c
On Mon, 22 May 2023 16:03:37 +0100 Alexander Chernikov wrote: > Sorry for the breakage (and thanks for markj@ for the prompt fix) > No big deal. It was easy to find the cause and temporarily fix it. > > On 22 May 2023, at 16:00, Gary Jennejohn wrote: > > > > I just ran buildworld using the latest current source. > > > > It dies due to this error in line 385 of /usr/src/sbin/ifconfig/af_inet.c: > > > > static void > > warn_nomask(ifflags) > > > > The compiler really doesn't like not seeing a type for ifflags and bails > > out as the result. > > > > Strangely enough, in_proc() a few lines later clearly has int ifflags in > > its list of variables. > > > > Setting ifflags to int in warn_nomask() fixes the build. > > > > Wasn't this compile tested before it was committed? > It was & it didn't yell on my setup. > That's interesting. Maybe I have some different settings. But the error message was the standard one about badly formed prototypes. -- Gary Jennejohn
Re: builworld fails due to error in af_inet.c
Sorry for the breakage (and thanks for markj@ for the prompt fix) > On 22 May 2023, at 16:00, Gary Jennejohn wrote: > > I just ran buildworld using the latest current source. > > It dies due to this error in line 385 of /usr/src/sbin/ifconfig/af_inet.c: > > static void > warn_nomask(ifflags) > > The compiler really doesn't like not seeing a type for ifflags and bails > out as the result. > > Strangely enough, in_proc() a few lines later clearly has int ifflags in > its list of variables. > > Setting ifflags to int in warn_nomask() fixes the build. > > Wasn't this compile tested before it was committed? It was & it didn’t yell on my setup. > > -- > Gary Jennejohn >
Re: builworld fails due to error in af_inet.c
On Mon, 22 May 2023 15:00:00 + Gary Jennejohn wrote: > I just ran buildworld using the latest current source. > > It dies due to this error in line 385 of /usr/src/sbin/ifconfig/af_inet.c: > > static void > warn_nomask(ifflags) > > The compiler really doesn't like not seeing a type for ifflags and bails > out as the result. > > Strangely enough, in_proc() a few lines later clearly has int ifflags in > its list of variables. > > Setting ifflags to int in warn_nomask() fixes the build. > > Wasn't this compile tested before it was committed? > Woops! It turns out that my source was NOT fully up to date. I just saw that af_inet.c was fixed. Sorry for the noise. -- Gary Jennejohn
builworld fails due to error in af_inet.c
I just ran buildworld using the latest current source. It dies due to this error in line 385 of /usr/src/sbin/ifconfig/af_inet.c: static void warn_nomask(ifflags) The compiler really doesn't like not seeing a type for ifflags and bails out as the result. Strangely enough, in_proc() a few lines later clearly has int ifflags in its list of variables. Setting ifflags to int in warn_nomask() fixes the build. Wasn't this compile tested before it was committed? -- Gary Jennejohn
