Re: MOTD is not created correctly (since 2022/02/18)

2023-05-24 Thread Jamie Landeg-Jones
Garance A Drosehn  wrote:

> Not that it helps you much, but I did notice it and have an alternate
> version of rc.d/motd on my own systems.  I had no particular attachment
> to the earlier format, so my motd starts out by printing the two lines
> of:
> ```
>  -KU 1302505 1302505 -b 18fa15f83c483db67b818e3a48bbb312908754b1
> FreeBSD 13.2-STABLE (Garance-13x) #0 -- Fri May  5 17:53:55 EDT 2023

I too was actually not all that fussed with the old style, but the
multiple spaces in the output bugged me, so I was going to change it
back, when I stumbled on the issue.

I actually have closer to yours in my ssh-banner:

**  **
 FreeBSD/amd64 13.2-STABLE - Build 1302505 (May 13, 2023)
   23:25 BST  up 1 01:30   0.16,  0.18,  0.16
  -- SOD OFF IF YOU AREN'T AUTHORISED


> But I thought that committing that would trigger a bikeshed debate, so I
> also have an option to produce the output we previously had.  And given
> that no one seemed to be complaining about the "full uname" version, I
> figured I had an option for that too.  And then I thought all these 
> options
> were overkill and would trigger and even longer debate, so I never 
> brought
> the ideas forward.   :)

:-)

Oh yeah, definitely! It would be worse than the fractional seconds in
sleep(1) debate!

Cheers, for the response,
Jamie



Re: Build failure in usr.sbin/bhyvectl; sources at main-n263112-ad513b4dba3e

2023-05-24 Thread Mark Johnston
On Wed, May 24, 2023 at 01:39:26PM +0200, Dimitry Andric wrote:
> On 24 May 2023, at 13:25, David Wolfskill  wrote:
> > 
> > This is from an in-place source update from main-n263073-634a770a5e16 to
> > main-n263112-ad513b4dba3e:
> > 
> > ...
> > Building /common/S4/obj/usr/src/amd64.amd64/lib/libc/tests/stdio/scanf_test
> > Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/ncurses/dump_entry.o
> > Building 
> > /common/S4/obj/usr/src/amd64.amd64/usr.bin/mkimg/tests/img-1x1-4096-mbr.vhdx
> > Building /common/S4/obj/usr/src/amd64.amd64/cddl/usr.sbin/zfsd/zfsd.full
> > /usr/src/usr.sbin/bhyvectl/bhyvectl.c:2389:24: error: incompatible pointer 
> > types passing 'struct vm_exit *' to parameter of type 'struct vm_run *' 
> > [-Werror,-Wincompatible-pointer-types]
> >error = vm_run(vcpu, &vmexit);
> > ^~~
> > /common/S4/obj/usr/src/amd64.amd64/tmp/usr/include/vmmapi.h:158:46: note: 
> > passing argument to parameter 'vmrun' here
> > int vm_run(struct vcpu *vcpu, struct vm_run *vmrun);
> > ^
> > 1 error generated.
> > 
> > 
> > Given that yesterday's update was uneventful, and that
> > src/usr.sbin/bhyvectl/bhyvectl.c has not changed in several days,
> > I'm guessing that perhaps a recent change to a header, possibly
> > involving vmexit, may be at issue here.
> 
> It appears to be broken since "vmm: Avoid embedding cpuset_t ioctl ABIs":
> https://cgit.freebsd.org/src/commit/?id=e17eca327633efc511450310afb5e4a662724e3d
> 
> See also https://ci.freebsd.org/job/FreeBSD-main-amd64-build/, where it shows 
> an error since https://ci.freebsd.org/job/FreeBSD-main-amd64-build/26653/

This should be fixed now.  My apologies, I had no idea bhyvectl provided
a way to run a VM...



Re: Build failure in usr.sbin/bhyvectl; sources at main-n263112-ad513b4dba3e

2023-05-24 Thread Dimitry Andric
On 24 May 2023, at 13:25, David Wolfskill  wrote:
> 
> This is from an in-place source update from main-n263073-634a770a5e16 to
> main-n263112-ad513b4dba3e:
> 
> ...
> Building /common/S4/obj/usr/src/amd64.amd64/lib/libc/tests/stdio/scanf_test
> Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/ncurses/dump_entry.o
> Building 
> /common/S4/obj/usr/src/amd64.amd64/usr.bin/mkimg/tests/img-1x1-4096-mbr.vhdx
> Building /common/S4/obj/usr/src/amd64.amd64/cddl/usr.sbin/zfsd/zfsd.full
> /usr/src/usr.sbin/bhyvectl/bhyvectl.c:2389:24: error: incompatible pointer 
> types passing 'struct vm_exit *' to parameter of type 'struct vm_run *' 
> [-Werror,-Wincompatible-pointer-types]
>error = vm_run(vcpu, &vmexit);
> ^~~
> /common/S4/obj/usr/src/amd64.amd64/tmp/usr/include/vmmapi.h:158:46: note: 
> passing argument to parameter 'vmrun' here
> int vm_run(struct vcpu *vcpu, struct vm_run *vmrun);
> ^
> 1 error generated.
> 
> 
> Given that yesterday's update was uneventful, and that
> src/usr.sbin/bhyvectl/bhyvectl.c has not changed in several days,
> I'm guessing that perhaps a recent change to a header, possibly
> involving vmexit, may be at issue here.

It appears to be broken since "vmm: Avoid embedding cpuset_t ioctl ABIs":
https://cgit.freebsd.org/src/commit/?id=e17eca327633efc511450310afb5e4a662724e3d

See also https://ci.freebsd.org/job/FreeBSD-main-amd64-build/, where it shows 
an error since https://ci.freebsd.org/job/FreeBSD-main-amd64-build/26653/

-Dimitry



signature.asc
Description: Message signed with OpenPGP


Re: Build failure in usr.sbin/bhyvectl; sources at main-n263112-ad513b4dba3e

2023-05-24 Thread Yuri
David Wolfskill wrote:
> This is from an in-place source update from main-n263073-634a770a5e16 to
> main-n263112-ad513b4dba3e:
> 
> ...
> Building /common/S4/obj/usr/src/amd64.amd64/lib/libc/tests/stdio/scanf_test
> Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/ncurses/dump_entry.o
> Building 
> /common/S4/obj/usr/src/amd64.amd64/usr.bin/mkimg/tests/img-1x1-4096-mbr.vhdx
> Building /common/S4/obj/usr/src/amd64.amd64/cddl/usr.sbin/zfsd/zfsd.full
> /usr/src/usr.sbin/bhyvectl/bhyvectl.c:2389:24: error: incompatible pointer 
> types passing 'struct vm_exit *' to parameter of type 'struct vm_run *' 
> [-Werror,-Wincompatible-pointer-types]
> error = vm_run(vcpu, &vmexit);
>  ^~~
> /common/S4/obj/usr/src/amd64.amd64/tmp/usr/include/vmmapi.h:158:46: note: 
> passing argument to parameter 'vmrun' here
> int vm_run(struct vcpu *vcpu, struct vm_run *vmrun);
>  ^
> 1 error generated.
> 
> 
> Given that yesterday's update was uneventful, and that
> src/usr.sbin/bhyvectl/bhyvectl.c has not changed in several days,
> I'm guessing that perhaps a recent change to a header, possibly
> involving vmexit, may be at issue here.

https://lists.freebsd.org/archives/dev-commits-src-all/2023-May/026954.html



Build failure in usr.sbin/bhyvectl; sources at main-n263112-ad513b4dba3e

2023-05-24 Thread David Wolfskill
This is from an in-place source update from main-n263073-634a770a5e16 to
main-n263112-ad513b4dba3e:

...
Building /common/S4/obj/usr/src/amd64.amd64/lib/libc/tests/stdio/scanf_test
Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/ncurses/dump_entry.o
Building 
/common/S4/obj/usr/src/amd64.amd64/usr.bin/mkimg/tests/img-1x1-4096-mbr.vhdx
Building /common/S4/obj/usr/src/amd64.amd64/cddl/usr.sbin/zfsd/zfsd.full
/usr/src/usr.sbin/bhyvectl/bhyvectl.c:2389:24: error: incompatible pointer 
types passing 'struct vm_exit *' to parameter of type 'struct vm_run *' 
[-Werror,-Wincompatible-pointer-types]
error = vm_run(vcpu, &vmexit);
 ^~~
/common/S4/obj/usr/src/amd64.amd64/tmp/usr/include/vmmapi.h:158:46: note: 
passing argument to parameter 'vmrun' here
int vm_run(struct vcpu *vcpu, struct vm_run *vmrun);
 ^
1 error generated.


Given that yesterday's update was uneventful, and that
src/usr.sbin/bhyvectl/bhyvectl.c has not changed in several days,
I'm guessing that perhaps a recent change to a header, possibly
involving vmexit, may be at issue here.

Peace,
david
-- 
David H. Wolfskill  da...@catwhisker.org
Folks who wish to control what others do with their bodies are often
called "conservative," when they are actually "authoritarian."

See https://www.catwhisker.org/~david/publickey.gpg for my public key.


signature.asc
Description: PGP signature