Re: Heads-up: ifconfig address without a mask/width to become an error
On Mon, 17 Jun 2024 at 11:16, Michael Gmelin wrote: > > Hi Ed, > > In case there is no EN, what is the process to add information about > issues like this to the release notes? Something like "known issues", > which those of us who read the release notes can stumble over and check? Great question - we don't have a consistent process for an announcement like this that does not come with a patch. It would make sense to me to issue an Erratum Notice without a patch, although I don't believe we've done that before. At a minimum we could update the release notes for 14.0 and 14.1 on the website to make note of this.
Re: Heads-up: ifconfig address without a mask/width to become an error
> On 17. Jun 2024, at 20:34, Shawn Webb wrote: > > On Mon, Jun 17, 2024 at 10:54:29AM -0400, Ed Maste wrote: >> It is currently possible to specify an IPv4 address without a >> netmask/width to ifconfig or in rc.conf, e.g.: >> >>ifconfig_igb0="192.168.0.2" >> >> phk recently discovered[1] that ifconfig chose a poor netmask/width >> when none was specified. This was not an intentional change in >> defaults but rather a bug that has now been fixed by grembo@, in >> commit 8a9f0fa42b1c and merged to stable/14 in 048ad7a9ef9f. The fix >> will be in FreeBSD 14.2. I am unsure if there will be an EN update for >> 14.0/14.1. The bug does not exist in FreeBSD 13.x. >> >> Specifying an IPv4 address without a mask/width has been deprecated >> since the deprecation of classful addressing. As of FreeBSD 13.1 >> ifconfig has emitted a warning when no mask/width is specified, and >> the intent was to make it an error after a sufficient amount of time >> passed. >> >> I've opened a Phabricator review[2] for ifconfig to change the warning >> into an error. I included a link to the review in phk's thread, and >> asked for input on timing for landing the change. As there seems to be >> consensus to include this change in FreeBSD 15.0 I plan to commit it >> soon and am sending this note to increase the visibility of the >> upcoming change. >> >> This will be prominently noted in the 15.0 release notes, and should >> be mentioned in release notes for upcoming 13.x and 14.x releases. > > Hey Ed, > > I hope I don't sound pathetically verbose here, but I just wanted to > make sure to remove any sense of ambiguity. > > Would the "netmask " option still work? For example: > > # ifconfig em0 inet 192.168.0.1 netmask 255.255.255.0 > > I suspect the answer is "yes". > Yes, this affects only configs without any netmask. So 192.168.0.1/24 => ok 192.168.0.1 netmask 255.255.255.0 => ok 192.168.0.1 => deprecated now, error then Best > Thanks, > > -- > Shawn Webb > Cofounder / Security Engineer > HardenedBSD > > Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 > https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc
Re: Heads-up: ifconfig address without a mask/width to become an error
On Mon, Jun 17, 2024 at 10:54:29AM -0400, Ed Maste wrote: > It is currently possible to specify an IPv4 address without a > netmask/width to ifconfig or in rc.conf, e.g.: > > ifconfig_igb0="192.168.0.2" > > phk recently discovered[1] that ifconfig chose a poor netmask/width > when none was specified. This was not an intentional change in > defaults but rather a bug that has now been fixed by grembo@, in > commit 8a9f0fa42b1c and merged to stable/14 in 048ad7a9ef9f. The fix > will be in FreeBSD 14.2. I am unsure if there will be an EN update for > 14.0/14.1. The bug does not exist in FreeBSD 13.x. > > Specifying an IPv4 address without a mask/width has been deprecated > since the deprecation of classful addressing. As of FreeBSD 13.1 > ifconfig has emitted a warning when no mask/width is specified, and > the intent was to make it an error after a sufficient amount of time > passed. > > I've opened a Phabricator review[2] for ifconfig to change the warning > into an error. I included a link to the review in phk's thread, and > asked for input on timing for landing the change. As there seems to be > consensus to include this change in FreeBSD 15.0 I plan to commit it > soon and am sending this note to increase the visibility of the > upcoming change. > > This will be prominently noted in the 15.0 release notes, and should > be mentioned in release notes for upcoming 13.x and 14.x releases. Hey Ed, I hope I don't sound pathetically verbose here, but I just wanted to make sure to remove any sense of ambiguity. Would the "netmask " option still work? For example: # ifconfig em0 inet 192.168.0.1 netmask 255.255.255.0 I suspect the answer is "yes". Thanks, -- Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc signature.asc Description: PGP signature
Re: Heads-up: ifconfig address without a mask/width to become an error
On Mon, 17 Jun 2024 10:54:29 -0400 Ed Maste wrote: > It is currently possible to specify an IPv4 address without a > netmask/width to ifconfig or in rc.conf, e.g.: > > ifconfig_igb0="192.168.0.2" > > phk recently discovered[1] that ifconfig chose a poor netmask/width > when none was specified. This was not an intentional change in > defaults but rather a bug that has now been fixed by grembo@, in > commit 8a9f0fa42b1c and merged to stable/14 in 048ad7a9ef9f. The fix > will be in FreeBSD 14.2. I am unsure if there will be an EN update for > 14.0/14.1. The bug does not exist in FreeBSD 13.x. > > Specifying an IPv4 address without a mask/width has been deprecated > since the deprecation of classful addressing. As of FreeBSD 13.1 > ifconfig has emitted a warning when no mask/width is specified, and > the intent was to make it an error after a sufficient amount of time > passed. > > I've opened a Phabricator review[2] for ifconfig to change the warning > into an error. I included a link to the review in phk's thread, and > asked for input on timing for landing the change. As there seems to be > consensus to include this change in FreeBSD 15.0 I plan to commit it > soon and am sending this note to increase the visibility of the > upcoming change. > > This will be prominently noted in the 15.0 release notes, and should > be mentioned in release notes for upcoming 13.x and 14.x releases. > > [1] > https://lists.freebsd.org/archives/freebsd-current/2024-June/006047.html > [2] https://reviews.freebsd.org/D45585 > Hi Ed, In case there is no EN, what is the process to add information about issues like this to the release notes? Something like "known issues", which those of us who read the release notes can stumble over and check? This would be useful in general, as it seems like doing ENs is a lot of overhead. Also, if that process would be fast, users would be warned early - especially in a case like this, where the workaround/long term fix is actually fairly trivial (add a netmask to your ifconfig_xxx line). Best Michael -- Michael Gmelin
Heads-up: ifconfig address without a mask/width to become an error
It is currently possible to specify an IPv4 address without a netmask/width to ifconfig or in rc.conf, e.g.: ifconfig_igb0="192.168.0.2" phk recently discovered[1] that ifconfig chose a poor netmask/width when none was specified. This was not an intentional change in defaults but rather a bug that has now been fixed by grembo@, in commit 8a9f0fa42b1c and merged to stable/14 in 048ad7a9ef9f. The fix will be in FreeBSD 14.2. I am unsure if there will be an EN update for 14.0/14.1. The bug does not exist in FreeBSD 13.x. Specifying an IPv4 address without a mask/width has been deprecated since the deprecation of classful addressing. As of FreeBSD 13.1 ifconfig has emitted a warning when no mask/width is specified, and the intent was to make it an error after a sufficient amount of time passed. I've opened a Phabricator review[2] for ifconfig to change the warning into an error. I included a link to the review in phk's thread, and asked for input on timing for landing the change. As there seems to be consensus to include this change in FreeBSD 15.0 I plan to commit it soon and am sending this note to increase the visibility of the upcoming change. This will be prominently noted in the 15.0 release notes, and should be mentioned in release notes for upcoming 13.x and 14.x releases. [1] https://lists.freebsd.org/archives/freebsd-current/2024-June/006047.html [2] https://reviews.freebsd.org/D45585
