Re: [PATCH] unbreak imake build when clang set as base compiler

2012-09-26 Thread Oliver Pinter
On 9/26/12, Garrett Cooper yaneg...@gmail.com wrote:
 On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter oliver.p...@gmail.com
 wrote:
 Hi all!

 This patch fixed the problem, when buildig imake on a machine where
 clang is the base the compiler (WITH_CLANG_IS_CC).

 (Picking a random message to reply to) Why not create PRs and CC the
 relevant parties?

because I hope, there become this issue a mote attention ;)

of course, I create in near future a PR, but before that, I send an
updated patch, and yes, I know, that this is not a clean solution, but
better than nothing.


___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: [PATCH] unbreak imake build when clang set as base compiler

2012-09-26 Thread Garrett Cooper
On Wed, Sep 26, 2012 at 2:18 PM, Oliver Pinter oliver.p...@gmail.com wrote:
 On 9/26/12, Garrett Cooper yaneg...@gmail.com wrote:
 On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter oliver.p...@gmail.com
 wrote:
 Hi all!

 This patch fixed the problem, when buildig imake on a machine where
 clang is the base the compiler (WITH_CLANG_IS_CC).

 (Picking a random message to reply to) Why not create PRs and CC the
 relevant parties?

 because I hope, there become this issue a mote attention ;)

Or gets lost in someone's mailbox :(...

 of course, I create in near future a PR, but before that, I send an
 updated patch, and yes, I know, that this is not a clean solution, but
 better than nothing.

Having a PR is better than a random email that will most likely get
lost. I would definitely respond to:

Hey $dev! I filed $PR -- can you please take a look at it? It solves
'$reason'. Thanks!

You might get better results this way too and less duplicated effort
by multiple individuals.. just sayin'...

Thanks!
-Garrett
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: [PATCH] unbreak imake build when clang set as base compiler

2012-09-26 Thread Oliver Pinter
On 9/26/12, Garrett Cooper yaneg...@gmail.com wrote:
 On Wed, Sep 26, 2012 at 2:18 PM, Oliver Pinter oliver.p...@gmail.com
 wrote:
 On 9/26/12, Garrett Cooper yaneg...@gmail.com wrote:
 On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter oliver.p...@gmail.com
 wrote:
 Hi all!

 This patch fixed the problem, when buildig imake on a machine where
 clang is the base the compiler (WITH_CLANG_IS_CC).

 (Picking a random message to reply to) Why not create PRs and CC the
 relevant parties?

 because I hope, there become this issue a mote attention ;)

 Or gets lost in someone's mailbox :(...

 of course, I create in near future a PR, but before that, I send an
 updated patch, and yes, I know, that this is not a clean solution, but
 better than nothing.

 Having a PR is better than a random email that will most likely get
 lost. I would definitely respond to:

 Hey $dev! I filed $PR -- can you please take a look at it? It solves
 '$reason'. Thanks!

ports/172103 ports/172104 ports/172102 ports/172101 ports/172100 ;)


 You might get better results this way too and less duplicated effort
 by multiple individuals.. just sayin'...

 Thanks!
 -Garrett

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: [PATCH] unbreak imake build when clang set as base compiler

2012-09-26 Thread Oliver Pinter
On 9/27/12, Oliver Pinter oliver.p...@gmail.com wrote:
 On 9/26/12, Garrett Cooper yaneg...@gmail.com wrote:
 On Wed, Sep 26, 2012 at 2:18 PM, Oliver Pinter oliver.p...@gmail.com
 wrote:
 On 9/26/12, Garrett Cooper yaneg...@gmail.com wrote:
 On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter oliver.p...@gmail.com
 wrote:
 Hi all!

 This patch fixed the problem, when buildig imake on a machine where
 clang is the base the compiler (WITH_CLANG_IS_CC).

 (Picking a random message to reply to) Why not create PRs and CC the
 relevant parties?

 because I hope, there become this issue a mote attention ;)

 Or gets lost in someone's mailbox :(...

 of course, I create in near future a PR, but before that, I send an
 updated patch, and yes, I know, that this is not a clean solution, but
 better than nothing.

 Having a PR is better than a random email that will most likely get
 lost. I would definitely respond to:

 Hey $dev! I filed $PR -- can you please take a look at it? It solves
 '$reason'. Thanks!

 ports/172103 ports/172104 ports/172102 ports/172101 ports/172100 ;)

and the patches are here too:
http://oliverp.teteny.bme.hu/freebsd/patches/ports-clang/



 You might get better results this way too and less duplicated effort
 by multiple individuals.. just sayin'...

 Thanks!
 -Garrett


___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


[PATCH] unbreak imake build when clang set as base compiler

2012-09-25 Thread Oliver Pinter
Hi all!

This patch fixed the problem, when buildig imake on a machine where
clang is the base the compiler (WITH_CLANG_IS_CC).


unbreak_imake_build_when_clang_set_as_CC.diff
Description: Binary data
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: [PATCH] unbreak imake build when clang set as base compiler

2012-09-25 Thread Garrett Cooper
On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter oliver.p...@gmail.com wrote:
 Hi all!

 This patch fixed the problem, when buildig imake on a machine where
 clang is the base the compiler (WITH_CLANG_IS_CC).

(Picking a random message to reply to) Why not create PRs and CC the
relevant parties?
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: [PATCH] unbreak imake build when clang set as base compiler

2012-09-25 Thread Eitan Adler
On 25 September 2012 18:45, Garrett Cooper yaneg...@gmail.com wrote:
 On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter oliver.p...@gmail.com wrote:
 Hi all!

 This patch fixed the problem, when buildig imake on a machine where
 clang is the base the compiler (WITH_CLANG_IS_CC).

 (Picking a random message to reply to) Why not create PRs and CC the
 relevant parties?

Yes, please do this. It helps us keep track of what's going on and not
lose patches. :)


-- 
Eitan Adler
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org