Re: BSD grep performance
Em 2010.08.19. 8:41, Doug Barton escreveu: The performance is now almost comparable to GNU grep. I think you're using a very liberal definition of "comparable." Ok, comparable for the casual cases but not generally comparable. I think with this, BSD grep may remain default if no other serious issues come up. I'm not going to re-state my opinion here except to say it hasn't changed. Even if the performance were not an issue I think the bugs mentioned below combined with your 4-day absence should also have been considerations. However, in regards to this particular case I think it's pretty obvious that I'm either alone, or in a very non-vocal group; so c'est la vie. I think the 4-day absence was not such a big deal given that we are talking about -current, I just wanted to let you know that I would not be responsive because of absence not ignorance. Other people also felt in the same way; it's fine to allow a short unstable period in -current to get things arranged. However, from the standpoint of committer relations I think that first stating that you would change the default, then not doing so before all of the outstanding issues were resolved is not what I would consider a good model for others to follow. I've just changed it back. No, I didn't lie to you, I just wanted to reevaluate if the remaining difference in ther performance was acceptable. We improved it a lot since you let us know about this problem and there is possibility that further improvements are to happen soon. I thank you that you helped the process with valuable feedback but I think it could have been done in a less noisy way and arrogant way. You called the attention to the performance problem, which is fine and necessary but I'd have reacted in the same way if you hadn't CC'd core@ in the very first mail and hadn't included the "Official request" words in the subject. But I know that there are people, who feel them so important that they have to always call the attention in the noisy way (ego in the Buddhist meaning) and I also have some personal problems that I feel bothered by such type of behaviour. This is a sign for me that I have to practice more acceptance and patience in the life. Gabor ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: BSD grep performance
Doug Barton writes: > I'm not going to re-state my opinion here except to say it hasn't > changed. Even if the performance were not an issue I think the bugs > mentioned below combined with your 4-day absence should also have been > considerations. However, in regards to this particular case I think > it's pretty obvious that I'm either alone, or in a very non-vocal > group; so c'est la vie. "This is madness!" "Madness? This... is... CURRENT!" DES -- Dag-Erling Smørgrav - d...@des.no ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: BSD grep performance
Out of interest I tried the first test here add ack into the mix we I've grown to like as a developer as it uses some nice sensible defaults for every day use avoiding svn etc. Its a pure perl app so wasn't expecting it to be particularly quick in the single file case, its much quicker in the multi file case, but it seems to do quite well. ./grep-time-trial.sh GNU grep 2.5.4 Elapsed time: 2 seconds GNU grep 2.5.1-FreeBSD (base on 8.1-RELEASE) Elapsed time: 2 seconds BSD grep ( from ports 2.5.1 ) Elapsed time: 48 seconds ack 1.92 ( perl 5.8.9 ) Elapsed time: 4 seconds Regards Steve This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmas...@multiplay.co.uk. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
BSD grep performance
On 08/18/2010 10:48, Gabor Kovesdan wrote: I've just committed a patch with the kind help of Dimitry Andric, which gives BSD grep a huge performance boost. Agreed, as I reported earlier. The performance is now almost comparable to GNU grep. I think you're using a very liberal definition of "comparable." http://people.freebsd.org/~dougb/grep-time-trial.sh.txt http://people.freebsd.org/~dougb/grep-time-trial-2.sh.txt ./grep-time-trial GNU grep Elapsed time: 2 seconds BSD grep Elapsed time: 15 seconds ./grep-time-trial-2 GNU grep Elapsed time: 3 seconds BSD grep Elapsed time: 11 seconds I think with this, BSD grep may remain default if no other serious issues come up. I'm not going to re-state my opinion here except to say it hasn't changed. Even if the performance were not an issue I think the bugs mentioned below combined with your 4-day absence should also have been considerations. However, in regards to this particular case I think it's pretty obvious that I'm either alone, or in a very non-vocal group; so c'est la vie. However, from the standpoint of committer relations I think that first stating that you would change the default, then not doing so before all of the outstanding issues were resolved is not what I would consider a good model for others to follow. FWIW, Doug Please report if you notice something weird. I know about some minor issues, which aren't fixed yet. I'll be out for 4 days as of tomorrow but when I come back I'll take care of these:- Infinite loop when reading directory on ZFS/NFS filesystem - Problems with context grepping ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
