Re: Files under src/ not used for building world

2010-11-08 Thread David O'Brien
On Fri, Nov 05, 2010 at 09:42:27PM -0700, Garrett Cooper wrote:
> On Fri, Nov 5, 2010 at 1:25 PM, Ulrich Sp?rlein  wrote:
> > Hey folks, not sure why, but I had a stab at looking which files were
> > actually read during building world.
[..] 
> > usr.bin/cpio/test/* ? ? # move to tools/regression?
> 
> Seems like a legitimate request.

Not necessary.  I prefer to have the tests under the thing being tested.
It makes it much easier to test the util before committing.

That said, the tests should be hooked up and referred to in
tools/regression/usr.bin/

-- 
-- David  (obr...@freebsd.org)
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Files under src/ not used for building world

2010-11-07 Thread Jilles Tjoelker
On Fri, Nov 05, 2010 at 09:42:27PM -0700, Garrett Cooper wrote:
> On Fri, Nov 5, 2010 at 1:25 PM, Ulrich Spörlein  wrote:
> > Hey folks, not sure why, but I had a stab at looking which files were
> > actually read during building world.

> > bin/sh/bltin/echo.1

> I'd talk to jilles@ (weird thing is that this is installed on my machine).

This is a man page for sh's echo builtin. It is a little more extensive
but otherwise equivalent to the description in sh(1). It is different
from bin/echo/echo.1.

Unfortunately, sh's echo builtin and /bin/echo work differently. This
should not have been allowed to happen, but now we are stuck with it.

I suppose bin/sh/bltin/echo.1 can go away.

-- 
Jilles Tjoelker
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Files under src/ not used for building world

2010-11-05 Thread Hajimu UMEMOTO
Hi,

> On Fri, 5 Nov 2010 17:16:47 -0400
> John Baldwin  said:

> etc/periodic/security/610.ipf6denied

jhb> I wonder if this is stale due to ip6fw being removed?

No, it seems to me that it is not related to ip6fw, and it calls
ipfstat.  Perhaps, some work for IPv6 support of IP Filter?

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
u...@mahoroba.org  u...@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Files under src/ not used for building world

2010-11-05 Thread Garrett Cooper
On Fri, Nov 5, 2010 at 1:25 PM, Ulrich Spörlein  wrote:
> Hey folks, not sure why, but I had a stab at looking which files were
> actually read during building world.
>
> Method went something like this:
>
> (turn on atime)
> # find . -exec touch {} +
> # sleep 2; touch timestamp
> # make buildworld buildkernel installworld installkernel (this is on amd64)
> # make universe
> # make distribution DESTDIR=/foo
> # mergemaster (I think this is redundant)
> # find . -name .svn -prune -or -not -anewer timestamp
>
> Please note that I skipped 'make release' as I don't know all the
> parameters off-hand.
>
> The list of files (tools/ removed) can be seen at
> https://www.spoerlein.net/pub/untouched_files
>
> Here are some curiosities (cddl/, gnu/, contrib/, and crypto/ skipped):
>
> bin/sh/bltin/echo.1

I'd talk to jilles@ (weird thing is that this is installed on my machine).

...

> lib/libarchive/archive_crc32.h
> lib/libarchive/libarchive_internals.3

I'd talk to kient...@.

> lib/libautofs/Makefile
> lib/libautofs/libautofs.3
> lib/libautofs/libautofs.c
> lib/libautofs/libautofs.h

Missing from lib/Makefile (hmmm...).

> lib/libc/sys/kse.2

Shouldn't kse be yanked?

...

> lib/libkse/*   # dito

Same as above.

...

> sbin/bsdlabel/bsdlabel.5 # eh?

Not sure why but this was commented out (see the Makefile).

> sbin/mount/getmntopts.3

It would be nice if this was installed too.

> sbin/mount_autofs/Makefile
> sbin/mount_autofs/mount_autofs.8
> sbin/mount_autofs/mount_autofs.c
> sbin/mount_ext2fs/Makefile
> sbin/mount_ext2fs/mount_ext2fs.8
> sbin/mount_ext2fs/mount_ext2fs.c
> sbin/mount_hpfs/Makefile
> sbin/mount_hpfs/mount_hpfs.8
> sbin/mount_hpfs/mount_hpfs.c
> sbin/mount_reiserfs/Makefile
> sbin/mount_reiserfs/mount_reiserfs.8
> sbin/mount_reiserfs/mount_reiserfs.c
> sbin/mount_std/Makefile
> sbin/mount_std/mount_std.8
> sbin/mount_std/mount_std.c

Not sure about the above items.

> usr.bin/cpio/test/*     # move to tools/regression?

Seems like a legitimate request.

...

> usr.bin/setchannel/Makefile
> usr.bin/setchannel/setchannel.1
> usr.bin/setchannel/setchannel.c

Not included in usr.bin/Makefile .

...

> usr.sbin/gpioctl        # wtf? my system has MK_GPIO=no set?

Unless you say WITH_GPIO, it defaults to WITHOUT_GPIO (according to
what I'm reading from bsd.own.mk).

...

> I haven't looked too closely (ie., not at all) at these cases. Please
> discuss and happy browsing the list!

Thanks!
-Garrett
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Files under src/ not used for building world

2010-11-05 Thread John Baldwin
On Friday, November 05, 2010 4:25:36 pm Ulrich Spörlein wrote:
> Hey folks, not sure why, but I had a stab at looking which files were
> actually read during building world.
> 
> Method went something like this:
> 
> (turn on atime)
> # find . -exec touch {} +
> # sleep 2; touch timestamp
> # make buildworld buildkernel installworld installkernel (this is on amd64)
> # make universe
> # make distribution DESTDIR=/foo
> # mergemaster (I think this is redundant)
> # find . -name .svn -prune -or -not -anewer timestamp
> 
> Please note that I skipped 'make release' as I don't know all the
> parameters off-hand.
> 
> The list of files (tools/ removed) can be seen at
> https://www.spoerlein.net/pub/untouched_files
> 
> Here are some curiosities (cddl/, gnu/, contrib/, and crypto/ skipped):
> 
> etc/periodic/security/610.ipf6denied

I wonder if this is stale due to ip6fw being removed?

> usr.bin/objformat/Makefile
> usr.bin/objformat/objformat.sh  # delete?

This can definitely go.

-- 
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Files under src/ not used for building world

2010-11-05 Thread Steve Kargl
On Fri, Nov 05, 2010 at 09:25:36PM +0100, Ulrich Sp??rlein wrote:
> lib/msun/src/s_fabs.c
> lib/msun/src/s_modf.c

These are explicitly ignored by msun/Makefile.

# FreeBSD's C library supplies these functions:
#COMMON_SRCS+=  s_fabs.c s_frexp.c s_isnan.c s_ldexp.c s_modf.c

-- 
Steve
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"