Re: HEADS UP Re: cvs commit: src/crypto/openssh/pam_ssh pam_ssh.c src/gnu/usr.bin/binutils/gdb freebsd-uthread.c src/include mpool.h src/lib/libc/net name6.c src/lib/libc_r/uthread pthread_private.h uthread_file.csrc/lib/libncp ncpl_rcfile.c src/lib/libstand if_ether.h ...

[Bruce Evans]

On Wed, 24 May 2000, Garrett Wollman wrote:

> < said:
> 
> > I've just built a fresh world here; if you use the cvs-crypto from
> > internat, it may be broken.  I submitted a patch to Mark Murray which
> > should fix it, here it is again just in case:
> 
> I still think (and am going on record) that this is a REALLY, REALLY
> BAD idea.

Especially since most of the queue macros require the type to be a struct
to work.  E.g.:

#define SLIST_REMOVE(head, elm, type, field) do {   \
 a supposedly general type
if (SLIST_FIRST((head)) == (elm)) { \
SLIST_REMOVE_HEAD((head), field);   \
}   \
else {  \
type *curelm = SLIST_FIRST((head)); \
while (SLIST_NEXT(curelm, field) != (elm))  \
   ^

I objected to a recent commit hiding the fact that this is
"(elm)->field.sle_next".  Anyway, curelm must be a pointer to a struct.
Not just any struct; the struct must contain a "field" declared using
SLIST_ENTRY().

Bruce



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Re: HEADS UP Re: cvs commit: src/crypto/openssh/pam_ssh pam_ssh.c src/gnu/usr.bin/binutils/gdb freebsd-uthread.c src/include mpool.h src/lib/libc/net name6.c src/lib/libc_r/uthread pthread_private.h uthread_file.csrc/lib/libncp ncpl_rcfile.c src/lib/libstand if_ether.h ...

[Chuck Robey]

On Tue, 23 May 2000, Jake Burkholder wrote:

> > jake2000/05/23 13:41:02 PDT
> >   Log:
> >   Change the way that the queue(3) structures are declared; don't assume that
> >   the type argument to *_HEAD and *_ENTRY is a struct.
> >   
> >   Suggested by: phk
> >   Reviewed by:  phk
> >   Approved by:  mdodd
> >   
> 
> HEADS UP
> 
> Possible action required!
> 
> Some drivers use headers from the installed system during the kernel build,
> and a make world, or at least make includes, is necessary before a new kernel
> can be built.
> 
> LINT is affected by this.

Is anyone else having trouble compiling the libpam things, because of
this?  I couldn't compile a kernel because of the the assembler changes,
so I went to do a buildworld, and now I can't get thru a buildworld.  I
tried the suggestion above (do a make includes) but that didn't seem to do
the trick.  Here's about the first 5 of the 30 (or so) errors I see:

cc -O -pipe -mpentium -Wall
-I/usr/src/lib/libpam/modules/pam_ssh/../../../../cr
ypto/openssh -c
/usr/src/lib/libpam/modules/pam_ssh/../../../../crypto/openssh/p
am_ssh/pam_ssh.c -o pam_ssh.o
/usr/src/lib/libpam/modules/pam_ssh/../../../../crypto/openssh/pam_ssh/pam_ssh.c
:89: syntax error before `env_entry'
/usr/src/lib/libpam/modules/pam_ssh/../../../../crypto/openssh/pam_ssh/pam_ssh.c
:93: syntax error before `env_entry'
/usr/src/lib/libpam/modules/pam_ssh/../../../../crypto/openssh/pam_ssh/pam_ssh.c
: In function `env_new':
/usr/src/lib/libpam/modules/pam_ssh/../../../../crypto/openssh/pam_ssh/pam_ssh.c
:116: structure has no member named `slh_first'
/

It all seems to do with the new queue.h, which is indeed installed in my
/usr/include/sys (newly installed, I checked, after the make includes).



Chuck Robey| Interests include C & Java programming, FreeBSD,
[EMAIL PROTECTED]  | electronics, communications, and signal processing.

New Year's Resolution:  I will not sphroxify gullible people into looking up
fictitious words in the dictionary.




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message