Re: cdcontrol no longer needs 'c' partition?
On Fri, 22 Aug 2003, 19:49+0400, Maxim Konovalov wrote: > On Fri, 22 Aug 2003, 10:39-0400, Craig Rodrigues wrote: > > > On Fri, Aug 22, 2003 at 09:00:32AM +0400, Maxim Konovalov wrote: > > > On Sun, 17 Aug 2003, 17:21-0400, Craig Rodrigues wrote: > > > > > > > Hi, > > > > > > > > With GEOM in place, is the 'c' partition for a CD device no > > > > longer necessary for cdcontrol? At least on my system, > > > > the CD shows up as /dev/acd0, not as /dev/acd0c. > > > > > > What's about CDROM environment var defined in login.conf? > > > > I don't understand your question. > > If the CDROM environment variable is set to a device name, cdcontrol will > > try to open that device. This is documented in the cdcontrol man page. > > If the CDROM environment variable is not set, a default device > > name of of /dev/cd0c is used, unless you override this with the -f flag. > > Ah, nevermind, I messed with my local login.conf modifications. > > Your patch looks OK, I will commit it on the next week if nobody > objects. done. -- Maxim Konovalov, [EMAIL PROTECTED], [EMAIL PROTECTED] ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cdcontrol no longer needs 'c' partition?
On Fri, 22 Aug 2003, 10:39-0400, Craig Rodrigues wrote: > On Fri, Aug 22, 2003 at 09:00:32AM +0400, Maxim Konovalov wrote: > > On Sun, 17 Aug 2003, 17:21-0400, Craig Rodrigues wrote: > > > > > Hi, > > > > > > With GEOM in place, is the 'c' partition for a CD device no > > > longer necessary for cdcontrol? At least on my system, > > > the CD shows up as /dev/acd0, not as /dev/acd0c. > > > > What's about CDROM environment var defined in login.conf? > > I don't understand your question. > If the CDROM environment variable is set to a device name, cdcontrol will > try to open that device. This is documented in the cdcontrol man page. > If the CDROM environment variable is not set, a default device > name of of /dev/cd0c is used, unless you override this with the -f flag. Ah, nevermind, I messed with my local login.conf modifications. Your patch looks OK, I will commit it on the next week if nobody objects. -- Maxim Konovalov, [EMAIL PROTECTED], [EMAIL PROTECTED] ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cdcontrol no longer needs 'c' partition?
On Fri, Aug 22, 2003 at 09:00:32AM +0400, Maxim Konovalov wrote: > On Sun, 17 Aug 2003, 17:21-0400, Craig Rodrigues wrote: > > > Hi, > > > > With GEOM in place, is the 'c' partition for a CD device no > > longer necessary for cdcontrol? At least on my system, > > the CD shows up as /dev/acd0, not as /dev/acd0c. > > What's about CDROM environment var defined in login.conf? I don't understand your question. If the CDROM environment variable is set to a device name, cdcontrol will try to open that device. This is documented in the cdcontrol man page. If the CDROM environment variable is not set, a default device name of of /dev/cd0c is used, unless you override this with the -f flag. -- Craig Rodrigues http://crodrigues.org [EMAIL PROTECTED] ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cdcontrol no longer needs 'c' partition?
On Sun, 17 Aug 2003, 17:21-0400, Craig Rodrigues wrote: > Hi, > > With GEOM in place, is the 'c' partition for a CD device no > longer necessary for cdcontrol? At least on my system, > the CD shows up as /dev/acd0, not as /dev/acd0c. What's about CDROM environment var defined in login.conf? [ patch ] -- Maxim Konovalov, [EMAIL PROTECTED], [EMAIL PROTECTED] ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cdcontrol no longer needs 'c' partition?
On Sun, Aug 17, 2003 at 11:27:23PM +0200, Poul-Henning Kamp wrote: > > Yes, the 'a' and 'c' partitions on CD drives are bogus, but this > has nothing directly to do with GEOM, it is only a sideeffect > of the semantic cleanups that went ahead of GEOM. > > The patch looks good to me, but I'd like somebody to test it > before it gets committed. Any takers ? Well, I tested it and it worked for me. :) > >--- src/usr.sbin/cdcontrol/cdcontrol.c.orig Sun Aug 17 17:25:46 2003 > >+++ src/usr.sbin/cdcontrol/cdcontrol.c Sun Aug 17 17:27:49 2003 > >@@ -52,10 +52,6 @@ > > # define DEFAULT_CD_DRIVE "/dev/cd0" > > #endif > > > >-#ifndef DEFAULT_CD_PARTITION > >-# define DEFAULT_CD_PARTITION "c" > >-#endif > >- > > #define CMD_DEBUG 1 > > #define CMD_EJECT 2 > > #define CMD_HELP3 > >@@ -1248,11 +1244,6 @@ > > } > > > > fd = open (devbuf, O_RDONLY); > >- > >-if (fd < 0 && errno == ENOENT) { > >-strcat (devbuf, DEFAULT_CD_PARTITION); > >-fd = open (devbuf, O_RDONLY); > >-} > > > > if (fd < 0) { > > if (errno == ENXIO) { > >--- src/usr.sbin/cdcontrol/cdcontrol.1.orig Sun Aug 17 17:25:39 2003 > >+++ src/usr.sbin/cdcontrol/cdcontrol.1 Sun Aug 17 17:26:27 2003 > >@@ -185,10 +185,10 @@ > > .Ev CDROM . > > .El > > .Sh FILES > >-.Bl -tag -width ".Pa /dev/mcd0c" -compact > >-.It Pa /dev/cd0c > >-.It Pa /dev/mcd0c > >-.It Pa /dev/acd0c > >+.Bl -tag -width ".Pa /dev/mcd0" -compact > >+.It Pa /dev/cd0 > >+.It Pa /dev/mcd0 > >+.It Pa /dev/acd0 > > .El > > .Sh AUTHORS > > .An Jean-Marc Zucconi > > > > > > > > > >-- > >Craig Rodrigues > >http://crodrigues.org > >[EMAIL PROTECTED] > >___ > >[EMAIL PROTECTED] mailing list > >http://lists.freebsd.org/mailman/listinfo/freebsd-current > >To unsubscribe, send any mail to "[EMAIL PROTECTED]" > > > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > [EMAIL PROTECTED] | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. -- Craig Rodrigues http://crodrigues.org [EMAIL PROTECTED] ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cdcontrol no longer needs 'c' partition?
Yes, the 'a' and 'c' partitions on CD drives are bogus, but this has nothing directly to do with GEOM, it is only a sideeffect of the semantic cleanups that went ahead of GEOM. The patch looks good to me, but I'd like somebody to test it before it gets committed. Any takers ? Poul-Henning In message <[EMAIL PROTECTED]>, Craig Rodrigues writes: >Hi, > >With GEOM in place, is the 'c' partition for a CD device no >longer necessary for cdcontrol? At least on my system, >the CD shows up as /dev/acd0, not as /dev/acd0c. > > >--- src/usr.sbin/cdcontrol/cdcontrol.c.origSun Aug 17 17:25:46 2003 >+++ src/usr.sbin/cdcontrol/cdcontrol.c Sun Aug 17 17:27:49 2003 >@@ -52,10 +52,6 @@ > # define DEFAULT_CD_DRIVE "/dev/cd0" > #endif > >-#ifndef DEFAULT_CD_PARTITION >-# define DEFAULT_CD_PARTITION "c" >-#endif >- > #define CMD_DEBUG 1 > #define CMD_EJECT 2 > #define CMD_HELP 3 >@@ -1248,11 +1244,6 @@ > } > > fd = open (devbuf, O_RDONLY); >- >- if (fd < 0 && errno == ENOENT) { >- strcat (devbuf, DEFAULT_CD_PARTITION); >- fd = open (devbuf, O_RDONLY); >- } > > if (fd < 0) { > if (errno == ENXIO) { >--- src/usr.sbin/cdcontrol/cdcontrol.1.origSun Aug 17 17:25:39 2003 >+++ src/usr.sbin/cdcontrol/cdcontrol.1 Sun Aug 17 17:26:27 2003 >@@ -185,10 +185,10 @@ > .Ev CDROM . > .El > .Sh FILES >-.Bl -tag -width ".Pa /dev/mcd0c" -compact >-.It Pa /dev/cd0c >-.It Pa /dev/mcd0c >-.It Pa /dev/acd0c >+.Bl -tag -width ".Pa /dev/mcd0" -compact >+.It Pa /dev/cd0 >+.It Pa /dev/mcd0 >+.It Pa /dev/acd0 > .El > .Sh AUTHORS > .An Jean-Marc Zucconi > > > > >-- >Craig Rodrigues >http://crodrigues.org >[EMAIL PROTECTED] >___ >[EMAIL PROTECTED] mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-current >To unsubscribe, send any mail to "[EMAIL PROTECTED]" > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "[EMAIL PROTECTED]"