Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On 7/16/19 5:37 PM, Warner Losh wrote: On Tue, Jul 16, 2019 at 3:32 PM Dennis Clarke wrote: The window would have been smaller. CI detected the breakage within 10 minutes, but I was away from my email attending to some household things for an hour more... Ha! Sometimes I hear people even sleep ? I was just thinking the probability of landing in that one failed buildworld was real real small and somehow myself and a few others managed to do it. The changes survived a buildworld on amd64. I had no reason to even suspect they might be troublesome on other archs. Since I have a busy day, I took a shortcut. I don't build universe for every change, there's simply not time. So it's more complicated than you're trying to paint. I am not trying to paint anything. I know there are a few of us with limited time and limited resources and we are all just doing what we can. In spite of this we have an open source UNIX with ZFS running. On more than just x86 little boxen. So we can expect bumps in the road : a typical bump in the road for ppc64 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239245 Yep .. changes happen and things break. Such is life. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On Tue, Jul 16, 2019 at 3:32 PM Dennis Clarke wrote: > > > The window would have been smaller. CI detected the breakage within 10 > > minutes, but I was away from my email attending to some household things > > for an hour more... > > > > Ha! Sometimes I hear people even sleep ? > > I was just thinking the probability of landing in that one failed > buildworld was real real small and somehow myself and a few others > managed to do it. > The changes survived a buildworld on amd64. I had no reason to even suspect they might be troublesome on other archs. Since I have a busy day, I took a shortcut. I don't build universe for every change, there's simply not time. So it's more complicated than you're trying to paint. Warner ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
The window would have been smaller. CI detected the breakage within 10 minutes, but I was away from my email attending to some household things for an hour more... Ha! Sometimes I hear people even sleep ? I was just thinking the probability of landing in that one failed buildworld was real real small and somehow myself and a few others managed to do it. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On Tue, Jul 16, 2019 at 5:04 AM Dennis Clarke wrote: > On 7/16/19 6:55 AM, Dimitry Andric wrote: > > On 16 Jul 2019, at 12:36, Dennis Clarke wrote: > >> > >> On 7/16/19 2:48 AM, Warner Losh wrote: > >>> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke > >>> wrote: > /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function > 'getdevtype': > /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison > of unsigned expression < 0 is always false > > Anyone else seeing this ? > > >>> Fixed hours ago in 350020. > >> > >> Hours ago. Cool. However is there no CI testing on ppc64? > > > > There is a CI build, in any case: > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ > > > > It showed a failure for build #11532 (r350018): > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ > > > > and also how it got fixed in build #11533 (r350020): > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ > > > > Unfortunately there is no test job which attempts to fire up a world > > inside e.g. qemu. > > Oh well, thank you for the info. Lucky me that I fell into the exact > same build problem which only happens rarely. Hardly a lottery ticket > win but I am happy to see the CI information. > The window would have been smaller. CI detected the breakage within 10 minutes, but I was away from my email attending to some household things for an hour more... Warner ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On 7/16/19 6:55 AM, Dimitry Andric wrote: On 16 Jul 2019, at 12:36, Dennis Clarke wrote: On 7/16/19 2:48 AM, Warner Losh wrote: On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke wrote: /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison of unsigned expression < 0 is always false Anyone else seeing this ? Fixed hours ago in 350020. Hours ago. Cool. However is there no CI testing on ppc64? There is a CI build, in any case: https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ It showed a failure for build #11532 (r350018): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ and also how it got fixed in build #11533 (r350020): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ Unfortunately there is no test job which attempts to fire up a world inside e.g. qemu. Oh well, thank you for the info. Lucky me that I fell into the exact same build problem which only happens rarely. Hardly a lottery ticket win but I am happy to see the CI information. Dennis ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On 16 Jul 2019, at 12:36, Dennis Clarke wrote: > > On 7/16/19 2:48 AM, Warner Losh wrote: >> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke >> wrote: >>> /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': >>> /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison >>> of unsigned expression < 0 is always false >>> >>> Anyone else seeing this ? >>> >> Fixed hours ago in 350020. > > Hours ago. Cool. However is there no CI testing on ppc64? There is a CI build, in any case: https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ It showed a failure for build #11532 (r350018): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ and also how it got fixed in build #11533 (r350020): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ Unfortunately there is no test job which attempts to fire up a world inside e.g. qemu. -Dimitry signature.asc Description: Message signed with OpenPGP
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On 7/16/19 2:48 AM, Warner Losh wrote: On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke wrote: /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison of unsigned expression < 0 is always false Anyone else seeing this ? Fixed hours ago in 350020. Hours ago. Cool. However is there no CI testing on ppc64? Maybe a jenkins type of deal would be helpful but the code base is moving so fast that it may only catch a few things here and there. Regardless the ppc64 world has bigger problems this morning : r350018 will panic on ppc64 PowerMac G5 in vm_phys_enqueue_contig https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239245 Another day another panic. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sbin/camcontrol/camcontrol.c error breaks buildworld
On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke wrote: > /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': > /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison > of unsigned expression < 0 is always false > > Anyone else seeing this ? > Fixed hours ago in 350020. Warner ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
