RE: cvs commit: src/sys/dev/pci pci.c (fwd)

2003-06-09 Thread Doug Barton
On Mon, 9 Jun 2003, John Baldwin wrote:

> This message is due to a bug in ACPICA.  Patch looks like this:

Thanks John! I look forward to trying this when I get home tonight.

Doug

-- 

This .signature sanitized for your protection
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


RE: cvs commit: src/sys/dev/pci pci.c (fwd)

2003-06-09 Thread John Baldwin

On 08-Jun-2003 Doug Barton wrote:
> This set of commits seems to have fixed a perennial problem I've had with
> my laptop and acpi. Previously, about every 3rd or 4th reboot the pci bus
> would fail to initialize, the major symptom of which was that the xl card
> wouldn't set up, and I'd have to reboot again. Disabling acpi eliminated
> the problem (or the symptom, depending on how you look at it).
> 
> With a kernel built from the latest sources, the pci bus and xl are happy,
> but I'm getting flooded with the following:
> 
> ACPI-0340: *** Error: Could not release ACPI Global Lock, AE_BAD_PARAMETER
> 
> This is on an older thinkpad A21e. It has run -current fine for over a
> year, modulo this pci problem, and general thinkpad <> acpi unhappiness.
> Any other details needed, just ask.

This message is due to a bug in ACPICA.  Patch looks like this:

Index: hwregs.c
===
RCS file: /usr/cvs/src/sys/contrib/dev/acpica/hwregs.c,v
retrieving revision 1.1.1.16
diff -u -r1.1.1.16 hwregs.c
--- hwregs.c3 May 2003 17:16:40 -   1.1.1.16
+++ hwregs.c7 Jun 2003 14:23:57 -
@@ -510,8 +510,8 @@
 ACPI_REGISTER_INSERT_VALUE (RegisterValue, BitRegInfo->BitPosition,
 BitRegInfo->AccessBitMask, Value);
 
-Status = AcpiHwRegisterWrite (ACPI_MTX_DO_NOT_LOCK, RegisterId,
-(UINT16) RegisterValue);
+Status = AcpiHwRegisterWrite (ACPI_MTX_DO_NOT_LOCK,
+   ACPI_REGISTER_PM1_CONTROL, (UINT16) RegisterValue);
 break;

Glad to hear your other problems have been solved. :)

-- 

John Baldwin <[EMAIL PROTECTED]>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/pci pci.c (fwd)

2003-06-07 Thread Doug Barton
This set of commits seems to have fixed a perennial problem I've had with
my laptop and acpi. Previously, about every 3rd or 4th reboot the pci bus
would fail to initialize, the major symptom of which was that the xl card
wouldn't set up, and I'd have to reboot again. Disabling acpi eliminated
the problem (or the symptom, depending on how you look at it).

With a kernel built from the latest sources, the pci bus and xl are happy,
but I'm getting flooded with the following:

ACPI-0340: *** Error: Could not release ACPI Global Lock, AE_BAD_PARAMETER

This is on an older thinkpad A21e. It has run -current fine for over a
year, modulo this pci problem, and general thinkpad <> acpi unhappiness.
Any other details needed, just ask.

Doug


-- 

This .signature sanitized for your protection

-- Forwarded message --
From: John Baldwin <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED]
Date: Sat, 7 Jun 2003 08:00:19 -0700 (PDT)
Subject: cvs commit: src/sys/dev/pci pci.c

jhb 2003/06/07 08:00:19 PDT

  FreeBSD src repository

  Modified files:
sys/dev/pci  pci.c
  Log:
  - Adjust the comment about re-routing PCI interrupts to be less
ia64-specific.
  - When trying to re-route interrupts, don't change cfg->intline if the
re-route fails by returning an invalid vector.  This fixes machines
without any way of routing interrupts such as older PC's without a
$PIR table.

  We do not currently write the new intline value back to the hardware, but
  we should.  That will likely be added in a later commit.

  Revision  ChangesPath
  1.217 +11 -7 src/sys/dev/pci/pci.c

http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pci.c.diff?&r1=1.216&r2=1.217&f=h

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[EMAIL PROTECTED]"