Re: cvs commit: src/sys/i386/eisa ahb.c
:Are you volunteering to review Matt's stuff? It's something I'm sure :he'd be more than happy to take you up on, Warner! :-) As usual, the :amount of work which various folks would more than love to have :reviewed outstrips the number of people willing to do such review work :in any serious way. Yes. I'd review the changes with a 48 hour turn around time (usually better). Generally they are somewhat obvious changes, but some of them require a bit of thought to ensure that they are right. I can handle that. Warner To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: cvs commit: src/sys/i386/eisa ahb.c
:> Given that there is a good potential to introduce bugs, the age old :> "have another committer review it" would likely allay many of the :> fears that have been expressed. In the past that has been the MO for :> this group. : :Are you volunteering to review Matt's stuff? It's something I'm sure :he'd be more than happy to take you up on, Warner! :-) As usual, the :amount of work which various folks would more than love to have :reviewed outstrips the number of people willing to do such review work :in any serious way. : :- Jordan ( Matt mumbles something about what trying to review dozens of commits with hundreds of modifications day after day would do to someone's sanity ) -Matt Matthew Dillon To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: cvs commit: src/sys/i386/eisa ahb.c
> Given that there is a good potential to introduce bugs, the age old > "have another committer review it" would likely allay many of the > fears that have been expressed. In the past that has been the MO for > this group. Are you volunteering to review Matt's stuff? It's something I'm sure he'd be more than happy to take you up on, Warner! :-) As usual, the amount of work which various folks would more than love to have reviewed outstrips the number of people willing to do such review work in any serious way. - Jordan To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: cvs commit: src/sys/i386/eisa ahb.c
> : Any other strategy will, eventually, have you > : charging around the crowd, waving your golf club and slobbering > : maniacally - not really the kind of public image you want to be > : cultivating here. :-) > > Given that there is a good potential to introduce bugs, the age old > "have another committer review it" would likely allay many of the > fears that have been expressed. In the past that has been the MO for > this group. Thanks. This is what did not communicate, but intended to say. :) Nate To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: cvs commit: src/sys/i386/eisa ahb.c
In message <83910.917513...@zippy.cdrom.com> "Jordan K. Hubbard" writes: : Any other strategy will, eventually, have you : charging around the crowd, waving your golf club and slobbering : maniacally - not really the kind of public image you want to be : cultivating here. :-) I'm sure there are many examples of this in the bsd community. Given that there is a good potential to introduce bugs, the age old "have another committer review it" would likely allay many of the fears that have been expressed. In the past that has been the MO for this group. Warner To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: cvs commit: src/sys/i386/eisa ahb.c
> Ah, you mean like John McEnroe ? ;-) Specifically NOT like John McEnroe. :-) - Jordan To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: cvs commit: src/sys/i386/eisa ahb.c
As Jordan K. Hubbard wrote... > > How Mr. ignoromous Nate could construe this to mean that I was trying > > to brush something under the rug is beyond me. As I said to Julian, > > I probably shouldn't have made the committ, but the fact is that I > > not only left the module on my hotlist, I also immediately brought > > the potential problem to the attention of the entire list and thence, > > I think this whole tangled thread can probably be summed up thusly: > > There will always be those remarking from the sidelines about any > change which goes into the FreeBSD source tree, and I do mean ANY > change, the amount of commentary usually in inverse proportion to the > importance of the change. This is just a given. It's also a given > that some of these people will have far less clue than others and even > those who have a clue will often express their comments in such a way > as to come across as criticising or carping, even though they may not > have meant to. There are a lot of engineers here and human > interaction is rarely their strong suit. > > In any case, rather than getting into a protracted furball with each > and every commentator and perhaps using inappropriate language in a > public mailing list in the process, you've gotta do what pro golfers > and ballplayers do - learn to ignore the crowd when it hasn't got Ah, you mean like John McEnroe ? ;-) Wilko _ __ | / o / / _ Bulteemail: wi...@yedi.iaf.nl |/|/ / / /( (_) Arnhem, The Netherlands WWW : http://www.tcja.nl __ Powered by FreeBSD __ To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: cvs commit: src/sys/i386/eisa ahb.c
> How Mr. ignoromous Nate could construe this to mean that I was trying > to brush something under the rug is beyond me. As I said to Julian, > I probably shouldn't have made the committ, but the fact is that I > not only left the module on my hotlist, I also immediately brought > the potential problem to the attention of the entire list and thence, I think this whole tangled thread can probably be summed up thusly: There will always be those remarking from the sidelines about any change which goes into the FreeBSD source tree, and I do mean ANY change, the amount of commentary usually in inverse proportion to the importance of the change. This is just a given. It's also a given that some of these people will have far less clue than others and even those who have a clue will often express their comments in such a way as to come across as criticising or carping, even though they may not have meant to. There are a lot of engineers here and human interaction is rarely their strong suit. In any case, rather than getting into a protracted furball with each and every commentator and perhaps using inappropriate language in a public mailing list in the process, you've gotta do what pro golfers and ballplayers do - learn to ignore the crowd when it hasn't got anything useful to say. Any other strategy will, eventually, have you charging around the crowd, waving your golf club and slobbering maniacally - not really the kind of public image you want to be cultivating here. :-) - Jordan To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: cvs commit: src/sys/i386/eisa ahb.c
:> > Bullshit. You don't know what the fuck you are talking about. :> :> I don't know that you screwed up in your quest to fix a warning? Gee, :> forgive me for sounding suprised, but: :> :> "Matt, you screwed up with your fix that tried to fix a -Wall warning". :> The fix was wrong. Wrong. Wrong. If you don't understand it, don't :> fix it and leave the warning. The warning is there for a reason, and :> making it go away because it bothers you is *WRONG* WRONG *WRONG*. : :Please disregard previous email asking what the bug was.. :-) : :-Archie : :___ :Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com The eisa code was already broken, just not badly enough to crash the machine instantly. I comitted a fix that was essentially what I believed the author meant to do, but the code still didn't look right so I also brought it up on the lists and kept it dog-ear'd. How Mr. ignoromous Nate could construe this to mean that I was trying to brush something under the rug is beyond me. As I said to Julian, I probably shouldn't have made the committ, but the fact is that I not only left the module on my hotlist, I also immediately brought the potential problem to the attention of the entire list and thence, when reminded, onto the scsi list as well -- the problem was NOT being ignored or brushed under the rug. It had NOTHING whatsoever to do with cleaning up a compiler warning. As mistakes go, this was a pretty minor one. Only an idiot would come to a different conclusion. -Matt Matthew Dillon To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
