Followup: if_em.c prevents the 2nd time resuming
PR filed as kern/146614. http://www.freebsd.org/cgi/query-pr.cgi?pr=146614 -- -|-__ YAMAMOTO, Taku | __ t...@tackymt.homeip.net - A chicken is an egg's way of producing more eggs. - ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Followup: if_em.c prevents the 2nd time resuming
On Sat, May 15, 2010 at 8:23 AM, Taku YAMAMOTO t...@tackymt.homeip.net wrote: PR filed as kern/146614. http://www.freebsd.org/cgi/query-pr.cgi?pr=146614 Thanks brother! I didn't know exactly how to fix it -- I just commented the code out! Gad someone did (no offense Jack, you're still THE MAN!!!) ;) -Brandon ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Followup: if_em.c prevents the 2nd time resuming
On Sat, May 15, 2010 at 10:23:17PM +0900, Taku YAMAMOTO wrote: PR filed as kern/146614. http://www.freebsd.org/cgi/query-pr.cgi?pr=146614 That was an mismerge introduced when moving the original patch forward to a newer version of the e1000 source. It's now fixed. Thanks for reporting. Marius ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
if_em.c prevents the 2nd time resuming
Greetings, I found a bug in if_em.c which triggers a panic when resuming from the 2nd suspend. (sleep, wakeup, sleep and wakeup will result to a panic) It seems it has got introduced by r206001 (head) or r206211 (stable/8). I guess the following change mistakenly slipped into em_resume() which is completely bogus (suppose these lines should go into em_detach()?): @@ -769,6 +774,9 @@ struct adapter *adapter = device_get_softc(dev); struct ifnet *ifp = adapter-ifp; + if (adapter-led_dev != NULL) + led_destroy(adapter-led_dev); + EM_CORE_LOCK(adapter); em_init_locked(adapter); em_init_manageability(adapter); Should I file a PR? Virtually yours, -- -|-__ YAMAMOTO, Taku | __ t...@tackymt.homeip.net - A chicken is an egg's way of producing more eggs. - ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
