Re: panic in ufs_extattr_uepm_destroy()
On Fri, 6 Oct 2000, David O'Brien wrote: > This has a KNF style problem. The line you remove should stay and > "ump = VFSTOUFS(mp);" added. Well, either way, it has to be moved further up in the function or you dereference the NULL pointer. Bruce also pointed out the style problem, and I'll commit a fix to that this evening when I'm backin in Massachusetts. I should point out that the reason I modified it the way I did was to make it consistent witth use of VFSTOUFS in many other locations in the UFS/FFS code. Robert N M Watson [EMAIL PROTECTED] http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: panic in ufs_extattr_uepm_destroy()
On Fri, Oct 06, 2000 at 09:41:29AM -0400, Robert Watson wrote: > Index: ffs_vfsops.c > === > RCS file: /home/ncvs/src/sys/ufs/ffs/ffs_vfsops.c,v > retrieving revision 1.129 > diff -u -r1.129 ffs_vfsops.c > --- ffs_vfsops.c 2000/10/04 04:44:51 1.129 > +++ ffs_vfsops.c 2000/10/06 13:40:57 > @@ -772,7 +772,7 @@ > int mntflags; > struct proc *p; > { > - register struct ufsmount *ump; > + register struct ufsmount *ump = VFSTOUFS(mp); > register struct fs *fs; > int error, flags; This has a KNF style problem. The line you remove should stay and "ump = VFSTOUFS(mp);" added. -- -- David ([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: panic in ufs_extattr_uepm_destroy()
On Thu, 5 Oct 2000, Wesley Morgan wrote: > I'm getting a panic in ufs_extattr_uepm_destroy() because in ffs_vfsops.c > it is being called (line 788) with ump NULL: > > ufs_extattr_uepm_destroy(&ump->um_extattr); > > Of course disabling FFS_EXTATTR gets rid of this:) Hmm. I added these changes without adequate testing so as to fix a problem with Jason's addition of a lockdestroy, which also rapidly resulted in a mess :-). I'm away from my dev box right now, as I'm on travel, so haven't tested the following, but it should work. Let me know, and I'll commit it ASAP. Robert N M Watson [EMAIL PROTECTED] http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services Index: ffs_vfsops.c === RCS file: /home/ncvs/src/sys/ufs/ffs/ffs_vfsops.c,v retrieving revision 1.129 diff -u -r1.129 ffs_vfsops.c --- ffs_vfsops.c2000/10/04 04:44:51 1.129 +++ ffs_vfsops.c2000/10/06 13:40:57 @@ -772,7 +772,7 @@ int mntflags; struct proc *p; { - register struct ufsmount *ump; + register struct ufsmount *ump = VFSTOUFS(mp); register struct fs *fs; int error, flags; @@ -794,7 +794,6 @@ if ((error = ffs_flushfiles(mp, flags, p)) != 0) return (error); } - ump = VFSTOUFS(mp); fs = ump->um_fs; if (fs->fs_ronly == 0) { fs->fs_clean = fs->fs_flags & FS_UNCLEAN ? 0 : 1; To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
panic in ufs_extattr_uepm_destroy()
I'm getting a panic in ufs_extattr_uepm_destroy() because in ffs_vfsops.c it is being called (line 788) with ump NULL: ufs_extattr_uepm_destroy(&ump->um_extattr); Of course disabling FFS_EXTATTR gets rid of this:) -- _ __ ___ ___ ___ ___ Wesley N Morgan _ __ ___ | _ ) __| \ [EMAIL PROTECTED] _ __ | _ \._ \ |) | FreeBSD: The Power To Serve _ |___/___/___/ 6bone: 3ffe:1ce3:7::b4ff:fe53:c297 Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread! To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message