panic on boot with fresh current
Hi, I just rebuilt a fresh current on my laptop. It panics on boot with: panic: witness_init: pending locks list is too small, increase WITNESS_PENDLIST I'm in a hurry right now so I can't gather much more info at the moment, but I thought I'd mention it. -- Joel ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: panic on boot with fresh current
On 8/10/2013 6:24 AM, Joel Dahl wrote: Hi, I just rebuilt a fresh current on my laptop. It panics on boot with: panic: witness_init: pending locks list is too small, increase WITNESS_PENDLIST I'm in a hurry right now so I can't gather much more info at the moment, but I thought I'd mention it. I also get this. The last stable revision for me was r254150 -- Regards, Bryan Drewery ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: panic on boot with fresh current
On 8/10/2013 11:44 AM, Bryan Drewery wrote: On 8/10/2013 6:24 AM, Joel Dahl wrote: panic: witness_init: pending locks list is too small, increase WITNESS_PENDLIST I also get this. The last stable revision for me was r254150 r254150 stable, r254171 panic. backtrace: https://dl.dropboxusercontent.com/u/8732004/r254171-panic.jpg -- Regards, Bryan Drewery ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: panic on boot with fresh current
On Sat, Aug 10, 2013 at 12:15:35PM -0500, Bryan Drewery wrote: On 8/10/2013 11:44 AM, Bryan Drewery wrote: On 8/10/2013 6:24 AM, Joel Dahl wrote: panic: witness_init: pending locks list is too small, increase WITNESS_PENDLIST I also get this. The last stable revision for me was r254150 r254150 stable, r254171 panic. backtrace: https://dl.dropboxusercontent.com/u/8732004/r254171-panic.jpg So could you point to exact commit which causes panic ? pgpci7am3AOaR.pgp Description: PGP signature
Re: panic on boot with fresh current
On Sat, Aug 10, 2013 at 08:44:07PM +0300, Konstantin Belousov wrote: On Sat, Aug 10, 2013 at 12:15:35PM -0500, Bryan Drewery wrote: On 8/10/2013 11:44 AM, Bryan Drewery wrote: On 8/10/2013 6:24 AM, Joel Dahl wrote: panic: witness_init: pending locks list is too small, increase WITNESS_PENDLIST I also get this. The last stable revision for me was r254150 r254150 stable, r254171 panic. backtrace: https://dl.dropboxusercontent.com/u/8732004/r254171-panic.jpg So could you point to exact commit which causes panic ? It is r254167, right ? pgpN3VVMpSXEV.pgp Description: PGP signature
Re: panic on boot with fresh current
On Sat, Aug 10, 2013 at 08:45:47PM +0300, Konstantin Belousov wrote: On Sat, Aug 10, 2013 at 08:44:07PM +0300, Konstantin Belousov wrote: On Sat, Aug 10, 2013 at 12:15:35PM -0500, Bryan Drewery wrote: On 8/10/2013 11:44 AM, Bryan Drewery wrote: On 8/10/2013 6:24 AM, Joel Dahl wrote: panic: witness_init: pending locks list is too small, increase WITNESS_PENDLIST I also get this. The last stable revision for me was r254150 r254150 stable, r254171 panic. backtrace: https://dl.dropboxusercontent.com/u/8732004/r254171-panic.jpg So could you point to exact commit which causes panic ? It is r254167, right ? So I cannot reproduce it locally. The problem is that r254167 moved sleepq initialization before witness is operational, and witness has a backlog of locks initialized before witness init. The backlog overflown. The right fix looks to be just what the panic message told, please try this: diff --git a/sys/kern/subr_witness.c b/sys/kern/subr_witness.c index 3b4d7a2..37e8cf2 100644 --- a/sys/kern/subr_witness.c +++ b/sys/kern/subr_witness.c @@ -135,7 +135,7 @@ __FBSDID($FreeBSD$); #defineWITNESS_COUNT 1024 #defineWITNESS_CHILDCOUNT (WITNESS_COUNT * 4) #defineWITNESS_HASH_SIZE 251 /* Prime, gives load factor 2 */ -#defineWITNESS_PENDLIST768 +#defineWITNESS_PENDLIST1024 /* Allocate 256 KB of stack data space */ #defineWITNESS_LO_DATA_COUNT 2048 If this does not help, try to increse PENDLIST even more. But, sleepq uses 256 elements, which means that my increase should be enough. pgplJa4OJUjKh.pgp Description: PGP signature
Re: panic on boot with fresh current
Konstantin Belousov kostik...@gmail.com writes: The right fix looks to be just what the panic message told, please try this: The patch managed to fix the crash here at least. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: panic on boot with fresh current
On 8/10/2013 12:45 PM, Konstantin Belousov wrote: On Sat, Aug 10, 2013 at 08:44:07PM +0300, Konstantin Belousov wrote: On Sat, Aug 10, 2013 at 12:15:35PM -0500, Bryan Drewery wrote: On 8/10/2013 11:44 AM, Bryan Drewery wrote: On 8/10/2013 6:24 AM, Joel Dahl wrote: panic: witness_init: pending locks list is too small, increase WITNESS_PENDLIST I also get this. The last stable revision for me was r254150 r254150 stable, r254171 panic. backtrace: https://dl.dropboxusercontent.com/u/8732004/r254171-panic.jpg So could you point to exact commit which causes panic ? It is r254167, right ? That was my guess based on the stack trace. I will try your patch. -- Regards, Bryan Drewery bdrewery@freenode/EFNet ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: panic on boot with fresh current
Hi, I can reproduce it locally, purely by booting an unchanged amd64 GENERIC. Are you testing it against an _unmodified_ GENERIC, on amd64? If it doesn't panic for you but it does panic for me (and I'll go and get the svn version once I reboot to the old kernel and test) then there may be a hidden problem here that needs solving as this could vary based upon the machine it's happening on. Thanks, -adrian ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: panic on boot with fresh current
On 8/10/2013 1:21 PM, Konstantin Belousov wrote: On Sat, Aug 10, 2013 at 08:45:47PM +0300, Konstantin Belousov wrote: On Sat, Aug 10, 2013 at 08:44:07PM +0300, Konstantin Belousov wrote: On Sat, Aug 10, 2013 at 12:15:35PM -0500, Bryan Drewery wrote: On 8/10/2013 11:44 AM, Bryan Drewery wrote: On 8/10/2013 6:24 AM, Joel Dahl wrote: panic: witness_init: pending locks list is too small, increase WITNESS_PENDLIST I also get this. The last stable revision for me was r254150 r254150 stable, r254171 panic. backtrace: https://dl.dropboxusercontent.com/u/8732004/r254171-panic.jpg So could you point to exact commit which causes panic ? It is r254167, right ? So I cannot reproduce it locally. The problem is that r254167 moved sleepq initialization before witness is operational, and witness has a backlog of locks initialized before witness init. The backlog overflown. The right fix looks to be just what the panic message told, please try this: Yup this patch fixed it, as stated. Thank you for looking at this. -- Regards, Bryan Drewery ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Panic during boot with fresh CURRENT (r248090)
Hi, Just updated to the latest CURRENT. Got this during boot: (sorry for the large image) http://mirror.vnode.se/upload/r248090_panic.jpg -- Joel ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Panic during boot with fresh CURRENT (r248090)
On Sat, Mar 09, 2013 at 10:39:20AM +0100, Joel Dahl wrote: Hi, Just updated to the latest CURRENT. Got this during boot: (sorry for the large image) http://mirror.vnode.se/upload/r248090_panic.jpg This is fixed with r248093. -- Joel ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
