Re: problem building virtualbox-ose-kmod
On 26/01/21 13:29, Dima Panov wrote: Moin! Stefan, please add check for __FreeBSD_version and fill PR or commit it directly with ports-secteam approval. There's a bug report for this: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252675 And another one which is marked as a duplicate of this. In the duplicate I posted a patch including the __FreeBSD_version check. Since you just gave approval for that I'll go ahead and commit, it should also be merged to 2021Q1, since it affects 13. -- Guido Falsi ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: problem building virtualbox-ose-kmod
Moin! Stefan, please add check for __FreeBSD_version and fill PR or commit it directly with ports-secteam approval. -- Dima. (desktop, kde, x11, office, ports-secteam)@FreeBSD team (flu...@freebsd.org, https://t.me/dima_panov) > On Tuesday, Jan 26, 2021 at 8:37 PM, Stefan Esser (mailto:s...@freebsd.org)> wrote: > Am 26.01.21 um 07:34 schrieb monochrome: > > having this issue building virtualbox-ose-kmod, its been like this for a > > while but I deinstalled and forgot, for quite a while now, maybe over a > > month. now that I've moved from 13-current to stable/13 I thought I > > would try to put it back, but it still wont build. I haven't seen anyone > > else with this problem, did I miss a memo? > > I have sent a patch to vbox@on 2020-01-16, but only received an > automatic reply that it had to be accepted by the moderator of the > list (and never got any further reply or reaction on it). > > The signature of vm_map_protect() has changed, but the port has not > been updated. > > Here is the patch in case the attachment gets stripped (but probably > with messed-up white-space): > > Index: files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c > === > --- files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c > (revision 561738) > +++ files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c > (working copy) > @@ -421,7 +421,8 @@ > @@ -826,6 +885,7 @@ DECLHIDDEN(int) rtR0MemObjNativeProtect(PRTR0MEMOBJINT > ProtectionFlags |= VM_PROT_EXECUTE; > > - int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, > ProtectionFlags, FALSE); > +- int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, > ProtectionFlags, FALSE); > ++ int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, > ProtectionFlags, 0, VM_MAP_PROTECT_SET_PROT); > + IPRT_FREEBSD_RESTORE_EFL_AC(); > if (krc == KERN_SUCCESS) > return VINF_SUCCESS; > > Seems that __FreeBSD_version has been bumped to 1300135 less than > 2 hours before 0659df6faddfb27ba54a2cae2a12552cf4f823a0 and thus > the patch could be made to depend on that __FreeBSD_version value, > but I did not bother to add the condition since all my systems have > been updated to newer versions. > > Regards, STefan > > > --- memobj-r0drv-freebsd.o --- > > /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c:887:80: > > error: too few arguments to function call, expected 6, have 5 > > int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, > > ProtectionFlags, FALSE); > > ~~ ^ > > /usr/src/sys/vm/vm_map.h:517:5: note: 'vm_map_protect' declared here > > int vm_map_protect(vm_map_t map, vm_offset_t start, vm_offset_t end, > > ^ > > 1 error generated. > > *** [memobj-r0drv-freebsd.o] Error code 1 signature.asc Description: PGP signature
Re: problem building virtualbox-ose-kmod
Am 26.01.21 um 07:34 schrieb monochrome: having this issue building virtualbox-ose-kmod, its been like this for a while but I deinstalled and forgot, for quite a while now, maybe over a month. now that I've moved from 13-current to stable/13 I thought I would try to put it back, but it still wont build. I haven't seen anyone else with this problem, did I miss a memo? I have sent a patch to vbox@on 2020-01-16, but only received an automatic reply that it had to be accepted by the moderator of the list (and never got any further reply or reaction on it). The signature of vm_map_protect() has changed, but the port has not been updated. Here is the patch in case the attachment gets stripped (but probably with messed-up white-space): Index: files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c === --- files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c (revision 561738) +++ files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c (working copy) @@ -421,7 +421,8 @@ @@ -826,6 +885,7 @@ DECLHIDDEN(int) rtR0MemObjNativeProtect(PRTR0MEMOBJINT ProtectionFlags |= VM_PROT_EXECUTE; - int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, FALSE); +-int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, FALSE); ++int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, 0, VM_MAP_PROTECT_SET_PROT); +IPRT_FREEBSD_RESTORE_EFL_AC(); if (krc == KERN_SUCCESS) return VINF_SUCCESS; Seems that __FreeBSD_version has been bumped to 1300135 less than 2 hours before 0659df6faddfb27ba54a2cae2a12552cf4f823a0 and thus the patch could be made to depend on that __FreeBSD_version value, but I did not bother to add the condition since all my systems have been updated to newer versions. Regards, STefan --- memobj-r0drv-freebsd.o --- /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c:887:80: error: too few arguments to function call, expected 6, have 5 int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, FALSE); ~~ ^ /usr/src/sys/vm/vm_map.h:517:5: note: 'vm_map_protect' declared here int vm_map_protect(vm_map_t map, vm_offset_t start, vm_offset_t end, ^ 1 error generated. *** [memobj-r0drv-freebsd.o] Error code 1 Index: files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c === --- files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c (revision 561738) +++ files/patch-src_VBox_Runtime_r0drv_freebsd_memobj-r0drv-freebsd.c (working copy) @@ -421,7 +421,8 @@ @@ -826,6 +885,7 @@ DECLHIDDEN(int) rtR0MemObjNativeProtect(PRTR0MEMOBJINT ProtectionFlags |= VM_PROT_EXECUTE; - int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, FALSE); +-int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, FALSE); ++int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, 0, VM_MAP_PROTECT_SET_PROT); +IPRT_FREEBSD_RESTORE_EFL_AC(); if (krc == KERN_SUCCESS) return VINF_SUCCESS; OpenPGP_signature Description: OpenPGP digital signature
Re: problem building virtualbox-ose-kmod
On 1/26/21 9:13 AM, Mark Millard via freebsd-current wrote: monochrome monochrome at twcny.rr.com wrote on Tue Jan 26 06:34:23 UTC 2021 : . . . for quite a while now, maybe over a month . . . --- memobj-r0drv-freebsd.o --- /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c:887:80: error: too few arguments to function call, expected 6, have 5 int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, FALSE); ~~ ^ /usr/src/sys/vm/vm_map.h:517:5: note: 'vm_map_protect' declared here int vm_map_protect(vm_map_t map, vm_offset_t start, vm_offset_t end, ^ 1 error generated. *** [memobj-r0drv-freebsd.o] Error code 1 The change from 5 parameters to 6 parameters is recent: main's 0659df6faddf as of 2021-01-12 23:35:22 + (commit). Its one line description is: QUOTE vm_map_protect: allow to set prot and max_prot in one go END QUOTE It added a "int flags" parameter. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252952 is about: vm_map_protect manual page requires an update after 0659df6faddf . . . (So if there was a problem about a month ago, there may be another problem as well as the above that was something else, the above just happens first now.) Looks like emulators/virtualbox-ose-kmod needs to track the kernel change(s). See solution in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252675 Henri ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: problem building virtualbox-ose-kmod
monochrome monochrome at twcny.rr.com wrote on Tue Jan 26 06:34:23 UTC 2021 : > . . . for quite a while now, maybe over a month . . . > --- memobj-r0drv-freebsd.o --- > /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c:887:80: > > error: too few arguments to function call, expected 6, have 5 > int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, > ProtectionFlags, FALSE); >~~ > ^ > /usr/src/sys/vm/vm_map.h:517:5: note: 'vm_map_protect' declared here > int vm_map_protect(vm_map_t map, vm_offset_t start, vm_offset_t end, > ^ > 1 error generated. > *** [memobj-r0drv-freebsd.o] Error code 1 The change from 5 parameters to 6 parameters is recent: main's 0659df6faddf as of 2021-01-12 23:35:22 + (commit). Its one line description is: QUOTE vm_map_protect: allow to set prot and max_prot in one go END QUOTE It added a "int flags" parameter. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252952 is about: vm_map_protect manual page requires an update after 0659df6faddf . . . (So if there was a problem about a month ago, there may be another problem as well as the above that was something else, the above just happens first now.) Looks like emulators/virtualbox-ose-kmod needs to track the kernel change(s). === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
problem building virtualbox-ose-kmod
having this issue building virtualbox-ose-kmod, its been like this for a while but I deinstalled and forgot, for quite a while now, maybe over a month. now that I've moved from 13-current to stable/13 I thought I would try to put it back, but it still wont build. I haven't seen anyone else with this problem, did I miss a memo? . . . --- semfastmutex-r0drv-freebsd.o --- cc -O2 -pipe -fno-strict-aliasing -DRT_OS_FREEBSD -DIN_RING0 -DIN_RT_R0 -DIN_SUP_R0 -DSUPDRV_WITH_RELEASE_LOGGER -DVBOX -DRT_WITH_VBOX -w -DVBOX_WITH_HARDENING -DVBOX_WITH_64_BITS_GUESTS -DRT_ARCH_AMD64 -Werror -D_KERNEL -DKLD_MODULE -nostdinc -Iinclude -I. -Ir0drv -include /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -MD -MF.depend.semfastmutex-r0drv-freebsd.o -MTsemfastmutex-r0drv-freebsd.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length -mno-aes -mno-avx -std=iso9899:1999 -c /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/semfastmutex-r0drv-freebsd.c -o semfastmutex-r0drv-freebsd.o --- memobj-r0drv-freebsd.o --- /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c:887:80: error: too few arguments to function call, expected 6, have 5 int krc = vm_map_protect(pVmMap, AddrStart, AddrEnd, ProtectionFlags, FALSE); ~~ ^ /usr/src/sys/vm/vm_map.h:517:5: note: 'vm_map_protect' declared here int vm_map_protect(vm_map_t map, vm_offset_t start, vm_offset_t end, ^ 1 error generated. *** [memobj-r0drv-freebsd.o] Error code 1 make[3]: stopped in /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv 1 error make[3]: stopped in /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src/vboxdrv *** [all] Error code 2 make[2]: stopped in /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src 1 error make[2]: stopped in /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/freebsd.amd64/release/bin/src ===> Compilation failed unexpectedly. Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer. *** Error code 1 Stop. make[1]: stopped in /usr/ports/emulators/virtualbox-ose-kmod *** Error code 1 Stop. make: stopped in /usr/ports/emulators/virtualbox-ose-kmod ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
