Re: racct crash/Linux Emulation

2015-08-29 Thread Edward Tomasz Napierała
On 0828T1207, Larry Rosenman wrote:
 On 2015-08-24 11:07, Edward Tomasz Napierała wrote:
  On 0824T0731, Larry Rosenman wrote:
  On 2015-08-24 03:37, Edward Tomasz Napierała wrote:
   On 0823T2028, Larry Rosenman wrote:
   got the below panio, on a linux (world community grid) process exit.
  
  
   borg.lerctr.org dumped core - see /var/crash/vmcore.5
  
   Sun Aug 23 20:14:24 CDT 2015
  
   FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #46 r287028:
   Sat Aug 22 18:34:59 CDT 2015
   r...@borg.lerctr.org:/usr/obj/usr/src/sys/VT-LER  amd64
  
   panic: racct_sub: freeing 1 of resource 11, which is more than
   allocated 0 for wcgrid_fahv_vina_pr (pid 1140)
  
   Could you try the patch below?
  
  [removed]
  
  Yes, that seems to fix it.  THANKS!
  
  Thanks.  It's pending review at https://reviews.freebsd.org/D3470.
 What's it going to take to get this committed?
 
 Seems(!) simple enough..

I'd prefer someone who knows this code to take a look and confirm
it's indeed the right way to fix it.  Don't worry, I won't forget
about it :-)

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: racct crash/Linux Emulation

2015-08-28 Thread Larry Rosenman

On 2015-08-24 11:07, Edward Tomasz Napierała wrote:

On 0824T0731, Larry Rosenman wrote:

On 2015-08-24 03:37, Edward Tomasz Napierała wrote:
 On 0823T2028, Larry Rosenman wrote:
 got the below panio, on a linux (world community grid) process exit.


 borg.lerctr.org dumped core - see /var/crash/vmcore.5

 Sun Aug 23 20:14:24 CDT 2015

 FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #46 r287028:
 Sat Aug 22 18:34:59 CDT 2015
 r...@borg.lerctr.org:/usr/obj/usr/src/sys/VT-LER  amd64

 panic: racct_sub: freeing 1 of resource 11, which is more than
 allocated 0 for wcgrid_fahv_vina_pr (pid 1140)

 Could you try the patch below?

[removed]

Yes, that seems to fix it.  THANKS!


Thanks.  It's pending review at https://reviews.freebsd.org/D3470.

What's it going to take to get this committed?

Seems(!) simple enough..
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 7011 W Parmer Ln, Apt 1115, Austin, TX 78729-6961

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: racct crash/Linux Emulation

2015-08-24 Thread Larry Rosenman

On 2015-08-24 03:37, Edward Tomasz Napierała wrote:

On 0823T2028, Larry Rosenman wrote:

got the below panio, on a linux (world community grid) process exit.


borg.lerctr.org dumped core - see /var/crash/vmcore.5

Sun Aug 23 20:14:24 CDT 2015

FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #46 r287028: 
Sat Aug 22 18:34:59 CDT 2015 
r...@borg.lerctr.org:/usr/obj/usr/src/sys/VT-LER  amd64


panic: racct_sub: freeing 1 of resource 11, which is more than 
allocated 0 for wcgrid_fahv_vina_pr (pid 1140)


Could you try the patch below?


[removed]

Yes, that seems to fix it.  THANKS!

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: l...@lerctr.org
US Mail: 7011 W Parmer Ln, Apt 1115, Austin, TX 78729-6961

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: racct crash/Linux Emulation

2015-08-24 Thread Edward Tomasz Napierała
On 0824T0731, Larry Rosenman wrote:
 On 2015-08-24 03:37, Edward Tomasz Napierała wrote:
  On 0823T2028, Larry Rosenman wrote:
  got the below panio, on a linux (world community grid) process exit.
  
  
  borg.lerctr.org dumped core - see /var/crash/vmcore.5
  
  Sun Aug 23 20:14:24 CDT 2015
  
  FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #46 r287028: 
  Sat Aug 22 18:34:59 CDT 2015 
  r...@borg.lerctr.org:/usr/obj/usr/src/sys/VT-LER  amd64
  
  panic: racct_sub: freeing 1 of resource 11, which is more than 
  allocated 0 for wcgrid_fahv_vina_pr (pid 1140)
  
  Could you try the patch below?
  
 [removed]
 
 Yes, that seems to fix it.  THANKS!

Thanks.  It's pending review at https://reviews.freebsd.org/D3470.

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: racct crash/Linux Emulation

2015-08-24 Thread Edward Tomasz Napierała
On 0823T2028, Larry Rosenman wrote:
 got the below panio, on a linux (world community grid) process exit.
 
 
 borg.lerctr.org dumped core - see /var/crash/vmcore.5
 
 Sun Aug 23 20:14:24 CDT 2015
 
 FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #46 r287028: Sat 
 Aug 22 18:34:59 CDT 2015 r...@borg.lerctr.org:/usr/obj/usr/src/sys/VT-LER 
  amd64
 
 panic: racct_sub: freeing 1 of resource 11, which is more than allocated 0 
 for wcgrid_fahv_vina_pr (pid 1140)

Could you try the patch below?

Index: sys/compat/linux/linux_fork.c
===
--- sys/compat/linux/linux_fork.c   (revision 287034)
+++ sys/compat/linux/linux_fork.c   (working copy)
@@ -285,10 +285,20 @@ linux_clone_thread(struct thread *td, struct linux
 
p = td-td_proc;
 
+#ifdef RACCT
+   if (racct_enable) {
+   PROC_LOCK(p);
+   error = racct_add(p, RACCT_NTHR, 1);
+   PROC_UNLOCK(p);
+   if (error != 0)
+   return (EPROCLIM);
+   }
+#endif
+
/* Initialize our td */
error = kern_thr_alloc(p, 0, newtd);
if (error)
-   return (error);
+   goto fail;


cpu_set_upcall(newtd, td);
 
@@ -369,6 +379,16 @@ linux_clone_thread(struct thread *td, struct linux
td-td_retval[0] = newtd-td_tid;
 
return (0);
+
+fail:
+#ifdef RACCT
+   if (racct_enable) {
+   PROC_LOCK(p);
+   racct_sub(p, RACCT_NTHR, 1);
+   PROC_UNLOCK(p);
+   }
+#endif
+   return (error);
 }
 
 int
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


racct crash/Linux Emulation

2015-08-23 Thread Larry Rosenman
got the below panio, on a linux (world community grid) process exit.


borg.lerctr.org dumped core - see /var/crash/vmcore.5

Sun Aug 23 20:14:24 CDT 2015

FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #46 r287028: Sat Aug 
22 18:34:59 CDT 2015 r...@borg.lerctr.org:/usr/obj/usr/src/sys/VT-LER  amd64

panic: racct_sub: freeing 1 of resource 11, which is more than allocated 0 for 
wcgrid_fahv_vina_pr (pid 1140)

GNU gdb 6.1.1 [FreeBSD]
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type show copying to see the conditions.
There is absolutely no warranty for GDB.  Type show warranty for details.
This GDB was configured as amd64-marcel-freebsd...

Unread portion of the kernel message buffer:
panic: racct_sub: freeing 1 of resource 11, which is more than allocated 0 for 
wcgrid_fahv_vina_pr (pid 1140)
cpuid = 3
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfe2eb3859920
vpanic() at vpanic+0x189/frame 0xfe2eb38599a0
kassert_panic() at kassert_panic+0x132/frame 0xfe2eb3859a10
racct_sub() at racct_sub+0x13e/frame 0xfe2eb3859a50
exit1() at exit1+0xd4/frame 0xfe2eb3859ad0
linux_exit_group() at linux_exit_group+0xd/frame 0xfe2eb3859ae0
ia32_syscall() at ia32_syscall+0x28b/frame 0xfe2eb3859bf0
Xint0x80_syscall() at Xint0x80_syscall+0x95/frame 0xfe2eb3859bf0
--- syscall (252, Linux ELF32, linux_exit_group), rip = 0x817a9d7, rsp = 
0xca3c, rbp = 0xca58 ---
Uptime: 2m22s
Dumping 2881 out of 64454 MB:..1%..11%..21%..31%..41%..51%..61%..71%..81%..91%

Reading symbols from /boot/kernel/linux.ko.symbols...done.
Loaded symbols for /boot/kernel/linux.ko.symbols
Reading symbols from /boot/kernel/linux_common.ko.symbols...done.
Loaded symbols for /boot/kernel/linux_common.ko.symbols
Reading symbols from /boot/kernel/if_lagg.ko.symbols...done.
Loaded symbols for /boot/kernel/if_lagg.ko.symbols
Reading symbols from /boot/kernel/snd_envy24ht.ko.symbols...done.
Loaded symbols for /boot/kernel/snd_envy24ht.ko.symbols
Reading symbols from /boot/kernel/snd_spicds.ko.symbols...done.
Loaded symbols for /boot/kernel/snd_spicds.ko.symbols
Reading symbols from /boot/kernel/coretemp.ko.symbols...done.
Loaded symbols for /boot/kernel/coretemp.ko.symbols
Reading symbols from /boot/kernel/ichsmb.ko.symbols...done.
Loaded symbols for /boot/kernel/ichsmb.ko.symbols
Reading symbols from /boot/kernel/smbus.ko.symbols...done.
Loaded symbols for /boot/kernel/smbus.ko.symbols
Reading symbols from /boot/kernel/ichwd.ko.symbols...done.
Loaded symbols for /boot/kernel/ichwd.ko.symbols
Reading symbols from /boot/kernel/cpuctl.ko.symbols...done.
Loaded symbols for /boot/kernel/cpuctl.ko.symbols
Reading symbols from /boot/kernel/cryptodev.ko.symbols...done.
Loaded symbols for /boot/kernel/cryptodev.ko.symbols
Reading symbols from /boot/kernel/dtraceall.ko.symbols...done.
Loaded symbols for /boot/kernel/dtraceall.ko.symbols
Reading symbols from /boot/kernel/profile.ko.symbols...done.
Loaded symbols for /boot/kernel/profile.ko.symbols
Reading symbols from /boot/kernel/dtrace.ko.symbols...done.
Loaded symbols for /boot/kernel/dtrace.ko.symbols
Reading symbols from /boot/kernel/systrace_freebsd32.ko.symbols...done.
Loaded symbols for /boot/kernel/systrace_freebsd32.ko.symbols
Reading symbols from /boot/kernel/systrace.ko.symbols...done.
Loaded symbols for /boot/kernel/systrace.ko.symbols
Reading symbols from /boot/kernel/sdt.ko.symbols...done.
Loaded symbols for /boot/kernel/sdt.ko.symbols
Reading symbols from /boot/kernel/fasttrap.ko.symbols...done.
Loaded symbols for /boot/kernel/fasttrap.ko.symbols
Reading symbols from /boot/kernel/fbt.ko.symbols...done.
Loaded symbols for /boot/kernel/fbt.ko.symbols
Reading symbols from /boot/kernel/dtnfscl.ko.symbols...done.
Loaded symbols for /boot/kernel/dtnfscl.ko.symbols
Reading symbols from /boot/kernel/dtmalloc.ko.symbols...done.
Loaded symbols for /boot/kernel/dtmalloc.ko.symbols
Reading symbols from /boot/modules/nvidia.ko...done.
Loaded symbols for /boot/modules/nvidia.ko
Reading symbols from /boot/kernel/ipmi.ko.symbols...done.
Loaded symbols for /boot/kernel/ipmi.ko.symbols
Reading symbols from /boot/kernel/ipmi_linux.ko.symbols...done.
Loaded symbols for /boot/kernel/ipmi_linux.ko.symbols
Reading symbols from /boot/kernel/radeonkms.ko.symbols...done.
Loaded symbols for /boot/kernel/radeonkms.ko.symbols
Reading symbols from /boot/kernel/iicbb.ko.symbols...done.
Loaded symbols for /boot/kernel/iicbb.ko.symbols
Reading symbols from /boot/kernel/iicbus.ko.symbols...done.
Loaded symbols for /boot/kernel/iicbus.ko.symbols
Reading symbols from /boot/kernel/iic.ko.symbols...done.
Loaded symbols for /boot/kernel/iic.ko.symbols
Reading symbols from /boot/kernel/drm2.ko.symbols...done.
Loaded symbols for /boot/kernel/drm2.ko.symbols
Reading symbols from