Re: world breakage in pam_echo

2003-07-16 Thread Doug White
On Wed, 16 Jul 2003, Christian Brueffer wrote:

> my world is broken with the following error message for some days now:
>
>
> ===> lib/libpam/modules/pam_echo
> cc -O2 -pipe -march=pentium2 
> -I/usr/src/lib/libpam/modules/pam_echo/../../../../contrib/openpam/include 
> -I/usr/src/lib/libpam/modules/pam_echo/../../libpam  -Wsystem-headers -Werror -Wall 
> -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
> -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align 
> -Wno-uninitialized  -c /usr/src/lib/libpam/modules/pam_echo/pam_echo.c

1.  Optimization levels above -O are not supported.
2.  -Werror is NOT recommended post-gcc 3.3 upgrade unless you are fixing
warnings.  gcc3.3 is much more warn-happy.  I'm not sure how you got
-Werror in there since it was removed prior to the gcc3.3 import.

-- 
Doug White|  FreeBSD: The Power to Serve
[EMAIL PROTECTED]  |  www.FreeBSD.org
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: world breakage in pam_echo

2003-07-16 Thread LLeweLLyn Reese
Wesley Morgan <[EMAIL PROTECTED]> writes:

> On Wed, 16 Jul 2003, Christian Brueffer wrote:
> 
> > ===> lib/libpam/modules/pam_echo
> > cc -O2 -pipe -march=pentium2 
> > -I/usr/src/lib/libpam/modules/pam_echo/../../../../contrib/openpam/include 
> > -I/usr/src/lib/libpam/modules/pam_echo/../../libpam  -Wsystem-headers -Werror 
> > -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
> > -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align 
> > -Wno-uninitialized  -c /usr/src/lib/libpam/modules/pam_echo/pam_echo.c
> > /usr/src/lib/libpam/modules/pam_echo/pam_echo.c: In function `_pam_echo':
> > /usr/src/lib/libpam/modules/pam_echo/pam_echo.c:92: warning: dereferencing 
> > type-punned pointer will break strict-aliasing rules
> > *** Error code 1
> 
> I was just about to report this myself. The breakage only occurs with
> optimization levels of -O2 (and maybe higher). Officially -O2 is not
> supported for world, but in my experience there are real problems with
> code (warnings in this case) that do not show up until the optimizer takes
> a closer look at them.
[snip]

It's my impression that these warnings mean the C code in question is
undefined or implementation-defined according to the C standard,
and the generated assembler may have unexpected behavior.
I get this impression from reading the description of
-fstrict-aliasing (enabled at -O2, -O3, -Os) at:
http://gcc.gnu.org/onlinedocs/gcc-3.3/gcc/Optimize-Options.html#Optimize%20Options

(The relevant warning flag is -Wstrict-aliasing, see
http://gcc.gnu.org/onlinedocs/gcc-3.3/gcc/Warning-Options.html#Warning%20Options
)

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: world breakage in pam_echo

2003-07-16 Thread Wesley Morgan
On Wed, 16 Jul 2003, Christian Brueffer wrote:

> ===> lib/libpam/modules/pam_echo
> cc -O2 -pipe -march=pentium2 
> -I/usr/src/lib/libpam/modules/pam_echo/../../../../contrib/openpam/include 
> -I/usr/src/lib/libpam/modules/pam_echo/../../libpam  -Wsystem-headers -Werror -Wall 
> -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
> -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align 
> -Wno-uninitialized  -c /usr/src/lib/libpam/modules/pam_echo/pam_echo.c
> /usr/src/lib/libpam/modules/pam_echo/pam_echo.c: In function `_pam_echo':
> /usr/src/lib/libpam/modules/pam_echo/pam_echo.c:92: warning: dereferencing 
> type-punned pointer will break strict-aliasing rules
> *** Error code 1

I was just about to report this myself. The breakage only occurs with
optimization levels of -O2 (and maybe higher). Officially -O2 is not
supported for world, but in my experience there are real problems with
code (warnings in this case) that do not show up until the optimizer takes
a closer look at them.


-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


world breakage in pam_echo

2003-07-16 Thread Christian Brueffer

--iIq+KTIB+xWY0FJy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

my world is broken with the following error message for some days now:


=3D=3D=3D> lib/libpam/modules/pam_echo
cc -O2 -pipe -march=3Dpentium2 -I/usr/src/lib/libpam/modules/pam_echo/../..=
/../../contrib/openpam/include -I/usr/src/lib/libpam/modules/pam_echo/../..=
/libpam  -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototy=
pes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-=
strings -Wswitch -Wshadow -Wcast-align -Wno-uninitialized  -c /usr/src/lib/=
libpam/modules/pam_echo/pam_echo.c
/usr/src/lib/libpam/modules/pam_echo/pam_echo.c: In function `_pam_echo':
/usr/src/lib/libpam/modules/pam_echo/pam_echo.c:92: warning: dereferencing =
type-punned pointer will break strict-aliasing rules
*** Error code 1

Stop in /usr/src/lib/libpam/modules/pam_echo.
*** Error code 1

Stop in /usr/src/lib/libpam/modules.
*** Error code 1

Stop in /usr/src/lib/libpam.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.


Does anyone have some insight into this?

- Christian

--=20
Christian Brueffer  [EMAIL PROTECTED]   [EMAIL PROTECTED]
GPG Key: http://people.freebsd.org/~brueffer/brueffer.key.asc
GPG Fingerprint: A5C8 2099 19FF AACA F41B  B29B 6C76 178C A0ED 982D

--iIq+KTIB+xWY0FJy
Content-Type: application/pgp-signature
Content-Disposition: inline

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE/FWYzbHYXjKDtmC0RAmikAKCcf+97hb8MYVmFkcB98FFaBgZ2zQCg59oY
zt3LZ+pRTuf0O8ndWBklElI=
=cQku
-END PGP SIGNATURE-

--iIq+KTIB+xWY0FJy--