[Bug 277021] www/firefox: error on start after updating to 123.0 (rc1, rc2)

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277021

--- Comment #73 from Tomoaki AOKI  ---
(In reply to Tatsuki Makino from comment #70)

Interesting. But resulting assembly codes seems to be reverse with what
happened.

For "-march=" case, libm should be surely needed, while "-march=haswell" case,
possibly not needed (functions in libm are not called). But what's happening is
that sane boot with blank (default) CPUTYPE) but fais without "-lm" on
CPUTYPE=haswell case.

And assuming the problematic library is a codec as of its name, disabling sse*
and/or avx+ options could result in severe performance degradation when they
are actually available.

Moreover, some of external libraries linked against libxul.so (IIUC, a core
component of firefox) are linked against libm. So blindly linking with libm
looks reasonable foe me. As libxul.so itself is linked with libm could be
because of the patch, list others below. (Picked from outputs of `ldd -a
usr/local/lib/firefox/libxul.so`.)

usr/local/lib/libicui18n.so.74
/usr/local/lib/libicuuc.so.74
/usr/local/lib/libaom.so.3
/usr/local/lib/libgdk-3.so.0
/usr/local/lib/libharfbuzz.so.0
/usr/local/lib/libpango-1.0.so.0
/usr/local/lib/libgtk-3.so.0
/usr/local/lib/libcairo.so.2
/usr/local/lib/libcairo-gobject.so.2
/usr/local/lib/libpng16.so.16
/usr/local/lib/libwebp.so.7
/usr/local/lib/libvpx.so.9
/usr/local/lib/libpixman-1.so.0
/usr/local/lib/libvmaf.so.3
/usr/local/lib/libbrotlidec.so.1
/usr/local/lib/libexpat.so.1/usr/local/lib/libsharpyuv.so.0
/usr/local/lib/libpangocairo-1.0.so.0
/usr/local/lib/libsharpyuv.so.0
/usr/local/lib/libbrotlicommon.so.1

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 277021] www/firefox: error on start after updating to 123.0 (rc1, rc2)

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277021

--- Comment #72 from Nuno Teixeira  ---
(In reply to Tatsuki Makino from comment #70)

> This seems to be an SSE4 instruction, so CFLAGS+=-mno-sse4 is the 
> minimal workaround.
How could that affect aarch64 like I'm experience on rpi4?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 277021] www/firefox: error on start after updating to 123.0 (rc1, rc2)

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277021

--- Comment #71 from Nuno Teixeira  ---
(In reply to Nuno Teixeira from comment #67)
> Status: aarch64 (rpi4)

> - main and poudriere jail @ 3733d82c4deb
> - build from a cleaned pkgs poudriere
> - `pkg delete -af` && install pkgs

> `firefox`: same error as mentioned.

Patch fixes issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 277021] www/firefox: error on start after updating to 123.0 (rc1, rc2)

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277021

--- Comment #70 from Tatsuki Makino  ---
(In reply to Tomoaki AOKI from comment #69)

> I cannot understand why CPUTYPE causes ceil() and floor() is used or not.

Me too :)
There is no reason for this anywhere in the Firefox source code.


So a new experiment will be made.
#include ,  and 
int main(int argc, char * argv[]) { double d; d = ceil(floor(atof(argv[1])));
printf("%f\n", d); return 0; }
~
Compile it with the following options
clang15 -S -O0 -march= /tmp/test_src.c
clang15 -S -O0 -march=haswell /tmp/test_src.c

It would make the file with the suffix changed to s.
If -march= is empty, there is a callq of ceil and floor.
If -march=haswell then it does not exist.
vroundsd is used for floor and ceil.

This seems to be an SSE4 instruction, so CFLAGS+=-mno-sse4 is the minimal
workaround.


Could this time be the basis for a correct patch? :)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[package - 132i386-quarterly][www/firefox] Failed for firefox-123.0_2,2 in build-depends

2024-02-17 Thread pkg-fallout
You are receiving this mail as a port that you maintain
is failing to build on the FreeBSD package build server.
Please investigate the failure and submit a PR to fix
build.

Maintainer: ge...@freebsd.org
Log URL:
https://pkg-status.freebsd.org/beefy13/data/132i386-quarterly/459b3c57e6c4/logs/firefox-123.0_2,2.log
Build URL:  
https://pkg-status.freebsd.org/beefy13/build.html?mastername=132i386-quarterly=459b3c57e6c4
Log:

=>> Building www/firefox
build started at Sun Feb 18 05:27:27 UTC 2024
port directory: /usr/ports/www/firefox
package name: firefox-123.0_2,2
building for: FreeBSD 132i386-quarterly-job-12 13.2-RELEASE-p10 FreeBSD 
13.2-RELEASE-p10 i386
maintained by: ge...@freebsd.org
Makefile datestamp: -rw-r--r--  1 root  wheel  2609 Feb 15 01:01 
/usr/ports/www/firefox/Makefile
Ports top last git commit: 459b3c57e
Ports top unclean checkout: no
Port dir last git commit: 3085d3b93
Port dir unclean checkout: no
Poudriere version: poudriere-git-3.4.1
Host OSVERSION: 156
Jail OSVERSION: 1302001
Job Id: 12

---Begin Environment---
SHELL=/bin/csh
BLOCKSIZE=K
MAIL=/var/mail/root
MM_CHARSET=UTF-8
LANG=C.UTF-8
OSVERSION=1302001
STATUS=1
HOME=/root
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
MAKE_OBJDIR_CHECK_WRITABLE=0
UNAME_m=i386
UNAME_p=i386
UNAME_r=13.2-RELEASE-p10
LOCALBASE=/usr/local
UNAME_v=FreeBSD 13.2-RELEASE-p10
USER=root
POUDRIERE_NAME=poudriere-git
LIBEXECPREFIX=/usr/local/libexec/poudriere
POUDRIERE_VERSION=3.4.1
MASTERMNT=/usr/local/poudriere/data/.m/132i386-quarterly/ref
LC_COLLATE=C
POUDRIERE_BUILD_TYPE=bulk
PACKAGE_BUILDING=yes
SAVED_TERM=
OUTPUT_REDIRECTED_STDERR=4
OUTPUT_REDIRECTED=1
PWD=/usr/local/poudriere/data/.m/132i386-quarterly/12/.p
OUTPUT_REDIRECTED_STDOUT=3
P_PORTS_FEATURES=FLAVORS SUBPACKAGES SELECTED_OPTIONS
MASTERNAME=132i386-quarterly
SCRIPTPREFIX=/usr/local/share/poudriere
SCRIPTNAME=bulk.sh
OLDPWD=/usr/local/poudriere/data/.m/132i386-quarterly/ref/.p/pool
POUDRIERE_PKGNAME=poudriere-git-3.4.1
SCRIPTPATH=/usr/local/share/poudriere/bulk.sh
POUDRIEREPATH=/usr/local/bin/poudriere
---End Environment---

---Begin Poudriere Port Flags/Env---
PORT_FLAGS=
PKGENV=
FLAVOR=
MAKE_ARGS=
---End Poudriere Port Flags/Env---

---Begin OPTIONS List---
===> The following configuration options are available for firefox-123.0_2,2:
 CANBERRA=off: Sound theme alerts
 DBUS=on: D-Bus IPC system support
 DEBUG=off: Build with debugging support
 FFMPEG=on: FFmpeg support (WMA, AIFF, AC3, APE...)
 LIBPROXY=off: Proxy support via libproxy
 LTO=off: Use Link-Time Optimization
 OPTIMIZED_CFLAGS=on: Use extra compiler optimizations
 PROFILE=on: Build with profiling support
 TEST=off: Build and/or run tests
> Extra cubeb audio backends (OSS is always available)
 ALSA=off: ALSA audio architecture support
 JACK=on: JACK audio server support
 PULSEAUDIO=on: PulseAudio sound server support
 SNDIO=on: Sndio audio support
===> Use 'make config' to modify these settings
---End OPTIONS List---

--MAINTAINER--
ge...@freebsd.org
--End MAINTAINER--

--CONFIGURE_ARGS--

--End CONFIGURE_ARGS--

--CONFIGURE_ENV--
BINDGEN_CFLAGS="-I/usr/local/include" MAKE=gmake PKG_CONFIG=pkgconf 
PYTHON="/usr/local/bin/python3.9" 
XDG_DATA_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CACHE_HOME=/wrkdirs/usr/ports/www/firefox/work/.cache  
HOME=/wrkdirs/usr/ports/www/firefox/work TMPDIR="/tmp" 
PATH=/wrkdirs/usr/ports/www/firefox/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
 
PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/www/firefox/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig
 SHELL=/bin/sh CONFIG_SHELL=/bin/sh CMAKE_PREFIX_PATH="/usr/local" 
LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8
--End CONFIGURE_ENV--

--MAKE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CACHE_HOME=/wrkdirs/usr/ports/www/firefox/work/.cache  
HOME=/wrkdirs/usr/ports/www/firefox/work TMPDIR="/tmp" 
PATH=/wrkdirs/usr/ports/www/firefox/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
 
PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/www/firefox/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig
 MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES 
LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 PREFIX=/usr/local  LOCALBASE=/usr/local  
CC="/usr/local/bin/clang15" CFLAGS="-O2 -pipe  -O3 -DLIBICONV_PLUG 
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing "  
CPP="/usr/local/bin/clang-cpp15" CPPFLAGS="-DLIBICONV_PLUG -isystem 
/usr/local/include"  LDFLAGS=" -Wl,--as-needed -fstack-protector-strong " 
LIBS="-L/usr/local/lib"  CXX="/usr/local/bin/clang++15" CXXFLAGS="-O2 -pipe -O3 
-D
LIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include 
-fno-strict-aliasing  -DLIBICONV_PLUG 

[package - 140i386-quarterly][www/firefox] Failed for firefox-123.0_2,2 in build-depends

2024-02-17 Thread pkg-fallout
You are receiving this mail as a port that you maintain
is failing to build on the FreeBSD package build server.
Please investigate the failure and submit a PR to fix
build.

Maintainer: ge...@freebsd.org
Log URL:
https://pkg-status.freebsd.org/beefy7/data/140i386-quarterly/b3e5282399eb/logs/firefox-123.0_2,2.log
Build URL:  
https://pkg-status.freebsd.org/beefy7/build.html?mastername=140i386-quarterly=b3e5282399eb
Log:

=>> Building www/firefox
build started at Sun Feb 18 03:37:52 UTC 2024
port directory: /usr/ports/www/firefox
package name: firefox-123.0_2,2
building for: FreeBSD 140i386-quarterly-job-09 14.0-RELEASE-p5 FreeBSD 
14.0-RELEASE-p5 i386
maintained by: ge...@freebsd.org
Makefile datestamp: -rw-r--r--  1 root wheel 2609 Feb 15 01:01 
/usr/ports/www/firefox/Makefile
Ports top last git commit: b3e528239
Ports top unclean checkout: no
Port dir last git commit: 3085d3b93
Port dir unclean checkout: no
Poudriere version: poudriere-git-3.4.1
Host OSVERSION: 156
Jail OSVERSION: 1400097
Job Id: 09

---Begin Environment---
SHELL=/bin/sh
BLOCKSIZE=K
MAIL=/var/mail/root
MM_CHARSET=UTF-8
LANG=C.UTF-8
OSVERSION=1400097
STATUS=1
HOME=/root
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
MAKE_OBJDIR_CHECK_WRITABLE=0
UNAME_m=i386
UNAME_p=i386
UNAME_r=14.0-RELEASE-p5
LOCALBASE=/usr/local
UNAME_v=FreeBSD 14.0-RELEASE-p5
USER=root
POUDRIERE_NAME=poudriere-git
LIBEXECPREFIX=/usr/local/libexec/poudriere
POUDRIERE_VERSION=3.4.1
MASTERMNT=/usr/local/poudriere/data/.m/140i386-quarterly/ref
LC_COLLATE=C
POUDRIERE_BUILD_TYPE=bulk
PACKAGE_BUILDING=yes
SAVED_TERM=
OUTPUT_REDIRECTED_STDERR=4
OUTPUT_REDIRECTED=1
PWD=/usr/local/poudriere/data/.m/140i386-quarterly/09/.p
OUTPUT_REDIRECTED_STDOUT=3
P_PORTS_FEATURES=FLAVORS SUBPACKAGES SELECTED_OPTIONS
MASTERNAME=140i386-quarterly
SCRIPTPREFIX=/usr/local/share/poudriere
SCRIPTNAME=bulk.sh
OLDPWD=/usr/local/poudriere/data/.m/140i386-quarterly/ref/.p/pool
POUDRIERE_PKGNAME=poudriere-git-3.4.1
SCRIPTPATH=/usr/local/share/poudriere/bulk.sh
POUDRIEREPATH=/usr/local/bin/poudriere
---End Environment---

---Begin Poudriere Port Flags/Env---
PORT_FLAGS=
PKGENV=
FLAVOR=
MAKE_ARGS=
---End Poudriere Port Flags/Env---

---Begin OPTIONS List---
===> The following configuration options are available for firefox-123.0_2,2:
 CANBERRA=off: Sound theme alerts
 DBUS=on: D-Bus IPC system support
 DEBUG=off: Build with debugging support
 FFMPEG=on: FFmpeg support (WMA, AIFF, AC3, APE...)
 LIBPROXY=off: Proxy support via libproxy
 LTO=off: Use Link-Time Optimization
 OPTIMIZED_CFLAGS=on: Use extra compiler optimizations
 PROFILE=on: Build with profiling support
 TEST=off: Build and/or run tests
> Extra cubeb audio backends (OSS is always available)
 ALSA=off: ALSA audio architecture support
 JACK=on: JACK audio server support
 PULSEAUDIO=on: PulseAudio sound server support
 SNDIO=on: Sndio audio support
===> Use 'make config' to modify these settings
---End OPTIONS List---

--MAINTAINER--
ge...@freebsd.org
--End MAINTAINER--

--CONFIGURE_ARGS--

--End CONFIGURE_ARGS--

--CONFIGURE_ENV--
BINDGEN_CFLAGS="-I/usr/local/include" MAKE=gmake PKG_CONFIG=pkgconf 
PYTHON="/usr/local/bin/python3.9" 
XDG_DATA_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CACHE_HOME=/wrkdirs/usr/ports/www/firefox/work/.cache  
HOME=/wrkdirs/usr/ports/www/firefox/work TMPDIR="/tmp" 
PATH=/wrkdirs/usr/ports/www/firefox/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
 
PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/www/firefox/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig
 SHELL=/bin/sh CONFIG_SHELL=/bin/sh CMAKE_PREFIX_PATH="/usr/local" 
LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8
--End CONFIGURE_ENV--

--MAKE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CACHE_HOME=/wrkdirs/usr/ports/www/firefox/work/.cache  
HOME=/wrkdirs/usr/ports/www/firefox/work TMPDIR="/tmp" 
PATH=/wrkdirs/usr/ports/www/firefox/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
 
PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/www/firefox/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig
 MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES 
LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 PREFIX=/usr/local  LOCALBASE=/usr/local  
CC="/usr/local/bin/clang15" CFLAGS="-O2 -pipe  -O3 -DLIBICONV_PLUG 
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing "  
CPP="/usr/local/bin/clang-cpp15" CPPFLAGS="-DLIBICONV_PLUG -isystem 
/usr/local/include"  LDFLAGS=" -Wl,--as-needed -fstack-protector-strong " 
LIBS="-L/usr/local/lib"  CXX="/usr/local/bin/clang++15" CXXFLAGS="-O2 -pipe -O3 
-D
LIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include 
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem 

[Bug 277021] www/firefox: error on start after updating to 123.0 (rc1, rc2)

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277021

--- Comment #69 from Tomoaki AOKI  ---
(In reply to Tatsuki Makino from comment #68)

I cannot understand why CPUTYPE causes ceil() and floor() is used or not.

Just a possibility, for slow and old CPUTYPEs, firefox has alternative, maybe
scale and int'ify then calculate as integer, and fp'fy with scaling again. If
it's correct, this problem can be happen, but really?!

Moreover, such a implementation should require guarded inclusion of math.h
using CPUTYPE and/or arch. If none, and if math.h is included regardless
directly or indirectly, blindly adding -lm option for the module should be
fine. Reading /usr/include/math.h, most of mathematic functions are defined as
usual prototype only, including sin(), atan(), ceil() and floor().

As, IIUC, C doesn't have specs to seek for function bodies which are not in
#include chain, inline them, and render to instruction which can do it
directly. So if there's only prototypes of needed function in the header file
included, corresponding library must be linked.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 277021] www/firefox: error on start after updating to 123.0 (rc1, rc2)

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277021

--- Comment #68 from Tatsuki Makino  ---
(In reply to Tomoaki AOKI from comment #66)

Perhaps so.
Looking a little more closely, first, the commands to which
/usr/local/lib/firefox/firefox is linked are as follows.
All seemingly unimportant parts were replaced with "...".

/usr/local/bin/clang++15 -std=gnu++17 -o ../../dist/bin/firefox ... -O2 -pipe
-march=haswell -O3 ... -funwind-tables
/wrkdirs/usr/ports/www/firefox/work/.build/browser/app/firefox.list -pthread
-Wl,--as-needed ... -fuse-ld=lld ... -rdynamic ... 
./../build/pure_virtual/libpure_virtual.a -pie  -L/usr/local/lib

There is no such thing as a -lm being added by CPUTYPE.
The link to libm relies completely on the behavior of clang++.

The resulting firefox binary will show the following differences in readelf -s.
Filtered and sorted by cut -w -f 9.

@@ -664,22 +664,10 @@
 _ZN7mozilla11Compression3LZ48compressEPKcmPc
 _ZN7mozilla11sse_private11aes_enabledE
 _ZN7mozilla11sse_private11aes_enabledE
-_ZN7mozilla11sse_private11avx_enabledE
-_ZN7mozilla11sse_private11avx_enabledE
-_ZN7mozilla11sse_private12avx2_enabledE
-_ZN7mozilla11sse_private12avx2_enabledE
 _ZN7mozilla11sse_private12fma3_enabledE
 _ZN7mozilla11sse_private12fma3_enabledE
-_ZN7mozilla11sse_private12sse3_enabledE
-_ZN7mozilla11sse_private12sse3_enabledE
 _ZN7mozilla11sse_private13sse4a_enabledE
 _ZN7mozilla11sse_private13sse4a_enabledE
-_ZN7mozilla11sse_private13ssse3_enabledE
-_ZN7mozilla11sse_private13ssse3_enabledE
-_ZN7mozilla11sse_private14sse4_1_enabledE
-_ZN7mozilla11sse_private14sse4_1_enabledE
-_ZN7mozilla11sse_private14sse4_2_enabledE
-_ZN7mozilla11sse_private14sse4_2_enabledE
 _ZN7mozilla11sse_private15avxvnni_enabledE
 _ZN7mozilla11sse_private15avxvnni_enabledE
 _ZN7mozilla11sse_private16has_constant_tscE
@@ -1915,8 +1903,6 @@
 bcmp@FBSD_1.0
 calloc
 calloc@FBSD_1.0
-ceil
-ceil@FBSD_1.0
 clock_getres
 clock_getres@FBSD_1.0
 clock_gettime
@@ -1957,8 +1943,6 @@
 fileno
 fileno@FBSD_1.0
 finalizer
-floor
-floor@FBSD_1.0
 fopen
 fopen@FBSD_1.0
 fprint_stderr

By leaving ceil and floor to what is in the CPU, it would mean that libm would
be unnecessary.

When pure_virtual is traced to where it comes from,
${WRCSRC}/build/pure_virtual/pure_virtual.c is reached.
But it is almost empty inside and I am not sure.
I suspect that ${WRKDIR}/.build/browser/app/firefox.list is involved in the
contents of this binary, but I am not sure.

Also, libgkcodecs.so link seems to use clang instead of clang++.
This would require explicitly linking libm with -lm, as already said.
A similar fix would be needed for all *.so that they received the undefined
symbol warning.

Is that a good rationale for applying the patch? :)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 277121] www/firefox: fails to build on /quarterly (2024Q1) due to libvpx < 1.14.0

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277121

Jan Beich  changed:

   What|Removed |Added

   Assignee|jbe...@freebsd.org  |ge...@freebsd.org
 CC||ge...@freebsd.org
Summary|multimedia/libvpx version   |www/firefox: fails to build
   |>= 1.14.0 needed for|on /quarterly (2024Q1) due
   |firefox-123.0_2,2 in ports  |to libvpx < 1.14.0
   |2024Q1  |
  Flags|maintainer-feedback?(jbeich |maintainer-feedback+,
   |@FreeBSD.org)   |maintainer-feedback?(gecko@
   ||FreeBSD.org)
   Keywords||regression

--- Comment #1 from Jan Beich  ---
ports 7659a22057ab forced libvpx 1.14.0 despite toolkit/moz.configure having
pkg_check_modules("MOZ_LIBVPX", "vpx >= 1.10.0"). While system libvpx (on
"main" branch or /latest set) is now ahead of the version bundled in Firefox
123 it may change soon (this year). For example, the last bundled libvpx update
was in Firefox 121 (not 123) per
https://bugzilla.mozilla.org/show_bug.cgi?id=1860623 which updated libvpx from
v1.13.1-490-g25a9a8e35 to v1.13.1-505-gb759032a0. About 1 month prior it was
v1.13.0-329-g19ec57e14 to v1.13.1-490-g25a9a8e35, 5 months prior it was
v1.13.0-217-g31b6d1289 to v1.13.0-329-g19ec57e14, 1 month prior it was
v1.13.0-182-g5b05f6f3a to v1.13.0-217-g31b6d1289, 1 month prior it was
v1.13.0-48-gbc2965ff7 to v1.13.0-182-g5b05f6f3a, 1 month prior it was
v1.12.0-267-g5c38ffbfa to v1.13.0-48-gbc2965ff7, etc.

I didn't backport ports 589aaaeb09b7 primarily due to ABI break and lack of
non-x86 testing. As https://portsfallout.com/fallout?port=multimedia%2Flibvpx
remained *silent* non-x86 are likely fine. libvpx upstream backported 1.14.0
security fixes into 1.13.1 which is already on /quarterly.

How to fix this is up to gecko@: either revert/adjust the version check or
backport libvpx 1.14.0 by fixing merge conflicts and doing limited QA on
/quarterly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


maintainer-feedback requested: [Bug 277121] www/firefox: fails to build on /quarterly (2024Q1) due to libvpx < 1.14.0

2024-02-17 Thread bugzilla-noreply
Jan Beich  has asked freebsd-gecko (Nobody)
 for maintainer-feedback:
Bug 277121: www/firefox: fails to build on /quarterly (2024Q1) due to libvpx <
1.14.0
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277121



--- Comment #1 from Jan Beich  ---
ports 7659a22057ab forced libvpx 1.14.0 despite toolkit/moz.configure having
pkg_check_modules("MOZ_LIBVPX", "vpx >= 1.10.0"). While system libvpx (on
"main" branch or /latest set) is now ahead of the version bundled in Firefox
123 it may change soon (this year). For example, the last bundled libvpx update
was in Firefox 121 (not 123) per
https://bugzilla.mozilla.org/show_bug.cgi?id=1860623 which updated libvpx from
v1.13.1-490-g25a9a8e35 to v1.13.1-505-gb759032a0. About 1 month prior it was
v1.13.0-329-g19ec57e14 to v1.13.1-490-g25a9a8e35, 5 months prior it was
v1.13.0-217-g31b6d1289 to v1.13.0-329-g19ec57e14, 1 month prior it was
v1.13.0-182-g5b05f6f3a to v1.13.0-217-g31b6d1289, 1 month prior it was
v1.13.0-48-gbc2965ff7 to v1.13.0-182-g5b05f6f3a, 1 month prior it was
v1.12.0-267-g5c38ffbfa to v1.13.0-48-gbc2965ff7, etc.

I didn't backport ports 589aaaeb09b7 primarily due to ABI break and lack of
non-x86 testing. As https://portsfallout.com/fallout?port=multimedia%2Flibvpx
remained *silent* non-x86 are likely fine. libvpx upstream backported 1.14.0
security fixes into 1.13.1 which is already on /quarterly.

How to fix this is up to gecko@: either revert/adjust the version check or
backport libvpx 1.14.0 by fixing merge conflicts and doing limited QA on
/quarterly.



[Bug 277021] www/firefox: error on start after updating to 123.0 (rc1, rc2)

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277021

--- Comment #67 from Nuno Teixeira  ---
Status: aarch64 (rpi4)

- main and poudriere jail @ 3733d82c4deb
- build from a cleaned pkgs poudriere
- `pkg delete -af` && install pkgs

`firefox`: same error as mentioned.

Rebuilding only firefox now with PR patch.
Tomorrow I will share results.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[package - 132arm64-quarterly][www/firefox] Failed for firefox-123.0_2,2 in build-depends

2024-02-17 Thread pkg-fallout
You are receiving this mail as a port that you maintain
is failing to build on the FreeBSD package build server.
Please investigate the failure and submit a PR to fix
build.

Maintainer: ge...@freebsd.org
Log URL:
https://pkg-status.freebsd.org/ampere1/data/132arm64-quarterly/b3e5282399eb/logs/firefox-123.0_2,2.log
Build URL:  
https://pkg-status.freebsd.org/ampere1/build.html?mastername=132arm64-quarterly=b3e5282399eb
Log:

=>> Building www/firefox
build started at Sat Feb 17 11:03:54 UTC 2024
port directory: /usr/ports/www/firefox
package name: firefox-123.0_2,2
building for: FreeBSD 132arm64-quarterly-job-13 13.2-RELEASE-p10 FreeBSD 
13.2-RELEASE-p10 arm64
maintained by: ge...@freebsd.org
Makefile datestamp: -rw-r--r--  1 root  wheel  2609 Feb 15 01:01 
/usr/ports/www/firefox/Makefile
Ports top last git commit: b3e528239
Ports top unclean checkout: no
Port dir last git commit: 3085d3b93
Port dir unclean checkout: no
Poudriere version: poudriere-git-3.4.1
Host OSVERSION: 156
Jail OSVERSION: 1302001
Job Id: 13

---Begin Environment---
SHELL=/bin/csh
OSVERSION=1302001
UNAME_v=FreeBSD 13.2-RELEASE-p10
UNAME_r=13.2-RELEASE-p10
BLOCKSIZE=K
MAIL=/var/mail/root
MM_CHARSET=UTF-8
LANG=C.UTF-8
STATUS=1
HOME=/root
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
MAKE_OBJDIR_CHECK_WRITABLE=0
LOCALBASE=/usr/local
USER=root
POUDRIERE_NAME=poudriere-git
LIBEXECPREFIX=/usr/local/libexec/poudriere
POUDRIERE_VERSION=3.4.1
MASTERMNT=/usr/local/poudriere/data/.m/132arm64-quarterly/ref
LC_COLLATE=C
POUDRIERE_BUILD_TYPE=bulk
PACKAGE_BUILDING=yes
SAVED_TERM=
OUTPUT_REDIRECTED_STDERR=4
OUTPUT_REDIRECTED=1
PWD=/usr/local/poudriere/data/.m/132arm64-quarterly/13/.p
OUTPUT_REDIRECTED_STDOUT=3
P_PORTS_FEATURES=FLAVORS SUBPACKAGES SELECTED_OPTIONS
MASTERNAME=132arm64-quarterly
SCRIPTPREFIX=/usr/local/share/poudriere
SCRIPTNAME=bulk.sh
OLDPWD=/usr/local/poudriere/data/.m/132arm64-quarterly/ref/.p/pool
POUDRIERE_PKGNAME=poudriere-git-3.4.1
SCRIPTPATH=/usr/local/share/poudriere/bulk.sh
POUDRIEREPATH=/usr/local/bin/poudriere
---End Environment---

---Begin Poudriere Port Flags/Env---
PORT_FLAGS=
PKGENV=
FLAVOR=
MAKE_ARGS=
---End Poudriere Port Flags/Env---

---Begin OPTIONS List---
===> The following configuration options are available for firefox-123.0_2,2:
 CANBERRA=off: Sound theme alerts
 DBUS=on: D-Bus IPC system support
 DEBUG=off: Build with debugging support
 FFMPEG=on: FFmpeg support (WMA, AIFF, AC3, APE...)
 LIBPROXY=off: Proxy support via libproxy
 LTO=off: Use Link-Time Optimization
 OPTIMIZED_CFLAGS=on: Use extra compiler optimizations
 PROFILE=on: Build with profiling support
 TEST=off: Build and/or run tests
> Extra cubeb audio backends (OSS is always available)
 ALSA=off: ALSA audio architecture support
 JACK=on: JACK audio server support
 PULSEAUDIO=on: PulseAudio sound server support
 SNDIO=on: Sndio audio support
===> Use 'make config' to modify these settings
---End OPTIONS List---

--MAINTAINER--
ge...@freebsd.org
--End MAINTAINER--

--CONFIGURE_ARGS--

--End CONFIGURE_ARGS--

--CONFIGURE_ENV--
BINDGEN_CFLAGS="-I/usr/local/include" MAKE=gmake PKG_CONFIG=pkgconf 
PYTHON="/usr/local/bin/python3.9" 
XDG_DATA_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CACHE_HOME=/wrkdirs/usr/ports/www/firefox/work/.cache  
HOME=/wrkdirs/usr/ports/www/firefox/work TMPDIR="/tmp" 
PATH=/wrkdirs/usr/ports/www/firefox/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
 
PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/www/firefox/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig
 SHELL=/bin/sh CONFIG_SHELL=/bin/sh CMAKE_PREFIX_PATH="/usr/local" 
LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8
--End CONFIGURE_ENV--

--MAKE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/www/firefox/work  
XDG_CACHE_HOME=/wrkdirs/usr/ports/www/firefox/work/.cache  
HOME=/wrkdirs/usr/ports/www/firefox/work TMPDIR="/tmp" 
PATH=/wrkdirs/usr/ports/www/firefox/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
 
PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/www/firefox/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig
 MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES 
LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 PREFIX=/usr/local  LOCALBASE=/usr/local  
CC="/usr/local/bin/clang15" CFLAGS="-O2 -pipe  -O3 -DLIBICONV_PLUG 
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing "  
CPP="/usr/local/bin/clang-cpp15" CPPFLAGS="-DLIBICONV_PLUG -isystem 
/usr/local/include"  LDFLAGS=" -Wl,--as-needed -fstack-protector-strong " 
LIBS="-L/usr/local/lib"  CXX="/usr/local/bin/clang++15" CXXFLAGS="-O2 -pipe -O3 
-D
LIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include 
-fno-strict-aliasing  -DLIBICONV_PLUG -isystem 

[Bug 277021] www/firefox: error on start after updating to 123.0 (rc1, rc2)

2024-02-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277021

--- Comment #66 from Tomoaki AOKI  ---
(In reply to Tatsuki Makino from comment #65)

According to math(3) manpage, lines including and below atan seems to be belong
to libm. So libm shoule be required regardless dropped lines for blank CPUTYPE
exist or not. (Need to resolve left unresolved symbols.)

Possobly, it could be a race condition, promissingly settled at build time.
For old CPUTYPE, libm is required by any of libraries other than the
problematic one, thus symbols can be resolved, but for newer CPUTYPE, added
instruction sets cause the problematic one to be loaded before any other
library require libm. Does it look reasonable?

Codecs would usually require libm like 2 examples below.

% ldd -a  /usr/local/lib/libvpx.so.9.0.0 
/usr/local/lib/libvpx.so.9.0.0:
libthr.so.3 => /lib/libthr.so.3 (0x2135faafd000)
libm.so.5 => /lib/libm.so.5 (0x2135fabb9000)
libc++.so.1 => /lib/libc++.so.1 (0x2135fb0e5000)
libcxxrt.so.1 => /lib/libcxxrt.so.1 (0x2135fb299000)
libc.so.7 => /lib/libc.so.7 (0x2135fbbf6000)
/lib/libthr.so.3:
libc.so.7 => /lib/libc.so.7 (0x2135fbbf6000)
/lib/libm.so.5:
libc.so.7 => /lib/libc.so.7 (0x2135fbbf6000)
/lib/libc++.so.1:
libcxxrt.so.1 => /lib/libcxxrt.so.1 (0x2135fb299000)
libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x2135fd6d1000)
libc.so.7 => /lib/libc.so.7 (0x2135fbbf6000)
/lib/libcxxrt.so.1:
libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x2135fd6d1000)
libc.so.7 => /lib/libc.so.7 (0x2135fbbf6000)
/lib/libgcc_s.so.1:
libc.so.7 => /lib/libc.so.7 (0x2135fbbf6000)
[preloaded]
[vdso] (0x2135f8f3e000)
% ldd -a  /usr/local/lib/libopus.so.0.9.0
/usr/local/lib/libopus.so.0.9.0:
libm.so.5 => /lib/libm.so.5 (0x1f58e8f1)
libc.so.7 => /lib/libc.so.7 (0x1f58e9727000)
/lib/libm.so.5:
libc.so.7 => /lib/libc.so.7 (0x1f58e9727000)
[preloaded]
[vdso] (0x1f58e87ae000)

-- 
You are receiving this mail because:
You are the assignee for the bug.