Re: [RFC][patch] dhclient Classless Static Routes support

2006-06-20 Thread Ed Maste
On Mon, Jun 19, 2006 at 09:26:12PM -0700, Brooks Davis wrote:

 On Sun, Jun 18, 2006 at 01:12:22PM +0400, Andrey V. Elsukov wrote:
  Hi!
  
  I have implemented RFC3442 support for the FreeBSD dhclient.
  Patch can be fetched from 
  http://butcher.heavennet.ru/patches/other/dhclient/
  
  I have a small bit of testing with isc-dhcpd and dnsmasqd. 
  And i think it works fine. I have tested with:
  1) Normal classless routes:  10.0.0.0/21 router, 10.1.0.0/19 router
  2) default route
  3) link routes: 192.168.0.0/24 0.0.0.0, 192.168.1.0/24 0.0.0.0
  
  I don't know what i should make with incorrect data received from DHCP 
  server..
 
 At a glance I don't see any major issues.  I won't have time to do
 anything more with it for at least a couple weeks.  I'd suggest filing
 a PR with it to ensure it isn't lost.  Ed, if you're interested in it,
 feel free to commit.

Hi Brooks.  I'll be testing this out shortly and plan to commit it soon.
One question I had for you was how we want to handle dhclient with
respect to OpenBSD -- I seem to recall that we've decided to own our
dhclient after the import.  So it would be advantageous if OpenBSD
decides to take the patch, but not necessary.

-ed
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: [RFC][patch] dhclient Classless Static Routes support

2006-06-19 Thread Brooks Davis
On Sun, Jun 18, 2006 at 01:12:22PM +0400, Andrey V. Elsukov wrote:
 Hi!
 
 I have implemented RFC3442 support for the FreeBSD dhclient.
 Patch can be fetched from 
 http://butcher.heavennet.ru/patches/other/dhclient/
 
 I have a small bit of testing with isc-dhcpd and dnsmasqd. 
 And i think it works fine. I have tested with:
 1) Normal classless routes:  10.0.0.0/21 router, 10.1.0.0/19 router
 2) default route
 3) link routes: 192.168.0.0/24 0.0.0.0, 192.168.1.0/24 0.0.0.0
 
 I don't know what i should make with incorrect data received from DHCP 
 server..

At a glance I don't see any major issues.  I won't have time to do
anything more with it for at least a couple weeks.  I'd suggest filing
a PR with it to ensure it isn't lost.  Ed, if you're interested in it,
feel free to commit.

The one thing I might worry about is that implementing classless static
routes means you have to ignore the default route and I'm a little
worried there might broken servers out there that spew bogus ones.
There's probably not way to find out other than shipping a release
though. :(

-- Brooks

-- 
Any statement of the form X is the one, true Y is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4


pgp9W6b8v0xIF.pgp
Description: PGP signature


[RFC][patch] dhclient Classless Static Routes support

2006-06-18 Thread Andrey V. Elsukov
Hi!

I have implemented RFC3442 support for the FreeBSD dhclient.
Patch can be fetched from 
http://butcher.heavennet.ru/patches/other/dhclient/

I have a small bit of testing with isc-dhcpd and dnsmasqd. 
And i think it works fine. I have tested with:
1) Normal classless routes:  10.0.0.0/21 router, 10.1.0.0/19 router
2) default route
3) link routes: 192.168.0.0/24 0.0.0.0, 192.168.1.0/24 0.0.0.0

I don't know what i should make with incorrect data received from DHCP server..

-- 
WBR, Andrey V. Elsukov
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to [EMAIL PROTECTED]