Re: CONF class of files

2011-06-22 Thread Chris Rees 
On 19 June 2011 10:14, Henrik Brix Andersen b...@freebsd.org wrote:
 On Jun 19, 2011, at 10:50, Chris Rees wrote:
 On 19 June 2011 09:15, Henrik Brix Andersen b...@freebsd.org wrote:

 On Jun 17, 2011, at 18:40, Chris Rees wrote:
 Macros are being tested for bsd.port.mk that use a new class of files,
 in the same vein as the BINOWN variables I have introduced CONFOWN,
 CONFGRP, CONFMODE and CONFDIR.

 Please would someone review and give an opinion on [1]?

 Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc?

 Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk where 
 we currently use some form of */etc/* - otherwise we will get a mismatch if 
 $CONFDIR is changed from the default.

 CONFDIR is for base, not ports, just like most other stuff in that
 file. Have a look at the other DIR variables.

 Gah, I was confused by you initial mail mentioning bsd.port.mk.

 Rereading the patch, I think it looks good. I'd love to see this go in before 
 9.0 as well.


Hey guys,

Now we've had a bit of interest in this PR, can someone please type
the magic words before the freeze?

Chris

http://www.freebsd.org/cgi/query-pr.cgi?pr=misc/157062
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org

Re: CONF class of files

2011-06-19 Thread Henrik Brix Andersen 
Hi Chris,

On Jun 17, 2011, at 18:40, Chris Rees wrote:
 Macros are being tested for bsd.port.mk that use a new class of files,
 in the same vein as the BINOWN variables I have introduced CONFOWN,
 CONFGRP, CONFMODE and CONFDIR.
 
 Please would someone review and give an opinion on [1]?

Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc?

Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk where we 
currently use some form of */etc/* - otherwise we will get a mismatch if 
$CONFDIR is changed from the default.

Brix
-- 
Henrik Brix Andersen b...@freebsd.org







PGP.sig
Description: This is a digitally signed message part

Re: CONF class of files

2011-06-19 Thread Chris Rees 
On 19 June 2011 09:15, Henrik Brix Andersen b...@freebsd.org wrote:
 Hi Chris,

 On Jun 17, 2011, at 18:40, Chris Rees wrote:
 Macros are being tested for bsd.port.mk that use a new class of files,
 in the same vein as the BINOWN variables I have introduced CONFOWN,
 CONFGRP, CONFMODE and CONFDIR.

 Please would someone review and give an opinion on [1]?

 Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc?

 Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk where we 
 currently use some form of */etc/* - otherwise we will get a mismatch if 
 $CONFDIR is changed from the default.



CONFDIR is for base, not ports, just like most other stuff in that
file. Have a look at the other DIR variables.

Chris
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org

Re: CONF class of files

2011-06-19 Thread Henrik Brix Andersen 
On Jun 19, 2011, at 10:50, Chris Rees wrote:
 On 19 June 2011 09:15, Henrik Brix Andersen b...@freebsd.org wrote:
 
 On Jun 17, 2011, at 18:40, Chris Rees wrote:
 Macros are being tested for bsd.port.mk that use a new class of files,
 in the same vein as the BINOWN variables I have introduced CONFOWN,
 CONFGRP, CONFMODE and CONFDIR.
 
 Please would someone review and give an opinion on [1]?
 
 Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc?
 
 Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk where 
 we currently use some form of */etc/* - otherwise we will get a mismatch if 
 $CONFDIR is changed from the default.
 
 CONFDIR is for base, not ports, just like most other stuff in that
 file. Have a look at the other DIR variables.

Gah, I was confused by you initial mail mentioning bsd.port.mk.

Rereading the patch, I think it looks good. I'd love to see this go in before 
9.0 as well.

Brix
-- 
Henrik Brix Andersen b...@freebsd.org







PGP.sig
Description: This is a digitally signed message part

Re: CONF class of files

2011-06-19 Thread Dieter BSD 
 CONFDIR is for base, not ports

Perhaps ${BASE_CONF_DIR}, ${PORTS_CONF_DIR}, ...
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org

Re: CONF class of files

2011-06-19 Thread Chris Rees 
On 19 June 2011 15:36, Dieter BSD dieter...@engineer.com wrote:
 CONFDIR is for base, not ports

 Perhaps ${BASE_CONF_DIR}, ${PORTS_CONF_DIR}, ...

Have a look at the surrounding code, it matches the other variables
that we have always used.

Please don't let this become a bikeshed!

Chris
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org

CONF class of files

2011-06-17 Thread Chris Rees 
Hi all,

Macros are being tested for bsd.port.mk that use a new class of files,
in the same vein as the BINOWN variables I have introduced CONFOWN,
CONFGRP, CONFMODE and CONFDIR.

Please would someone review and give an opinion on [1]?

I'd _really_ appreciate getting it in before 9-R

Chris

http://www.freebsd.org/cgi/query-pr.cgi?pr=misc/157062
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org

Re: CONF class of files

2011-06-17 Thread Warner Losh 
I like it.  I think we should get it in ASAP.

Warner

On Jun 17, 2011, at 10:40 AM, Chris Rees wrote:

 Hi all,
 
 Macros are being tested for bsd.port.mk that use a new class of files,
 in the same vein as the BINOWN variables I have introduced CONFOWN,
 CONFGRP, CONFMODE and CONFDIR.
 
 Please would someone review and give an opinion on [1]?
 
 I'd _really_ appreciate getting it in before 9-R
 
 Chris
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=misc/157062
 ___
 freebsd-hackers@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
 To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
 
 

___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org

Re: CONF class of files

2011-06-17 Thread Chris Rees 
On 17 Jun 2011 19:53, Warner Losh i...@bsdimp.com wrote:

 I like it.  I think we should get it in ASAP.

 Warner

You have a src bit ;)

Chris
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org