Re: indent bugfix / added features
On Mon, Jun 14, 2004 at 08:05:34AM -0500, Chip Norkus wrote: > > Followup: > > I was off most of the weekend, but I did find one bug and have > corrected it. The new patch can be found at > http://telekinesis.org/indent/indent.patch. I whipped up a simple > script to test it over /usr/src and that is at > http://telekinesis.org/indent/test.sh. I found that my patched version > (when run with no options) produced identical output to the existing > version. You should see what Bruce Evans <[EMAIL PROTECTED]> has to say -- he is the closest thing to a maintainer that indent has. -- Brian Fundakowski Feldman \'[ FreeBSD ]''\ <> [EMAIL PROTECTED] \ The Power to Serve! \ Opinions expressed are my own. \,,\ ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: indent bugfix / added features
On Tue Jun 15, 2004; 12:42AM +0200 Cyrille Lefevre propagated the following: > "Chip Norkus" <[EMAIL PROTECTED]> wrote > > > > I was off most of the weekend, but I did find one bug and have > > corrected it. The new patch can be found at > > http://telekinesis.org/indent/indent.patch. I whipped up a simple > > script to test it over /usr/src and that is at > > http://telekinesis.org/indent/test.sh. I found that my patched version > > (when run with no options) produced identical output to the existing > > version. > > > don't know if you submit a PR, if not, man send-pr. I have now. It is bin/67983. Thanks for the pointer. > > Cyrille Lefevre. > -- > home: mailto:[EMAIL PROTECTED] -chip -- personal: chip norkus; renaissance hacker;[EMAIL PROTECTED] work: systems engineer @ lunarpages, inc.;[EMAIL PROTECTED] info: finger [EMAIL PROTECTED] for plan or keys; http://telekinesis.org ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: indent bugfix / added features
"Chip Norkus" <[EMAIL PROTECTED]> wrote > > I was off most of the weekend, but I did find one bug and have > corrected it. The new patch can be found at > http://telekinesis.org/indent/indent.patch. I whipped up a simple > script to test it over /usr/src and that is at > http://telekinesis.org/indent/test.sh. I found that my patched version > (when run with no options) produced identical output to the existing > version. don't know if you submit a PR, if not, man send-pr. Cyrille Lefevre. -- home: mailto:[EMAIL PROTECTED] ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: indent bugfix / added features
Followup: I was off most of the weekend, but I did find one bug and have corrected it. The new patch can be found at http://telekinesis.org/indent/indent.patch. I whipped up a simple script to test it over /usr/src and that is at http://telekinesis.org/indent/test.sh. I found that my patched version (when run with no options) produced identical output to the existing version. -chip -- personal: chip norkus; renaissance hacker;[EMAIL PROTECTED] work: systems engineer @ lunarpages, inc.;[EMAIL PROTECTED] info: finger [EMAIL PROTECTED] for plan or keys; http://telekinesis.org ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: indent bugfix / added features
On Fri Jun 11, 2004; 04:07PM +0200 Jens Schweikhardt propagated the following: > > I'm willing to commit this if you could demonstrate that it will not > produce different output in the default case than it does now. Say, > run the old an new versions against the FreeBSD src tree and make a diff > which should vanish apart from the bug-fixing effects. If you want to > make yourself known as a quality software engineer, do the same for > various sets of indent options :-) > Hi, Thanks! I'll give it a run against a significant stack of code today and let you know. If anyone else is willing to test it out as well that would be extremely helpful. > Regards, > > Jens > -- > Jens Schweikhardt http://www.schweikhardt.net/ > SIGSIG -- signature too long (core dumped) -chip -- personal: chip norkus; renaissance hacker;[EMAIL PROTECTED] work: systems engineer @ lunarpages, inc.;[EMAIL PROTECTED] info: finger [EMAIL PROTECTED] for plan or keys; http://telekinesis.org ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: indent bugfix / added features
On Fri, Jun 11, 2004 at 05:20:19PM +0200, Jens Schweikhardt wrote: ... > Sigh. A request for a little bit of QA and an emoticon as well and > I'm criticised. I remember when I was not yet a committer that the > better I could demonstrate that the code has no ill-effect the more > chances some committer would bring it in the tree. yeah but that's not a reason to give the same 'treatment' to other people. In the end, if you don't feel like taking the risk, you don't commit the patch and nobody will blame you. > I've looked at too many "innocous" patches that performed unexpectedly > when run, to not let myself get away with this. Of course this may be i am not trying to discuss general principles, but only this specific case. This is a very small patch and you can easily check it while you type/paste it in (if nothing else just for curiosity on what was the problem and how was it fixed). In the end, if you don't feel like taking the risk, you don't commit the patch; nobody will blame you. > No hard feelings, Luigi :-) nor on my side! I was just trying to make a point that we should not try to scare or annoy people who are so kind to contribute patches just because we don't have time to scrutinize them (which in the end is our responsibility, not theirs). I wouldn't have said a word if you had some actual comments/criticism on the contributed code. Even if they were only style issues (which we shouldn't even bother to criticise in these cases, as they can be trivially fixed at commit time). But asking for "more input or i won't even look at your code" (at least, that was the sense one could perceive) was a bit too much... cheers luigi ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: indent bugfix / added features
On Fri, Jun 11, 2004 at 07:26:15AM -0700, Luigi Rizzo wrote: # On Fri, Jun 11, 2004 at 04:07:40PM +0200, Jens Schweikhardt wrote: # > On Thu, Jun 10, 2004 at 09:53:07PM -0500, Chip Norkus wrote: # ... # > # normalize the code a bit. In doing so I discovered a few deficencies in # > # the stock FreeBSD (5.2-CURRENT) indent and decided to fix them, I # > # thought these might be fairly common wishes (and one of them is a # > # bugfix) and have attached a patch which does the following: # ... # > # I don't know if anyone would be interested in committing the bugfix (I # > # believe it is correct) or added features, but I hope someone else finds # > # this useful. # ... # > I'm willing to commit this if you could demonstrate that it will not # > produce different output in the default case than it does now. Say, # > run the old an new versions against the FreeBSD src tree and make a diff # > which should vanish apart from the bug-fixing effects. If you want to # > make yourself known as a quality software engineer, do the same for # > various sets of indent options :-) # # ?? this sounds like an absurd request, please... Sigh. A request for a little bit of QA and an emoticon as well and I'm criticised. I remember when I was not yet a committer that the better I could demonstrate that the code has no ill-effect the more chances some committer would bring it in the tree. # First, for a small patch like this you are much better off looking # at the source code diffs rather than checking the output in a # necessarily small set of test cases. I've looked at too many "innocous" patches that performed unexpectedly when run, to not let myself get away with this. Of course this may be because I'm not a good C programmer. # Second, either you trust the author (in which case his statement # "I believe is correct" is all you need), or you don't, in which # case you'd have to check the patch yourself in whatever way you # believe suitable. Either way, I don't see how the additional # tests you are asking for would change your behaviour. They'd improve my confidence of not having to backout someone else's patch. I was making my proposal on the premise that doing this test would not be very difficult or time consuming, and that the author, who apparently used indent a lot, would know better where potential pitfalls are (like option combos). If I can get any other committer's opinion saying "go ahead, commit", that's fine and I'll get to it ASAP. No hard feelings, Luigi :-) Regards, Jens -- Jens Schweikhardt http://www.schweikhardt.net/ SIGSIG -- signature too long (core dumped) ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: indent bugfix / added features
On Fri, Jun 11, 2004 at 04:07:40PM +0200, Jens Schweikhardt wrote: > On Thu, Jun 10, 2004 at 09:53:07PM -0500, Chip Norkus wrote: ... > # normalize the code a bit. In doing so I discovered a few deficencies in > # the stock FreeBSD (5.2-CURRENT) indent and decided to fix them, I > # thought these might be fairly common wishes (and one of them is a > # bugfix) and have attached a patch which does the following: ... > # I don't know if anyone would be interested in committing the bugfix (I > # believe it is correct) or added features, but I hope someone else finds > # this useful. ... > I'm willing to commit this if you could demonstrate that it will not > produce different output in the default case than it does now. Say, > run the old an new versions against the FreeBSD src tree and make a diff > which should vanish apart from the bug-fixing effects. If you want to > make yourself known as a quality software engineer, do the same for > various sets of indent options :-) ?? this sounds like an absurd request, please... First, for a small patch like this you are much better off looking at the source code diffs rather than checking the output in a necessarily small set of test cases. Second, either you trust the author (in which case his statement "I believe is correct" is all you need), or you don't, in which case you'd have to check the patch yourself in whatever way you believe suitable. Either way, I don't see how the additional tests you are asking for would change your behaviour. cheers luigi ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: indent bugfix / added features
On Thu, Jun 10, 2004 at 09:53:07PM -0500, Chip Norkus wrote:
#
# Hi all,
#
# I've been working on a major project, and decided to use indent to
# normalize the code a bit. In doing so I discovered a few deficencies in
# the stock FreeBSD (5.2-CURRENT) indent and decided to fix them, I
# thought these might be fairly common wishes (and one of them is a
# bugfix) and have attached a patch which does the following:
# * Adds an option to control tab use in output code (-ut and -nut)
# (This is in the GNU indent)
# * Adds an option to control brace placement after function declaration
# (-fbs and -nfbs). What this does, specifically, is allow you to have
# indent produce 'func(args..) {' instead of 'func(args..)\n{'. The old
# behavior is the default.
# * Fixes the indent bug when aligning variable names with an indentation
# level that is not a multiple of 8. This works for both the 'tab use'
# and 'no tab use' varieties of code output.
#
# I don't know if anyone would be interested in committing the bugfix (I
# believe it is correct) or added features, but I hope someone else finds
# this useful.
#
# -chip
I'm willing to commit this if you could demonstrate that it will not
produce different output in the default case than it does now. Say,
run the old an new versions against the FreeBSD src tree and make a diff
which should vanish apart from the bug-fixing effects. If you want to
make yourself known as a quality software engineer, do the same for
various sets of indent options :-)
Regards,
Jens
--
Jens Schweikhardt http://www.schweikhardt.net/
SIGSIG -- signature too long (core dumped)
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
