Re: cleanup and diffs ?

2005-05-03 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]>
Kris Kennaway <[EMAIL PROTECTED]> writes:
: it.  This can be nontrivial.  Also, Dragonfly doesn't have to worry
: about any other architectures than i386, so it's possible that they
: haven't "really" fixed many of these warnings (i.e. they might still
: be there on a 64-bit platform).

Lord knows in the past how many tinderbox breakages we've had in the
tree because someone "fixed" all the warnings at level 6, but in fact
broke 64 bit ports...

Warner
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: cleanup and diffs ?

2005-05-03 Thread Kris Kennaway
On Tue, May 03, 2005 at 10:38:37PM +, Thordur I. Bjornsson wrote:
> Hello.
> 
> I was surfing the dragonflybsd wiki site the other day and found out
> that they are doing a "base-cleanup". That is they are compiling the
> tools that come with the base system with WARNS?=6 ...
> 
> Humm... This is something that I could do.. Minor cleanup (since I'm no
> C expert or a OS developer ;) this fits my skillset just fine.
> 
> Now I have two questions is this something that will be appriciated by
> someone ? (that is would this clean-up if done properly find its way to
> the tree ?... nobody likes going through "trouble" like this when it
> will have no affect ;). If so.. what is the diff format that is expected
> (diff -crN ?) and should this be sent via send-pr(1) ?
> 
> I know that a ,,clean-up'' like this is propably not high on the todo
> list for FreeBSD but.. for me this would be an easy way to contribute
> something back since I have no skill to work in the kernel &c.

You need to understand how to fix the warnings properly..it isn't just
a matter of making random changes until gcc stops complaining about
it.  This can be nontrivial.  Also, Dragonfly doesn't have to worry
about any other architectures than i386, so it's possible that they
haven't "really" fixed many of these warnings (i.e. they might still
be there on a 64-bit platform).

Kris


pgp03VLHskpAZ.pgp
Description: PGP signature


cleanup and diffs ?

2005-05-03 Thread Thordur I. Bjornsson
Hello.

I was surfing the dragonflybsd wiki site the other day and found out
that they are doing a "base-cleanup". That is they are compiling the
tools that come with the base system with WARNS?=6 ...

Humm... This is something that I could do.. Minor cleanup (since I'm no
C expert or a OS developer ;) this fits my skillset just fine.

Now I have two questions is this something that will be appriciated by
someone ? (that is would this clean-up if done properly find its way to
the tree ?... nobody likes going through "trouble" like this when it
will have no affect ;). If so.. what is the diff format that is expected
(diff -crN ?) and should this be sent via send-pr(1) ?

I know that a ,,clean-up'' like this is propably not high on the todo
list for FreeBSD but.. for me this would be an easy way to contribute
something back since I have no skill to work in the kernel &c.

-- 
Thordur I.  <[EMAIL PROTECTED]>
FreeBSD - Unix the way *I* like it.
A man can do as he will, but not will as he will.
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[EMAIL PROTECTED]"