Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp
The following reply was made to PR kern/177948; it has been noted by GNATS. From: Ian Smith smi...@nimnet.asn.au To: bug-follo...@freebsd.org, j...@oxit.fi Cc: Subject: Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp Date: Tue, 18 Feb 2014 02:43:21 +1100 Having been determined not to be an ipfw problem, could this be closed? If still an open clang issue, Jukka or somebody might reopen it there. cheers, Ian ___ freebsd-ipfw@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw To unsubscribe, send any mail to freebsd-ipfw-unsubscr...@freebsd.org
Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp
The following reply was made to PR kern/177948; it has been noted by GNATS. From: Jukka Ukkonen j...@oxit.fi To: Ian Smith smi...@nimnet.asn.au Cc: bug-follo...@freebsd.org Subject: Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp Date: Sun, 21 Apr 2013 14:33:07 +0300 On 04/21/13 05:17, Ian Smith wrote: I can't reproduce this on 9.1-RELEASE, unless I put a space anywhere amongst p1, '-' and p2, in which case I see the same error you show. # ipfw add 03011 deny log udp from any to any 1024-65535 in recv fxp0 03011 deny log udp from any to any dst-port 1024-65535 in recv fxp0 # ipfw list 3011 03011 deny log udp from any to any dst-port 1024-65535 in recv fxp0 # ipfw add 03011 deny log udp from any to any 1024 -65535 in recv fxp0 ipfw: unrecognised option [-1] -65535 # ipfw add 03011 deny log udp from any to any 1024- 65535 in recv fxp0 ipfw: unrecognised option [-1] 1024- Can you verify that there is no whitespace (obvious, or perhaps some non-printing character?) on or near line 7368 of your config file? If that looks ok, can you show the byte offset of that line in your file, for example by placing that line at the bottom of the screen in less(1) then pressing '='? cheers, Ian Right, After some further inspection I have news... This seems to be a problem in clang-cpp which adds an extra space before the dash in a macro which should have a value of the format number1-number2. So, e.g. 1024-65535 becomes 1024 -65535. If I use gcpp instead, everything works just fine with ipfw. The fact that I did not see this happening with TCP rules as well was just lucky coincidence. So, this is a clang problem, not an ipfw problem!!! Cheers, --jau ___ freebsd-ipfw@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw To unsubscribe, send any mail to freebsd-ipfw-unsubscr...@freebsd.org
Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp
The following reply was made to PR kern/177948; it has been noted by GNATS. From: Ian Smith smi...@nimnet.asn.au To: Jukka Ukkonen j...@oxit.fi Cc: bug-follo...@freebsd.org Subject: Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp Date: Sun, 21 Apr 2013 22:21:06 +1000 (EST) On Sun, 21 Apr 2013 14:33:07 +0300, Jukka Ukkonen wrote: On 04/21/13 05:17, Ian Smith wrote: I can't reproduce this on 9.1-RELEASE, unless I put a space anywhere amongst p1, '-' and p2, in which case I see the same error you show. [..] Right, After some further inspection I have news... This seems to be a problem in clang-cpp which adds an extra space before the dash in a macro which should have a value of the format number1-number2. So, e.g. 1024-65535 becomes 1024 -65535. Naughty clang! For one thing, that's emitting two values .. If I use gcpp instead, everything works just fine with ipfw. The fact that I did not see this happening with TCP rules as well was just lucky coincidence. So, this is a clang problem, not an ipfw problem!!! Cheers, --jau Good news for ipfw, anyway. I don't know the correct form .. should this PR be reassigned, or closed with a reference in a fresh clang PR? cheers, Ian ___ freebsd-ipfw@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw To unsubscribe, send any mail to freebsd-ipfw-unsubscr...@freebsd.org
Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp
The following reply was made to PR kern/177948; it has been noted by GNATS. From: Jukka Ukkonen j...@oxit.fi To: Ian Smith smi...@nimnet.asn.au Cc: bug-follo...@freebsd.org Subject: Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp Date: Sun, 21 Apr 2013 15:33:03 +0300 On 04/21/13 15:21, Ian Smith wrote: On Sun, 21 Apr 2013 14:33:07 +0300, Jukka Ukkonen wrote: On 04/21/13 05:17, Ian Smith wrote: I can't reproduce this on 9.1-RELEASE, unless I put a space anywhere amongst p1, '-' and p2, in which case I see the same error you show. [..] Right, After some further inspection I have news... This seems to be a problem in clang-cpp which adds an extra space before the dash in a macro which should have a value of the format number1-number2. So, e.g. 1024-65535 becomes 1024 -65535. Naughty clang! For one thing, that's emitting two values .. If I use gcpp instead, everything works just fine with ipfw. The fact that I did not see this happening with TCP rules as well was just lucky coincidence. So, this is a clang problem, not an ipfw problem!!! Cheers, --jau Good news for ipfw, anyway. I don't know the correct form .. should this PR be reassigned, or closed with a reference in a fresh clang PR? cheers, Ian Please, try reassigning first. This is anyhow a pretty clear issue. If the clang experts then wish to have a separate fresh PR for clang, they can close this one and request a new PR. Cheers, --jau ___ freebsd-ipfw@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw To unsubscribe, send any mail to freebsd-ipfw-unsubscr...@freebsd.org
Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp
The following reply was made to PR kern/177948; it has been noted by GNATS. From: Ian Smith smi...@nimnet.asn.au To: bug-follo...@freebsd.org, j...@oxit.fi Cc: Subject: Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp Date: Sun, 21 Apr 2013 12:17:12 +1000 I can't reproduce this on 9.1-RELEASE, unless I put a space anywhere amongst p1, '-' and p2, in which case I see the same error you show. # ipfw add 03011 deny log udp from any to any 1024-65535 in recv fxp0 03011 deny log udp from any to any dst-port 1024-65535 in recv fxp0 # ipfw list 3011 03011 deny log udp from any to any dst-port 1024-65535 in recv fxp0 # ipfw add 03011 deny log udp from any to any 1024 -65535 in recv fxp0 ipfw: unrecognised option [-1] -65535 # ipfw add 03011 deny log udp from any to any 1024- 65535 in recv fxp0 ipfw: unrecognised option [-1] 1024- Can you verify that there is no whitespace (obvious, or perhaps some non-printing character?) on or near line 7368 of your config file? If that looks ok, can you show the byte offset of that line in your file, for example by placing that line at the bottom of the screen in less(1) then pressing '='? cheers, Ian ___ freebsd-ipfw@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw To unsubscribe, send any mail to freebsd-ipfw-unsubscr...@freebsd.org
