RE: kern/180791: [ofed] [patch] Kernel crash on ifdown and kldunload mlxen
The following reply was made to PR kern/180791; it has been noted by GNATS.
From: Shahar Klein shah...@mellanox.com
To: John Baldwin j...@freebsd.org, bug-follo...@freebsd.org
bug-follo...@freebsd.org
Cc: Oded Shanoon od...@mellanox.com
Subject: RE: kern/180791: [ofed] [patch] Kernel crash on ifdown and
kldunload mlxen
Date: Mon, 29 Jul 2013 06:46:37 +
Thanks John,
I've reviewed and tested this patch and it's working fine.
Is this patch going to both 10.0 and 9.2?
10x
Shahar
-Original Message-
From: John Baldwin [mailto:j...@freebsd.org]=20
Sent: Thursday, July 25, 2013 10:39 PM
To: bug-follo...@freebsd.org; Shahar Klein
Subject: Re: kern/180791: [ofed] [patch] Kernel crash on ifdown and kldunlo=
ad mlxen
Thanks. One note is that it seems like the state_lock should be held when =
stop is called. Also, the callout used for stats should be drained during =
detach. (If you use callot_init_mtx() instead of callout_init() then
callout_stop() under the lock is race-free, though I'd still do the
callout_drain() during detach to be safe.)
Also, I had some other changes I made to this file to make the locking more=
consistent with other NIC drivers in the tree. Can you look at this and t=
est this patch please?
Index: en_netdev.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- en_netdev.c(revision 253547)
+++ en_netdev.c(working copy)
@@ -495,11 +495,6 @@ static void mlx4_en_do_get_stats(struct work_struc
=20
queue_delayed_work(mdev-workqueue, priv-stats_task,
STATS_DELAY);
}
- if (mdev-mac_removed[MLX4_MAX_PORTS + 1 - priv-port]) {
- panic(mlx4_en_do_get_stats: Unexpected mac removed for %d\n,
- priv-port);
- mdev-mac_removed[MLX4_MAX_PORTS + 1 - priv-port] =3D 0;
- }
mutex_unlock(mdev-state_lock);
}
=20
@@ -688,8 +683,8 @@ int mlx4_en_start_port(struct net_device *dev)
mlx4_en_set_multicast(dev);
=20
/* Enable the queues. */
- atomic_clear_int(dev-if_drv_flags, IFF_DRV_OACTIVE);
- atomic_set_int(dev-if_drv_flags, IFF_DRV_RUNNING);
+ dev-if_drv_flags =3D ~IFF_DRV_OACTIVE;
+ dev-if_drv_flags |=3D IFF_DRV_RUNNING;
=20
callout_reset(priv-watchdog_timer, MLX4_EN_WATCHDOG_TIMEOUT,
mlx4_en_watchdog_timeout, priv);
@@ -761,7 +756,7 @@ void mlx4_en_stop_port(struct net_device *dev)
=20
callout_stop(priv-watchdog_timer);
=20
- atomic_clear_int(dev-if_drv_flags, IFF_DRV_RUNNING);
+ dev-if_drv_flags =3D ~(IFF_DRV_RUNNING | IFF_DRV_OACTIVE);
}
=20
static void mlx4_en_restart(struct work_struct *work) @@ -802,19 +797,30 @=
@ mlx4_en_init(void *arg) {
struct mlx4_en_priv *priv;
struct mlx4_en_dev *mdev;
+
+ priv =3D arg;
+ mdev =3D priv-mdev;
+ mutex_lock(mdev-state_lock);
+ mlx4_en_init_locked(priv);
+ mutex_unlock(mdev-state_lock);
+}
+
+static void
+mlx4_en_init_locked(struct mlx4_en_priv *priv) {
+
+ struct mlx4_en_dev *mdev;
struct ifnet *dev;
int i;
=20
- priv =3D arg;
dev =3D priv-dev;
mdev =3D priv-mdev;
- mutex_lock(mdev-state_lock);
if (dev-if_drv_flags IFF_DRV_RUNNING)
mlx4_en_stop_port(dev);
=20
if (!mdev-device_up) {
en_err(priv, Cannot open - device down/disabled\n);
- goto out;
+ return;
}
=20
/* Reset HW statistics and performance counters */ @@ -835,9 +841,6 @@
ml=
x4_en_init(void *arg)
mlx4_en_set_default_moderation(priv);
if (mlx4_en_start_port(dev))
en_err(priv, Failed starting port:%d\n, priv-port);
-
-out:
- mutex_unlock(mdev-state_lock);
}
=20
void mlx4_en_free_resources(struct mlx4_en_priv *priv) @@ -927,9 +930,14 @=
@ void mlx4_en_destroy_netdev(struct net_device *dev
if (priv-sysctl)
sysctl_ctx_free(priv-conf_ctx);
=20
+ mutex_lock(mdev-state_lock);
+ mlx4_en_stop_port(dev);
+ mutex_unlock(mdev-state_lock);
+
cancel_delayed_work(priv-stats_task);
/* flush any pending task for this netdev */
flush_workqueue(mdev-workqueue);
+ callout_drain(priv-watchdog_timer);
=20
/* Detach the netdev so tasks would not attempt to access it */
mutex_lock(mdev-state_lock);
@@ -1091,25 +1099,25 @@ static int mlx4_en_ioctl(struct ifnet *dev, u_long
error =3D -mlx4_en_change_mtu(dev, ifr-ifr_mtu);
break;
case SIOCSIFFLAGS:
+ mutex_lock(mdev-state_lock);
if (dev-if_flags IFF_UP) {
- if ((dev-if_drv_flags IFF_DRV_RUNNING) =3D=3D 0) {
-
MTP2/Q.703/SS7 cards
Is there any hardware or support for MTP2/Q.703/SS7 line protocols in FreeBSD? I'm wanting to use FreeBSD to analyze FISUs and MSUs from a Q.703 stream. I don't know if this is a network or just just a TCP/IP email list, so sorry in advance if it's TCP/IP only. -- James Gosnell, ACP ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: netmap receiver crashes driver on exit
Hi Alex, We found a similar crash on our system, not sure of the cause yet; but did you find any solution for this? Thanks -- View this message in context: http://freebsd.1045724.n5.nabble.com/netmap-receiver-crashes-driver-on-exit-tp5827571p5832237.html Sent from the freebsd-net mailing list archive at Nabble.com. ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: Recommendations for 10gbps NIC
On Fri, 26 Jul 2013 15:14:17 -0700 (PDT) Barney Cordoba barney_cord...@yahoo.com wrote about Re: Recommendations for 10gbps NIC: BC I don't really understand why nearly all 10GBE cards are dual-port. BC Surely there is a market for NICs between 1 gigabit and 20 gigabit. Myricom has single port 10G cards. However, I only use them on Linux and cannot comment on FreeBSD usage here. cu Gerrit ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: netmap receiver crashes driver on exit
On 29.07.2013 13:14, vishal kumar wrote: Hi Alex, We found a similar crash on our system, not sure of the cause yet; but did you find any solution for this? Well, currently I'm using the following workaround: http://static.ipfw.ru/patches/netmap_intel.diff Thanks -- View this message in context: http://freebsd.1045724.n5.nabble.com/netmap-receiver-crashes-driver-on-exit-tp5827571p5832237.html Sent from the freebsd-net mailing list archive at Nabble.com. ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Current problem reports assigned to freebsd-net@FreeBSD.org
Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description o kern/180844 net[panic] [re] Intermittent panic (re driver?) o kern/180791 net[ofed] [patch] Kernel crash on ifdown and kldunload ml o kern/180775 net[bxe] if_bxe driver broken with Broadcom BCM57711 card o kern/180722 net[bluetooth] bluetooth takes 30-50 attempts to pair to s kern/180468 net[request] LOCAL_PEERCRED support for PF_INET o kern/180065 net[netinet6] [patch] Multicast loopback to own host brok p kern/179975 net[igb] igb(4) fails to do polling(4) o kern/179926 net[lacp] [patch] active aggregator selection bug o kern/179824 net[ixgbe] System (9.1-p4) hangs on heavy ixgbe network t o kern/179733 net[lagg] [patch] interface loses capabilities when proto o kern/179429 net[tap] STP enabled tap bridge o kern/179299 net[igb] Intel X540-T2 - unstable driver a kern/179264 net[vimage] [pf] Core dump with Packet filter and VIMAGE o kern/178947 net[arp] arp rejecting not working o kern/178782 net[ixgbe] 82599EB SFP does not work with passthrough und o kern/178612 net[run] kernel panic due the problems with run driver o kern/178472 net[ip6] [patch] make return code consistent with IPv4 co o kern/178079 net[tcp] Switching TCP CC algorithm panics on sparc64 wit s kern/178071 netFreeBSD unable to recongize Kontron (Industrial Comput o kern/177905 net[xl] [panic] ifmedia_set when pluging CardBus LAN card o kern/177618 net[bridge] Problem with bridge firewall with trunk ports o kern/177417 net[ip6] Invalid protocol value in ipsec6_common_input_cb o kern/177402 net[igb] [pf] problem with ethernet driver igb + pf / alt o kern/177400 net[jme] JMC25x 1000baseT establishment issues o kern/177366 net[ieee80211] negative malloc(9) statistics for 80211nod f kern/177362 net[netinet] [patch] Wrong control used to return TOS o kern/177194 net[netgraph] Unnamed netgraph nodes for vlan interfaces o kern/177139 net[igb] igb drops ethernet ports 2 and 3 o kern/176884 net[re] re0 flapping up/down o kern/176671 net[epair] MAC address for epair device not unique o kern/176484 net[ipsec] [enc] [patch] panic: IPsec + enc(4); device na o kern/176446 net[netinet] [patch] Concurrency in ixgbe driving out-of- o kern/176420 net[kernel] [patch] incorrect errno for LOCAL_PEERCRED o kern/176419 net[kernel] [patch] socketpair support for LOCAL_PEERCRED o kern/176401 net[netgraph] page fault in netgraph o kern/176167 net[ipsec][lagg] using lagg and ipsec causes immediate pa o kern/176097 net[lagg] [patch] lagg/lacp broken when aggregated interf o kern/176027 net[em] [patch] flow control systcl consistency for em dr o kern/176026 net[tcp] [patch] TCP wrappers caused quite a lot of warni o bin/175974 netppp(8): logic issue o kern/175864 net[re] Intel MB D510MO, onboard ethernet not working aft o kern/175852 net[amd64] [patch] in_cksum_hdr() behaves differently on o kern/175734 netno ethernet detected on system with EG20T PCH chipset o kern/175267 net[pf] [tap] pf + tap keep state problem o kern/175236 net[epair] [gif] epair and gif Devices On Bridge o kern/175182 net[panic] kernel panic on RADIX_MPATH when deleting rout o kern/175153 net[tcp] will there miss a FIN when do TSO? o kern/174959 net[net] [patch] rnh_walktree_from visits spurious nodes o kern/174958 net[net] [patch] rnh_walktree_from makes unreasonable ass o kern/174897 net[route] Interface routes are broken o kern/174851 net[bxe] [patch] UDP checksum offload is wrong in bxe dri o kern/174850 net[bxe] [patch] bxe driver does not receive multicasts o kern/174849 net[bxe] [patch] bxe driver can hang kernel when reset o kern/174822 net[tcp] Page fault in tcp_discardcb under high traffic o kern/174602 net[gif] [ipsec] traceroute issue on gif tunnel with ipse o kern/174535 net[tcp] TCP fast retransmit feature works strange o kern/173871 net[gif] process of 'ifconfig gif0 create hangs' when if_ o kern/173475 net[tun] tun(4) stays opened by PID after process is term o kern/173201 net[ixgbe] [patch] Missing / broken ixgbe sysctl's and tu o kern/173137 net[em] em(4) unable to run at gigabit with 9.1-RC2 o kern/173002 net[patch] data type size
Re: Recommendations for 10gbps NIC
On Fri, 26 Jul 2013 15:14:17 -0700 (PDT) Barney Cordoba barney_cord...@yahoo.com wrote about Re: Recommendations for 10gbps NIC: BC I don't really understand why nearly all 10GBE cards are dual-port. BC Surely there is a market for NICs between 1 gigabit and 20 gigabit. Myricom has single port 10G cards. However, I only use them on Linux and cannot comment on FreeBSD usage here. cu Gerrit I didn't write/ask that; But intel makes a single port x540 card thats available through popular online outlets. BC ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/92270: [ppp]: ppp does not work on renamed network interfaces
Synopsis: [ppp]: ppp does not work on renamed network interfaces Responsible-Changed-From-To: avg-freebsd-net@FreeBSD.org Responsible-Changed-By: avg Responsible-Changed-When: Mon Jul 29 14:30:44 UTC 2013 Responsible-Changed-Why: Return to the pool. I don't know why this PR was assigned to me and what to do with it. http://www.freebsd.org/cgi/query-pr.cgi?pr=92270 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
*
Добрый день! Предлагаю сим карту для отдыхающих за границей звонки в Россию от 4,8 рублей. Срок действия карты неограничен, без абонентской платы. Подскажите, какой у Вас сотовый оператор, чтобы я могла уточнить сможете ли Вы привязать свой мобильный номер к новой сим карте? PS Могу сделать не только для Турции. с уважением, Людмила ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/180791: [ofed] [patch] Kernel crash on ifdown and kldunload mlxen
Synopsis: [ofed] [patch] Kernel crash on ifdown and kldunload mlxen State-Changed-From-To: open-patched State-Changed-By: jhb State-Changed-When: Mon Jul 29 18:49:12 UTC 2013 State-Changed-Why: Patch committed to HEAD, thanks! Responsible-Changed-From-To: freebsd-net-jhb Responsible-Changed-By: jhb Responsible-Changed-When: Mon Jul 29 18:49:12 UTC 2013 Responsible-Changed-Why: Patch committed to HEAD, thanks! http://www.freebsd.org/cgi/query-pr.cgi?pr=180791 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: bce(4) panics, 9.2rc1 [redux]
On Wed, 2013-07-24 at 14:07 -0700, Sean Bruno wrote: Running 9.2 in production load mail servers. We're hitting the watchdog message and crashing with the stable/9 version. We're reverting the change from 2 weeks ago and seeing if it still happens. We didn't see this from stable/9 from about a month ago. Sean Not seeing any changes to core dumps, or crashes after updating the bce(4) interface on these Dell R410s. IPMI was a definite false hope. No changes noted after I modified the ipmi_attach code. stable/7 works just fine and stable/9 fails with NMI erros on the console very badly. It fails so badly that it won't come into service at all. I've reverted stable/9 back to august of 2012 with no changes. It sort of looks like r236216 is causing severe issues with my configuration. The Dell R410 has a 3rd ethernet interface for the BMC only, not sure if that is meaningful in this context. The 3rd interface is *not* visible from the o/s and is dedicated to the BMC interface. Doing more testing at this time to validate. Sean http://svnweb.freebsd.org/base?view=revisionrevision=236216 signature.asc Description: This is a digitally signed message part
Re: bce(4) panics, 9.2rc1 [redux]
From: Sean Bruno sean_br...@yahoo.com To: freebsd-net@freebsd.org freebsd-net@freebsd.org Sent: Monday, July 29, 2013 8:56 PM Subject: Re: bce(4) panics, 9.2rc1 [redux] On Wed, 2013-07-24 at 14:07 -0700, Sean Bruno wrote: Running 9.2 in production load mail servers. We're hitting the watchdog message and crashing with the stable/9 version. We're reverting the change from 2 weeks ago and seeing if it still happens. We didn't see this from stable/9 from about a month ago. Sean Not seeing any changes to core dumps, or crashes after updating the bce(4) interface on these Dell R410s. IPMI was a definite false hope. No changes noted after I modified the ipmi_attach code. stable/7 works just fine and stable/9 fails with NMI erros on the console very badly. It fails so badly that it won't come into service at all. I've reverted stable/9 back to august of 2012 with no changes. It sort of looks like r236216 is causing severe issues with my configuration. The Dell R410 has a 3rd ethernet interface for the BMC only, not sure if that is meaningful in this context. The 3rd interface is *not* visible from the o/s and is dedicated to the BMC interface. Doing more testing at this time to validate. Sean -- FWIW, I have an R210 with a BCM5716 running 9.1 RELEASE without any problems. I have customized the driver a bit. Try turning off the features and running it raw without any checksum or tso gobbledygook. BC ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/180893: [if_ethersubr] [patch] Packets received with own LLADDR confuse things.
Old Synopsis: Packets received with own LLADDR confuse things. New Synopsis: [if_ethersubr] [patch] Packets received with own LLADDR confuse things. Responsible-Changed-From-To: freebsd-bugs-freebsd-net Responsible-Changed-By: linimon Responsible-Changed-When: Tue Jul 30 02:12:37 UTC 2013 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=180893 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: Please implement patch in PR180893
On Sat, Jul 27, 2013 at 6:46 PM, Mike Karels m...@karels.net wrote: Sure, but it would be nice to file bugs with VMware and such to ensure they fix their bugs. There's quite a bit of chatter about this problem on the VMWare lists. Linux complains when these packets show up, so it isn't going unnoticed. fwiw, I use IPv6 with recent versions of ESXi and VMware Workstation, and have not seen this problem. I'm curious if the problem is in old versions or with particular configurations. I think you're only going to find this on the 'bridged' network type. When I tested this problem with other types of VMWare lans, the problem does not occur. Anyone have any issue with this? The issue I have is the if_printf(), it should be rate limited at the very least. It would also be nice to have a different counter to reflect that kind of dropped packet.. Agreed to both; I'd rather reserve if_ierrors for NIC-reported errors. I also think the message should say from my MAC address (vs IP). Obviously, it's really easy to modify the if_printf(), but what type of rate limiting is appropriate here? For instance, if you send a packet from an IP on the lan with changing MAC addresses, FreeBSD will printf() a note about each MAC address change. AFAICT, the if_printf() here can only be triggered by something right on the local lan (not by the internet at large --- even without filters). ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: Recommendations for 10gbps NIC
On Mon, Jul 29, 2013 at 2:36 AM, Gerrit Kühn gerrit.ku...@aei.mpg.dewrote: On Fri, 26 Jul 2013 15:14:17 -0700 (PDT) Barney Cordoba barney_cord...@yahoo.com wrote about Re: Recommendations for 10gbps NIC: BC I don't really understand why nearly all 10GBE cards are dual-port. BC Surely there is a market for NICs between 1 gigabit and 20 gigabit. Myricom has single port 10G cards. However, I only use them on Linux and cannot comment on FreeBSD usage here. I'm not sure if they are the current generation, but I did substantial testing on 10G Myricom cards of the day about 3 years ago. We selected them for our project, although their performance was very similar to that of the Chelsio. I did experience some issues of the Myicoms interoperating with Neterion, though I am not absolutely sure whose problem it was. We were looking for bulk data transfer, so I did no testing of small packets. Just 1500 and 9000. In any case, they worked quite well in our application with FreeBSD 8. In the past year the project moved to Linux due to a desire to standardize all systems to a common OS, but they ran reliably and at full line rate with jumbo frames over links that ran from California to Europe and Australia. (Yes, careful tuning was required.) -- R. Kevin Oberman, Network Engineer E-mail: rkober...@gmail.com ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
