[Bug 235411] sys.netpfil.pf.fragmentation.v6 panics after r343631

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235411

--- Comment #3 from commit-h...@freebsd.org ---
A commit references this bug:

Author: glebius
Date: Sat Feb  2 05:49:05 UTC 2019
New revision: 343678
URL: https://svnweb.freebsd.org/changeset/base/343678

Log:
  Return PFIL_CONSUMED if packet was consumed.  While here gather all
  the identical endings of pf_check_*() into single function.

  PR:   235411

Changes:
  head/sys/netpfil/pf/pf_ioctl.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235411] sys.netpfil.pf.fragmentation.v6 panics after r343631

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235411

Rodney W. Grimes  changed:

   What|Removed |Added

 CC||n...@freebsd.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235411] sys.netpfil.pf.fragmentation.v6 panics after r343631

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235411

Gleb Smirnoff  changed:

   What|Removed |Added

   Assignee|n...@freebsd.org |gleb...@freebsd.org
 Status|New |In Progress

--- Comment #1 from Gleb Smirnoff  ---
Created attachment 201621
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201621&action=edit
suggested patch

Can you please test this patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235411] sys.netpfil.pf.fragmentation.v6 panics after r343631

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235411

Li-Wen Hsu  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|n...@freebsd.org
 CC||gleb...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 204735] [net] [flowtable] Outgoing packets being sent via wrong interface

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204735

Oleksandr Tymoshenko  changed:

   What|Removed |Added

 Status|New |Closed
 CC||go...@freebsd.org
 Resolution|--- |Overcome By Events

--- Comment #4 from Oleksandr Tymoshenko  ---
flowtable feature was removed in base r321618, closing as OBE. If there are any
plans to fix this in 11-STABLE, please reopen PR.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 213239] [panic] Fatal trap 12: page fault while in kernel mode (flowcleaner/FLOWTABLE)

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213239

Oleksandr Tymoshenko  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|n...@freebsd.org
 Status|New |Closed
 CC||go...@freebsd.org
 Resolution|--- |Overcome By Events

--- Comment #4 from Oleksandr Tymoshenko  ---
flowtable feature was removed in base r321618, closing as OBE. If there are any
plans to fix this in 11-STABLE, please reopen PR.

Also assigning to net@ to reach potentially interested developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: Reminder: FCP-101: pending removal of some 10/100 Ethernet drivers

2019-02-01 Thread Warner Losh
On Fri, Feb 1, 2019, 11:05 AM Brooks Davis  On Fri, Feb 01, 2019 at 04:00:50AM -0800, Rodney W. Grimes wrote:
> > > On Thu, Jan 31, 2019 at 11:43:44PM +, Brooks Davis wrote:
> > > > We are currently planning to remove the following less-popular 10/100
> > > > Ethernet drivers in the March/April timeframe:
> > > >
> > > > ae, bm, cs, de, dme, ed, ep, ex, fe, pcn, sf, sn, tl, tx, txp, vx,
> wb, xe
> > > >
> > > > All of these drivers generate warnings in FreeBSD 12 and to the best
> of
> > > > my knowledge, none have cleared the bar specified in the FCP[0]:
> > > >
> > > > https://github.com/freebsd/fcp/blob/master/fcp-0101.md
> > >
> > > Hi,
> > >
> > > The above document states that the support lifetime for FreeBSD 12 is
> 2023.
> > >
> > > The expected EOL (but not decided) for 12 is June 30, 2020 however,
> according to
> >
> > Can someone please go revise where ever this is posted based on the 18
> month
> > minima that was set to simply state "undetermined", people are reading
> too much
> > into the date posted there.
> >
> > > https://www.freebsd.org/security/security.html#sup
> > >
> > > So, hardware in some of my machines will only be supported until
> sometime next
> > > year.
> >
> > Brooks,
> >   Given that at the time FCP-101 was written part of it was
> > based on the assumption of a 5 year life time for 12.0.  Since that
> > assumption is now invalid, and worse, unknown, I would ask that until
> > a decision about the life of 12.0 is made we back off on the FCP-101
> process
> > and not do anything about removing drivers until that support
> > model adjustment is finalized and we can evaluate the impact on
> > FCP-101's assumption.
>
> Per the text of my email and the schedule in the FCP, no deletions
> will occur until after the support lifetime of 12 is scheduled to be
> resolved.  Should that date slip then any deletions would also slip.
> Should the lifetime of 12 be drastically reduced relative to the
> original lifetime, then yes we should revisit our list and schedule.
>
> A majority of these devices have *zero* confirmed users so we should
> likely delete them before 13 no matter what happens to 12-STABLE's
> lifetime.
>

None of the drivers on the current list, with the possible exception of ae,
are used enough that the 12.x support timeline matters at all. And only in
the craziest of scenarios would ae come close to mattering. The rest are
all already dead and not even a close call between completely irrelevant
and almost completely irrelevant, let alone meeting a standard of relevant
enough to provide net value to the project.

No further action beyond data collection is scheduled on this FCP until
> after the end of the quarter.


I should run a new report based on the data we have around that time as
well...

Warner

-- Brooks
>
> P.S. All of this hardware will be supported until at least September 30,
> 2021 on FreeBSD 11-STABLE.
>
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 200319] Bridge+CARP crashes/freezes

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200319

--- Comment #14 from nv...@gmx.com ---
(In reply to Kristof Provost from comment #13)
At the same time the network stack is not functioning anymore. No IP, ARP, TCP
etc. For example, if you get inside the CARP jails and type "ifconfig bridge0",
ifconfig will never exit but wait forever:

root@moby:~ # jexec 2 ifconfig bridge0
bridge0: flags=8943 metric 0
mtu 1500
ether 9e:e2:5e:40:30:1e
inet 10.255.255.2 netmask 0xfff8 broadcast 10.255.255.7 
inet 10.255.255.1 netmask 0xfff8 broadcast 10.255.255.7 vhid 1 
load: 0.28  cmd: ifconfig 1024 [*if_bridge] 8.96r 0.00u 0.00s 0% 2948k
load: 0.28  cmd: ifconfig 1024 [*if_bridge] 9.26r 0.00u 0.00s 0% 2948k
load: 0.28  cmd: ifconfig 1024 [*if_bridge] 9.54r 0.00u 0.00s 0% 2948k
load: 0.28  cmd: ifconfig 1024 [*if_bridge] 9.80r 0.00u 0.00s 0% 2948k

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235031] [em] em0: poor NFS performance, strange behavior

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235031

--- Comment #25 from Martin Birgmeier  ---
Just for the record, the le0 (le(4)) issue is with the client running head as
of Dec. 8:

Copyright (c) 1992-2018 The FreeBSD Project.
Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
The Regents of the University of California. All rights reserved.
FreeBSD is a registered trademark of The FreeBSD Foundation.
FreeBSD 13.0-CURRENT #0 r341726M: Sat Dec  8 19:24:08 CET 2018
   
root@v903.xyzzy:/.../hal/z/OBJ/FreeBSD/amd64/head/amd64.amd64/sys/XYZZY_SMP_NOSPIN
amd64
FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on LLVM
6.0.1)


The exactly same client runs fine under Hyper-V using de0 (de(4)).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235031] [em] em0: poor NFS performance, strange behavior

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235031

--- Comment #24 from Martin Birgmeier  ---
I have observed that using le0 in a VirtualBox virtual machine also has very
poor NFS performance. Is le0 affected by the same issues?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: Reminder: FCP-101: pending removal of some 10/100 Ethernet drivers

2019-02-01 Thread Brooks Davis
On Fri, Feb 01, 2019 at 04:00:50AM -0800, Rodney W. Grimes wrote:
> > On Thu, Jan 31, 2019 at 11:43:44PM +, Brooks Davis wrote:
> > > We are currently planning to remove the following less-popular 10/100
> > > Ethernet drivers in the March/April timeframe:
> > > 
> > > ae, bm, cs, de, dme, ed, ep, ex, fe, pcn, sf, sn, tl, tx, txp, vx, wb, xe
> > > 
> > > All of these drivers generate warnings in FreeBSD 12 and to the best of
> > > my knowledge, none have cleared the bar specified in the FCP[0]:
> > > 
> > > https://github.com/freebsd/fcp/blob/master/fcp-0101.md
> > 
> > Hi,
> > 
> > The above document states that the support lifetime for FreeBSD 12 is 2023.
> > 
> > The expected EOL (but not decided) for 12 is June 30, 2020 however, 
> > according to
> 
> Can someone please go revise where ever this is posted based on the 18 month
> minima that was set to simply state "undetermined", people are reading too 
> much
> into the date posted there.
> 
> > https://www.freebsd.org/security/security.html#sup
> > 
> > So, hardware in some of my machines will only be supported until sometime 
> > next
> > year.
> 
> Brooks,
>   Given that at the time FCP-101 was written part of it was
> based on the assumption of a 5 year life time for 12.0.  Since that
> assumption is now invalid, and worse, unknown, I would ask that until
> a decision about the life of 12.0 is made we back off on the FCP-101 process
> and not do anything about removing drivers until that support
> model adjustment is finalized and we can evaluate the impact on
> FCP-101's assumption.

Per the text of my email and the schedule in the FCP, no deletions
will occur until after the support lifetime of 12 is scheduled to be
resolved.  Should that date slip then any deletions would also slip.
Should the lifetime of 12 be drastically reduced relative to the
original lifetime, then yes we should revisit our list and schedule.

A majority of these devices have *zero* confirmed users so we should
likely delete them before 13 no matter what happens to 12-STABLE's
lifetime.

No further action beyond data collection is scheduled on this FCP until
after the end of the quarter.

-- Brooks

P.S. All of this hardware will be supported until at least September 30,
2021 on FreeBSD 11-STABLE.


signature.asc
Description: PGP signature


[Bug 167603] [ip] IP fragment reassembly's broken: file transfer over NFSv3/UDP fails for default NFS packet size

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=167603

Eugene Grosbein  changed:

   What|Removed |Added

 Status|Open|Closed
 Resolution|--- |FIXED

--- Comment #5 from Eugene Grosbein  ---
(In reply to Tom Jones from comment #3)

I've repeated the test and now the problem does not repeat: no timeouts and
zero "dropped" counters in the output of "netstat -ss -p ip".

The only problem is crawling copying speed (7KByte/s-14KByte/s) unless I add
mount options "rsize=10240,wsize=10240,readahead=4" to old list of options
"rw,soft,intr,mntudp", then it saturates 100Mbit/s link.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 200319] Bridge+CARP crashes/freezes

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200319

--- Comment #13 from Kristof Provost  ---
(In reply to nvass from comment #12)
For anyone else who wants to try: the script doesn't load the carp module, so
load it manually first.

The manifestation of it isn't exactly what I expected. I don't see an OS hang,
but I do see ping report errors: "ping: sendto: No buffer space available".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 167603] [ip] IP fragment reassembly's broken: file transfer over NFSv3/UDP fails for default NFS packet size

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=167603

--- Comment #4 from Eugene Grosbein  ---
(In reply to Tom Jones from comment #3)

All involved hosts have been upgraded since 2012 and now run 11.2-STABLE but
still have same hardware and network topology including intermediate L2
switches. NFS service is still in use same way, too (over TCP).

I will repeat the test using 11.2-STABLE and report back.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 199489] NAT with IPv6 and PF round robins between external address and link-local address

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199489

Kristof Provost  changed:

   What|Removed |Added

 CC||k...@freebsd.org
 Resolution|--- |FIXED
 Status|New |Closed

--- Comment #1 from Kristof Provost  ---
I believe this was fixed in #201695. Please re-open this bug if that's not the
case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 167603] [ip] IP fragment reassembly's broken: file transfer over NFSv3/UDP fails for default NFS packet size

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=167603

Tom Jones  changed:

   What|Removed |Added

 CC||t...@freebsd.org

--- Comment #3 from Tom Jones  ---
Hi Eugene,

Can you still reproduce this? 

My reading of this it sounds like your network had trouble with ip fragments. I
am not sure this is an NFS bug.

- Tom

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 138266] [panic] kernel panic when udp benchmark test used as regular user

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=138266

Tom Jones  changed:

   What|Removed |Added

 Resolution|--- |Overcome By Events
 Status|Open|Closed
 CC||t...@freebsd.org

--- Comment #3 from Tom Jones  ---
I was unable to reproduce this in 13CURRENT in bhyve with two machines
connected via bridge. manu@ was unable to reproduce this on a box with igb.

If you can reproduce this on a modern FreeBSD please reopen this bug with your
reproduction case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235256] [net] IW10 without ABC leads to initial window of 11 Segments

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235256

--- Comment #4 from commit-h...@freebsd.org ---
A commit references this bug:

Author: tuexen
Date: Fri Feb  1 12:33:01 UTC 2019
New revision: 343661
URL: https://svnweb.freebsd.org/changeset/base/343661

Log:
  When handling SYN-ACK segments in the SYN-RCVD state, set tp->snd_wnd
  consistently.

  This inconsistency was observed when working on the bug reported in
  PR 235256, although it does not fix the reported issue. The fix for
  the PR will be a separate commit.

  PR:   235256
  Reviewed by:  rrs@, Richard Scheffenegger
  MFC after:3 days
  Sponsored by: Netflix, Inc.
  Differential Revision:https://reviews.freebsd.org/D19033

Changes:
  head/sys/netinet/tcp_input.c
  head/sys/netinet/tcp_stacks/rack.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 221317] ifconfig down/up issue after ixgbe driver update in r320897

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221317

--- Comment #42 from Charles Goncalves  ---
(In reply to Piotr Pietruszewski from comment #35)

In 11.1 and 11.2 I can't apply this patch.

I tested ifconfig down/up script in FreeBSD 12.0-RELEASE r341666 and this issue
not occurs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: Reminder: FCP-101: pending removal of some 10/100 Ethernet drivers

2019-02-01 Thread Rodney W. Grimes
> On Thu, Jan 31, 2019 at 11:43:44PM +, Brooks Davis wrote:
> > We are currently planning to remove the following less-popular 10/100
> > Ethernet drivers in the March/April timeframe:
> > 
> > ae, bm, cs, de, dme, ed, ep, ex, fe, pcn, sf, sn, tl, tx, txp, vx, wb, xe
> > 
> > All of these drivers generate warnings in FreeBSD 12 and to the best of
> > my knowledge, none have cleared the bar specified in the FCP[0]:
> > 
> > https://github.com/freebsd/fcp/blob/master/fcp-0101.md
> 
> Hi,
> 
> The above document states that the support lifetime for FreeBSD 12 is 2023.
> 
> The expected EOL (but not decided) for 12 is June 30, 2020 however, according 
> to

Can someone please go revise where ever this is posted based on the 18 month
minima that was set to simply state "undetermined", people are reading too much
into the date posted there.

> https://www.freebsd.org/security/security.html#sup
> 
> So, hardware in some of my machines will only be supported until sometime next
> year.

Brooks,
Given that at the time FCP-101 was written part of it was
based on the assumption of a 5 year life time for 12.0.  Since that
assumption is now invalid, and worse, unknown, I would ask that until
a decision about the life of 12.0 is made we back off on the FCP-101 process
and not do anything about removing drivers until that support
model adjustment is finalized and we can evaluate the impact on
FCP-101's assumption.

Regards,
-- 
Rod Grimes rgri...@freebsd.org
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235097] ci runs panic with use-after-free when running sys/netpfil/pf/nat tests

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235097

Kristof Provost  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|New |Closed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235097] ci runs panic with use-after-free when running sys/netpfil/pf/nat tests

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235097

--- Comment #19 from commit-h...@freebsd.org ---
A commit references this bug:

Author: kp
Date: Fri Feb  1 10:04:55 UTC 2019
New revision: 343653
URL: https://svnweb.freebsd.org/changeset/base/343653

Log:
  MFC r343418:

  pf: Fix use-after-free of counters

  When cleaning up a vnet we free the counters in V_pf_default_rule and
  V_pf_status from shutdown_pf(), but we can still use them later, for example
  through pf_purge_expired_src_nodes().

  Free them as the very last operation, as they rely on nothing else
themselves.

  PR:   235097

Changes:
_U  stable/11/
  stable/11/sys/netpfil/pf/pf_ioctl.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235097] ci runs panic with use-after-free when running sys/netpfil/pf/nat tests

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235097

--- Comment #18 from commit-h...@freebsd.org ---
A commit references this bug:

Author: kp
Date: Fri Feb  1 10:04:53 UTC 2019
New revision: 343652
URL: https://svnweb.freebsd.org/changeset/base/343652

Log:
  MFC r343418:

  pf: Fix use-after-free of counters

  When cleaning up a vnet we free the counters in V_pf_default_rule and
  V_pf_status from shutdown_pf(), but we can still use them later, for example
  through pf_purge_expired_src_nodes().

  Free them as the very last operation, as they rely on nothing else
themselves.

  PR:   235097

Changes:
_U  stable/12/
  stable/12/sys/netpfil/pf/pf_ioctl.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Re: Reminder: FCP-101: pending removal of some 10/100 Ethernet drivers

2019-02-01 Thread Joel Dahl
On Thu, Jan 31, 2019 at 11:43:44PM +, Brooks Davis wrote:
> We are currently planning to remove the following less-popular 10/100
> Ethernet drivers in the March/April timeframe:
> 
> ae, bm, cs, de, dme, ed, ep, ex, fe, pcn, sf, sn, tl, tx, txp, vx, wb, xe
> 
> All of these drivers generate warnings in FreeBSD 12 and to the best of
> my knowledge, none have cleared the bar specified in the FCP[0]:
> 
> https://github.com/freebsd/fcp/blob/master/fcp-0101.md

Hi,

The above document states that the support lifetime for FreeBSD 12 is 2023.

The expected EOL (but not decided) for 12 is June 30, 2020 however, according to
https://www.freebsd.org/security/security.html#sup

So, hardware in some of my machines will only be supported until sometime next
year.

-- 
Joel
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 233535] Fix refcount leak in IPv6 MLD code leading to loss of IPv6 connectivity

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233535

--- Comment #56 from commit-h...@freebsd.org ---
A commit references this bug:

Author: hselasky
Date: Fri Feb  1 09:08:20 UTC 2019
New revision: 343650
URL: https://svnweb.freebsd.org/changeset/base/343650

Log:
  MFC r343395:
  Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6
  connectivity.

  Looking at past changes in this area like r337866, some refcounting
  bugs have been introduced, one by one. For example like calling
  in6m_disconnect() and in6m_rele_locked() in mld_v1_process_group_timer()
  where previously no disconnect nor refcount decrement was done.
  Calling in6m_disconnect() when it shouldn't causes IPv6 solitation to no
  longer work, because all the multicast addresses receiving the solitation
  messages are now deleted from the network interface.

  This patch reverts some recent changes while improving the MLD
  refcounting and concurrency model after the MLD code was converted
  to using EPOCH(9).

  List changes:
  - All CK_STAILQ_FOREACH() macros are now properly enclosed into
EPOCH(9) sections. This simplifies assertion of locking inside
in6m_ifmultiaddr_get_inm().
  - Corrected bad use of in6m_disconnect() leading to loss of IPv6
connectivity for MLD v1.
  - Factored out checks for valid inm structure into
in6m_ifmultiaddr_get_inm().

  PR:   233535
  Differential Revision:https://reviews.freebsd.org/D18887
  Reviewed by:  bz (net)
  Tested by:ae
  Sponsored by: Mellanox Technologies

Changes:
_U  stable/12/
  stable/12/sys/netinet6/in6_ifattach.c
  stable/12/sys/netinet6/in6_mcast.c
  stable/12/sys/netinet6/in6_var.h
  stable/12/sys/netinet6/mld6.c
  stable/12/sys/netinet6/mld6_var.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 233535] Fix refcount leak in IPv6 MLD code leading to loss of IPv6 connectivity

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233535

--- Comment #55 from commit-h...@freebsd.org ---
A commit references this bug:

Author: hselasky
Date: Fri Feb  1 09:07:28 UTC 2019
New revision: 343649
URL: https://svnweb.freebsd.org/changeset/base/343649

Log:
  MFC r343394:
  When detaching a network interface drain the workqueue freeing the inm's
  because the destructor will access the if_ioctl() callback in the ifnet
  pointer which is about to be freed. This prevents use-after-free.

  PR:   233535
  Differential Revision:https://reviews.freebsd.org/D18887
  Reviewed by:  bz (net)
  Tested by:ae
  Sponsored by: Mellanox Technologies

Changes:
_U  stable/12/
  stable/12/sys/netinet6/in6_ifattach.c
  stable/12/sys/netinet6/in6_mcast.c
  stable/12/sys/netinet6/in6_var.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 233535] Fix refcount leak in IPv6 MLD code leading to loss of IPv6 connectivity

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233535

--- Comment #54 from commit-h...@freebsd.org ---
A commit references this bug:

Author: hselasky
Date: Fri Feb  1 09:06:40 UTC 2019
New revision: 343648
URL: https://svnweb.freebsd.org/changeset/base/343648

Log:
  MFC r343393:
  Add debugging sysctl to disable incoming MLD v2 messages similar to the
  existing sysctl for MLD v1 messages.

  PR:   233535
  Differential Revision:https://reviews.freebsd.org/D18887
  Reviewed by:  bz (net)
  Tested by:ae
  Sponsored by: Mellanox Technologies

Changes:
_U  stable/12/
  stable/12/sys/netinet6/mld6.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 233535] Fix refcount leak in IPv6 MLD code leading to loss of IPv6 connectivity

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233535

--- Comment #53 from commit-h...@freebsd.org ---
A commit references this bug:

Author: hselasky
Date: Fri Feb  1 09:05:42 UTC 2019
New revision: 343647
URL: https://svnweb.freebsd.org/changeset/base/343647

Log:
  MFC r343392:
  Fix duplicate acquiring of refcount when joining IPv6 multicast groups.
  This was observed by starting and stopping rpcbind(8) multiple times.

  PR:   233535
  Differential Revision:https://reviews.freebsd.org/D18887
  Reviewed by:  bz (net)
  Tested by:ae
  Sponsored by: Mellanox Technologies

Changes:
_U  stable/12/
  stable/12/sys/netinet6/in6_mcast.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 200319] Bridge+CARP crashes/freezes

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200319

--- Comment #12 from nv...@gmx.com ---
Created attachment 201585
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201585&action=edit
script to demosntrate the carp-on-bridge deadlock

Hi,

I wrote a small script to reproduce the problem per Kristof's request.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 235342] [em] em0 hangs when vnet jail starts while transferring files

2019-02-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235342

--- Comment #6 from Yuichiro NAITO  ---
(In reply to Martin Birgmeier from comment #5)
I'm not sure this problem is related to #235031.
With `ifconfig em0 lro` and ` ifconfig em0 -lro`, nothing happens to me.
It seems that error messages are same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"