[Bug 237843] arp: Skips all name lookups if first fail with TRY_AGAIN

2019-05-12 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237843

--- Comment #3 from p...@twisted.org.uk ---
Wasn't supposed to be a patch, as its not a real fix - its removing intended
functionality to let me debug what was going on, which is not a great way to
proceed, but for reference the diff looks like this:

--- arp.c   2019-05-12 10:20:57.920473000 +0100
+++ /usr/src/usr.sbin/arp/arp.c 2018-11-11 17:59:35.794752000 +
@@ -605,8 +605,11 @@
hp = 0;
if (hp)
host = hp->h_name;
-   else
+   else {
host = "?";
+   if (h_errno == TRY_AGAIN)
+   nflag = 1;
+   }
xo_emit("{:hostname/%s} ({:ip-address/%s}) at ", host,
inet_ntoa(addr->sin_addr));
if (sdl->sdl_alen) {

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 237843] arp: Skips all name lookups if first fail with TRY_AGAIN

2019-05-12 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237843

--- Comment #4 from p...@twisted.org.uk ---
Gah, thats backwards of course! here it is with the arguments the right way
round :)

--- /usr/src/usr.sbin/arp/arp.c 2018-11-11 17:59:35.794752000 +
+++ arp.c   2019-05-12 10:20:57.920473000 +0100
@@ -605,11 +605,8 @@
hp = 0;
if (hp)
host = hp->h_name;
-   else {
+   else
host = "?";
-   if (h_errno == TRY_AGAIN)
-   nflag = 1;
-   }
xo_emit("{:hostname/%s} ({:ip-address/%s}) at ", host,
inet_ntoa(addr->sin_addr));
if (sdl->sdl_alen) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 237843] arp: Skips all name lookups if first fail with TRY_AGAIN

2019-05-11 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237843

Kubilay Kocak  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|n...@freebsd.org
 Status|New |Open
   Keywords||needs-qa
Summary|arp skips all name lookups  |arp: Skips all name lookups
   |if first fall with  |if first fail with
   |TRY_AGAIN   |TRY_AGAIN
 CC||ko...@freebsd.org,
   ||n...@freebsd.org

--- Comment #2 from Kubilay Kocak  ---
Thank you for the report Pete

"removing the line which sets 'nflag' to 1 after a TRY_AGAIN results in this."

If the above refers to a patch to attempt to fix the issue, could you please
include it as an attachment

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"