Re: Exposing full 32bit RSS hash from card for ixgbe(4)
On Wednesday, August 5, 2015 4:28 PM, Kevin Oberman wrote: On Wed, Aug 5, 2015 at 7:10 AM, Barney Cordoba via freebsd-net < freebsd-net@freebsd.org> wrote: > > > > On Wednesday, August 5, 2015 2:19 AM, Olivier Cochard-Labbé < > oliv...@cochard.me> wrote: > > > On Wed, Aug 5, 2015 at 1:15 AM, Barney Cordoba via freebsd-net < > freebsd-net@freebsd.org> wrote: > > > What's the point of all of this gobbledygook anyway? Seriously, 99% of > the > > world needs a driver that passes packets in the most efficient way, and > > every time I look at igb and ixgbe it has another 2 heads. It's up to 8 > > heads, and none of the things wrong with it have been fixed. This is now > > even uglier than Kip Macy's cxgb abortion. > > I'm not trying to be snarky here. I wrote a simple driver 3 years ago > that > > runs and runs and uses little cpu; maybe 8% for a full gig load on an E3. > > > > Hi, > > I will be very happy to bench your simple driver. Where can I download the > sources ? > > Thanks, > > Olivier > ___ > > Another unproductive dick head on the FreeBSD team? Figures. > A typical Barney thread. First he calls the developers incompetent and says he has done better. Then someone who has experience in real world benchmarking (not a trivial thing) offers to evaluate Barney's code, and gets a quick, rude, obscene dismissal. Is it any wonder that, even though he made some valid arguments (at least for some workloads), almost everyone just dismisses him as too obnoxious to try to deal with. Based on my pre-retirement work with high-performance networking, in some cases it was clear that it would be better to locking down things to a single CPU on with FreeBSD or Linux. I can further state that this was NOT true for all workloads, so it is quite possible that Barney's code works for some cases (perhaps his) and would be bad in others. But without good benchmarking, it's hard to tell. I will say that for large volume data transfers (very large flows), a single CPU solution does work best. But if Barney is going at this with his usual attitude, it's probably not worth it to continue the discussion. -- the "give us the source and we'll test it" nonsense is kindergarden stuff. As if my code is open source and you can just have it, and like you know how to benchmark anything since you can't even benchmark what you have. Some advice is to ignore guys like Oberman who spent their lives randomly pounding networks on slow machines with slow busses and bad NICs on OS's that couldn't do SMP properly. Because he'll just lead you down the road to dusty death. Multicore design isn't simple math; its about efficiency, lock minimization and the understanding that shifting memory between cpus unnecessarily is costly. Today's CPUs and NICs can't be judged using test methods of the past. You'll just end up playing the Microsoft Windows game; get bigger machines and more memory and don't worry about the fact that the code is junk. It's just that the "default" in these drivers is so obviously wrong that it's mind-boggling. The argument to use 1, 2 or 4 queues is one worth having; using "all" of the cpus, including the hyperthreads, is just plain incompetent. I will contribute one possibly useful tidbit: disable_queue() only disables receive interrupts. Both tx and rx ints are effectively tied together by moderation so you'll just getan interrupt at the next slot anyway. BC ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
On Wed, Aug 5, 2015 at 7:10 AM, Barney Cordoba via freebsd-net < freebsd-net@freebsd.org> wrote: > > > > On Wednesday, August 5, 2015 2:19 AM, Olivier Cochard-Labbé < > oliv...@cochard.me> wrote: > > > On Wed, Aug 5, 2015 at 1:15 AM, Barney Cordoba via freebsd-net < > freebsd-net@freebsd.org> wrote: > > > What's the point of all of this gobbledygook anyway? Seriously, 99% of > the > > world needs a driver that passes packets in the most efficient way, and > > every time I look at igb and ixgbe it has another 2 heads. It's up to 8 > > heads, and none of the things wrong with it have been fixed. This is now > > even uglier than Kip Macy's cxgb abortion. > > I'm not trying to be snarky here. I wrote a simple driver 3 years ago > that > > runs and runs and uses little cpu; maybe 8% for a full gig load on an E3. > > > > Hi, > > I will be very happy to bench your simple driver. Where can I download the > sources ? > > Thanks, > > Olivier > ___ > > Another unproductive dick head on the FreeBSD team? Figures. > A typical Barney thread. First he calls the developers incompetent and says he has done better. Then someone who has experience in real world benchmarking (not a trivial thing) offers to evaluate Barney's code, and gets a quick, rude, obscene dismissal. Is it any wonder that, even though he made some valid arguments (at least for some workloads), almost everyone just dismisses him as too obnoxious to try to deal with. Based on my pre-retirement work with high-performance networking, in some cases it was clear that it would be better to locking down things to a single CPU on with FreeBSD or Linux. I can further state that this was NOT true for all workloads, so it is quite possible that Barney's code works for some cases (perhaps his) and would be bad in others. But without good benchmarking, it's hard to tell. I will say that for large volume data transfers (very large flows), a single CPU solution does work best. But if Barney is going at this with his usual attitude, it's probably not worth it to continue the discussion. -- Kevin Oberman, Network Engineer, Retired E-mail: rkober...@gmail.com PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
On Wed, Aug 05, 2015 at 02:10:09PM +, Barney Cordoba via freebsd-net wrote: > > > > On Wednesday, August 5, 2015 2:19 AM, Olivier Cochard-Labb?? > wrote: > > > On Wed, Aug 5, 2015 at 1:15 AM, Barney Cordoba via freebsd-net < > freebsd-net@freebsd.org> wrote: > > > What's the point of all of this gobbledygook anyway? Seriously, 99% of the > > world needs a driver that passes packets in the most efficient way, and > > every time I look at igb and ixgbe it has another 2 heads. It's up to 8 > > heads, and none of the things wrong with it have been fixed. This is now > > even uglier than Kip Macy's cxgb abortion. > > I'm not trying to be snarky here. I wrote a simple driver 3 years ago that > > runs and runs and uses little cpu; maybe 8% for a full gig load on an E3. > > > > ???Hi, > > I will be very happy to bench your simple driver. Where can I download the > sources ? > > Thanks, > > Olivier > ___ > > Another unproductive dick head on the FreeBSD team? Figures. Barney, Please refrain from swearing and ad hominem attacks on the FreeBSD lists. Thank you ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/05/15 07:10, Barney Cordoba via freebsd-net wrote: > > > > On Wednesday, August 5, 2015 2:19 AM, Olivier Cochard-Labbé > wrote: > > > On Wed, Aug 5, 2015 at 1:15 AM, Barney Cordoba via freebsd-net < > freebsd-net@freebsd.org> wrote: > >> What's the point of all of this gobbledygook anyway? Seriously, >> 99% of the world needs a driver that passes packets in the most >> efficient way, and every time I look at igb and ixgbe it has >> another 2 heads. It's up to 8 heads, and none of the things wrong >> with it have been fixed. This is now even uglier than Kip Macy's >> cxgb abortion. I'm not trying to be snarky here. I wrote a simple >> driver 3 years ago that runs and runs and uses little cpu; maybe >> 8% for a full gig load on an E3. >> > > Hi, > > I will be very happy to bench your simple driver. Where can I > download the sources ? > > Thanks, > > Olivier ___ > > Another unproductive dick head on the FreeBSD team? Figures. BC > I had assumed that Olivier was being serious. He benchmarks lots of drivers and points out regressions from time to time. I'd love to see some "competitive" measurements made with new ideas. sean -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQF8BAEBCgBmBQJVwiHWXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kZaAH/iVn1CldgX9kLVbwmxAUJCS/ pJiLU6lEHaNKlmw5PwVctiVdPnt3q4sK9ffx4U1i9qZyYh9/MkNUL/s+yAwXs1yv ZdAojJSwWj4O5JS3eZ7wPa2cZpE13e4hn/wVnlW0YE6eawoPF6ATWs2kvSaZJjzb o5v+qwct4ncWFfqhUyN/8DrfwzJJRcyPtZZu5IVRXHB5qQ2wc+kkNj+FI9kPXGOs IrdJ9plb1fQ0SrUmjzepyalLX/1Hr4jZyogImxzjmmgANBjcnfYD5FfoFT1YzwWu w/oK6pvScoId6e4UKp/mOt6ItVNLByvncXTseGt7rwvJzJCxXjRI8CPhuL78bfs= =Iw/7 -END PGP SIGNATURE- ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
On Wednesday, August 5, 2015 2:19 AM, Olivier Cochard-Labbé wrote: On Wed, Aug 5, 2015 at 1:15 AM, Barney Cordoba via freebsd-net < freebsd-net@freebsd.org> wrote: > What's the point of all of this gobbledygook anyway? Seriously, 99% of the > world needs a driver that passes packets in the most efficient way, and > every time I look at igb and ixgbe it has another 2 heads. It's up to 8 > heads, and none of the things wrong with it have been fixed. This is now > even uglier than Kip Macy's cxgb abortion. > I'm not trying to be snarky here. I wrote a simple driver 3 years ago that > runs and runs and uses little cpu; maybe 8% for a full gig load on an E3. > Hi, I will be very happy to bench your simple driver. Where can I download the sources ? Thanks, Olivier ___ Another unproductive dick head on the FreeBSD team? Figures. BC ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
On Wed, Aug 5, 2015 at 1:15 AM, Barney Cordoba via freebsd-net < freebsd-net@freebsd.org> wrote: > What's the point of all of this gobbledygook anyway? Seriously, 99% of the > world needs a driver that passes packets in the most efficient way, and > every time I look at igb and ixgbe it has another 2 heads. It's up to 8 > heads, and none of the things wrong with it have been fixed. This is now > even uglier than Kip Macy's cxgb abortion. > I'm not trying to be snarky here. I wrote a simple driver 3 years ago that > runs and runs and uses little cpu; maybe 8% for a full gig load on an E3. > Hi, I will be very happy to bench your simple driver. Where can I download the sources ? Thanks, Olivier ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
What's the point of all of this gobbledygook anyway? Seriously, 99% of the world needs a driver that passes packets in the most efficient way, and every time I look at igb and ixgbe it has another 2 heads. It's up to 8 heads, and none of the things wrong with it have been fixed. This is now even uglier than Kip Macy's cxgb abortion. I'm not trying to be snarky here. I wrote a simple driver 3 years ago that runs and runs and uses little cpu; maybe 8% for a full gig load on an E3. What is the benefit of implementing all of these stupid offload and RSS hashes? Spreading across cpus is incredibly inefficient; running 8 'queues' on a quad core cpu with hyperthreading is incredibly stupid. 1 cpu can easily handle a full gig, so why are you dirtying the code with 8000 "features" when it runs just fine without any of them? you're subjecting 1000s of users to constant instability (and fear in upgrading at all) for what amounts to a college science project. I know you haven't benchmarked it, so why are you doing it? hell, you added that buf_ring stuff without even making any determination that it was beneficial to use it, just because it was there. You're trying to steal a handful of cycles with these hokey features, and then you're losing buckets of cycles (maybe wheelbarrows) by unnecessarily spreading the processes across too many cpus. It just makes no sense at all. If you want to play, that's fine. But there should be simple I/O drivers for em, igb and ixgbe available as alternatives for the 99% of users who just want to run a router, a bridge/filter or a web server. Drivers that don't break features A and C when you make a change to Q and Z because you can't possibly test all 8000 features every time you do something. Im horrified that some poor schlub with a 1 gig webserver is losing half of his cpu power because of the ridiculous defaults in the igb driver. On Wednesday, July 15, 2015 2:01 PM, hiren panchasara wrote: On 07/14/15 at 02:18P, hiren panchasara wrote: > On 07/14/15 at 12:38P, Eric Joyner wrote: > > Sorry for the delay; it looked fine to me, but I never got back to you. > > > > - Eric > > > > On Mon, Jul 13, 2015 at 3:16 PM Adrian Chadd wrote: > > > > > Hi, > > > > > > It's fine by me. Please do it! > > Thanks Adrian and Eric. Committed as r285528. FYI: I am planning to do a partial mfc of this to stable10. Here is the patch: https://people.freebsd.org/~hiren/patches/ix_expose_rss_hash_stable10.patch (I did the same for igb(4), r282831) Cheers, Hiren ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
On 07/14/15 at 02:18P, hiren panchasara wrote: > On 07/14/15 at 12:38P, Eric Joyner wrote: > > Sorry for the delay; it looked fine to me, but I never got back to you. > > > > - Eric > > > > On Mon, Jul 13, 2015 at 3:16 PM Adrian Chadd wrote: > > > > > Hi, > > > > > > It's fine by me. Please do it! > > Thanks Adrian and Eric. Committed as r285528. FYI: I am planning to do a partial mfc of this to stable10. Here is the patch: https://people.freebsd.org/~hiren/patches/ix_expose_rss_hash_stable10.patch (I did the same for igb(4), r282831) Cheers, Hiren pgpL2qLeXt_mN.pgp Description: PGP signature
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
On 07/14/15 at 12:38P, Eric Joyner wrote: > Sorry for the delay; it looked fine to me, but I never got back to you. > > - Eric > > On Mon, Jul 13, 2015 at 3:16 PM Adrian Chadd wrote: > > > Hi, > > > > It's fine by me. Please do it! Thanks Adrian and Eric. Committed as r285528. Cheers, Hiren pgpE3U4icUTHA.pgp Description: PGP signature
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
Sorry for the delay; it looked fine to me, but I never got back to you. - Eric On Mon, Jul 13, 2015 at 3:16 PM Adrian Chadd wrote: > Hi, > > It's fine by me. Please do it! > > > -a > > > On 13 July 2015 at 13:05, hiren panchasara wrote: > > Here is the patch I'd like to push which exposes 32bit RSS has that we > > get from ixgbe cards irrespective of whether RSS is defined or not. > > > > https://people.freebsd.org/~hiren/patches/ix_expose_rss_hash.patch > > > > This is similar to what we've done for igb(4): r281838 > > > > In this patch I am also proposing to remove FreeBSD version check (and > > therefore the check for M_FLOWID) as I don't see such a check in other > > Intel drivers like igb(4). But I am on adamant wrt that and can restore > > if someone feels strongly about it. > > > > (I need to update my arc client (again) to generate the phabric review > > and that can take some time so I'd appreciate any reviews/comments > > here.) > > > > Cheers, > > Hiren > ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: Exposing full 32bit RSS hash from card for ixgbe(4)
Hi, It's fine by me. Please do it! -a On 13 July 2015 at 13:05, hiren panchasara wrote: > Here is the patch I'd like to push which exposes 32bit RSS has that we > get from ixgbe cards irrespective of whether RSS is defined or not. > > https://people.freebsd.org/~hiren/patches/ix_expose_rss_hash.patch > > This is similar to what we've done for igb(4): r281838 > > In this patch I am also proposing to remove FreeBSD version check (and > therefore the check for M_FLOWID) as I don't see such a check in other > Intel drivers like igb(4). But I am on adamant wrt that and can restore > if someone feels strongly about it. > > (I need to update my arc client (again) to generate the phabric review > and that can take some time so I'd appreciate any reviews/comments > here.) > > Cheers, > Hiren ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
