Re: kern/142197: [ndis] [patch] ndis is missing media status reporting

2011-06-11 Thread Paul B. Mahol 
On Wed, Jan 6, 2010 at 1:04 PM,  ga...@freebsd.org wrote:
 Synopsis: [ndis] [patch] ndis is missing media status reporting

 State-Changed-From-To: open-patched
 State-Changed-By: gavin
 State-Changed-When: Wed Jan 6 12:02:52 UTC 2010
 State-Changed-Why:
 Committed to HEAD in r201620


 Responsible-Changed-From-To: freebsd-net-rpaulo
 Responsible-Changed-By: gavin
 Responsible-Changed-When: Wed Jan 6 12:02:52 UTC 2010
 Responsible-Changed-Why:
 Over to rpaulo as MFC reminder

 http://www.freebsd.org/cgi/query-pr.cgi?pr=142197


Please close this bug report.
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: kern/142197: [ndis] [patch] ndis is missing media status reporting

2010-01-06 Thread Roman Bogorodskiy 
The following reply was made to PR kern/142197; it has been noted by GNATS.

From: Roman Bogorodskiy no...@freebsd.org
To: bug-follo...@freebsd.org, one...@gmail.com, rpa...@freebsd.org
Cc:  
Subject: Re: kern/142197: [ndis] [patch] ndis is missing media status
 reporting
Date: Wed, 6 Jan 2010 12:32:42 +0300

 --uAKRQypu60I7Lcqm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hello,
 
 Seems like there's a minor problem with that:
 
 cc1: warnings being treated as errors
 /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c: In function 'ndis=
 _media_status':
 /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c:2252: warning: pas=
 sing argument 4 of 'ndis_get_info' from incompatible pointer type
 *** Error code 1
 
 As ndis_get_info accepts 'int', not 'size_t', so after applying this:
 
 --- if_ndis.c.orig 2010-01-06 12:15:17.0 +0300
 +++ if_ndis.c  2010-01-06 12:17:03.0 +0300
 @@ -2243,7 +2243,7 @@
struct ieee80211vap *vap =3D ifp-if_softc;
struct ndis_softc *sc =3D vap-iv_ic-ic_ifp-if_softc;
uint32_t txrate;
 -  size_t len;
 +  int len;
 =20
if (!NDIS_INITIALIZED(sc))
return;
 
 it compiles fine.
 
 Roman Bogorodskiy
 
 --uAKRQypu60I7Lcqm
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1.4.10 (FreeBSD)
 
 iJwEAQECAAYFAktEWLAACgkQgHRbOB2qykYkkQP9HBbpfcBkyEl7eLyZz1Egga8i
 MkkjIWtZLDYzfP4I40n1msmydvWPiiFMpXl7M7I4F9qx4dygWhFeYhTSpyRdpxQx
 aWk9c0exeYae5y+hjfciHZ4yEdJtV8A7yOkAXs4Sgi9hYaomWebkK4svUwbVyQsR
 nlb7YXKsPMnLUxkPtmo=
 =W1Zn
 -END PGP SIGNATURE-
 
 --uAKRQypu60I7Lcqm--
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: kern/142197: [ndis] [patch] ndis is missing media status reporting

2010-01-06 Thread Paul B Mahol 
The following reply was made to PR kern/142197; it has been noted by GNATS.

From: Paul B Mahol one...@gmail.com
To: Roman Bogorodskiy no...@freebsd.org
Cc: bug-follo...@freebsd.org, rpa...@freebsd.org
Subject: Re: kern/142197: [ndis] [patch] ndis is missing media status 
reporting
Date: Wed, 6 Jan 2010 11:54:48 +0100

 On 1/6/10, Roman Bogorodskiy no...@freebsd.org wrote:
  Hello,
 
  Seems like there's a minor problem with that:
 
  cc1: warnings being treated as errors
  /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c: In function
  'ndis_media_status':
  /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c:2252: warning:
  passing argument 4 of 'ndis_get_info' from incompatible pointer type
  *** Error code 1
 
  As ndis_get_info accepts 'int', not 'size_t', so after applying this:
 
  --- if_ndis.c.orig   2010-01-06 12:15:17.0 +0300
  +++ if_ndis.c2010-01-06 12:17:03.0 +0300
  @@ -2243,7 +2243,7 @@
   struct ieee80211vap *vap = ifp-if_softc;
   struct ndis_softc *sc = vap-iv_ic-ic_ifp-if_softc;
   uint32_t txrate;
  -size_t len;
  +int len;
 
   if (!NDIS_INITIALIZED(sc))
   return;
 
  it compiles fine.
 
  Roman Bogorodskiy
 
 
 Right, I generated patch from my git repo which is less broken then
 code in CURRENT.
 
 ndis_get_info should really use size_t and not int for *buflen
 
 -- 
 Paul B Mahol
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: kern/142197: [ndis] [patch] ndis is missing media status reporting

2010-01-06 Thread gavin 
Synopsis: [ndis] [patch] ndis is missing media status reporting

State-Changed-From-To: open-patched
State-Changed-By: gavin
State-Changed-When: Wed Jan 6 12:02:52 UTC 2010
State-Changed-Why: 
Committed to HEAD in r201620


Responsible-Changed-From-To: freebsd-net-rpaulo
Responsible-Changed-By: gavin
Responsible-Changed-When: Wed Jan 6 12:02:52 UTC 2010
Responsible-Changed-Why: 
Over to rpaulo as MFC reminder

http://www.freebsd.org/cgi/query-pr.cgi?pr=142197
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: kern/142197: [ndis] [patch] ndis is missing media status reporting

2009-12-31 Thread linimon 
Old Synopsis: ndis is missing media status reporting
New Synopsis: [ndis] [patch] ndis is missing media status reporting

Responsible-Changed-From-To: freebsd-bugs-freebsd-net
Responsible-Changed-By: linimon
Responsible-Changed-When: Thu Dec 31 16:49:09 UTC 2009
Responsible-Changed-Why: 
Over to maintainer(s).

http://www.freebsd.org/cgi/query-pr.cgi?pr=142197
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org