Re: Kernel Panic

2018-02-28 Thread Kristof Provost

On 28 Feb 2018, at 9:52, Kristof Provost wrote:

On 27 Feb 2018, at 20:40, Joe Jones wrote:

we have a kernel panic after compiling with witness and invariant

Feb 27 13:49:33 sovapn1 kernel: lock order reversal:
Feb 27 13:49:33 sovapn1 kernel: 1st 0xfe000fed78b8 pf_idhash 
(pf_idhash) @ /usr/src/sys/netpfil/pf/pf.c:1078
Feb 27 13:49:33 sovapn1 kernel: 2nd 0xf8001e0474a8 pfsync 
(pfsync) @ /usr/src/sys/netpfil/pf/if_pfsync.c:1667


That’s a lock order reversal. It’s not good, but it should at 
worst result in a deadlock. Did the system stop after this?
It also looks like a different problem from the panic you initially 
reported.


Also, do you actively use pfsync in this setup? Does the panic happen on 
the box where you DIOCRADDADDRS or the other(s)?


Regards,
Kristof
___
freebsd-pf@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "freebsd-pf-unsubscr...@freebsd.org"


[Bug 127814] [pf] The flush in pf_reload in /etc/rc.d/pf does not work as intended

2018-02-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=127814

--- Comment #3 from commit-h...@freebsd.org ---
A commit references this bug:

Author: kp
Date: Wed Feb 28 08:53:07 UTC 2018
New revision: 330105
URL: https://svnweb.freebsd.org/changeset/base/330105

Log:
  pf: Do not flush on reload

  pfctl only takes the last '-F' argument into account, so this never did what
  was intended.

  Moreover, there is no reason to flush rules before reloading, because pf
keeps
  track of the rule which created a given state. That means that existing
  connections will keep being processed according to the rule which originally
  created them. Simply reloading the (new) rules suffices. The new rules will
  apply to new connections.

  PR:   127814
  Submitted by: Andreas Longwitz 
  MFC after:3 weeks

Changes:
  head/etc/rc.d/pf

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-pf@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "freebsd-pf-unsubscr...@freebsd.org"