Re: MAKE_JOBS and openjdk6
On Saturday 28 August 2010 23:30:22 Greg Lewis wrote:
On Sun, Aug 29, 2010 at 12:44:39AM +0400, Anonymous wrote:
Greg Lewis gle...@eyesbeyond.com writes:
I would argue that overriding a private variable is a hack (other ports
doing it doesn't make it not a hack).
You could've spoke up in ports/148754 about your concern in order for
portmgr@ to notice. The PR strived to be less intrusive than divorcing
build jobs from make jobs. Besides, I think adding more clutter to
Makefiles defeats purpose of having stuff in bsd.port.mk.
In that case, whichever way you cut it, we're deliberately trying to
circumvent what is in bsd.port.mk.
The circumvention is required because bsd.port.mk assumes a certain interface
that may not be applicable for all ports.
Alternative patch attached which seems to achieve the same result from
my perspective without overriding _MAKE_JOBS.
Hardcoding kern.smp.cpus and ignoring MAKE_JOBS_SAFE/UNSAFE doesn't seem
like a less hacky solution. I'd argue that it's more confusing because
MAKE_JOBS_UNSAFE is not equal to DISABLE_MAKE_JOBS.
The patch I attached (a) does not ignore MAKE_JOBS_{SAFE,UNSAFE} and (b)
the first patch similarly uses DISABLE_MAKE_JOBS.
The first patch does the following:
1. Sets MAKE_JOBS_SAFE _erroneously_ (the port is _not_ MAKE_JOBS_SAFE)
purely so it can force the setting of MAKE_JOBS_NUMBER.
Yes and no. The port is partially MAKE_JOBS_SAFE and is able to build some of
the code using make jobs. This is similar to python26: it is _SAFE but only a
small portion of the build actually uses more than one job which in effect
makes it the same as _UNSAFE (from a performance perspective).
2. Overrides passing of -j to the make invocation by fiddling the private
variable _MAKE_JOBS, which it has to do because of (1).
The one I just provided
1. Leaves the port correctly marked as MAKE_JOBS_UNSAFE and doesn't mess
with any private variables.
Your attached patch does not explicitly define either MAKE_JOBS_(UN)SAFE. I
would by happy with it being defined as _UNSAFE. If there are no other
problems with your patch (see my comment at the bottom) then I'm happy for
this patch to be committed.
There will still be issues with scripts that try some form of load balancing
when building ports but either way it will not be doing what was advertised.
Similar to python.
2. Respects MAKE_JOB_NUMBER if it is set and otherwise uses the sysctl
kern.smp.cpus, the latter being what the port _already_ does.
Index: Makefile
===
RCS file: /var/fcvs/ports/java/openjdk6/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- Makefile 15 Aug 2010 05:23:06 - 1.28
+++ Makefile 28 Aug 2010 18:27:44 -
@@ -147,8 +147,14 @@
USE_DISPLAY= yes
.endif
-BUILD_JOBS_NUMBER!= ${SYSCTL} -n kern.smp.cpus
+.if !defined(DISABLE_MAKE_JOBS)
+.if defined(MAKE_JOBS_NUMBER)
+BUILD_JOBS_NUMBER= ${MAKE_JOBS_NUMBER}
+.else
+BUILD_JOBS_NUMBER= `${SYSCTL} -n kern.smp.cpus`
+.endif
MAKE_ENV+= HOTSPOT_BUILD_JOBS=${BUILD_JOBS_NUMBER}
Is it safe to pass an empty HOTSPOT_BUILD_JOBS to MAKE_ENV? (i.e. when
DISABLE_MAKE_JOBS is defined.)
+.endif
COPYDIRS=\
hotspot/src/os/linux/launcher \
signature.asc
Description: This is a digitally signed message part.
devel/p4d patch
Hi Gordon,
I just upgraded devel/p4d port and you might find this patch
interesting. This port would previously bail out trying to display the
pkg-message file that it can't find without a path.
On a second note. Where it displays this message ``post-install'' does
not seem like the right place to display this message as it is not
really noticeable during that stage. But to solve this file not being
found I patched it up with the following.
--- Makefile.orig 2010-08-29 08:08:25.801295898 -0400
+++ Makefile2010-08-29 08:10:49.149776482 -0400
@@ -49,7 +49,7 @@
${INSTALL_PROGRAM} ${_DISTDIR}/p4d ${PREFIX}/sbin/
post-install:
- @${CAT} pkg-message
+ @${CAT} ${PORTSDIR}/devel/${PORTNAME}/pkg-message
${MKDIR} ${DESTDIR}${P4ROOT}
${CHOWN} p4admin:p4admin ${DESTDIR}${P4ROOT}
${CHMOD} 750 ${DESTDIR}${P4ROOT}
Regards,
--
jhell,v
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
MuseScore port
Hi, I'm trying to port MuseScore to FreeBSD. I managed to build it, so I have made some patches for the sources, that compile on FreeBSD (I hope so). The port has no dependencies yet and MASTER_SITE is missing, but I would be very happy if someone with a faster computer (and or net connection) than mine could test it. You can find it on http://friebsd.blogspot.com/2010/08/musescore-port-alpha.html. It is not a real port yet, but I'll update it as often as I can ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: devel/p4d patch
On 08/29/2010 09:18, olli hauer wrote:
On 2010-08-29 14:17, jhell wrote:
Hi Gordon,
I just upgraded devel/p4d port and you might find this patch
interesting. This port would previously bail out trying to display the
pkg-message file that it can't find without a path.
On a second note. Where it displays this message ``post-install'' does
not seem like the right place to display this message as it is not
really noticeable during that stage. But to solve this file not being
found I patched it up with the following.
--- Makefile.orig 2010-08-29 08:08:25.801295898 -0400
+++ Makefile2010-08-29 08:10:49.149776482 -0400
@@ -49,7 +49,7 @@
${INSTALL_PROGRAM} ${_DISTDIR}/p4d ${PREFIX}/sbin/
post-install:
- @${CAT} pkg-message
+ @${CAT} ${PORTSDIR}/devel/${PORTNAME}/pkg-message
${MKDIR} ${DESTDIR}${P4ROOT}
${CHOWN} p4admin:p4admin ${DESTDIR}${P4ROOT}
${CHMOD} 750 ${DESTDIR}${P4ROOT}
Hi J,
this will only work if you install via ports but not via package.
Try '@${CAT} ${PKGMESSAGE}' instead, the port system will find
the file and it will be displayed during (package) install.
post-install is the right section, but I agree the message can be
overlooked easily, this is one of the reason some pkg-messages
start and end with a line of '=' signs and have some blanks
between the '..' line and the message self.
Hi Olli,
Thank you for the feedback. I knew there was something more to it!. Good
to know that is the right place for this. Maybe adding a @${ECHO} to the
bottom and top of that statement to echo a separation line would make it
more clear. Leaving it up to Gordon as I just wanted to inform him about
the error so it can be fixed.
Thank you again Regards,
--
jhell,v
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [SOLVED] Work on update for math/saga
On 26.08.2010 19:06 (UTC+1), Rainer Hurling wrote: Now it is time to update math/saga from version 2.0.4 to 2.0.5. In the actual state the port is able to fetch the source, to patch and then to start make. The build process stops with the following error messages. Obviously there is a problem with converting 'wxString' to 'const wchar_t*'. The described error depends on a small inaccuracy with unicode handling in the original linux sources. It is identified and will be corrected. In the meantime I am working with a small extra patch. The updated port is basically ready and running now ;-) I have no clue what to do next. Some help is greatly appreciated. Thanks in advance, Rainer Hurling -- Making all in saga_cmd Making all in man c++ -DPACKAGE_NAME=\saga\ -DPACKAGE_TARNAME=\saga\ -DPACKAGE_VERSION=\2.0.5\ -DPACKAGE_STRING=\saga\ 2.0.5\ -DPACKAGE_BUGREPORT=\BUG-REPORT-ADDRESS\ -DPACKAGE=\saga\ -DVERSION=\2.0.5\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DSTDC_HEADERS=1 -DHAVE_FLOAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_UNISTD_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STDLIB_H=1 -DHAVE_MALLOC=1 -DHAVE_STDLIB_H=1 -DHAVE_REALLOC=1 -DLSTAT_FOLLOWS_SLASHED_SYMLINK=1 -DHAVE_VPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_MEMSET=1 -DHAVE_MODF=1 -DHAVE_STRCHR=1 -DHAVE_STRDUP=1 -DHAVE_STRERROR=1 -DHAVE_STRRCHR=1 -DHAVE_STRSTR=1 -DHAVE_STRTOL=1 -I. -fPIC `/usr/local/bin/wxgtk2-2.8-config --unicode=no --cxxflags` -D_SAGA_LINUX -D_SAGA_UNICODE -D_TYPEDEF_BYTE -D_TYPEDEF_WORD -I.. -DMODULE_LIBRARY_PATH=\/usr/local/lib/saga\ -O2 -pipe -I/usr/local/include -fno-strict-aliasing -MT callback.o -MD -MP -MF .deps/callback.Tpo -c -o callback.o callback.cpp mv -f .deps/callback.Tpo .deps/callback.Po c++ -DPACKAGE_NAME=\saga\ -DPACKAGE_TARNAME=\saga\ -DPACKAGE_VERSION=\2.0.5\ -DPACKAGE_STRING=\saga\ 2.0.5\ -DPACKAGE_BUGREPORT=\BUG-REPORT-ADDRESS\ -DPACKAGE=\saga\ -DVERSION=\2.0.5\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DSTDC_HEADERS=1 -DHAVE_FLOAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_UNISTD_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STDLIB_H=1 -DHAVE_MALLOC=1 -DHAVE_STDLIB_H=1 -DHAVE_REALLOC=1 -DLSTAT_FOLLOWS_SLASHED_SYMLINK=1 -DHAVE_VPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_MEMSET=1 -DHAVE_MODF=1 -DHAVE_STRCHR=1 -DHAVE_STRDUP=1 -DHAVE_STRERROR=1 -DHAVE_STRRCHR=1 -DHAVE_STRSTR=1 -DHAVE_STRTOL=1 -I. -fPIC `/usr/local/bin/wxgtk2-2.8-config --unicode=no --cxxflags` -D_SAGA_LINUX -D_SAGA_UNICODE -D_TYPEDEF_BYTE -D_TYPEDEF_WORD -I.. -DMODULE_LIBRARY_PATH=\/usr/local/lib/saga\ -O2 -pipe -I/usr/local/include -fno-strict-aliasing -MT module_library.o -MD -MP -MF .deps/module_library.Tpo -c -o module_library.o module_library.cpp module_library.cpp: In member function 'bool CModule_Library::Create(const wchar_t*, const wchar_t*)': module_library.cpp:139: error: cannot convert 'wxString' to 'const wchar_t*' in argument passing module_library.cpp: In member function 'void CModule_Library::_Set_CMD(CSG_Parameters*, bool)': module_library.cpp:320: error: no matching function for call to 'wxString::Format(const wchar_t*)' /usr/local/include/wx-2.8/wx/string.h:1208: note: candidates are: static wxString wxString::Format(const wxChar*, ...) module_library.cpp:333: error: no matching function for call to 'wxString::Format(const wchar_t*)' /usr/local/include/wx-2.8/wx/string.h:1208: note: candidates are: static wxString wxString::Format(const wxChar*, ...) module_library.cpp:337: error: no matching function for call to 'wxString::Format(const wchar_t*)' /usr/local/include/wx-2.8/wx/string.h:1208: note: candidates are: static wxString wxString::Format(const wxChar*, ...) module_library.cpp:342: error: no matching function for call to 'wxString::Format(const wchar_t*)' /usr/local/include/wx-2.8/wx/string.h:1208: note: candidates are: static wxString wxString::Format(const wxChar*, ...) module_library.cpp:347: error: no matching function for call to 'wxString::Format(const wchar_t*)' /usr/local/include/wx-2.8/wx/string.h:1208: note: candidates are: static wxString wxString::Format(const wxChar*, ...) module_library.cpp:351: error: no matching function for call to 'wxString::Format(const wchar_t*)' /usr/local/include/wx-2.8/wx/string.h:1208: note: candidates are: static wxString wxString::Format(const wxChar*, ...) module_library.cpp:352: error: no matching function for call to 'wxString::Format(const wchar_t*)' /usr/local/include/wx-2.8/wx/string.h:1208: note: candidates are: static wxString wxString::Format(const wxChar*, ...) module_library.cpp:358: error: no
Re: ports/148691: [NEW PORT] multimedia/gtk-recordmydesktop
Ruslan Mahmatkhanov wrote:
Hi!
Can please anybody with spare time pick this PR:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148691
It is hanging around more than one month. It's small and simple, but
useful - it's gtk frontend to multimedia/recordmydesktop - a tool for
creating screencasts.
Thanks in advance.
Hi,
I quickly test your port and it seems some missing dependences. At this
point I just notice py-gtk. And of course portlint
seems not really happy with some lines in your makefile. Here is a patch
with suggested 'fixes'.
- regards
Rodrigo OSORIO
--- Makefile2010-08-29 21:34:42.0 +0200
+++ Makefile.new2010-08-29 21:37:11.0 +0200
@@ -2,6 +2,7 @@
# Date created:16 July 2010
# Whom:Ruslan Mahmatkhanov
cvs-...@yandex.ru
#
+# $FreeBSD$
#
PORTNAME= gtk-recordmydesktop
@@ -14,6 +15,7 @@
COMMENT= GTK+ frontend to recordMyDesktop
RUN_DEPENDS=
${LOCALBASE}/bin/recordmydesktop:${PORTSDIR}/multimedia/recordmydesktop
+BUILD_DEPENDS= py-gtk2=2.4:${PORTSDIR}/x11-toolkits/py-gtk2
GNU_CONFIGURE= yes
USE_GMAKE= yes
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: ports/148691: [NEW PORT] multimedia/gtk-recordmydesktop
On 29.08.2010 23:45, Rodrigo OSORIO (ros) wrote: Ruslan Mahmatkhanov wrote: Hi! Can please anybody with spare time pick this PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148691 It is hanging around more than one month. It's small and simple, but useful - it's gtk frontend to multimedia/recordmydesktop - a tool for creating screencasts. Thanks in advance. Hi, I quickly test your port and it seems some missing dependences. At this point I just notice py-gtk. And of course portlint seems not really happy with some lines in your makefile. Here is a patch with suggested 'fixes'. - regards Rodrigo OSORIO Thanks! I sent updated patch with fixes, that you pointed out, to original PR and also placed it here: http://happy-nation.by.ru/ports/gtk-recordmydesktop.shar.txt -- Regards, Ruslan ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: devel/p4d patch
On Sun, Aug 29, 2010 at 7:10 AM, jhell jh...@dataix.net wrote:
Hi J,
this will only work if you install via ports but not via package.
Try '@${CAT} ${PKGMESSAGE}' instead, the port system will find
the file and it will be displayed during (package) install.
post-install is the right section, but I agree the message can be
overlooked easily, this is one of the reason some pkg-messages
start and end with a line of '=' signs and have some blanks
between the '..' line and the message self.
Hi Olli,
Thank you for the feedback. I knew there was something more to it!. Good
to know that is the right place for this. Maybe adding a @${ECHO} to the
bottom and top of that statement to echo a separation line would make it
more clear. Leaving it up to Gordon as I just wanted to inform him about
the error so it can be fixed.
Thanks for the report. The porter's guide called out the post-install
section for displaying the pkg-message. I'll look to add the ${PKGMESSAGE}
into the port instead of relying on the local directory. I'm going to guess
such a minor change doesn't warrant touching the revision for the port.
As a suggestion for the Porter's Handbook, can someone add some suggested
code (@${ECHO} ${PKGMESSAGE}) instead of the note that is currently in
8.1? A warning in portlint would be helpful too.
Gordon
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: ports/146754: [patch] new port: add devel/atf framework to ports
On Fri, Aug 20, 2010 at 2:22 PM, Garrett Cooper yaneg...@gmail.com wrote:
On Fri, Aug 20, 2010 at 12:39 PM, Ade Lovett a...@freebsd.org wrote:
On Aug 19, 2010, at 20:30 , Garrett Cooper wrote:
This request has been sitting mostly idle for the last 3 months. I
realize people are busy, but could someone with some time please help
me work out any issues that might exist with this port, and commit
this to ports? There are a _lot_ of developers that would be happy to
see this committed to ports so they can add unittests for their work,
and I would like to see this committed so I can start writing real
testcases for pkg_install.
It looks relatively straightforward. My only concern is the bunch of files
being dumped into ${PREFIX}/tests, which violates hier(7). Would it be
possible to move them to, say ${PREFIX}/share/${PORTNAME}/tests ??
It might be but I'll have to check with Julio from NetBSD about that
because this is how things install today; they use a fixed version in
NetBSD though instead of from pkgsrc, and it hasn't gained a lot of
traction outside of a smaller niche of users, so I might be able to
convince him to change the default (or at least parameterize it so it
conforms to hier(7)).
Found the reference. The stuff that gets installed under
${PREFIX}/tests (to some degree) are actually executables
($(execdir)), and some are data files ($(datarootdir)). The author --
Julio -- used $(execdir) for everything... incorrectly as you noted,
but I think that this should be resolved at a later date (say, when
0.11 rolls out?) because I don't know what functional issues might
arise if I start monkeying around with paths right now.
The package upstream is already at 0.10, and I would rather get
this in and resolve issues as they come instead of waiting for
perfection, if that's ok.. atf is still a rather fledgling project
that's changing a bit from release to release, and is being modified
on a regular basis, so just waiting for things to resolve themselves
will be more hurtful than beneficial. I want to get to the 0.11
release though in the next hop, so I'd be more than happy to work
towards achieving that goal in that period of time (0.12 at the
latest).
Thoughts?
-Garrett
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
