Re: Creation of a diff of a new port

2019-08-07 Thread Kurt Jaeger
Hi!

> I can create a shar (example 3.2), but the handbook suggests to me that
> I should be able to make a diff (example 3.1). If someone confirms that
> I really should not be able to make a diff, I will update the handbook
> appropriately.

New ports should be submitted as shar. Changes to existing ports
should be submitted as diff.

-- 
p...@opsec.eu+49 171 3101372One year to go !
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Creation of a diff of a new port

2019-08-07 Thread Bob Eager
On Wed, 07 Aug 2019 00:16:13 +
Kralj Karlo  wrote:

> Jonathan Chen writes:
> > Details can be found at:
> >   
> > https://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html
> >   
> 
> I can create a shar (example 3.2), but the handbook suggests to me
> that I should be able to make a diff (example 3.1). If someone
> confirms that I really should not be able to make a diff, I will
> update the handbook appropriately.

For new ports, you do a shar file. 

For existing ports, you do a diff. But not using the svn repository. I
personally use the 'port' command - 'port diff' for that.
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Creation of a diff of a new port

2019-08-07 Thread Kubilay Kocak

On 7/08/2019 6:16 pm, Kurt Jaeger wrote:

Hi!


I can create a shar (example 3.2), but the handbook suggests to me that
I should be able to make a diff (example 3.1). If someone confirms that
I really should not be able to make a diff, I will update the handbook
appropriately.


New ports should be submitted as shar. Changes to existing ports
should be submitted as diff.



new ports can be submitted as shars or diffs. "new ports must/should be 
shar" is historic.

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: devel/llvm90 requires math/z3 first; building math/z3 requires a c++ toolchain be in place

2019-08-07 Thread Brooks Davis
On Tue, Aug 06, 2019 at 09:22:52PM -0700, Mark Millard wrote:
> [I found something known to be missing in the
> in at least some versions of
> llvm/cmake/modules/CrossCompile.cmake that messes
> up the overall handling of LLVM_ENABLE_Z3_SOLVER .]
> 
> On 2019-Aug-6, at 20:23, Mark Millard  wrote:
> 
> 
> 
> > On 2019-Aug-6, at 19:08, Brooks Davis  wrote:
> > 
> >> On Tue, Aug 06, 2019 at 05:59:21PM -0700, Mark Millard wrote:
> >>> 
> >>> 
> >>> On 2019-Aug-6, at 09:55, Brooks Davis  wrote:
> >>> 
>  I'd prefer to disable this dependency.  There's a knob that worked in
>  the 8.0 timeframe, but the lit build now autodetects z3 when it is
>  present and I've failed to find a knob to disable it.  For now, the easy
>  workaround is probably to disable options LIT.  We could make that the
>  default on non-LLVM platforms is that makes sense.
>  
>  -- Brooks
> >>> 
> >>> Okay.
> >>> 
> >>> poudriere-devel automatically built math/z3 because
> >>> I'd indicated to build devel/llvm90 . math/z3 was not
> >>> previously built: I've never had other use of it. So
> >>> my context was not one of an implicit autodetect.
> >> 
> >> The dependency is there because if z3 is installed then the package
> >> that is built depends on z3.  Thus I had not choice but to add a z3
> >> dependency until I find a way to turn it off.  You can either help find
> >> a way to disable z3 detection in the cmake infrastructure or turn off
> >> LIT.  I don't have any use for reports on the effects of commenting out
> >> the DEPENDS line.  I know what that does.
> > 
> > 
> > I hope this helps. (I'm not a cmake expert.)
> > 
> > llvm-9.0.0rc1.src/lib/Support/Z3Solver.cpp does:
> > 
> > #if LLVM_WITH_Z3
> > 
> > #include 
> > 
> > namespace {
> > . . .
> > } // end anonymous namespace
> > 
> > #endif
> > 
> > llvm::SMTSolverRef llvm::CreateZ3Solver() {
> > #if LLVM_WITH_Z3
> >  return llvm::make_unique();
> > #else
> >  llvm::report_fatal_error("LLVM was not compiled with Z3 support, rebuild "
> >   "with -DLLVM_ENABLE_Z3_SOLVER=ON",
> >   false);
> >  return nullptr;
> > #endif
> > }
> > 
> > (There are other places LLVM_WITH_Z3 is used but the
> > above is suggestive.)
> > 
> > Working backwards finds that:
> > 
> > /wrkdirs/usr/ports/devel/llvm90/work/llvm-9.0.0rc1.src/CMakeLists.txt
> > 
> > shows LLVM_WITH_Z3 being conditionally set to 1 via . . .
> > 
> > set(LLVM_Z3_INSTALL_DIR "" CACHE STRING "Install directory of the Z3 
> > solver.")
> > 
> > find_package(Z3 4.7.1)
> > 
> > if (LLVM_Z3_INSTALL_DIR)
> >  if (NOT Z3_FOUND)
> >message(FATAL_ERROR "Z3 >= 4.7.1 has not been found in 
> > LLVM_Z3_INSTALL_DIR: ${LLVM_Z3_INSTALL_DIR}.")
> >  endif()
> > endif()
> > 
> > set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
> > 
> > option(LLVM_ENABLE_Z3_SOLVER
> >  "Enable Support for the Z3 constraint solver in LLVM."
> >  ${LLVM_ENABLE_Z3_SOLVER_DEFAULT}
> > )
> > 
> > if (LLVM_ENABLE_Z3_SOLVER)
> >  if (NOT Z3_FOUND)
> >message(FATAL_ERROR "LLVM_ENABLE_Z3_SOLVER cannot be enabled when Z3 is 
> > not available.")
> >  endif()
> > 
> >  set(LLVM_WITH_Z3 1)
> > endif()
> > 
> > if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
> >  set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
> > endif()
> > 
> > 
> > If I read that correctly, LLVM_ENABLE_Z3_SOLVER set directly
> > appears to override the default (that tracks if z3 was found).
> 
> I saw a reference to:
> 
> diff --git a/llvm/cmake/modules/CrossCompile.cmake 
> b/llvm/cmake/modules/CrossCompile.cmake
> index bc3b210f018..0c30b88f80f 100644
> --- a/llvm/cmake/modules/CrossCompile.cmake
> +++ b/llvm/cmake/modules/CrossCompile.cmake
> @@ -53,6 +53,7 @@ function(llvm_create_cross_target_internal target_name 
> toolchain buildtype)
>  -DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"
>  -DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"
>  
> -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"
> +-DLLVM_ENABLE_Z3_SOLVER="${LLVM_ENABLE_Z3_SOLVER}"
>  ${build_type_flags} ${linker_flag} ${external_clang_dir}
>  WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}
>  DEPENDS CREATE_LLVM_${target_name}
> 
> in https://reviews.llvm.org/D54978 on Feb 12 2019, 5:41 PM
> and it had the comment:
> 
> QUOTE
> Independent of the rest of the discussion, this patch should be part of the 
> reland, to make sure that explicitly turning off Z3 works reliably. Thanks 
> for coming up with that, and thanks everyone for the good discussion here :)
> END QUOTE
> 
> This apparently fixes a sub-cmake not respecting the
> LLVM_ENABLE_Z3_SOLVER setting in the parent cmake.
> (The overall review earlier describes the sub-cmake
> not doing the right thing.)

Thanks for digging this up.  Unfortunately, this doesn't seem to have
solved the problem.  With this patch applied I still get this if I have
z3 installed on the system and no LIB_DEPENDS line:

Error: /usr/local/bin/FileCheck90 is lin

Re: Clamav

2019-08-07 Thread Florian Smeets via freebsd-ports
On 7. Aug 2019, at 04:02, Kubilay Kocak  wrote:
> 
> On 7/08/2019 7:57 am, The Doctor via freebsd-ports wrote:
>> Wehen Will clamav be updated?
>> I understand there is a security issue?
> 
> The best / most effective method to report/request security releases or 
> updates is in Bugzilla, I've created one for the ClamAV 0.101.3 version 
> (security) update) here:
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239684

FWIW, the fix in 0.101.3 seems to be incomplete. I guess there will be another 
version soon.

https://www.openwall.com/lists/oss-security/2019/08/06/3 


Florian

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: devel/llvm90 requires math/z3 first; building math/z3 requires a c++ toolchain be in place

2019-08-07 Thread Brooks Davis
On Wed, Aug 07, 2019 at 05:17:14PM +, Brooks Davis wrote:
> On Tue, Aug 06, 2019 at 09:22:52PM -0700, Mark Millard wrote:
> > [I found something known to be missing in the
> > in at least some versions of
> > llvm/cmake/modules/CrossCompile.cmake that messes
> > up the overall handling of LLVM_ENABLE_Z3_SOLVER .]
> > 
> > On 2019-Aug-6, at 20:23, Mark Millard  wrote:
> > 
> > 
> > 
> > > On 2019-Aug-6, at 19:08, Brooks Davis  wrote:
> > > 
> > >> On Tue, Aug 06, 2019 at 05:59:21PM -0700, Mark Millard wrote:
> > >>> 
> > >>> 
> > >>> On 2019-Aug-6, at 09:55, Brooks Davis  wrote:
> > >>> 
> >  I'd prefer to disable this dependency.  There's a knob that worked in
> >  the 8.0 timeframe, but the lit build now autodetects z3 when it is
> >  present and I've failed to find a knob to disable it.  For now, the 
> >  easy
> >  workaround is probably to disable options LIT.  We could make that the
> >  default on non-LLVM platforms is that makes sense.
> >  
> >  -- Brooks
> > >>> 
> > >>> Okay.
> > >>> 
> > >>> poudriere-devel automatically built math/z3 because
> > >>> I'd indicated to build devel/llvm90 . math/z3 was not
> > >>> previously built: I've never had other use of it. So
> > >>> my context was not one of an implicit autodetect.
> > >> 
> > >> The dependency is there because if z3 is installed then the package
> > >> that is built depends on z3.  Thus I had not choice but to add a z3
> > >> dependency until I find a way to turn it off.  You can either help find
> > >> a way to disable z3 detection in the cmake infrastructure or turn off
> > >> LIT.  I don't have any use for reports on the effects of commenting out
> > >> the DEPENDS line.  I know what that does.
> > > 
> > > 
> > > I hope this helps. (I'm not a cmake expert.)
> > > 
> > > llvm-9.0.0rc1.src/lib/Support/Z3Solver.cpp does:
> > > 
> > > #if LLVM_WITH_Z3
> > > 
> > > #include 
> > > 
> > > namespace {
> > > . . .
> > > } // end anonymous namespace
> > > 
> > > #endif
> > > 
> > > llvm::SMTSolverRef llvm::CreateZ3Solver() {
> > > #if LLVM_WITH_Z3
> > >  return llvm::make_unique();
> > > #else
> > >  llvm::report_fatal_error("LLVM was not compiled with Z3 support, rebuild 
> > > "
> > >   "with -DLLVM_ENABLE_Z3_SOLVER=ON",
> > >   false);
> > >  return nullptr;
> > > #endif
> > > }
> > > 
> > > (There are other places LLVM_WITH_Z3 is used but the
> > > above is suggestive.)
> > > 
> > > Working backwards finds that:
> > > 
> > > /wrkdirs/usr/ports/devel/llvm90/work/llvm-9.0.0rc1.src/CMakeLists.txt
> > > 
> > > shows LLVM_WITH_Z3 being conditionally set to 1 via . . .
> > > 
> > > set(LLVM_Z3_INSTALL_DIR "" CACHE STRING "Install directory of the Z3 
> > > solver.")
> > > 
> > > find_package(Z3 4.7.1)
> > > 
> > > if (LLVM_Z3_INSTALL_DIR)
> > >  if (NOT Z3_FOUND)
> > >message(FATAL_ERROR "Z3 >= 4.7.1 has not been found in 
> > > LLVM_Z3_INSTALL_DIR: ${LLVM_Z3_INSTALL_DIR}.")
> > >  endif()
> > > endif()
> > > 
> > > set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
> > > 
> > > option(LLVM_ENABLE_Z3_SOLVER
> > >  "Enable Support for the Z3 constraint solver in LLVM."
> > >  ${LLVM_ENABLE_Z3_SOLVER_DEFAULT}
> > > )
> > > 
> > > if (LLVM_ENABLE_Z3_SOLVER)
> > >  if (NOT Z3_FOUND)
> > >message(FATAL_ERROR "LLVM_ENABLE_Z3_SOLVER cannot be enabled when Z3 
> > > is not available.")
> > >  endif()
> > > 
> > >  set(LLVM_WITH_Z3 1)
> > > endif()
> > > 
> > > if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
> > >  set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
> > > endif()
> > > 
> > > 
> > > If I read that correctly, LLVM_ENABLE_Z3_SOLVER set directly
> > > appears to override the default (that tracks if z3 was found).
> > 
> > I saw a reference to:
> > 
> > diff --git a/llvm/cmake/modules/CrossCompile.cmake 
> > b/llvm/cmake/modules/CrossCompile.cmake
> > index bc3b210f018..0c30b88f80f 100644
> > --- a/llvm/cmake/modules/CrossCompile.cmake
> > +++ b/llvm/cmake/modules/CrossCompile.cmake
> > @@ -53,6 +53,7 @@ function(llvm_create_cross_target_internal target_name 
> > toolchain buildtype)
> >  -DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"
> >  -DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"
> >  
> > -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"
> > +-DLLVM_ENABLE_Z3_SOLVER="${LLVM_ENABLE_Z3_SOLVER}"
> >  ${build_type_flags} ${linker_flag} ${external_clang_dir}
> >  WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}
> >  DEPENDS CREATE_LLVM_${target_name}
> > 
> > in https://reviews.llvm.org/D54978 on Feb 12 2019, 5:41 PM
> > and it had the comment:
> > 
> > QUOTE
> > Independent of the rest of the discussion, this patch should be part of the 
> > reland, to make sure that explicitly turning off Z3 works reliably. Thanks 
> > for coming up with that, and thanks everyone for the good discussion here :)
> > END QUOTE
> > 
> > This apparently fixes a sub-cmake not respecting the
> > LLVM_ENABLE_Z3

www/luakit: dropping maintainership

2019-08-07 Thread Stefan Hagen

Hello,

I moved on and I don't have the time and actually no freebsd system 
anymore to maintain the www/luakit port. There is still an update to

the current version in bugzilla with minor issues.

I'm dropping maintenance. If someone is going to pick it up and has
questions, feel free to ask!

Best Regards,
Stefan
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: devel/llvm90 requires math/z3 first; building math/z3 requires a c++ toolchain be in place

2019-08-07 Thread Mark Millard via freebsd-ports



On 2019-Aug-7, at 11:02, Brooks Davis  wrote:

> On Wed, Aug 07, 2019 at 05:17:14PM +, Brooks Davis wrote:
>> On Tue, Aug 06, 2019 at 09:22:52PM -0700, Mark Millard wrote:
>>> [I found something known to be missing in the
>>> in at least some versions of
>>> llvm/cmake/modules/CrossCompile.cmake that messes
>>> up the overall handling of LLVM_ENABLE_Z3_SOLVER .]
>>> 
>>> On 2019-Aug-6, at 20:23, Mark Millard  wrote:
>>> 
>>> 
>>> 
 On 2019-Aug-6, at 19:08, Brooks Davis  wrote:
 
> On Tue, Aug 06, 2019 at 05:59:21PM -0700, Mark Millard wrote:
>> 
>> 
>> On 2019-Aug-6, at 09:55, Brooks Davis  wrote:
>> 
>>> I'd prefer to disable this dependency.  There's a knob that worked in
>>> the 8.0 timeframe, but the lit build now autodetects z3 when it is
>>> present and I've failed to find a knob to disable it.  For now, the easy
>>> workaround is probably to disable options LIT.  We could make that the
>>> default on non-LLVM platforms is that makes sense.
>>> 
>>> -- Brooks
>> 
>> Okay.
>> 
>> poudriere-devel automatically built math/z3 because
>> I'd indicated to build devel/llvm90 . math/z3 was not
>> previously built: I've never had other use of it. So
>> my context was not one of an implicit autodetect.
> 
> The dependency is there because if z3 is installed then the package
> that is built depends on z3.  Thus I had not choice but to add a z3
> dependency until I find a way to turn it off.  You can either help find
> a way to disable z3 detection in the cmake infrastructure or turn off
> LIT.  I don't have any use for reports on the effects of commenting out
> the DEPENDS line.  I know what that does.
 
 
 I hope this helps. (I'm not a cmake expert.)
 
 llvm-9.0.0rc1.src/lib/Support/Z3Solver.cpp does:
 
 #if LLVM_WITH_Z3
 
 #include 
 
 namespace {
 . . .
 } // end anonymous namespace
 
 #endif
 
 llvm::SMTSolverRef llvm::CreateZ3Solver() {
 #if LLVM_WITH_Z3
 return llvm::make_unique();
 #else
 llvm::report_fatal_error("LLVM was not compiled with Z3 support, rebuild "
  "with -DLLVM_ENABLE_Z3_SOLVER=ON",
  false);
 return nullptr;
 #endif
 }
 
 (There are other places LLVM_WITH_Z3 is used but the
 above is suggestive.)
 
 Working backwards finds that:
 
 /wrkdirs/usr/ports/devel/llvm90/work/llvm-9.0.0rc1.src/CMakeLists.txt
 
 shows LLVM_WITH_Z3 being conditionally set to 1 via . . .
 
 set(LLVM_Z3_INSTALL_DIR "" CACHE STRING "Install directory of the Z3 
 solver.")
 
 find_package(Z3 4.7.1)
 
 if (LLVM_Z3_INSTALL_DIR)
 if (NOT Z3_FOUND)
   message(FATAL_ERROR "Z3 >= 4.7.1 has not been found in 
 LLVM_Z3_INSTALL_DIR: ${LLVM_Z3_INSTALL_DIR}.")
 endif()
 endif()
 
 set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
 
 option(LLVM_ENABLE_Z3_SOLVER
 "Enable Support for the Z3 constraint solver in LLVM."
 ${LLVM_ENABLE_Z3_SOLVER_DEFAULT}
 )
 
 if (LLVM_ENABLE_Z3_SOLVER)
 if (NOT Z3_FOUND)
   message(FATAL_ERROR "LLVM_ENABLE_Z3_SOLVER cannot be enabled when Z3 is 
 not available.")
 endif()
 
 set(LLVM_WITH_Z3 1)
 endif()
 
 if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
 set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
 endif()
 
 
 If I read that correctly, LLVM_ENABLE_Z3_SOLVER set directly
 appears to override the default (that tracks if z3 was found).
>>> 
>>> I saw a reference to:
>>> 
>>> diff --git a/llvm/cmake/modules/CrossCompile.cmake 
>>> b/llvm/cmake/modules/CrossCompile.cmake
>>> index bc3b210f018..0c30b88f80f 100644
>>> --- a/llvm/cmake/modules/CrossCompile.cmake
>>> +++ b/llvm/cmake/modules/CrossCompile.cmake
>>> @@ -53,6 +53,7 @@ function(llvm_create_cross_target_internal target_name 
>>> toolchain buildtype)
>>> -DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"
>>> -DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"
>>> 
>>> -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"
>>> +-DLLVM_ENABLE_Z3_SOLVER="${LLVM_ENABLE_Z3_SOLVER}"
>>> ${build_type_flags} ${linker_flag} ${external_clang_dir}
>>> WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}
>>> DEPENDS CREATE_LLVM_${target_name}
>>> 
>>> in https://reviews.llvm.org/D54978 on Feb 12 2019, 5:41 PM
>>> and it had the comment:
>>> 
>>> QUOTE
>>> Independent of the rest of the discussion, this patch should be part of the 
>>> reland, to make sure that explicitly turning off Z3 works reliably. Thanks 
>>> for coming up with that, and thanks everyone for the good discussion here :)
>>> END QUOTE
>>> 
>>> This apparently fixes a sub-cmake not respecting the
>>> LLVM_ENABLE_Z3_SOLVER setting in the parent cmake.
>>> (The overall review earlier describes the s

Re: devel/llvm90 requires math/z3 first; building math/z3 requires a c++ toolchain be in place

2019-08-07 Thread Brooks Davis
On Wed, Aug 07, 2019 at 11:55:04AM -0700, Mark Millard wrote:
> 
> 
> On 2019-Aug-7, at 11:02, Brooks Davis  wrote:
> 
> > On Wed, Aug 07, 2019 at 05:17:14PM +, Brooks Davis wrote:
> >> On Tue, Aug 06, 2019 at 09:22:52PM -0700, Mark Millard wrote:
> >>> [I found something known to be missing in the
> >>> in at least some versions of
> >>> llvm/cmake/modules/CrossCompile.cmake that messes
> >>> up the overall handling of LLVM_ENABLE_Z3_SOLVER .]
> >>> 
> >>> On 2019-Aug-6, at 20:23, Mark Millard  wrote:
> >>> 
> >>> 
> >>> 
>  On 2019-Aug-6, at 19:08, Brooks Davis  wrote:
>  
> > On Tue, Aug 06, 2019 at 05:59:21PM -0700, Mark Millard wrote:
> >> 
> >> 
> >> On 2019-Aug-6, at 09:55, Brooks Davis  wrote:
> >> 
> >>> I'd prefer to disable this dependency.  There's a knob that worked in
> >>> the 8.0 timeframe, but the lit build now autodetects z3 when it is
> >>> present and I've failed to find a knob to disable it.  For now, the 
> >>> easy
> >>> workaround is probably to disable options LIT.  We could make that the
> >>> default on non-LLVM platforms is that makes sense.
> >>> 
> >>> -- Brooks
> >> 
> >> Okay.
> >> 
> >> poudriere-devel automatically built math/z3 because
> >> I'd indicated to build devel/llvm90 . math/z3 was not
> >> previously built: I've never had other use of it. So
> >> my context was not one of an implicit autodetect.
> > 
> > The dependency is there because if z3 is installed then the package
> > that is built depends on z3.  Thus I had not choice but to add a z3
> > dependency until I find a way to turn it off.  You can either help find
> > a way to disable z3 detection in the cmake infrastructure or turn off
> > LIT.  I don't have any use for reports on the effects of commenting out
> > the DEPENDS line.  I know what that does.
>  
>  
>  I hope this helps. (I'm not a cmake expert.)
>  
>  llvm-9.0.0rc1.src/lib/Support/Z3Solver.cpp does:
>  
>  #if LLVM_WITH_Z3
>  
>  #include 
>  
>  namespace {
>  . . .
>  } // end anonymous namespace
>  
>  #endif
>  
>  llvm::SMTSolverRef llvm::CreateZ3Solver() {
>  #if LLVM_WITH_Z3
>  return llvm::make_unique();
>  #else
>  llvm::report_fatal_error("LLVM was not compiled with Z3 support, rebuild 
>  "
>   "with -DLLVM_ENABLE_Z3_SOLVER=ON",
>   false);
>  return nullptr;
>  #endif
>  }
>  
>  (There are other places LLVM_WITH_Z3 is used but the
>  above is suggestive.)
>  
>  Working backwards finds that:
>  
>  /wrkdirs/usr/ports/devel/llvm90/work/llvm-9.0.0rc1.src/CMakeLists.txt
>  
>  shows LLVM_WITH_Z3 being conditionally set to 1 via . . .
>  
>  set(LLVM_Z3_INSTALL_DIR "" CACHE STRING "Install directory of the Z3 
>  solver.")
>  
>  find_package(Z3 4.7.1)
>  
>  if (LLVM_Z3_INSTALL_DIR)
>  if (NOT Z3_FOUND)
>    message(FATAL_ERROR "Z3 >= 4.7.1 has not been found in 
>  LLVM_Z3_INSTALL_DIR: ${LLVM_Z3_INSTALL_DIR}.")
>  endif()
>  endif()
>  
>  set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
>  
>  option(LLVM_ENABLE_Z3_SOLVER
>  "Enable Support for the Z3 constraint solver in LLVM."
>  ${LLVM_ENABLE_Z3_SOLVER_DEFAULT}
>  )
>  
>  if (LLVM_ENABLE_Z3_SOLVER)
>  if (NOT Z3_FOUND)
>    message(FATAL_ERROR "LLVM_ENABLE_Z3_SOLVER cannot be enabled when Z3 
>  is not available.")
>  endif()
>  
>  set(LLVM_WITH_Z3 1)
>  endif()
>  
>  if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
>  set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
>  endif()
>  
>  
>  If I read that correctly, LLVM_ENABLE_Z3_SOLVER set directly
>  appears to override the default (that tracks if z3 was found).
> >>> 
> >>> I saw a reference to:
> >>> 
> >>> diff --git a/llvm/cmake/modules/CrossCompile.cmake 
> >>> b/llvm/cmake/modules/CrossCompile.cmake
> >>> index bc3b210f018..0c30b88f80f 100644
> >>> --- a/llvm/cmake/modules/CrossCompile.cmake
> >>> +++ b/llvm/cmake/modules/CrossCompile.cmake
> >>> @@ -53,6 +53,7 @@ function(llvm_create_cross_target_internal target_name 
> >>> toolchain buildtype)
> >>> -DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"
> >>> -DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"
> >>> 
> >>> -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"
> >>> +-DLLVM_ENABLE_Z3_SOLVER="${LLVM_ENABLE_Z3_SOLVER}"
> >>> ${build_type_flags} ${linker_flag} ${external_clang_dir}
> >>> WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}
> >>> DEPENDS CREATE_LLVM_${target_name}
> >>> 
> >>> in https://reviews.llvm.org/D54978 on Feb 12 2019, 5:41 PM
> >>> and it had the comment:
> >>> 
> >>> QUOTE
> >>> Independent of the rest of the discussion, this patch should

Re: devel/llvm90 requires math/z3 first; building math/z3 requires a c++ toolchain be in place

2019-08-07 Thread Mark Millard via freebsd-ports



On 2019-Aug-7, at 12:56, Brooks Davis  wrote:

> On Wed, Aug 07, 2019 at 11:55:04AM -0700, Mark Millard wrote:
>> 
>> 
>> On 2019-Aug-7, at 11:02, Brooks Davis  wrote:
>> 
>>> On Wed, Aug 07, 2019 at 05:17:14PM +, Brooks Davis wrote:
 On Tue, Aug 06, 2019 at 09:22:52PM -0700, Mark Millard wrote:
> [I found something known to be missing in the
> in at least some versions of
> llvm/cmake/modules/CrossCompile.cmake that messes
> up the overall handling of LLVM_ENABLE_Z3_SOLVER .]
> 
> On 2019-Aug-6, at 20:23, Mark Millard  wrote:
> 
> 
> 
>> On 2019-Aug-6, at 19:08, Brooks Davis  wrote:
>> 
>>> On Tue, Aug 06, 2019 at 05:59:21PM -0700, Mark Millard wrote:
 
 
 On 2019-Aug-6, at 09:55, Brooks Davis  wrote:
 
> I'd prefer to disable this dependency.  There's a knob that worked in
> the 8.0 timeframe, but the lit build now autodetects z3 when it is
> present and I've failed to find a knob to disable it.  For now, the 
> easy
> workaround is probably to disable options LIT.  We could make that the
> default on non-LLVM platforms is that makes sense.
> 
> -- Brooks
 
 Okay.
 
 poudriere-devel automatically built math/z3 because
 I'd indicated to build devel/llvm90 . math/z3 was not
 previously built: I've never had other use of it. So
 my context was not one of an implicit autodetect.
>>> 
>>> The dependency is there because if z3 is installed then the package
>>> that is built depends on z3.  Thus I had not choice but to add a z3
>>> dependency until I find a way to turn it off.  You can either help find
>>> a way to disable z3 detection in the cmake infrastructure or turn off
>>> LIT.  I don't have any use for reports on the effects of commenting out
>>> the DEPENDS line.  I know what that does.
>> 
>> 
>> I hope this helps. (I'm not a cmake expert.)
>> 
>> llvm-9.0.0rc1.src/lib/Support/Z3Solver.cpp does:
>> 
>> #if LLVM_WITH_Z3
>> 
>> #include 
>> 
>> namespace {
>> . . .
>> } // end anonymous namespace
>> 
>> #endif
>> 
>> llvm::SMTSolverRef llvm::CreateZ3Solver() {
>> #if LLVM_WITH_Z3
>> return llvm::make_unique();
>> #else
>> llvm::report_fatal_error("LLVM was not compiled with Z3 support, rebuild 
>> "
>> "with -DLLVM_ENABLE_Z3_SOLVER=ON",
>> false);
>> return nullptr;
>> #endif
>> }
>> 
>> (There are other places LLVM_WITH_Z3 is used but the
>> above is suggestive.)
>> 
>> Working backwards finds that:
>> 
>> /wrkdirs/usr/ports/devel/llvm90/work/llvm-9.0.0rc1.src/CMakeLists.txt
>> 
>> shows LLVM_WITH_Z3 being conditionally set to 1 via . . .
>> 
>> set(LLVM_Z3_INSTALL_DIR "" CACHE STRING "Install directory of the Z3 
>> solver.")
>> 
>> find_package(Z3 4.7.1)
>> 
>> if (LLVM_Z3_INSTALL_DIR)
>> if (NOT Z3_FOUND)
>>  message(FATAL_ERROR "Z3 >= 4.7.1 has not been found in 
>> LLVM_Z3_INSTALL_DIR: ${LLVM_Z3_INSTALL_DIR}.")
>> endif()
>> endif()
>> 
>> set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
>> 
>> option(LLVM_ENABLE_Z3_SOLVER
>> "Enable Support for the Z3 constraint solver in LLVM."
>> ${LLVM_ENABLE_Z3_SOLVER_DEFAULT}
>> )
>> 
>> if (LLVM_ENABLE_Z3_SOLVER)
>> if (NOT Z3_FOUND)
>>  message(FATAL_ERROR "LLVM_ENABLE_Z3_SOLVER cannot be enabled when Z3 is 
>> not available.")
>> endif()
>> 
>> set(LLVM_WITH_Z3 1)
>> endif()
>> 
>> if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
>> set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
>> endif()
>> 
>> 
>> If I read that correctly, LLVM_ENABLE_Z3_SOLVER set directly
>> appears to override the default (that tracks if z3 was found).
> 
> I saw a reference to:
> 
> diff --git a/llvm/cmake/modules/CrossCompile.cmake 
> b/llvm/cmake/modules/CrossCompile.cmake
> index bc3b210f018..0c30b88f80f 100644
> --- a/llvm/cmake/modules/CrossCompile.cmake
> +++ b/llvm/cmake/modules/CrossCompile.cmake
> @@ -53,6 +53,7 @@ function(llvm_create_cross_target_internal target_name 
> toolchain buildtype)
>-DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"
>-DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"
>
> -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"
> +-DLLVM_ENABLE_Z3_SOLVER="${LLVM_ENABLE_Z3_SOLVER}"
>${build_type_flags} ${linker_flag} ${external_clang_dir}
>WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}
>DEPENDS CREATE_LLVM_${target_name}
> 
> in https://reviews.llvm.org/D54978 on Feb 12 2019, 5:41 PM
> and it had the comment:
> 
> QUOTE
> Independent of

Re: devel/llvm90 requires math/z3 first; building math/z3 requires a c++ toolchain be in place

2019-08-07 Thread Brooks Davis
On Wed, Aug 07, 2019 at 01:42:26PM -0700, Mark Millard wrote:
> 
> 
> On 2019-Aug-7, at 12:56, Brooks Davis  wrote:
> 
> > On Wed, Aug 07, 2019 at 11:55:04AM -0700, Mark Millard wrote:
> >> 
> >> 
> >> On 2019-Aug-7, at 11:02, Brooks Davis  wrote:
> >> 
> >>> On Wed, Aug 07, 2019 at 05:17:14PM +, Brooks Davis wrote:
>  On Tue, Aug 06, 2019 at 09:22:52PM -0700, Mark Millard wrote:
> > [I found something known to be missing in the
> > in at least some versions of
> > llvm/cmake/modules/CrossCompile.cmake that messes
> > up the overall handling of LLVM_ENABLE_Z3_SOLVER .]
> > 
> > On 2019-Aug-6, at 20:23, Mark Millard  wrote:
> > 
> > 
> > 
> >> On 2019-Aug-6, at 19:08, Brooks Davis  wrote:
> >> 
> >>> On Tue, Aug 06, 2019 at 05:59:21PM -0700, Mark Millard wrote:
>  
>  
>  On 2019-Aug-6, at 09:55, Brooks Davis  wrote:
>  
> > I'd prefer to disable this dependency.  There's a knob that worked 
> > in
> > the 8.0 timeframe, but the lit build now autodetects z3 when it is
> > present and I've failed to find a knob to disable it.  For now, the 
> > easy
> > workaround is probably to disable options LIT.  We could make that 
> > the
> > default on non-LLVM platforms is that makes sense.
> > 
> > -- Brooks
>  
>  Okay.
>  
>  poudriere-devel automatically built math/z3 because
>  I'd indicated to build devel/llvm90 . math/z3 was not
>  previously built: I've never had other use of it. So
>  my context was not one of an implicit autodetect.
> >>> 
> >>> The dependency is there because if z3 is installed then the package
> >>> that is built depends on z3.  Thus I had not choice but to add a z3
> >>> dependency until I find a way to turn it off.  You can either help 
> >>> find
> >>> a way to disable z3 detection in the cmake infrastructure or turn off
> >>> LIT.  I don't have any use for reports on the effects of commenting 
> >>> out
> >>> the DEPENDS line.  I know what that does.
> >> 
> >> 
> >> I hope this helps. (I'm not a cmake expert.)
> >> 
> >> llvm-9.0.0rc1.src/lib/Support/Z3Solver.cpp does:
> >> 
> >> #if LLVM_WITH_Z3
> >> 
> >> #include 
> >> 
> >> namespace {
> >> . . .
> >> } // end anonymous namespace
> >> 
> >> #endif
> >> 
> >> llvm::SMTSolverRef llvm::CreateZ3Solver() {
> >> #if LLVM_WITH_Z3
> >> return llvm::make_unique();
> >> #else
> >> llvm::report_fatal_error("LLVM was not compiled with Z3 support, 
> >> rebuild "
> >> "with -DLLVM_ENABLE_Z3_SOLVER=ON",
> >> false);
> >> return nullptr;
> >> #endif
> >> }
> >> 
> >> (There are other places LLVM_WITH_Z3 is used but the
> >> above is suggestive.)
> >> 
> >> Working backwards finds that:
> >> 
> >> /wrkdirs/usr/ports/devel/llvm90/work/llvm-9.0.0rc1.src/CMakeLists.txt
> >> 
> >> shows LLVM_WITH_Z3 being conditionally set to 1 via . . .
> >> 
> >> set(LLVM_Z3_INSTALL_DIR "" CACHE STRING "Install directory of the Z3 
> >> solver.")
> >> 
> >> find_package(Z3 4.7.1)
> >> 
> >> if (LLVM_Z3_INSTALL_DIR)
> >> if (NOT Z3_FOUND)
> >>  message(FATAL_ERROR "Z3 >= 4.7.1 has not been found in 
> >> LLVM_Z3_INSTALL_DIR: ${LLVM_Z3_INSTALL_DIR}.")
> >> endif()
> >> endif()
> >> 
> >> set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
> >> 
> >> option(LLVM_ENABLE_Z3_SOLVER
> >> "Enable Support for the Z3 constraint solver in LLVM."
> >> ${LLVM_ENABLE_Z3_SOLVER_DEFAULT}
> >> )
> >> 
> >> if (LLVM_ENABLE_Z3_SOLVER)
> >> if (NOT Z3_FOUND)
> >>  message(FATAL_ERROR "LLVM_ENABLE_Z3_SOLVER cannot be enabled when Z3 
> >> is not available.")
> >> endif()
> >> 
> >> set(LLVM_WITH_Z3 1)
> >> endif()
> >> 
> >> if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
> >> set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
> >> endif()
> >> 
> >> 
> >> If I read that correctly, LLVM_ENABLE_Z3_SOLVER set directly
> >> appears to override the default (that tracks if z3 was found).
> > 
> > I saw a reference to:
> > 
> > diff --git a/llvm/cmake/modules/CrossCompile.cmake 
> > b/llvm/cmake/modules/CrossCompile.cmake
> > index bc3b210f018..0c30b88f80f 100644
> > --- a/llvm/cmake/modules/CrossCompile.cmake
> > +++ b/llvm/cmake/modules/CrossCompile.cmake
> > @@ -53,6 +53,7 @@ function(llvm_create_cross_target_internal 
> > target_name toolchain buildtype)
> >-DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"
> >-DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"
> >
> > -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}

Re: devel/llvm90 requires math/z3 first; building math/z3 requires a c++ toolchain be in place

2019-08-07 Thread Mark Millard via freebsd-ports



On 2019-Aug-7, at 13:58, Brooks Davis  wrote:

> On Wed, Aug 07, 2019 at 01:42:26PM -0700, Mark Millard wrote:
>> 
>> 
>> On 2019-Aug-7, at 12:56, Brooks Davis  wrote:
>> 
>>> On Wed, Aug 07, 2019 at 11:55:04AM -0700, Mark Millard wrote:
 
 
 On 2019-Aug-7, at 11:02, Brooks Davis  wrote:
 
> On Wed, Aug 07, 2019 at 05:17:14PM +, Brooks Davis wrote:
>> On Tue, Aug 06, 2019 at 09:22:52PM -0700, Mark Millard wrote:
>>> [I found something known to be missing in the
>>> in at least some versions of
>>> llvm/cmake/modules/CrossCompile.cmake that messes
>>> up the overall handling of LLVM_ENABLE_Z3_SOLVER .]
>>> 
>>> On 2019-Aug-6, at 20:23, Mark Millard  wrote:
>>> 
>>> 
>>> 
 On 2019-Aug-6, at 19:08, Brooks Davis  wrote:
 
> On Tue, Aug 06, 2019 at 05:59:21PM -0700, Mark Millard wrote:
>> 
>> 
>> On 2019-Aug-6, at 09:55, Brooks Davis  wrote:
>> 
>>> I'd prefer to disable this dependency.  There's a knob that worked 
>>> in
>>> the 8.0 timeframe, but the lit build now autodetects z3 when it is
>>> present and I've failed to find a knob to disable it.  For now, the 
>>> easy
>>> workaround is probably to disable options LIT.  We could make that 
>>> the
>>> default on non-LLVM platforms is that makes sense.
>>> 
>>> -- Brooks
>> 
>> Okay.
>> 
>> poudriere-devel automatically built math/z3 because
>> I'd indicated to build devel/llvm90 . math/z3 was not
>> previously built: I've never had other use of it. So
>> my context was not one of an implicit autodetect.
> 
> The dependency is there because if z3 is installed then the package
> that is built depends on z3.  Thus I had not choice but to add a z3
> dependency until I find a way to turn it off.  You can either help 
> find
> a way to disable z3 detection in the cmake infrastructure or turn off
> LIT.  I don't have any use for reports on the effects of commenting 
> out
> the DEPENDS line.  I know what that does.
 
 
 I hope this helps. (I'm not a cmake expert.)
 
 llvm-9.0.0rc1.src/lib/Support/Z3Solver.cpp does:
 
 #if LLVM_WITH_Z3
 
 #include 
 
 namespace {
 . . .
 } // end anonymous namespace
 
 #endif
 
 llvm::SMTSolverRef llvm::CreateZ3Solver() {
 #if LLVM_WITH_Z3
 return llvm::make_unique();
 #else
 llvm::report_fatal_error("LLVM was not compiled with Z3 support, 
 rebuild "
"with -DLLVM_ENABLE_Z3_SOLVER=ON",
false);
 return nullptr;
 #endif
 }
 
 (There are other places LLVM_WITH_Z3 is used but the
 above is suggestive.)
 
 Working backwards finds that:
 
 /wrkdirs/usr/ports/devel/llvm90/work/llvm-9.0.0rc1.src/CMakeLists.txt
 
 shows LLVM_WITH_Z3 being conditionally set to 1 via . . .
 
 set(LLVM_Z3_INSTALL_DIR "" CACHE STRING "Install directory of the Z3 
 solver.")
 
 find_package(Z3 4.7.1)
 
 if (LLVM_Z3_INSTALL_DIR)
 if (NOT Z3_FOUND)
 message(FATAL_ERROR "Z3 >= 4.7.1 has not been found in 
 LLVM_Z3_INSTALL_DIR: ${LLVM_Z3_INSTALL_DIR}.")
 endif()
 endif()
 
 set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
 
 option(LLVM_ENABLE_Z3_SOLVER
 "Enable Support for the Z3 constraint solver in LLVM."
 ${LLVM_ENABLE_Z3_SOLVER_DEFAULT}
 )
 
 if (LLVM_ENABLE_Z3_SOLVER)
 if (NOT Z3_FOUND)
 message(FATAL_ERROR "LLVM_ENABLE_Z3_SOLVER cannot be enabled when Z3 
 is not available.")
 endif()
 
 set(LLVM_WITH_Z3 1)
 endif()
 
 if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
 set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
 endif()
 
 
 If I read that correctly, LLVM_ENABLE_Z3_SOLVER set directly
 appears to override the default (that tracks if z3 was found).
>>> 
>>> I saw a reference to:
>>> 
>>> diff --git a/llvm/cmake/modules/CrossCompile.cmake 
>>> b/llvm/cmake/modules/CrossCompile.cmake
>>> index bc3b210f018..0c30b88f80f 100644
>>> --- a/llvm/cmake/modules/CrossCompile.cmake
>>> +++ b/llvm/cmake/modules/CrossCompile.cmake
>>> @@ -53,6 +53,7 @@ function(llvm_create_cross_target_internal 
>>> target_name toolchain buildtype)
>>>   -DLLVM_DEFAULT_TARGET_TRIPLE="${TARGET_TRIPLE}"
>>>   -DLLVM_TARGET_ARCH="${LLVM_TARGET_ARCH}"
>>>   
>>> -DLLVM_TEMPORARILY_ALLOW_OLD_T

Re: Clamav

2019-08-07 Thread The Doctor via freebsd-ports
On Wed, Aug 07, 2019 at 07:43:17PM +0200, Florian Smeets via freebsd-ports 
wrote:
> On 7. Aug 2019, at 04:02, Kubilay Kocak  wrote:
> > 
> > On 7/08/2019 7:57 am, The Doctor via freebsd-ports wrote:
> >> Wehen Will clamav be updated?
> >> I understand there is a security issue?
> > 
> > The best / most effective method to report/request security releases or 
> > updates is in Bugzilla, I've created one for the ClamAV 0.101.3 version 
> > (security) update) here:
> > 
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239684
> 
> FWIW, the fix in 0.101.3 seems to be incomplete. I guess there will be 
> another version soon.
>

Fix what we can now and propose a ptch for this next flaw.

> https://www.openwall.com/lists/oss-security/2019/08/06/3 
> 
> 
> Florian
> 
> ___
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

-- 
Member - Liberal International This is doctor@@nl2k.ab.ca Ici doctor@@nl2k.ab.ca
Yahweh, Queen & country!Never Satan President Republic!Beware AntiChrist rising!
https://www.empire.kred/ROOTNK?t=94a1f39b  Look at Psalms 14 and 53 on Atheism
Flattery is like cologne water, to be smelt of, not swallowed.  -Josh Billings
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: devel/llvm90 requires math/z3 first; building math/z3 requires a c++ toolchain be in place

2019-08-07 Thread Mark Millard via freebsd-ports
[I found that the vintage of cmake matters: 3.12 and
earlier work differently. Details later.]

On 2019-Aug-7, at 14:37, Mark Millard  wrote:

> On 2019-Aug-7, at 13:58, Brooks Davis  wrote:
> 
>> On Wed, Aug 07, 2019 at 01:42:26PM -0700, Mark Millard wrote:
>>> 
>>> 
>>> On 2019-Aug-7, at 12:56, Brooks Davis  wrote:
>>> 
 On Wed, Aug 07, 2019 at 11:55:04AM -0700, Mark Millard wrote:
> 
> 
> On 2019-Aug-7, at 11:02, Brooks Davis  wrote:
> 
>> On Wed, Aug 07, 2019 at 05:17:14PM +, Brooks Davis wrote:
>>> On Tue, Aug 06, 2019 at 09:22:52PM -0700, Mark Millard wrote:
 [I found something known to be missing in the
 in at least some versions of
 llvm/cmake/modules/CrossCompile.cmake that messes
 up the overall handling of LLVM_ENABLE_Z3_SOLVER .]
 
 On 2019-Aug-6, at 20:23, Mark Millard  wrote:
 
 
 
> On 2019-Aug-6, at 19:08, Brooks Davis  wrote:
> 
>> On Tue, Aug 06, 2019 at 05:59:21PM -0700, Mark Millard wrote:
>>> 
>>> 
>>> On 2019-Aug-6, at 09:55, Brooks Davis  wrote:
>>> 
 I'd prefer to disable this dependency.  There's a knob that worked 
 in
 the 8.0 timeframe, but the lit build now autodetects z3 when it is
 present and I've failed to find a knob to disable it.  For now, 
 the easy
 workaround is probably to disable options LIT.  We could make that 
 the
 default on non-LLVM platforms is that makes sense.
 
 -- Brooks
>>> 
>>> Okay.
>>> 
>>> poudriere-devel automatically built math/z3 because
>>> I'd indicated to build devel/llvm90 . math/z3 was not
>>> previously built: I've never had other use of it. So
>>> my context was not one of an implicit autodetect.
>> 
>> The dependency is there because if z3 is installed then the package
>> that is built depends on z3.  Thus I had not choice but to add a z3
>> dependency until I find a way to turn it off.  You can either help 
>> find
>> a way to disable z3 detection in the cmake infrastructure or turn off
>> LIT.  I don't have any use for reports on the effects of commenting 
>> out
>> the DEPENDS line.  I know what that does.
> 
> 
> I hope this helps. (I'm not a cmake expert.)
> 
> llvm-9.0.0rc1.src/lib/Support/Z3Solver.cpp does:
> 
> #if LLVM_WITH_Z3
> 
> #include 
> 
> namespace {
> . . .
> } // end anonymous namespace
> 
> #endif
> 
> llvm::SMTSolverRef llvm::CreateZ3Solver() {
> #if LLVM_WITH_Z3
> return llvm::make_unique();
> #else
> llvm::report_fatal_error("LLVM was not compiled with Z3 support, 
> rebuild "
>"with -DLLVM_ENABLE_Z3_SOLVER=ON",
>false);
> return nullptr;
> #endif
> }
> 
> (There are other places LLVM_WITH_Z3 is used but the
> above is suggestive.)
> 
> Working backwards finds that:
> 
> /wrkdirs/usr/ports/devel/llvm90/work/llvm-9.0.0rc1.src/CMakeLists.txt
> 
> shows LLVM_WITH_Z3 being conditionally set to 1 via . . .
> 
> set(LLVM_Z3_INSTALL_DIR "" CACHE STRING "Install directory of the Z3 
> solver.")
> 
> find_package(Z3 4.7.1)
> 
> if (LLVM_Z3_INSTALL_DIR)
> if (NOT Z3_FOUND)
> message(FATAL_ERROR "Z3 >= 4.7.1 has not been found in 
> LLVM_Z3_INSTALL_DIR: ${LLVM_Z3_INSTALL_DIR}.")
> endif()
> endif()
> 
> set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
> 
> option(LLVM_ENABLE_Z3_SOLVER
> "Enable Support for the Z3 constraint solver in LLVM."
> ${LLVM_ENABLE_Z3_SOLVER_DEFAULT}
> )
> 
> if (LLVM_ENABLE_Z3_SOLVER)
> if (NOT Z3_FOUND)
> message(FATAL_ERROR "LLVM_ENABLE_Z3_SOLVER cannot be enabled when Z3 
> is not available.")
> endif()
> 
> set(LLVM_WITH_Z3 1)
> endif()
> 
> if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
> set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
> endif()
> 
> 
> If I read that correctly, LLVM_ENABLE_Z3_SOLVER set directly
> appears to override the default (that tracks if z3 was found).
 
 I saw a reference to:
 
 diff --git a/llvm/cmake/modules/CrossCompile.cmake 
 b/llvm/cmake/modules/CrossCompile.cmake
 index bc3b210f018..0c30b88f80f 100644
 --- a/llvm/cmake/modules/CrossCompile.cmake
 +++ b/llvm/cmake/modules/CrossCompile.cmake
>>>

ports/arj build failing on -current

2019-08-07 Thread Michael Butler
Is anyone else seeing this?

My in-jail build fails with .. (msgbind aborts)

gmake[3]: Entering directory '/usr/ports/archivers/arj/work/arj-3.10.22'
cc -DARJUTIL -c -Ifreebsd13.0 -I./freebsd13.0/en/rs -I. -O2 -pipe
-march=penryn  -fstack-protector-strong -fno-strict-aliasing
-DLOCALE=LANG_en -DLOCALE_DESC="\"en\""
-DPKGLIBDIR="\"/usr/local/lib/arj\"" -D_UNIX -O2 -pipe -march=penryn
-fstack-protector-strong -fno-strict-aliasing
-ofreebsd13.0/en/rs/tools/filemode.o filemode.c
cc -DARJUTIL -c -Ifreebsd13.0 -I./freebsd13.0/en/rs -I. -O2 -pipe
-march=penryn  -fstack-protector-strong -fno-strict-aliasing
-DLOCALE=LANG_en -DLOCALE_DESC="\"en\""
-DPKGLIBDIR="\"/usr/local/lib/arj\"" -D_UNIX -O2 -pipe -march=penryn
-fstack-protector-strong -fno-strict-aliasing
-ofreebsd13.0/en/rs/tools/msgbind.o msgbind.c
msgbind.c:452:50: warning: if statement has empty body [-Wempty-body]
  if(argv[6][strlen(argv[6])-1]!=PATHSEP_DEFAULT);
 ^
msgbind.c:452:50: note: put the semicolon on a separate line to silence
this warning
1 warning generated.
cc -DARJUTIL -c -Ifreebsd13.0 -I./freebsd13.0/en/rs -I. -O2 -pipe
-march=penryn  -fstack-protector-strong -fno-strict-aliasing
-DLOCALE=LANG_en -DLOCALE_DESC="\"en\""
-DPKGLIBDIR="\"/usr/local/lib/arj\"" -D_UNIX -O2 -pipe -march=penryn
-fstack-protector-strong -fno-strict-aliasing
-ofreebsd13.0/en/rs/tools/arjdata.o arjdata.c
cc -DARJUTIL -c -Ifreebsd13.0 -I./freebsd13.0/en/rs -I. -O2 -pipe
-march=penryn  -fstack-protector-strong -fno-strict-aliasing
-DLOCALE=LANG_en -DLOCALE_DESC="\"en\""
-DPKGLIBDIR="\"/usr/local/lib/arj\"" -D_UNIX -O2 -pipe -march=penryn
-fstack-protector-strong -fno-strict-aliasing
-ofreebsd13.0/en/rs/tools/crc32.o crc32.c
cc -DLOCALE=LANG_en -DLOCALE_DESC="\"en\""
-DPKGLIBDIR="\"/usr/local/lib/arj\"" -D_UNIX -O2 -pipe -march=penryn
-fstack-protector-strong -fno-strict-aliasing  -fstack-protector-strong
-s gnu/stripgcc.lnk -o freebsd13.0/en/rs/tools/msgbind
./freebsd13.0/en/rs/tools/filemode.o ./freebsd13.0/en/rs/tools/msgbind.o
./freebsd13.0/en/rs/tools/arjdata.o ./freebsd13.0/en/rs/tools/crc32.o
./freebsd13.0/en/rs/tools/msgbind ./resource/resource.txt msg_crp UNIX s
en ./freebsd13.0/en/rs
gmake[3]: *** [GNUmakefile:258: freebsd13.0/en/rs/msg_crp.h] Abort trap
gmake[3]: Leaving directory '/usr/ports/archivers/arj/work/arj-3.10.22'
gmake[2]: *** [GNUmakefile:169: all] Error 2
gmake[2]: Leaving directory '/usr/ports/archivers/arj/work/arj-3.10.22'
*** Error code 1
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"