Re: [ANNOUNCE] mod_perl-2.0.4

2008-04-21 Thread Philippe M. Chiasson

Philip M. Gollucci wrote:

Philippe M. Chiasson wrote:
| Philip M. Gollucci wrote:
| Philippe M. Chiasson wrote:
| |
|
http://tinderbox-i386.p6m7g8.net/tb/errors/8.0-FreeBSD/mod_perl2-2.0.4,3.log

|
|
| FWIW, also on 7.0
|
http://tinderbox-i386.p6m7g8.net/tb/errors/7.0-FreeBSD/mod_perl2-2.0.4,3.log

|
| | What's in xs/modperl_xs_typedefs.h:67 ? (it's generated, so I can
| easily
| | tell)
|
| ~From the 8-current tree:
| http://p6m7g8.com/modperl_xs_typedefs.h
|
| I don't have a FreeBSD machine handy, so, Philip, is there any chance you
| could try and figure out a little more about what's going on?
You do now, account info in offlist e-mail.

|
| Something is tripping up the compiler, so maybe
| apache/include/apr_thread_rwlock.h has something funky in there (or isn't
| even there)
My APR was compiled without Threads (/var/db/pkg/apr-nothr)


Sounds like a problem with APR without threads.


I'll look at tweaking the detection.


I think this patch to a bit of *magical* code should do the trick.

Index: lib/ModPerl/BuildMM.pm
===
--- lib/ModPerl/BuildMM.pm  (revision 648960)
+++ lib/ModPerl/BuildMM.pm  (working copy)
@@ -359,7 +359,7 @@

 $apr_config ||= $build-get_apr_config();

-if ($path =~ m/(Thread|Global)Mutex/) {
+if ($path =~ m/(Thread|Global)(Mutex|RWLock)/) {
 return unless $apr_config-{HAS_THREADS};
 }

Feels like something that doesn't belong in there, but rather in the
configuration somewhere in xs/maps...

--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/   m/gozer\@(apache|cpan|ectoplasm)\.org/



signature.asc
Description: OpenPGP digital signature


Re: [ANNOUNCE] mod_perl-2.0.4

2008-04-18 Thread Philippe M. Chiasson

Philip M. Gollucci wrote:

Philippe M. Chiasson wrote:
|
http://tinderbox-i386.p6m7g8.net/tb/errors/8.0-FreeBSD/mod_perl2-2.0.4,3.log

FWIW, also on 7.0
http://tinderbox-i386.p6m7g8.net/tb/errors/7.0-FreeBSD/mod_perl2-2.0.4,3.log
| What's in xs/modperl_xs_typedefs.h:67 ? (it's generated, so I can easily
| tell)

~From the 8-current tree:
http://p6m7g8.com/modperl_xs_typedefs.h


I don't have a FreeBSD machine handy, so, Philip, is there any chance you
could try and figure out a little more about what's going on?

Something is tripping up the compiler, so maybe
apache/include/apr_thread_rwlock.h has something funky in there (or isn't
even there)

Any chance you could run that one compilation invocation with
gcc -E instead ? That way, we can see the source _after_ macro
expansion, and it might help a lot in figuring out what's going on.

--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/   m/gozer\@(apache|cpan|ectoplasm)\.org/



signature.asc
Description: OpenPGP digital signature