Re: [PATCH] trafshow port broken
Hi Lawrence,
thank you for your report, the ports/133193 pr was commited yesterday
as the fix for this problem.
You're listed as the maintainer for the FreeBSD net/trafshow port. The port
doesn't compile on 8.0-CURRENT (r190457) amd64 at the moment. The recent
import of the new pcap into FreeBSD 8 means pcap.h no longer includes the
system's net/bpf.h, which has a required #define ioctl (BIOCIMMEDIATE).
Placing the attached patch in the port's files directory fixes the issue
for me. The patch should only be required for ${OSVERSION} = 800074.
--
Alexey V. Degtyarev
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
[PATCH] trafshow port broken
Hi Alexey,
You're listed as the maintainer for the FreeBSD net/trafshow port. The
port doesn't compile on 8.0-CURRENT (r190457) amd64 at the moment. The
recent import of the new pcap into FreeBSD 8 means pcap.h no longer
includes the system's net/bpf.h, which has a required #define ioctl
(BIOCIMMEDIATE). Placing the attached patch in the port's files
directory fixes the issue for me. The patch should only be required for
${OSVERSION} = 800074.
Rui, is patching the port the correct fix for this issue?
Cheers,
Lawrence
--- show_dump.c.orig2009-03-28 10:33:29.0 +1100
+++ show_dump.c 2009-03-28 10:28:44.0 +1100
@@ -30,6 +30,7 @@
#include string.h
#include unistd.h
#include errno.h
+#include net/bpf.h
#include pcap.h
#include pthread.h
#include time.h
--- trafshow.c.orig 2009-03-28 10:33:50.0 +1100
+++ trafshow.c 2009-03-28 10:27:52.0 +1100
@@ -30,6 +30,7 @@
#include string.h
#include unistd.h
#include time.h
+#include net/bpf.h
#include pcap.h
#include pthread.h
#include errno.h
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [PATCH] trafshow port broken
On 27 Mar 2009, at 23:56, Lawrence Stewart wrote:
Hi Alexey,
You're listed as the maintainer for the FreeBSD net/trafshow port.
The port doesn't compile on 8.0-CURRENT (r190457) amd64 at the
moment. The recent import of the new pcap into FreeBSD 8 means
pcap.h no longer includes the system's net/bpf.h, which has a
required #define ioctl (BIOCIMMEDIATE). Placing the attached patch
in the port's files directory fixes the issue for me. The patch
should only be required for ${OSVERSION} = 800074.
Rui, is patching the port the correct fix for this issue?
I think so. Hard to tell without looking at the program itself.
--
Rui Paulo
PGP.sig
Description: This is a digitally signed message part
Re: [PATCH] trafshow port broken
Rui Paulo wrote:
On 27 Mar 2009, at 23:56, Lawrence Stewart wrote:
Hi Alexey,
You're listed as the maintainer for the FreeBSD net/trafshow port. The
port doesn't compile on 8.0-CURRENT (r190457) amd64 at the moment. The
recent import of the new pcap into FreeBSD 8 means pcap.h no longer
includes the system's net/bpf.h, which has a required #define ioctl
(BIOCIMMEDIATE). Placing the attached patch in the port's files
directory fixes the issue for me. The patch should only be required
for ${OSVERSION} = 800074.
Rui, is patching the port the correct fix for this issue?
I think so. Hard to tell without looking at the program itself.
Ok cool. Just wanted to check that this wasn't *unexpected* fallout from
the recent pcap import and that a conscious decision has been made to
not include the system's bpf.h in pcap.h. Probably worth keeping an eye
out on the ports build cluster for any other ports that look like
they're failing to build because of bpf.h issues.
Cheers,
Lawrence
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
