Re: Approving a patch
On 3 March 2015, at 22:45, Kubilay Kocak ko...@freebsd.org wrote: Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope. This of course requires the maintainer-approval flag was set to ? with your email as the value first. Currently this is not automatic, but *should be* if there is an attachment of type: patch in the issue. I'll create an issue for that now for bugmeister@ to look into addressing. Only in cases where maintainer-approval is *not* already set to?, is using the maintainer-feedback flag + comment flow OK. Setting maintainer-feedback is ambiguous, and is used to prove 'acknowledgement' of an issue or question. This is especially the case when there are multiple version of patches, or patches from multiple contributors. In future it will be used to derive maintainer timeouts to kick issues along, and open them up for someone else to make a decision on. tldr; Set the maintainer-approval flag to + Thanks to all who replied. I found and set the maintainer-feedback flag at the issue/bug scope. I couldn’t find any similar flag at the attachment/patch scope. Nothing there was really applicable. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Approving a patch
On 4/03/2015 9:05 PM, Kubilay Kocak wrote: On 4/03/2015 9:00 PM, Doug Hardie wrote: On 3 March 2015, at 22:45, Kubilay Kocak ko...@freebsd.org wrote: Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope. This of course requires the maintainer-approval flag was set to ? with your email as the value first. Currently this is not automatic, but *should be* if there is an attachment of type: patch in the issue. I'll create an issue for that now for bugmeister@ to look into addressing. Only in cases where maintainer-approval is *not* already set to?, is using the maintainer-feedback flag + comment flow OK. Setting maintainer-feedback is ambiguous, and is used to prove 'acknowledgement' of an issue or question. This is especially the case when there are multiple version of patches, or patches from multiple contributors. In future it will be used to derive maintainer timeouts to kick issues along, and open them up for someone else to make a decision on. tldr; Set the maintainer-approval flag to + Thanks to all who replied. I found and set the maintainer-feedback flag at the issue/bug scope. I couldn’t find any similar flag at the attachment/patch scope. Nothing there was really applicable. Which issue? Doug, Ignore that, I found it: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198224 I've set the maintainer-approval flag to + for you. Note: this is what I meant in my on-list reply by: This of course requires the maintainer-approval flag was set to ? with your email as the value first. In your issues case, the flag hadn't been set yet. I've created a new issue on this exact point, so as to make setting the maintainer-approval flag automatic. You can follow it here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198271 -- Regards, Kubilay Kocak Bugmeister ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Approving a patch
On 4/03/2015 9:00 PM, Doug Hardie wrote: On 3 March 2015, at 22:45, Kubilay Kocak ko...@freebsd.org wrote: Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope. This of course requires the maintainer-approval flag was set to ? with your email as the value first. Currently this is not automatic, but *should be* if there is an attachment of type: patch in the issue. I'll create an issue for that now for bugmeister@ to look into addressing. Only in cases where maintainer-approval is *not* already set to?, is using the maintainer-feedback flag + comment flow OK. Setting maintainer-feedback is ambiguous, and is used to prove 'acknowledgement' of an issue or question. This is especially the case when there are multiple version of patches, or patches from multiple contributors. In future it will be used to derive maintainer timeouts to kick issues along, and open them up for someone else to make a decision on. tldr; Set the maintainer-approval flag to + Thanks to all who replied. I found and set the maintainer-feedback flag at the issue/bug scope. I couldn’t find any similar flag at the attachment/patch scope. Nothing there was really applicable. Which issue? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Approving a patch
On Wed, 04 Mar 2015 21:23:23 +1100 Kubilay Kocak ko...@freebsd.org wrote On 4/03/2015 9:05 PM, Kubilay Kocak wrote: On 4/03/2015 9:00 PM, Doug Hardie wrote: On 3 March 2015, at 22:45, Kubilay Kocak ko...@freebsd.org wrote: Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope. This of course requires the maintainer-approval flag was set to ? with your email as the value first. Currently this is not automatic, but *should be* if there is an attachment of type: patch in the issue. I'll create an issue for that now for bugmeister@ to look into addressing. Only in cases where maintainer-approval is *not* already set to?, is using the maintainer-feedback flag + comment flow OK. Setting maintainer-feedback is ambiguous, and is used to prove 'acknowledgement' of an issue or question. This is especially the case when there are multiple version of patches, or patches from multiple contributors. In future it will be used to derive maintainer timeouts to kick issues along, and open them up for someone else to make a decision on. tldr; Set the maintainer-approval flag to + Thanks to all who replied. I found and set the maintainer-feedback flag at the issue/bug scope. I couldn’t find any similar flag at the attachment/patch scope. Nothing there was really applicable. Which issue? Doug, Ignore that, I found it: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198224 I've set the maintainer-approval flag to + for you. Note: this is what I meant in my on-list reply by: This of course requires the maintainer-approval flag was set to ? with your email as the value first. In your issues case, the flag hadn't been set yet. I've created a new issue on this exact point, so as to make setting the maintainer-approval flag automatic. You can follow it here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198271 Along those lines; would it make any sense to convert the current [select] into a [radio]? I must admit, it took me awhile to *conclusively* determine what best applied, and when/where. It all just seemed a bit more difficult to ascertain, than need be. Using a [radio] would allow for a more concise (intuitive?) description. Just a thought. --Chris -- Regards, Kubilay Kocak Bugmeister ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Approving a patch
Hi! I am the maintainer for a port. I received a suggested patch for the port that is good. Did you receive it as part of a problem report in bugzilla or per e-mail ? Hmm, you're maintainer for mail/qpopper, as listed in /usr/ports/INDEX-10. There's a PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198224 There used to be a link in the notification email to click on to approve the patch. With the new port system, that is gone (or at least I didn???t find it). I went through the porters manual and didn???t find anything on how to approve a patch. How do I do that? You can go to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198224 login as bc...@lafn.org and click on the small selector box with '?' besides the maintainer-feedback field. -- p...@opsec.eu+49 171 3101372 5 years to go ! ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Approving a patch
On 3/3/2015 1:53 PM, Doug Hardie wrote: I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve the patch. With the new port system, that is gone (or at least I didn’t find it). I went through the porters manual and didn’t find anything on how to approve a patch. How do I do that? In bugzilla there is a maintainer feedback dropdown. You can change it to a '+' and also leave a comment saying approved. -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
Approving a patch
I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve the patch. With the new port system, that is gone (or at least I didn’t find it). I went through the porters manual and didn’t find anything on how to approve a patch. How do I do that? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Approving a patch
On 4/03/2015 5:45 PM, Kubilay Kocak wrote: On 4/03/2015 7:11 AM, Bryan Drewery wrote: On 3/3/2015 1:53 PM, Doug Hardie wrote: I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve the patch. With the new port system, that is gone (or at least I didn’t find it). I went through the porters manual and didn’t find anything on how to approve a patch. How do I do that? In bugzilla there is a maintainer feedback dropdown. You can change it to a '+' and also leave a comment saying approved. Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope. This of course requires the maintainer-approval flag was set to ? with your email as the value first. Currently this is not automatic, but *should be* if there is an attachment of type: patch in the issue. I'll create an issue for that now for bugmeister@ to look into addressing. Only in cases where maintainer-approval is *not* already set to?, is using the maintainer-feedback flag + comment flow OK. Setting maintainer-feedback is ambiguous, and is used to prove 'acknowledgement' of an issue or question. This is especially the case when there are multiple version of patches, or patches from multiple contributors. In future it will be used to derive maintainer timeouts to kick issues along, and open them up for someone else to make a decision on. tldr; Set the maintainer-approval flag to + -- Regards, Kubilay Bugmeister Further clarification: maintainer-feedback and maintainer-approval are independent and orthogonal. none, one or the other, or both can be used independently and to cumulative effect depending on the issues context and state with regard to what the issue needs to progress. -- Kubilay ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Approving a patch
On 4/03/2015 7:11 AM, Bryan Drewery wrote: On 3/3/2015 1:53 PM, Doug Hardie wrote: I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve the patch. With the new port system, that is gone (or at least I didn’t find it). I went through the porters manual and didn’t find anything on how to approve a patch. How do I do that? In bugzilla there is a maintainer feedback dropdown. You can change it to a '+' and also leave a comment saying approved. Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope. This of course requires the maintainer-approval flag was set to ? with your email as the value first. Currently this is not automatic, but *should be* if there is an attachment of type: patch in the issue. I'll create an issue for that now for bugmeister@ to look into addressing. Only in cases where maintainer-approval is *not* already set to?, is using the maintainer-feedback flag + comment flow OK. Setting maintainer-feedback is ambiguous, and is used to prove 'acknowledgement' of an issue or question. This is especially the case when there are multiple version of patches, or patches from multiple contributors. In future it will be used to derive maintainer timeouts to kick issues along, and open them up for someone else to make a decision on. tldr; Set the maintainer-approval flag to + -- Regards, Kubilay Bugmeister ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
